D17911: Fix failing knewfilemenu test and underlying reason for its failure

ngraham added a comment. Thanks! Does the code change in `src/filewidgets/knewfilemenu.cpp` make sense to you? I tested a bunch but I know you're the expert here. :) REPOSITORY R241 KIO BRANCH fix-test-and-code (branched from master) REVISION DETAIL https://phabricator.kde.org/D17911

D17911: Fix failing knewfilemenu test and underlying reason for its failure

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. Tests are good :-) REPOSITORY R241 KIO BRANCH fix-test-and-code (branched from master) REVISION DETAIL https://phabricator.kde.org/D17911 To: ngraham, #frameworks, dfaure,

D10305: Fix "Moving the mouse over a different application icon immediately changes the window list"

ngraham planned changes to this revision. ngraham added a comment. Still doesn't actually work right; need to hack on it more. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D10305 To: ngraham, #plasma, #plasma_accessibility, mart, aacid, lshoravi

D10305: Fix "Moving the mouse over a different application icon immediately changes the window list"

ngraham updated this revision to Diff 48569. ngraham marked an inline comment as done. ngraham added a comment. Rebase on current master, address review comments, fix bugs REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.9 - Build # 106 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.9/106/ Project: kf5-qt5 SUSEQt5.9 Date of build: Wed, 02 Jan 2019 19:33:30 + Build duration: 4 min 50 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.11 - Build # 19 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.11/19/ Project: kf5-qt5 SUSEQt5.11 Date of build: Wed, 02 Jan 2019 19:33:30 + Build duration: 1 min 30 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » breeze-icons » kf5-qt5 FreeBSDQt5.12 - Build # 6 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20FreeBSDQt5.12/6/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Wed, 02 Jan 2019 19:33:30 + Build duration: 1 min 12 sec and counting JUnit Tests Name:

D17927: Fix gradient positions (Breeze Dark)

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R266:742801be4a7a: Fix gradient positions (Breeze Dark) (authored by ndavis). REPOSITORY R266 Breeze Icons CHANGES

D17927: Fix gradient positions (Breeze Dark)

ndavis created this revision. ndavis added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ndavis requested review of this revision. REVISION SUMMARY Forgot to do Breeze Dark when I fixed them in my previous diff REPOSITORY R266 Breeze

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.9 - Build # 105 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.9/105/ Project: kf5-qt5 SUSEQt5.9 Date of build: Wed, 02 Jan 2019 19:01:20 + Build duration: 1 min 49 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » breeze-icons » kf5-qt5 FreeBSDQt5.12 - Build # 5 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20FreeBSDQt5.12/5/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Wed, 02 Jan 2019 19:01:20 + Build duration: 1 min 12 sec and counting JUnit Tests Name:

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.11 - Build # 18 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.11/18/ Project: kf5-qt5 SUSEQt5.11 Date of build: Wed, 02 Jan 2019 19:01:20 + Build duration: 1 min 33 sec and counting BUILD ARTIFACTS

D17912: Fix shadow gradients

This revision was automatically updated to reflect the committed changes. Closed by commit R266:9a4e5d509535: Fix shadow gradients (authored by ndavis). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17912?vs=48509=48561 REVISION DETAIL

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.9 - Build # 104 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.9/104/ Project: kf5-qt5 SUSEQt5.9 Date of build: Wed, 02 Jan 2019 18:54:40 + Build duration: 1 min 45 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.11 - Build # 17 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.11/17/ Project: kf5-qt5 SUSEQt5.11 Date of build: Wed, 02 Jan 2019 18:54:40 + Build duration: 1 min 35 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » breeze-icons » kf5-qt5 FreeBSDQt5.12 - Build # 4 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20FreeBSDQt5.12/4/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Wed, 02 Jan 2019 18:54:40 + Build duration: 1 min 9 sec and counting JUnit Tests Name:

D17923: Better desktop icon colors

This revision was automatically updated to reflect the committed changes. Closed by commit R266:7c81d01ed673: Better desktop icon colors (authored by GB_2, committed by ngraham). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17923?vs=48554=48560

D17924: Better plasma-media-center icon

ngraham added a comment. The gradient you used for the icons in D17924 looks different from the one you used here. This one has a darker one that almost looks radial instead of linear. Is that intentional? F6521196: Screenshot_20190102_115236.png

D17923: Better desktop icon colors

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Wow, the aesthetic improvement here is really dramatic. That purple is such a more pleasant color than the old orange in these icons! All relevant icons seem changed, tests pass, etc.

D17924: Better plasma-media-center icon

GB_2 created this revision. GB_2 added reviewers: Breeze, VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. GB_2 requested review of this revision. REVISION SUMMARY Forgot to change plasma-media-center in D17919 , this

D17923: Better desktop icon colors

GB_2 edited the summary of this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D17923 To: GB_2, #vdg, #breeze Cc: #breeze, kde-frameworks-devel, #vdg, michaelh, ngraham, bruns

D17923: Better desktop icon colors

GB_2 created this revision. GB_2 added reviewers: VDG, Breeze. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. GB_2 requested review of this revision. REVISION SUMMARY The current icons with an abstract desktop wallpaper in the background have a very hard

D17851: Add Android notification backend

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. These changes only will apply to Android, so let's get this in. The status quo is broken there anyway. As for the application, it could be in a separate repository too, no need to bloat

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.11 - Build # 16 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.11/16/ Project: kf5-qt5 SUSEQt5.11 Date of build: Wed, 02 Jan 2019 15:59:14 + Build duration: 4 min 19 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.9 - Build # 103 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.9/103/ Project: kf5-qt5 SUSEQt5.9 Date of build: Wed, 02 Jan 2019 15:59:14 + Build duration: 1 min 41 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » breeze-icons » kf5-qt5 FreeBSDQt5.12 - Build # 3 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20FreeBSDQt5.12/3/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Wed, 02 Jan 2019 15:59:15 + Build duration: 1 min 21 sec and counting JUnit Tests Name:

D17919: Better multimedia related icons

This revision was automatically updated to reflect the committed changes. Closed by commit R266:98e5d1a3bd63: Better multimedia related icons (authored by GB_2, committed by ngraham). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17919?vs=48538=48544

D17919: Better multimedia related icons

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R266 Breeze Icons BRANCH better-multimedia-category-icon (branched from master) REVISION DETAIL https://phabricator.kde.org/D17919 To: GB_2, #breeze, #vdg, ngraham Cc: ngraham, rooty, #vdg,

D17919: Better multimedia related icons

ngraham added a comment. lol you're too fast for me REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D17919 To: GB_2, #breeze, #vdg Cc: ngraham, rooty, #vdg, kde-frameworks-devel, #breeze, michaelh, bruns

D17919: Better multimedia related icons

ngraham added a comment. Great! This ugly gradient is also present in: - `preferences-desktop-multimedia` - `multimedia-player`. - `video-television` Can you fix it in those too? REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D17919 To: GB_2,

D17919: Better multimedia related icons

GB_2 updated this revision to Diff 48538. GB_2 added a comment. Update other multimedia related icons too REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17919?vs=48537=48538 BRANCH better-multimedia-category-icon (branched from master) REVISION

D17919: Better multimedia related icons

GB_2 created this revision. GB_2 added reviewers: Breeze, VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. GB_2 requested review of this revision. REVISION SUMMARY Improves the screen background gradient in the multimedia related icons to make them look

D17907: [KWidgetsAddons] Do not use light font styles for headings (3/3)

ngraham removed a dependent revision: D17916: [Login and lock screens] Do not use light font styles for the sddm clock. REPOSITORY R236 KWidgetsAddons BRANCH no-light-headings (branched from master) REVISION DETAIL https://phabricator.kde.org/D17907 To: rooty, ngraham, #frameworks,

D17906: [kirigami] Do not use light font styles for headings (2/3)

ngraham removed a dependent revision: D17916: [Login and lock screens] Do not use light font styles for the sddm clock. REPOSITORY R169 Kirigami BRANCH no-light-headings (branched from master) REVISION DETAIL https://phabricator.kde.org/D17906 To: filipf, ngraham, #plasma, #vdg,

D17905: [frameworks] Do not use light font styles for headings (1/3)

ngraham removed a dependent revision: D17916: [Login and lock screens] Do not use light font styles for the sddm clock. REPOSITORY R242 Plasma Framework (Library) BRANCH no-light-headings (branched from master) REVISION DETAIL https://phabricator.kde.org/D17905 To: filipf, ngraham,

D17912: Fix shadow gradients

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R266 Breeze Icons BRANCH fix-gradients (branched from master) REVISION DETAIL https://phabricator.kde.org/D17912 To: ndavis, #vdg, #breeze, ngraham Cc: kde-frameworks-devel, michaelh, ngraham,

D17310: Improve Kile icon with LaTeX font

trickyricky26 added a comment. Some designs that are more faithful to the original: F6520878: kile-faithful.svg.png This has almost the same letter design as the original. I adjusted it a bit to fit onto the notepad. F6520887:

D17906: [kirigami] Do not use light font styles for headings (2/3)

filipf edited the test plan for this revision. REPOSITORY R169 Kirigami BRANCH no-light-headings (branched from master) REVISION DETAIL https://phabricator.kde.org/D17906 To: filipf, ngraham, #plasma, #vdg, #frameworks Cc: plasma-devel, dkardarakos, apol, davidedmundson, mart, hein

D17905: [frameworks] Do not use light font styles for headings (1/3)

filipf edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) BRANCH no-light-headings (branched from master) REVISION DETAIL https://phabricator.kde.org/D17905 To: filipf, ngraham, #plasma, #vdg, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17907: [KWidgetsAddons] Do not use light font styles for headings (3/3)

rooty added a dependent revision: D17916: [Login and lock screens] Do not use light font styles for the sddm clock. REPOSITORY R236 KWidgetsAddons BRANCH no-light-headings (branched from master) REVISION DETAIL https://phabricator.kde.org/D17907 To: rooty, ngraham, #frameworks, #vdg,

D17905: [frameworks] Do not use light font styles for headings (1/3)

rooty added a dependent revision: D17916: [Login and lock screens] Do not use light font styles for the sddm clock. REPOSITORY R242 Plasma Framework (Library) BRANCH no-light-headings (branched from master) REVISION DETAIL https://phabricator.kde.org/D17905 To: filipf, ngraham, #plasma,

D17906: [kirigami] Do not use light font styles for headings (2/3)

rooty added a dependent revision: D17916: [Login and lock screens] Do not use light font styles for the sddm clock. REPOSITORY R169 Kirigami BRANCH no-light-headings (branched from master) REVISION DETAIL https://phabricator.kde.org/D17906 To: filipf, ngraham, #plasma, #vdg, #frameworks

D17310: Improve Kile icon with LaTeX font

trickyricky26 planned changes to this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D17310 To: trickyricky26, #vdg, ngraham, #kile Cc: loh.tar, mludwig, ndavis, ngraham, kde-frameworks-devel, michaelh, bruns

KDE CI: Frameworks » solid » kf5-qt5 FreeBSDQt5.12 - Build # 2 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20FreeBSDQt5.12/2/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Wed, 02 Jan 2019 11:01:26 + Build duration: 56 min and counting JUnit Tests Name: projectroot

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.12 - Build # 2 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.12/2/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Wed, 02 Jan 2019 06:19:31 + Build duration: 5 hr 26 min and counting JUnit Tests Name:

KDE CI: Frameworks » breeze-icons » kf5-qt5 FreeBSDQt5.12 - Build # 2 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20FreeBSDQt5.12/2/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Wed, 02 Jan 2019 02:50:15 + Build duration: 8 hr 54 min and counting JUnit Tests Name:

D17310: Improve Kile icon with LaTeX font

trickyricky26 added a comment. In D17310#384720 , @mludwig wrote: > Moreover, as you pointed out in https://phabricator.kde.org/T10243, the "Don't destroy the app's existing branding" recommendation in the HIG has actually been violated by the

D17904: Highlight CUDA .cu and .cuh files as C++

thomassc updated this revision to Diff 48519. thomassc added a comment. Thanks for having a look. I assume that the "version" attribute needs to be increased and the "kateversion" does not. I updated the diff accordingly. I don't think that I have any commit rights, can you commit?

D17910: [UDisks2] Use MediaRemovable to determine if media can be ejected

This revision was automatically updated to reflect the committed changes. Closed by commit R245:6d260195cf75: [UDisks2] Use MediaRemovable to determine if media can be ejected (authored by bruns). REPOSITORY R245 Solid CHANGES SINCE LAST UPDATE

D15421: [server] Add surface data proxy mechanism

romangg updated this revision to Diff 48515. romangg added a comment. - Fix typo - Rebase on master. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15421?vs=41497=48515 BRANCH 0proxyDataSurface REVISION DETAIL https://phabricator.kde.org/D15421 AFFECTED FILES

D15421: [server] Add surface data proxy mechanism

romangg marked an inline comment as done. REVISION DETAIL https://phabricator.kde.org/D15421 To: romangg, #kwin Cc: davidedmundson, kde-frameworks-devel, michaelh, ngraham, bruns

D15023: [server] Add selectionChanged signal

romangg updated this revision to Diff 48513. romangg added a comment. Rebase on master. REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15023?vs=41424=48513 BRANCH 0selectionChangeXwl REVISION DETAIL https://phabricator.kde.org/D15023 AFFECTED FILES