D18424: Instantiate QApplication before KCrash/KCatalog

mlaurent accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH master REVISION DETAIL https://phabricator.kde.org/D18424 To: sdepiets, #baloo, bruns, poboiko, mlaurent Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich,

D18424: Instantiate QApplication before KCrash/KCatalog

lbeltrame added reviewers: bruns, poboiko. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D18424 To: sdepiets, #baloo, bruns, poboiko Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D13216: Overhaul the file index scheduler.

smithjd added a comment. "Locking" the scheduler is simpler here than identifying that it "has gone idle". "Locking" only happens here for a small number of runnables (two) that can't run concurrently. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D13216 To:

D18125: KateStatusBar: Add dictionary button

loh.tar added a comment. > m_dictionaryGroup->checkedAction() might be null. Oops! Thanks. > For the naming: Given we show the encodings with their short-names, too, I can live with de_DE or stuff like that. Is it OK to add some cutting like that? Currently is that extra stuff

[sysadmin/ci-tooling] build-specs/Plasma: Disable execution of tests for plasma-integration.

Git commit f6c79ff4787148459aa91c17d683e4fd6a57c323 by Ben Cooksley. Committed on 21/01/2019 at 05:46. Pushed by bcooksley into branch 'master'. Disable execution of tests for plasma-integration. This is necessary to ensure CI nodes do not become blocked due to hanging tests withing

D17459: SearchBar: Add Cancel button to stop long running tasks

loh.tar added a comment. > are you interested in that challenge, too? Um...atm? No. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D17459 To: loh.tar, #ktexteditor, #vdg, cullmann Cc: dhaumann, anthonyfieroni, brauch, cullmann, abetts, kwrite-devel,

D17857: DocumentPrivate: Don't scroll view when add auto-bracket at end of file

loh.tar added a comment. > But on the other side: how does one reproduce this? Hm, I had just follow the descriptions in the report. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D17857 To: loh.tar, #ktexteditor Cc: cullmann, dhaumann, kwrite-devel,

D18167: Move -Wsuggest-override -Wlogical-op to regular compiler settings

graesslin added a comment. For done code this warning is pointless and negative. I invite you to work with a code base like KWin where it is more important to have a working git blame than protection for theoretical problems. Nobody will be able to guarantee that a 500+ change to add

D18424: Instantiate QApplication before KCrash/KCatalog

sdepiets edited the summary of this revision. sdepiets added a reviewer: Baloo. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D18424 To: sdepiets, #baloo Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D18424: Instantiate QApplication before KCrash/KCatalog

sdepiets created this revision. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. sdepiets requested review of this revision. REPOSITORY R293 Baloo BRANCH master REVISION DETAIL https://phabricator.kde.org/D18424 AFFECTED FILES

D13216: Overhaul the file index scheduler.

bruns requested changes to this revision. bruns added a comment. This revision now requires changes to proceed. STOP IT! You are reverting recent, required changes. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D13216 To: smithjd, bruns, mgallien Cc: ngraham,

D13216: Overhaul the file index scheduler.

smithjd updated this revision to Diff 49977. smithjd added a comment. - Re-write the file index scheduler. Combine content indexer suspend logic. - Update the balooctl tool with the changed suspend/resume behaviour. - Re-order and use IndexerState to prioritize the indexer thread pool. -

D18380: KIO: make file dialog columns resizable again (and movable)

rjvbb added a comment. > I don't see the squeezed text when using Breeze and Noto Sans. Am I missing something? No, I don't think so. This must correspond to the 2nd pair of images I attached. > I kind of hope so, because I predict that if we ship with text that gets squeezed

D18421: [autotests] Stabilize testWindowmanagement

zzag created this revision. zzag added a reviewer: KWin. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. zzag requested review of this revision. REVISION SUMMARY In rare cases testWindowmanagement fails because the initial iconChanged signal gets emitted

D11236: [KCrash] Establish socket to allow change of ptracer

croick added a comment. > the 3rd line is still wrong ... So I used the word "tracer" now. Otherwise I don't know what you mean. REPOSITORY R285 KCrash REVISION DETAIL https://phabricator.kde.org/D11236 To: croick, #frameworks, ossi Cc: dfaure, lepagevalleeemmanuel,

D11235: [DrKonqi] Request change of ptrace scope from KCrash

croick edited the summary of this revision. REPOSITORY R871 DrKonqi REVISION DETAIL https://phabricator.kde.org/D11235 To: croick, #plasma_workspaces, #frameworks, ossi Cc: ossi, lepagevalleeemmanuel, maximilianocuria, adridg, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot,

D11236: [KCrash] Establish socket to allow change of ptracer

croick edited the summary of this revision. REPOSITORY R285 KCrash REVISION DETAIL https://phabricator.kde.org/D11236 To: croick, #frameworks, ossi Cc: dfaure, lepagevalleeemmanuel, kde-frameworks-devel, sitter, michaelh, ngraham, bruns

D18167: Move -Wsuggest-override -Wlogical-op to regular compiler settings

aacid added a comment. In D18167#397020 , @graesslin wrote: > This causes in KWin 500+ new warnings. Do you really think it's a good idea to spam all of KDE with new compiler warnings. KDE has an old code base. We cannot enable warnings for

D18369: Create tel: links for phone numbers

svuorela added inline comments. INLINE COMMENTS > ktexttohtml.cpp:159 > +// this isn't 100% accurate, we filter stuff below that is too hard to > capture with a regexp > +static const QRegularExpression telPattern(QStringLiteral(R"([+0](( |( > ?[/-] ?)?)\(?\d+\)?+){6,30})")); > +

D18167: Move -Wsuggest-override -Wlogical-op to regular compiler settings

graesslin added a comment. This causes in KWin 500+ new warnings. Do you really think it's a good idea to spam all of KDE with new compiler warnings. KDE has an old code base. We cannot enable warnings for the way you developed C++ for 20 years. REPOSITORY R240 Extra CMake Modules

D18380: KIO: make file dialog columns resizable again (and movable)

ngraham added a comment. I don't see the squeezed text when using Breeze and Noto Sans. Am I missing something? I kind of hope so, because I predict that if we ship with text that gets squeezed at various sizes, we'll totally get bug reports about it. :-) No need to overcomplicate

D18380: KIO: make file dialog columns resizable again (and movable)

rjvbb added a comment. My QtCurve-based theme, "narrow mode" just activated: F6558463: kdialog-narrow-mode.png Idem, "narrow mode" just deactivated F6558464: kdialog-regular-mode.png Default theme, narrow

D18380: KIO: make file dialog columns resizable again (and movable)

rjvbb updated this revision to Diff 49947. rjvbb added a comment. Final attempt at being a bit clever :) Entering "narrow mode" now also sets the font stretch (exitting the mode will reset the stretch), the same as the Mac Finder will do. I use factor 83, which corresponds roughly to

D18384: Allow creating directory named '~' and throw a warning before creating it.

shubham retitled this revision from "Create directory named '~' and throw a warning before creating it successfully." to "Allow creating directory named '~' and throw a warning before creating it.". REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D18384 To: shubham,

D18384: Create directory named '~' and throw a warning before creating it successfully.

shubham retitled this revision from "Allow creating directory named '~' and throw a warning before creating it." to "Create directory named '~' and throw a warning before creating it successfully.". REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D18384 To: shubham,

D18384: Allow creating directory named '~' and throw a warning before creating it.

shubham updated this revision to Diff 49943. shubham marked an inline comment as done. shubham added a comment. Remove redundant setting of window title. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18384?vs=49935=49943 BRANCH dir REVISION DETAIL

D18408: Set new PlasmaShellSurface::PopupBehavior flags

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. davidedmundson requested review of this revision. REVISION SUMMARY Set on surface creation and on relevant setFlags API of Dialog

D18384: Allow creating directory named '~' and throw a warning before creating it.

pino added a comment. Ah yes, now I see it better, the whole KMessageBox::shouldBeShownContinue() check is bogus, since that key is not set by anything. INLINE COMMENTS > knewfilemenu.cpp:422 > QDialog *confirmDialog = new QDialog(m_parentWidget); >

D18384: Allow creating directory named '~' and throw a warning before creating it.

shubham added a comment. @pino The test case you told is not applicable(I confirmed). My test case: 1. Create directory named .foo (Results in a warning) 2. User checks "Do not ask again". 3. User tries to create directory named .xyz (This time NO WARNING appears, as it is obvious)

D18384: Allow creating directory named '~' and throw a warning before creating it.

pino added a comment. In D18384#396895 , @shubham wrote: > @pino got it what you meant. Definitely not. Let me explain it again: - so far, KNewFileMenuPrivate::confirmCreatingHiddenDir is used only to ask to the user whether choice

D18384: Allow creating directory named '~' and throw a warning before creating it.

shubham updated this revision to Diff 49935. shubham added a comment. 1. Use == 2. Rename slot's name REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18384?vs=49914=49935 BRANCH dir REVISION DETAIL https://phabricator.kde.org/D18384 AFFECTED FILES

D18384: Allow creating directory named '~' and throw a warning before creating it.

shubham marked 3 inline comments as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D18384 To: shubham, ngraham Cc: pino, dhaumann, kde-frameworks-devel, michaelh, ngraham, bruns

D18384: Allow creating directory named '~' and throw a warning before creating it.

shubham added a comment. @pino got it what you meant. Also do I need to change the _k_slotCreateHiddenDirectory( ) slot name? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D18384 To: shubham, ngraham Cc: pino, dhaumann, kde-frameworks-devel, michaelh, ngraham, bruns

D18384: Allow creating directory named '~' and throw a warning before creating it.

pino added inline comments. INLINE COMMENTS > shubham wrote in knewfilemenu.cpp:439 > == > > internally calls > > operator==() The compiler automatically replaces the operators into the calls to the appropriate functions. There is no speed penalty. REPOSITORY R241 KIO REVISION

D18384: Allow creating directory named '~' and throw a warning before creating it.

shubham added a comment. @pino Sorry for inconvenience caused. BTW I did not get what you meant? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D18384 To: shubham, ngraham Cc: pino, dhaumann, kde-frameworks-devel, michaelh, ngraham, bruns

D18384: Allow creating directory named '~' and throw a warning before creating it.

shubham added inline comments. INLINE COMMENTS > dhaumann wrote in knewfilemenu.cpp:439 > Really? But isn't == not exactly the same? Can you elaborate? == internally calls operator==() REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D18384 To: shubham, ngraham Cc:

D18384: Allow creating directory named '~' and throw a warning before creating it.

pino added a comment. Also, not related to the code: @shubham, you seem to often remove your own comments. This is a bad practice for many POV of views (transparency, breaks the logic of a conversation, etc). As these reviews send notification emails to mailing lists usually, then your

D18384: Allow creating directory named '~' and throw a warning before creating it.

dhaumann added inline comments. INLINE COMMENTS > shubham wrote in knewfilemenu.cpp:439 > This is faster than simple == Really? But isn't == not exactly the same? Can you elaborate? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D18384 To: shubham, ngraham Cc: dhaumann,

D17241: WIP:Disable highlighting after 512 characters on a line.

cullmann added a comment. Sorry to chime in that late ;=) Wouldn't it make more sense, to limit the number of ranges per line? I think the real issue is that we can't handle highlightings per line, not that the raw number of letters is that much an issue. This would relax the

D18125: KateStatusBar: Add dictionary button

cullmann requested changes to this revision. cullmann added a comment. This revision now requires changes to proceed. I played with this patch now ;) First: to now have KWrite crash on start, one need to modify one line to: if (!m_dictionaryGroup->checkedAction() ||

KDE CI: Frameworks » ktexteditor » kf5-qt5 FreeBSDQt5.12 - Build # 18 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20FreeBSDQt5.12/18/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sun, 20 Jan 2019 12:48:09 + Build duration: 6 min 45 sec and counting JUnit Tests Name:

D17459: SearchBar: Add Cancel button to stop long running tasks

This revision was automatically updated to reflect the committed changes. Closed by commit R39:7cf6644e8017: SearchBar: Add Cancel button to stop long running tasks (authored by loh.tar, committed by cullmann). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE

D17459: SearchBar: Add Cancel button to stop long running tasks

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. I played with the current state. I like it ;=) That the button "Cancel" spans over both "Replace/Find All" things is not bad in my eyes, This fixes the issue of

D17693: DocumentPrivate: Treat some chars also as "auto bracket" only when we have a selection

cullmann requested changes to this revision. cullmann added a comment. This revision now requires changes to proceed. Played a bit with it, works reasonable. Just replace const QChar with const QChar and we let this in. REVISION DETAIL https://phabricator.kde.org/D17693 To: loh.tar,

D17857: DocumentPrivate: Don't scroll view when add auto-bracket at end of file

cullmann added a comment. Extra setCursor calls are always fishy. But on the other side: how does one reproduce this? For me, if I scroll behind the last line, close to any editing action triggers scrolling, with or without this patch. REPOSITORY R39 KTextEditor REVISION DETAIL

D18384: Allow creating directory named '~' and throw a warning before creating it.

shubham added inline comments. INLINE COMMENTS > dhaumann wrote in knewfilemenu.cpp:439 > Please simply write name == QStringLiteral (...) instead of operator==. Same > below. This is faster than simple == REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D18384 To:

D17956: DocumentPrivate: Fix broken doc links in qCWarning

cullmann closed this revision. cullmann added a comment. Fixed links got commited in meantime: commit b64681408d840880c7625543992cc6a75535944a Author: Grzegorz Szymaszek Date: Thu Jan 10 08:42:46 2019 +0100

D18380: KIO: make file dialog columns resizable again (and movable)

rjvbb added a comment. One thing we might be able to do is use QFont::setStretch() to make the text a bit more compact. I'll follow that thought for a bit. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D18380 To: rjvbb, ngraham Cc: kde-frameworks-devel, michaelh,

D18380: KIO: make file dialog columns resizable again (and movable)

rjvbb added a comment. I agree that reducing the size column width isn't as easy as I thought. I find it takes up more space than necessary when horizontal space is at a premium and I was hoping to get a more compact read-out that can still be interpreted ... and that would show itself in

D18390: Build without D-Bus on Android

vkrause added a comment. In D18390#396771 , @dhaumann wrote: > You likely get a warning about an unused variable now in KBookmarkManager::init(const QString ), since the function is empty. Yep (and same for the other frameworks). I don't

D18385: Build without KAuth and D-Bus on Android

dhaumann accepted this revision. This revision is now accepted and ready to land. REPOSITORY R265 KConfigWidgets BRANCH master REVISION DETAIL https://phabricator.kde.org/D18385 To: vkrause, dhaumann Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18386: Build without D-Bus on Android

dhaumann accepted this revision. This revision is now accepted and ready to land. REPOSITORY R309 KService BRANCH master REVISION DETAIL https://phabricator.kde.org/D18386 To: vkrause, dhaumann Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18387: Build without D-Bus on Android

dhaumann accepted this revision. This revision is now accepted and ready to land. REPOSITORY R302 KIconThemes BRANCH master REVISION DETAIL https://phabricator.kde.org/D18387 To: vkrause, dhaumann Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18388: Build without D-Bus on Android

dhaumann accepted this revision. dhaumann added a comment. This revision is now accepted and ready to land. Lgtm. REPOSITORY R263 KXmlGui BRANCH master REVISION DETAIL https://phabricator.kde.org/D18388 To: vkrause, dhaumann Cc: dhaumann, kde-frameworks-devel, michaelh, ngraham,

D18389: Build without D-Bus on Android

dhaumann accepted this revision. dhaumann added a comment. This revision is now accepted and ready to land. Looks good to me. Same here: do you get warnings about unused variables now? REPOSITORY R245 Solid BRANCH master REVISION DETAIL https://phabricator.kde.org/D18389 To: vkrause,

D18390: Build without D-Bus on Android

dhaumann accepted this revision. dhaumann added a comment. This revision is now accepted and ready to land. Looks good to me. You likely get a warning about an unused variable now in KBookmarkManager::init(const QString ), since the function is empty. REPOSITORY R294 KBookmarks

D18384: Allow creating directory named '~' and throw a warning before creating it.

dhaumann added inline comments. INLINE COMMENTS > knewfilemenu.cpp:439 > KMessageBox::NoExec); > +} else if (name.operator==(QLatin1String("~"))) { > +confirmDialog->setWindowTitle(i18n("Create directory named ~?")); Please simply write name ==

KDE CI: Frameworks » ktexteditor » kf5-qt5 FreeBSDQt5.12 - Build # 17 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20FreeBSDQt5.12/17/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sun, 20 Jan 2019 07:07:49 + Build duration: 1 hr 6 min and counting JUnit Tests Name: