D18163: KateRenderer: when printing initially set the color scheme to Printing

ahmadsamir added a comment. A gentle ping. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D18163 To: ahmadsamir, cullmann, #ktexteditor, dhaumann, mwolff Cc: mwolff, kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, bruns, demsking, cullmann, sars, dha

D7446: [Places panel] Revamp the Recently Saved section

ngraham edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D7446 To: ngraham, #dolphin, broulik, elvisangelaccio, markg, #vdg, #frameworks Cc: trickyricky26, andreask, huftis, svenmauch, kde-frameworks-devel, spoorun, anthonyfieroni, andreas

D18380: KIO: make file dialog columns resizable again (and movable)

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. Sorry, I really don't think this text squeezing feature is actually desirable. Here's how it works in Kate: F6561155: squeezed-2019-01-21_16.03.33.webm

D18380: KIO: make file dialog columns resizable again (and movable)

rjvbb updated this revision to Diff 50032. rjvbb added a comment. This version uses letterspacing rather than font stretch, so works regardless of whether a stylename has been set on the font. Letterspacing reduction has a stronger impact on readability than stretch (if you cannot know t

D18380: KIO: make file dialog columns resizable again (and movable)

rjvbb set the repository for this revision to R241 KIO. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D18380 To: rjvbb, ngraham Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18116: Don't show document load trouble twice

dhaumann added a comment. Just for info: If openingErrorMessage is indeed not set anymore, this is a behavior change, since KTextEditor::Document::openingErrorMessage() is public API. Looking at lxr.kde.org, it seems this is not used (but ->openingError() is used, see https://lxr.kde.org/so

D18440: [client] Wrap wl_shell_surface_set_{class,title}

zzag added a comment. In D18440#397756 , @davidedmundson wrote: > ShellSurface is super-duper deprecated. I wouldn't invest too much time on it. Yes, I know. I just need set_class in some KWin's tests. :-) REPOSITORY R127 KWayland BR

D18440: [client] Wrap wl_shell_surface_set_{class,title}

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. ShellSurface is super-duper deprecated. I wouldn't invest too much time on it. REPOSITORY R127 KWayland BRANCH wl-shell-surface-missing-requests REVISION DETAIL https

D18440: [client] Wrap wl_shell_surface_set_{class,title}

zzag created this revision. zzag added a reviewer: KWin. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. zzag requested review of this revision. REVISION SUMMARY We have to wrap these two requests just for convenience. REPOSITORY R127 KWayland BRANCH wl

D18439: Add proper edit-delete-shred icons

trickyricky26 planned changes to this revision. trickyricky26 added a comment. I will experiment with some more pattern for the shredded part. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D18439 To: trickyricky26, #vdg Cc: ngraham, kde-frameworks-devel, michae

D18116: Don't show document load trouble twice

loh.tar updated this revision to Diff 50027. loh.tar added a comment. - Don't set m_openingErrorMessage in KateBuffer::openFile - m_openingErrorMessage is now nowhere set CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18116?vs=49031&id=50027 REVISION DETAIL https://phabricator.k

D18439: Add proper edit-delete-shred icons

ngraham added a comment. Also, visually speaking, I think that the checkerboard grid on the bottom is too fine. Making it a bit more coarse might improve things. Also have you experimented with using vertical lines instead of a checkerboard? Or maybe a checkerboard of vertical lines rather t

D18439: Add proper edit-delete-shred icons

ngraham added a comment. Symlink shenanigans make the patch not apply due to that Phab bug. :( Created and checked out branch arcpatch-D18439. Checking patch icons/actions/32/edit-delete.svg... Checking patch icons/actions/32/edit-delete-shred.svg... Checking patch dev/null =

D18439: Add proper edit-delete-shred icons

trickyricky26 edited the summary of this revision. trickyricky26 edited the test plan for this revision. trickyricky26 added a reviewer: VDG. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D18439 To: trickyricky26, #vdg Cc: kde-frameworks-devel, michaelh, ngraham, b

D18439: Add proper edit-delete-shred icons

trickyricky26 created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. trickyricky26 requested review of this revision. REPOSITORY R266 Breeze Icons BRANCH proper-shred-icons (branched from master) REVISION DETAIL https://phabricator.kde.o

D18380: KIO: make file dialog columns resizable again (and movable)

rjvbb added a comment. > The discussion in that bug kind of petered out, unfortunately. It did, and indeed. I thought a fix had been implemented for KFontRequester, but either I'm mistaken, or I have a fix locally. > I think you're the only one who understands what's going on there,

D18433: Add a Plasma Theme Preferences Icon

This revision was automatically updated to reflect the committed changes. Closed by commit R266:04e756751ceb: Add a Plasma Theme Preferences Icon (authored by trickyricky26, committed by ngraham). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18433?vs=50

D18433: Add a Plasma Theme Preferences Icon

ngraham added a comment. After some discussion, we decided to keep this name to ensure a proper fallback path for themes without this icon. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D18433 To: trickyricky26, #vdg, ndavis, GB_2, ngraham Cc: GB_2, ndavis, kd

D18433: Add a Plasma Theme Preferences Icon

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R266 Breeze Icons BRANCH add-plasma-theme-icon (branched from master) REVISION DETAIL https://phabricator.kde.org/D18433 To: trickyricky26, #vdg, ndavis, GB_2, ngraham Cc: GB_2, ndavis, kde-framewo

D18433: Add a Plasma Theme Preferences Icon

GB_2 added a comment. It should fall back to `preferences-desktop-plasma-theme`, because it fits better than `preferences-desktop-theme` and it is also what we use now. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D18433 To: trickyricky26, #vdg, ndavis, GB_2,

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.10 - Build # 4 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.10/4/ Project: kf5-qt5 SUSEQt5.10 Date of build: Mon, 21 Jan 2019 18:54:35 + Build duration: 11 min and counting BUILD ARTIFACTS abi-compatibili

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.11 - Build # 13 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.11/13/ Project: kf5-qt5 SUSEQt5.11 Date of build: Mon, 21 Jan 2019 18:54:35 + Build duration: 3 min 5 sec and counting BUILD ARTIFACTS abi-compa

D18434: exiv2extractor: add support for bmp, gif, webp, tga

kossebau created this revision. kossebau added a reviewer: Baloo. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. kossebau requested review of this revision. REVISION SUMMARY Gives only minimal info for bmp, gif & tga, but knowing the size can be usef

D18380: KIO: make file dialog columns resizable again (and movable)

ngraham added a comment. If this code depends on https://bugs.kde.org/show_bug.cgi?id=378523 being fixed, then we need to fix that first. The discussion in that bug kind of petered out, unfortunately. I think you're the only one who understands what's going on there, so would you care to hav

D18433: Add a Plasma Theme Preferences Icon

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. Please change the name to `preferences-desktop-theme-plasma`, and then I'll land it! REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D18433 To: tr

D18433: Add a Plasma Theme Preferences Icon

ndavis added a comment. In D18433#397602 , @ngraham wrote: > We have `preferences-desktop-theme-global`; shouldn't this be `preferences-desktop-theme-plasma`? Good point REPOSITORY R266 Breeze Icons BRANCH add-plasma-theme-icon (bra

D18432: Improve contrast of preferences-system-time

This revision was automatically updated to reflect the committed changes. Closed by commit R266:871dd742651b: Improve contrast of preferences-system-time (authored by trickyricky26, committed by ngraham). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D184

D18432: Improve contrast of preferences-system-time

ngraham accepted this revision. REPOSITORY R266 Breeze Icons BRANCH fix-clock-icon-contrast (branched from master) REVISION DETAIL https://phabricator.kde.org/D18432 To: trickyricky26, #vdg, ngraham, ndavis Cc: ndavis, ngraham, kde-frameworks-devel, michaelh, bruns

D18433: Add a Plasma Theme Preferences Icon

ngraham added a comment. We have `preferences-desktop-theme-global`; shouldn't this be `preferences-desktop-theme-plasma`? REPOSITORY R266 Breeze Icons BRANCH add-plasma-theme-icon (branched from master) REVISION DETAIL https://phabricator.kde.org/D18433 To: trickyricky26, #vdg, ndav

D18433: Add a Plasma Theme Preferences Icon

ngraham accepted this revision. REPOSITORY R266 Breeze Icons BRANCH add-plasma-theme-icon (branched from master) REVISION DETAIL https://phabricator.kde.org/D18433 To: trickyricky26, #vdg, ndavis, GB_2, ngraham Cc: GB_2, ndavis, kde-frameworks-devel, michaelh, ngraham, bruns

D18433: Add a Plasma Theme Preferences Icon

GB_2 accepted this revision. GB_2 added a comment. +1 REPOSITORY R266 Breeze Icons BRANCH add-plasma-theme-icon (branched from master) REVISION DETAIL https://phabricator.kde.org/D18433 To: trickyricky26, #vdg, ndavis, GB_2 Cc: GB_2, ndavis, kde-frameworks-devel, michaelh, ngraham, br

D18432: Improve contrast of preferences-system-time

ndavis accepted this revision. This revision is now accepted and ready to land. REPOSITORY R266 Breeze Icons BRANCH fix-clock-icon-contrast (branched from master) REVISION DETAIL https://phabricator.kde.org/D18432 To: trickyricky26, #vdg, ngraham, ndavis Cc: ndavis, ngraham, kde-framework

D18432: Improve contrast of preferences-system-time

trickyricky26 updated this revision to Diff 50007. trickyricky26 added a comment. - Make the outline a solid circle behind the black on to avoid weird aliasing issues REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18432?vs=50003&id=50007 BRANCH fix

D18433: Add a Plasma Theme Preferences Icon

ndavis accepted this revision. ndavis added a comment. This revision is now accepted and ready to land. Looks good to me! REPOSITORY R266 Breeze Icons BRANCH add-plasma-theme-icon (branched from master) REVISION DETAIL https://phabricator.kde.org/D18433 To: trickyricky26, #vdg, ndavis

D18433: Add a Plasma Theme Preferences Icon

trickyricky26 edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D18433 To: trickyricky26, #vdg Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18433: Add a Plasma Theme Preferences Icon

trickyricky26 edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D18433 To: trickyricky26, #vdg Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18433: Add a Plasma Theme Preferences Icon

trickyricky26 updated this revision to Diff 50006. trickyricky26 added a comment. - Make the Plasma Logo the same size as the Plasma Preferences Icon REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18433?vs=50005&id=50006 BRANCH add-plasma-theme-icon

D18432: Improve contrast of preferences-system-time

ndavis requested changes to this revision. ndavis added a comment. This revision now requires changes to proceed. Make the outline a solid circle behind the clock part instead of just an outline. The reason for this is that the edges between the outline and the clock look worse if the outline

D18433: Add a Plasma Theme Preferences Icon

trickyricky26 planned changes to this revision. trickyricky26 added a comment. I will make the Plasma logo the same size as the one in `preferences-desktop-plasma`. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D18433 To: trickyricky26, #vdg Cc: kde-frameworks

D18433: Add a Plasma Theme Preferences Icon

trickyricky26 edited the summary of this revision. trickyricky26 edited the test plan for this revision. trickyricky26 added a reviewer: VDG. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D18433 To: trickyricky26, #vdg Cc: kde-frameworks-devel, michaelh, ngraham, b

D18433: Add a Plasma Theme Preferences Icon

trickyricky26 created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. trickyricky26 requested review of this revision. REPOSITORY R266 Breeze Icons BRANCH add-plasma-theme-icon (branched from master) REVISION DETAIL https://phabricator.kd

D18432: Improve contrast of preferences-system-time

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Looks good to me! Other #VDG folks, shall we land this? REPOSITORY R266 Breeze Icons BRANCH fix-clock-icon-contrast (branched from master) REV

D18432: Improve contrast of preferences-system-time

trickyricky26 edited the summary of this revision. trickyricky26 edited the test plan for this revision. trickyricky26 added a reviewer: VDG. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D18432 To: trickyricky26, #vdg Cc: kde-frameworks-devel, michaelh, ngraham, b

D17691: Add rows info to the plasma virtual desktop protocol

zzag added inline comments. INLINE COMMENTS > plasmavirtualdesktop_interface.cpp:94 > > const quint32 PlasmaVirtualDesktopManagementInterface::Private::s_version = > 1; > This one should be bumped as well. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D17691 T

D13216: Overhaul the file index scheduler.

bruns added a comment. In D13216#397326 , @smithjd wrote: > "Locking" the scheduler is simpler here than identifying that it "has gone idle". "Locking" only happens here for a small number of runnables (two) that can't run concurrently.

D18432: Improve contrast of preferences-system-time

trickyricky26 created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. trickyricky26 requested review of this revision. REPOSITORY R266 Breeze Icons BRANCH fix-clock-icon-contrast (branched from master) REVISION DETAIL https://phabricator.

D17691: Add rows info to the plasma virtual desktop protocol

davidedmundson added inline comments. INLINE COMMENTS > davidedmundson wrote in plasma-virtual-desktop.xml:56 > This isn't done. event needs to be at the end (like how you keep source compatibility in a C++ enum) > plasmavirtualdesktop_interface.cpp:201 > +for (auto it = d->resources.const

D17691: Add rows info to the plasma virtual desktop protocol

mart updated this revision to Diff 49994. mart added a comment. - rows belongs to protocol version 2 REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17691?vs=49610&id=49994 BRANCH phab/virtualdesktoprows REVISION DETAIL https://phabricator.kde.org/D17

KDE CI: Frameworks » kdesu » kf5-qt5 FreeBSDQt5.12 - Build # 5 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kdesu/job/kf5-qt5%20FreeBSDQt5.12/5/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Mon, 21 Jan 2019 13:13:49 + Build duration: 1 min 7 sec and counting JUnit Tests Name: projectroo

D10716: handle wrong password when using sudo which asks for another password

This revision was automatically updated to reflect the committed changes. Closed by commit R299:2e8ce30c9498: handle wrong password when using sudo which asks for another password (authored by jriddell). REPOSITORY R299 KDESu CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10716?vs=49

D10716: handle wrong password when using sudo which asks for another password

fvogt accepted this revision. This revision is now accepted and ready to land. REPOSITORY R299 KDESu BRANCH arcpatch-D10716 REVISION DETAIL https://phabricator.kde.org/D10716 To: jriddell, sitter, fvogt Cc: starbuck, fvogt, kde-frameworks-devel, michaelh, ngraham, bruns

D10716: handle wrong password when using sudo which asks for another password

jriddell updated this revision to Diff 49986. jriddell added a comment. Don't use friend class REPOSITORY R299 KDESu CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10716?vs=49459&id=49986 BRANCH arcpatch-D10716 REVISION DETAIL https://phabricator.kde.org/D10716 AFFECTED FIL

D11236: [KCrash] Establish socket to allow change of ptracer

ossi added a comment. i said "3rd line", not "3rd case". it's about the ancestry; see the other change. REPOSITORY R285 KCrash REVISION DETAIL https://phabricator.kde.org/D11236 To: croick, #frameworks, ossi Cc: dfaure, lepagevalleeemmanuel, kde-frameworks-devel, sitter, michaelh, ngra

D17015: Fix the Qt doc creation with Qt 5.12.

cgiboudeaux abandoned this revision. cgiboudeaux added a comment. qhelpgenerator is back in Qt 5.12.1 REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D17015 To: cgiboudeaux, kossebau Cc: thiago, tcberner, kde-frameworks-devel, kde-buildsystem, michaelh, ng

D18425: [KUrlNavigatorPlacesSelector] Properly identify teardown action

broulik planned changes to this revision. broulik added a comment. There seems to be one issue that when you open a mounted drive directly, you get an "Unmount" entry at the top. Likely because the places are populated after the entry was created. Perhaps the remove codepath needs to itera

D18425: [KUrlNavigatorPlacesSelector] Properly identify teardown action

anthonyfieroni added a comment. +1 REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D18425 To: broulik, #frameworks, dfaure Cc: anthonyfieroni, kde-frameworks-devel, michaelh, ngraham, bruns

D18380: KIO: make file dialog columns resizable again (and movable)

rjvbb added a comment. Oh sh@@t, I understand what's happening here. The default look-and-feel still appends the Regular stylename to the font, and since font stretch is a programmatic way to set a font style ("condensed") this too is overridden when a stylename is set. That does NO

KDE CI: Frameworks » ktexteditor » kf5-qt5 FreeBSDQt5.12 - Build # 19 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20FreeBSDQt5.12/19/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Mon, 21 Jan 2019 10:56:43 + Build duration: 6 min 4 sec and counting JUnit Tests Name: pro

D18425: [KUrlNavigatorPlacesSelector] Properly identify teardown action

broulik created this revision. broulik added reviewers: Frameworks, dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY Rather than relying on the model count (which broke when we added places c

D18167: Move -Wsuggest-override -Wlogical-op to regular compiler settings

kossebau added a comment. In D18167#397319 , @graesslin wrote: > For done code this warning is pointless and negative. I invite you to work with a code base like KWin where it is more important to have a working git blame than protection for th

D18424: Instantiate QApplication before KCrash/KCatalog

sdepiets closed this revision. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D18424 To: sdepiets, #baloo, bruns, poboiko, mlaurent Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams