D18960: Add compile check to FindEGL

hausmann added a comment. Ooops. Could you paste the error from the cmake error output? I'm curious which part of the EGL compile test fails. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D18960 To: hausmann, vkrause, apol Cc: tcberner, kossebau, kde-fr

D18997: Add functions returning all definitions for a mimetype or file name

cullmann requested changes to this revision. cullmann added a comment. This revision now requires changes to proceed. Makes sense. Could you add a @since 5.56 to the doxygen? Otherwise this seems fine. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.o

D18997: Add functions returning all definitions for a mimetype or file name

davschul created this revision. davschul added a reviewer: vkrause. davschul added a project: Framework: Syntax Highlighting. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. davschul requested review of this revision. REVISION SUMMARY This c

D18982: prevent assertion in regex load

This revision was automatically updated to reflect the committed changes. Closed by commit R216:152968754edc: prevent assertion in regex load (authored by davschul, committed by cullmann). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18982?vs=516

D18982: prevent assertion in regex load

davschul added a comment. David Schulz david.sch...@qt.io REVISION DETAIL https://phabricator.kde.org/D18982 To: davschul, vkrause, cullmann Cc: cullmann, dhaumann, kwrite-devel, kde-frameworks-devel, gennad, michaelh, ngraham, bruns, demsking, sars

D18996: Fix building with namespaced Qt

cullmann added a comment. I think target_link_libraries is the right way to fix it, that's OK. I am not that into the QT_ macro magic, perhaps Volker can comment if that is ok ;) REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D18996 To: davschul, v

D18982: prevent assertion in regex load

cullmann added a comment. I can push that for you, which user to use? "David Schulz" REVISION DETAIL https://phabricator.kde.org/D18982 To: davschul, vkrause, cullmann Cc: cullmann, dhaumann, kwrite-devel, kde-frameworks-devel, gennad, michaelh, ngraham, bruns, demsking, sars

D18982: prevent assertion in regex load

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. I assume Volker profiled it. I think it is ok to just check if the logging is on. 99% of the syntax definitions are anyways bundled and are checked by the indexer for such obvious fa

D18996: Fix building with namespaced Qt

davschul added inline comments. INLINE COMMENTS > CMakeLists.txt:62 > set_property(TARGET SyntaxHighlightingData PROPERTY > POSITION_INDEPENDENT_CODE 1) > +target_link_libraries(SyntaxHighlightingData PRIVATE Qt5::Core) This seems like an overkill, but I'm new to CMAKE and it seems that this w

D18996: Fix building with namespaced Qt

davschul created this revision. davschul added a reviewer: vkrause. davschul added a project: Framework: Syntax Highlighting. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. davschul requested review of this revision. REVISION SUMMARY Add QT

D18986: [breeze-icons] Add video camera icons

trickyricky26 added a comment. In D18986#411807 , @ngraham wrote: > I like the head-on camcorder style, but there's the risk that it's less recognizable than the "classic" style of video recorder icon that's used pretty much everywhere. If we go

D18982: prevent assertion in regex load

davschul updated this revision to Diff 51643. davschul added a comment. added additional context to the diff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18982?vs=51588&id=51643 REVISION DETAIL https://phabricator.kde.org/D18982 AFFECTED FILES src/lib/rule.cpp To: davschul,

D18982: prevent assertion in regex load

davschul added inline comments. INLINE COMMENTS > dhaumann wrote in rule.cpp:579-582 > I even wonder whether this should be always printed, i.e.: > > const bool isValid = m_regexp.isValid(); > if (!isValid) > qCWarning(...) << "Invalid regexp:" << m_regexp.pattern(); > } > return i

D18940: Add battery icons

ndavis added a comment. This is the configuration for `status/32`: [status/32] Size=32 Context=Status Type=Fixed This currently prevents the 32px icons in this patch from being used: [status/22] Size=22 Context=Status Type=Scalable MinSize=22 M

D18951: HTML: highlight JSX, TypeScript & MustacheJS code in the

cullmann added a comment. In D18951#411715 , @nibags wrote: > I can add more examples in "autotests/input/highlight.php", for all the cases of languages ​​included That would be nice. REPOSITORY R216 Syntax Highlighting REVISION DETAI

D18995: Explicitly link against KAuth

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. OK, Thanks! REPOSITORY R39 KTextEditor BRANCH master REVISION DETAIL https://phabricator.kde.org/D18995 To: apol, #kate, #frameworks, vkrause, cullmann Cc: cullmann, kwrite-deve

KDE CI: Frameworks » kwayland » kf5-qt5 FreeBSDQt5.12 - Build # 22 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20FreeBSDQt5.12/22/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Thu, 14 Feb 2019 05:28:58 + Build duration: 29 sec and counting CONSOLE OUTPUT [...truncated 1

D18986: [breeze-icons] Add video camera icons

ngraham added a comment. I like the head-on camcorder style, but there's the risk that it's less recognizable than the "classic" style of video recorder icon that's used pretty much everywhere. If we go with the head-on style, it needs to be //perfect//. Oh and I agree with @ndavis: let'

D18995: Explicitly link against KAuth

apol created this revision. apol added reviewers: Kate, Frameworks, vkrause. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. apol requested review of this revision. REVISION SUMMARY Otherwise it fails on Android, probably because the KAuth d

D18988: Adapt to changes in kconfigwidgets

This revision was automatically updated to reflect the committed changes. Closed by commit R295:74a4c0240787: Adapt to changes in kconfigwidgets (authored by apol). REPOSITORY R295 KCMUtils CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18988?vs=51623&id=51640 REVISION DETAIL http

D18986: [breeze-icons] Add video camera icons

rooty added a comment. > Why would film reels go on a modern style camera?... If you do an old style camera, do a side view. That was my point exactly ... REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D18986 To: rooty, #vdg, hein, ndavis Cc: trickyr

D18986: [breeze-icons] Add video camera icons

ndavis added a comment. In D18986#411771 , @rooty wrote: > Should it be a head on view? Or should it be a side view? Head on if you're going to use this style. Side if you're going to use the first style. > People also complain about

D18986: [breeze-icons] Add video camera icons

rooty added a comment. In D18986#411765 , @ndavis wrote: > In D18986#411749 , @rooty wrote: > > > In D18986#411746 , @ndavis wrote: > > > > > In D18986#

D18986: [breeze-icons] Add video camera icons

ndavis added a comment. In D18986#411749 , @rooty wrote: > In D18986#411746 , @ndavis wrote: > > > In D18986#411735 , @rooty wrote: > > > > > https://co

D18986: [breeze-icons] Add video camera icons

rooty updated this revision to Diff 51636. rooty added a comment. Replace boxy 64 px version with newer head-on variant, still a WIP though REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18986?vs=51626&id=51636 BRANCH video-camera-icon (branched fro

D18986: [breeze-icons] Add video camera icons

rooty added a comment. In D18986#411746 , @ndavis wrote: > In D18986#411735 , @rooty wrote: > > > https://commons.wikimedia.org/wiki/File:Icons8_flat_camcorder.svg > > > > Can we use this one it's

D18986: [breeze-icons] Add video camera icons

ndavis added a comment. In D18986#411735 , @rooty wrote: > https://commons.wikimedia.org/wiki/File:Icons8_flat_camcorder.svg > > Can we use this one it's so pretty? Well, we can't use that exact icon, but you can make something similar

D18986: [breeze-icons] Add video camera icons

rooty added a comment. https://commons.wikimedia.org/wiki/File:Icons8_flat_camcorder.svg Can we use this one it's so pretty? REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D18986 To: rooty, #vdg, hein, ndavis Cc: trickyricky26, ngraham, kde-frameworks-devel

D18986: [breeze-icons] Add video camera icons

ndavis added a comment. In D18986#411719 , @rooty wrote: > Because of camera-photo.svg, and I also really like Plasma Blue. I'm open to suggestions, mockups, anything that would look better than the current 64 px icon. Interestingly, mos

D18986: [breeze-icons] Add video camera icons

rooty added a comment. > - The top and bottom outlines > - The blue patch on the side Because of camera-photo.svg, and I also really like Plasma Blue. I'm open to suggestions, mockups, anything that would look better than the current 64 px icon. > I'd suggest seeing how the lens o

D18986: [breeze-icons] Add video camera icons

ndavis added a comment. For the color icon: Avoid using the plasma logo unnecessarily. In existing device icons that use it (I want to move away from using it), it's usually placed where a brand logo would go on a real product. Just so I can have an idea about how your design works, co

D18951: HTML: highlight JSX, TypeScript & MustacheJS code in the

nibags added a comment. I can add more examples in "autotests/input/highlight.php", for all the cases of languages ​​included REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D18951 To: nibags, #framework_syntax_highlighting, dhaumann, cullmann Cc: kwrite-

D18986: [breeze-icons] Add video camera icons

rooty updated this revision to Diff 51626. rooty added a comment. Replace rounded corners with right angles REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18986?vs=51621&id=51626 BRANCH video-camera-icon (branched from master) REVISION DETAIL htt

D18988: Adapt to changes in kconfigwidgets

vkrause accepted this revision. This revision is now accepted and ready to land. REPOSITORY R295 KCMUtils BRANCH master REVISION DETAIL https://phabricator.kde.org/D18988 To: apol, #frameworks, vkrause Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18986: [breeze-icons] Add video camera icons

rooty added a comment. In D18986#411679 , @ndavis wrote: > In D18986#411636 , @rooty wrote: > > > How about now? F6613626: image.png I made the monochrome versi

D18986: [breeze-icons] Add video camera icons

ndavis added a comment. In D18986#411636 , @rooty wrote: > How about now? F6613626: image.png I made the monochrome version a little taller Breeze monochrome icons are primarily made of ellipses and

D18986: [breeze-icons] Add video camera icons

rooty added a comment. In D18986#411655 , @trickyricky26 wrote: > I think the monochrome version is fine. > For the colorful version, I suggest making the screen much bigger if that side isn't going to be filled with more buttons or the like.

D18988: Adapt to changes in kconfigwidgets

apol created this revision. apol added reviewers: Frameworks, vkrause. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. apol requested review of this revision. REVISION SUMMARY It may be built without KAuth KCONFIGWIDGETS_NO_KAUTH REPOSITORY R295 KCMUtils

D18986: [breeze-icons] Add video camera icons

trickyricky26 added a comment. I think the monochrome version is fine. For the colorful version, I suggest making the screen much bigger if that side isn't going to be filled with more buttons or the like. Also the partial outlines only on the top and bottom feel weird to me. I know th

D18986: [breeze-icons] Add video camera icons

rooty retitled this revision from "[breeze-icons] WIP, Add video camera icons" to "[breeze-icons] Add video camera icons". REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D18986 To: rooty, #vdg, hein, ndavis Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D18987: Add missing dependency on KAuth

This revision was automatically updated to reflect the committed changes. Closed by commit R295:a852059e0460: Add missing dependency on KAuth (authored by apol). REPOSITORY R295 KCMUtils CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18987?vs=51620&id=51622 REVISION DETAIL https:/

D18986: [breeze-icons] WIP, Add video camera icons

rooty edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D18986 To: rooty, #vdg, hein, ndavis Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D18987: Add missing dependency on KAuth

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R295 KCMUtils BRANCH master REVISION DETAIL https://phabricator.kde.org/D18987 To: apol, #frameworks, davidedmundson Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18986: [breeze-icons] WIP, Add video camera icons

rooty updated this revision to Diff 51621. rooty added a comment. Make monochrome versions taller REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18986?vs=51619&id=51621 BRANCH video-camera-icon (branched from master) REVISION DETAIL https://phabr

D18986: [breeze-icons] WIP, Add video camera icons

ngraham added a comment. That's much better! REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D18986 To: rooty, #vdg, hein, ndavis Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D18986: [breeze-icons] WIP, Add video camera icons

rooty added a comment. How about now? F6613626: image.png I made the monochrome version a little taller REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D18986 To: rooty, #vdg, hein, ndavis Cc: ngraham, kde-frameworks-devel,

D18987: Add missing dependency on KAuth

apol created this revision. apol added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. apol requested review of this revision. REVISION SUMMARY kcmoduleqml.cpp depends on it REPOSITORY R295 KCMUtils BRANCH master REVISION DETAIL

D18986: [breeze-icons] WIP, Add video camera icons

rooty added a comment. In D18986#411619 , @ngraham wrote: > Hmm, TBH I think this needs work. The monochrome version feels too long to me; I think shorter and more square would be better. And the color version feels too plain and boxy. > > M

D18986: [breeze-icons] WIP, Add video camera icons

rooty added a reviewer: ndavis. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D18986 To: rooty, #vdg, hein, ndavis Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18986: [breeze-icons] WIP, Add video camera icons

ngraham added a comment. Hmm, TBH I think this needs work. The monochrome version feels too long to me; I think shorter and more square would be better. And the color version feels too plain and boxy. Maybe take inspiration from some of the ones that show up here? https://www.flaticon.c

D18986: [breeze-icons] WIP, Add video camera icons

rooty edited the summary of this revision. rooty edited the test plan for this revision. rooty added reviewers: VDG, hein. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D18986 To: rooty, #vdg, hein Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18986: [breeze-icons] WIP, Add video camera icons

rooty created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. rooty requested review of this revision. REPOSITORY R266 Breeze Icons BRANCH video-camera-icon (branched from master) REVISION DETAIL https://phabricator.kde.org/D18986 AFFECT

D18960: Add compile check to FindEGL

tcberner added a comment. In D18960#411562 , @kossebau wrote: > Seems this is sadly breaking something for FreeBSD though, see > https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20FreeBSDQt5.12/21/console I'll look into it

D18960: Add compile check to FindEGL

kossebau added a comment. Seems this is sadly breaking something for FreeBSD though, see https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20FreeBSDQt5.12/21/console REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D18960 To: hausmann, vkraus

KDE CI: Frameworks » kwayland » kf5-qt5 FreeBSDQt5.12 - Build # 21 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20FreeBSDQt5.12/21/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Wed, 13 Feb 2019 17:14:08 + Build duration: 27 sec and counting CONSOLE OUTPUT [...truncated 1

D18940: Add battery icons

ngraham added a comment. Not trying to slip anything in (this patch doesn't and can't touch plasma-framework, after all), just mentioning it. :) The proposal is in T10046: Improve the colors, color consistency and colorscheme compatibility of Breeze .

D18940: Add battery icons

broulik added a comment. The do a proper proposal (I bet you already have a task about that) instead of just slipping things in one by one in unrelated reviews REPOSITORY R266 Breeze Icons BRANCH battery-icons (branched from master) REVISION DETAIL https://phabricator.kde.org/D18940

D18940: Add battery icons

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Ideally I would like to move all icons out of Plasma themes, because these themes are not 100% self-contained and often use icons from the icon theme anyway, and users get confused as to

D18982: prevent assertion in regex load

dhaumann added a comment. I think that makes a lot of sense. Maybe we should even always print the warning, not only in debug mode? See comment below... PS: When submitting patches without phabricator's arc tool, could you add more diff context, like `git diff -U99 ...`. Then reviewing i

D18822: Fix Windows build [hopefully]

kossebau added a comment. Good news, kauth now passed at least CI again for all platforms tested there (so incl. Windows) :) Your iniail fix was almost complete, @aacid, just missed that last bit for the autotests code, so take pride here :) REPOSITORY R283 KAuth REVISION DETAIL https:/

KDE CI: Frameworks » kauth » kf5-qt5 WindowsMSVCQt5.11 - Build # 26 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kauth/job/kf5-qt5%20WindowsMSVCQt5.11/26/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Wed, 13 Feb 2019 15:03:02 + Build duration: 2 min 50 sec and counting JUnit Tests Name: p

D18822: Fix Windows build [hopefully]

This revision was not accepted when it landed; it landed in state "Needs Revision". This revision was automatically updated to reflect the committed changes. Closed by commit R283:c0854de284b7: Fix Windows build [hopefully] (authored by aacid, committed by kossebau). CHANGED PRIOR TO COMMIT ht

D18734: Update octave.xml to Octave 4.2.0

sirgienko added a comment. In D18734#411032 , @cullmann wrote: > Good question: > > I added a minimal howto to the README.md: > > https://commits.kde.org/syntax-highlighting/9343341f91274f899f74b1ffe3fa260dadbc0978 > > Does that help

D18981: fix off-by-one on the version restriction for dnssd

This revision was automatically updated to reflect the committed changes. Closed by commit R320:ba940a1cba05: fix off-by-one on the version restriction for dnssd (authored by sitter). REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18981?vs=51587&id=51590 R

D18981: fix off-by-one on the version restriction for dnssd

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R320 KIO Extras BRANCH master REVISION DETAIL https://phabricator.kde.org/D18981 To: sitter, broulik, ngraham Cc: kde-frameworks-devel, kfm-devel, alexde, feverfew, michaelh, spoorun, navarromoral

D18982: prevent assertion in regex load

davschul created this revision. davschul added a reviewer: vkrause. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. davschul requested review of this revision. REVISION SUMMARY Instead of crashing the complete application with an assert on a

D18981: fix off-by-one on the version restriction for dnssd

sitter created this revision. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. sitter requested review of this revision. REVISION SUMMARY 5.54 had the fix, so anything greater 5.53 would do REPOSITORY R320 KIO Extras BRANCH master REVI

D18981: fix off-by-one on the version restriction for dnssd

sitter added a reviewer: broulik. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D18981 To: sitter, broulik Cc: kde-frameworks-devel, kfm-devel, alexde, feverfew, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov

D18907: Handle the case if createSpeller is passed an unavailable language

ahmadsamir added a comment. I don't have commit access, so please commit the diff. Thanks. REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D18907 To: ahmadsamir, sandsmark, cullmann, dhaumann Cc: dhaumann, cullmann, loh.tar, kde-frameworks-devel, michaelh, ngraham

D18907: Handle the case if createSpeller is passed an unavailable language

ahmadsamir updated this revision to Diff 51578. ahmadsamir added a comment. Avoid shorthand in api docs REPOSITORY R246 Sonnet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18907?vs=51552&id=51578 REVISION DETAIL https://phabricator.kde.org/D18907 AFFECTED FILES src/core/lo

D18878: Force NT1 protocol when listing smb:// network [work in progress]

mikhailnov updated this revision to Diff 51577. mikhailnov retitled this revision from "Force NT1 protocol when listing smb:// network" to "Force NT1 protocol when listing smb:// network [work in progress]". mikhailnov added a comment. Here is a new prototype of the patch. It builds, but the p

D18822: Fix Windows build [hopefully]

bcooksley added a comment. @kossebau Please go ahead with testing via trial and error in this manner. REPOSITORY R283 KAuth REVISION DETAIL https://phabricator.kde.org/D18822 To: aacid, vonreth Cc: bcooksley, albertvaka, kossebau, vonreth, kde-frameworks-devel, michaelh, ngraham, bruns

D18940: Add battery icons

ndavis added a comment. In D18940#411319 , @broulik wrote: > The battery icon is composited of multiple SVG items layered ontop of each other, it doesn't just load a single icon. > > I'm in favor of adding proper battery icons to the Breeze i

D18940: Add battery icons

broulik added a comment. The battery icon is composited of multiple SVG items layered ontop of each other, it doesn't just load a single icon. I'm in favor of adding proper battery icons to the Breeze iconset, definitely need "battery", "battery-caution", "battery-low" icons (from the fr

D18940: Add battery icons

ndavis added a comment. In D18940#411317 , @broulik wrote: > In D18940#411316 , @ndavis wrote: > > > Won't 3rd party themes contain their own icons? > > > Sure but in the style of a Plasma batte

D18940: Add battery icons

broulik added a comment. In D18940#411316 , @ndavis wrote: > Won't 3rd party themes contain their own icons? Sure but in the style of a Plasma battery.svgz, so if we change the `BatteryIcon` to use icon theme instead of Plasma theme icons

D18940: Add battery icons

ndavis added a comment. In D18940#411303 , @broulik wrote: > > maybe we can port the code to use these as icons from the icon theme rather than SVGs from the Plasma theme and then delete them from the Plasma theme > > And in the process brea

D18952: new find module for Canberra

sitter added a comment. Good point, I've also noticed that (all?) our finders now also create an IMPORTED target. Should we maybe add that too? If so I guess `Canberra::Canberra` would be the preferred target name? REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.

D18952: new find module for Canberra

sitter updated this revision to Diff 51576. sitter added a comment. document in rst syntax REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18952?vs=51491&id=51576 BRANCH master REVISION DETAIL https://phabricator.kde.org/D18952 AFFECTED FI

D18960: Add compile check to FindEGL

This revision was automatically updated to reflect the committed changes. Closed by commit R240:0b47899c1b92: Add compile check to FindEGL (authored by hausmann). REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18960?vs=51512&id=51574 REVISION DETA

D18940: Add battery icons

broulik added a comment. > maybe we can port the code to use these as icons from the icon theme rather than SVGs from the Plasma theme and then delete them from the Plasma theme And in the process break all third party Plasma themes? REPOSITORY R266 Breeze Icons REVISION DETAIL http