D19108: [ExternalExtractor] Provide more helpful output when extractor fails

lbeltrame accepted this revision. lbeltrame added a comment. This revision is now accepted and ready to land. LGTM!. Annoyed me for a long time (and made hard to debug some issues). INLINE COMMENTS > externalextractor.cpp:120 > extractorProcess.start(d->mainPath, QStringList(), QIODevice

D19020: [breeze-icons] Revamp system.svgz

ndavis added a comment. In D19020#414317 , @rooty wrote: > In D19020#414300 , @abetts wrote: > > > Well, maybe it is time to call it and be done. I don't think we are going to please everyone right n

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.12 - Build # 29 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.12/29/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Mon, 18 Feb 2019 04:19:23 + Build duration: 8 min 35 sec and counting JUnit Tests Name: projectroo

KDE CI: Frameworks » kio » kf5-qt5 WindowsMSVCQt5.11 - Build # 195 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20WindowsMSVCQt5.11/195/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Mon, 18 Feb 2019 04:19:22 + Build duration: 7.5 sec and counting CONSOLE OUTPUT [...trunca

D19111: Have ShareFileItemAction provide an output or an error if they are provided

apol created this revision. apol added reviewers: Dolphin, Frameworks, nicolasfella. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. apol requested review of this revision. REVISION SUMMARY BUG: 397567 TEST PLAN Manual testing on dolphin REPOSITORY R495

D19080: [WIP] Make file overwrite a bit safer

chinmoyr updated this revision to Diff 51939. chinmoyr marked 2 inline comments as done. chinmoyr added a comment. Update. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19080?vs=51876&id=51939 BRANCH safe-overwrite REVISION DETAIL https://phabricator.kde

D19109: [Extractor] Add metadata to extractors

bruns retitled this revision from "[Extractor] Add metadata to properties" to "[Extractor] Add metadata to extractors". REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D19109 To: bruns, #baloo, #frameworks, ngraham, astippich, poboiko Cc: kde-frameworks-devel, asha

D19020: [breeze-icons] Revamp system.svgz

rooty added a comment. In D19020#414300 , @abetts wrote: > Well, maybe it is time to call it and be done. I don't think we are going to please everyone right now. Maybe our best option is to have you, as the proponent of this idea, make the deci

D19020: [breeze-icons] Revamp system.svgz

rooty edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D19020 To: rooty, #vdg, #plasma, ngraham, abetts Cc: trickyricky26, ndavis, broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D19020: [breeze-icons] Revamp system.svgz

rooty updated this revision to Diff 51938. rooty added a comment. Center user prompt icon vertically REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19020?vs=51920&id=51938 BRANCH user-prompt-list-icons (branched from master) REVISION

D19005: android: don't default to gcc anymore

apol added a comment. In D19005#412258 , @vkrause wrote: > Actually having tested this, "deprecated_value" looks wrong there, shouldn't this be "default_value"? no, the value is coming from the cache, so that's the one we're setting. What

D19110: Don't show the tooltip when the drop-down menu is shown

apol created this revision. apol added reviewers: Kirigami, Frameworks. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY The menu itself should already offer enough information BUG: 404371 REPOSITORY R169

D19075: Fix FindEGL

apol accepted this revision. REPOSITORY R240 Extra CMake Modules BRANCH master REVISION DETAIL https://phabricator.kde.org/D19075 To: tcberner, #automotive, hausmann, #freebsd, apol Cc: kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D19109: [Extractor] Add metadata to properties

bruns edited the summary of this revision. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D19109 To: bruns, #baloo, #frameworks, ngraham, astippich, poboiko Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D19020: [breeze-icons] Revamp system.svgz

abetts added a comment. Well, maybe it is time to call it and be done. I don't think we are going to please everyone right now. Maybe our best option is to have you, as the proponent of this idea, make the decision after long debate. REPOSITORY R242 Plasma Framework (Library) REVISION DET

D19020: [breeze-icons] Revamp system.svgz

rooty added a comment. In D19020#414285 , @abetts wrote: > I think the icon is pretty much there. Maybe the label can help the meaning come across. What about: > > "Enter User" > "Type User" > "Change User" haha it was actually

D19109: [Extractor] Add metadata to properties

bruns created this revision. bruns added reviewers: Baloo, Frameworks, ngraham, astippich, poboiko. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY This adds extractor metadata in a backwards and

D19107: Write valid UTF8 characters without escaping.

rapiteanu added a comment. The commit fixes (as expected) the config write issue observed in 403557. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D19107 To: vandenoever, dfaure, arichardson, apol Cc: rapiteanu, kde-frameworks-devel, michaelh, ngraham, bruns

D19020: [breeze-icons] Revamp system.svgz

abetts added a comment. I think the icon is pretty much there. Maybe the label can help the meaning come across. What about: "Enter User" "Type User" "Change User" REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D19020 To: rooty, #vdg, #pl

D19108: [ExternalExtractor] Provide more helpful output when extractor fails

bruns created this revision. bruns added reviewers: Baloo, Frameworks, ngraham, poboiko, astippich. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY In case the executable fails to start, no error

D18611: [appimage thumbnailer] Rely on imported cmake target libappimage

kossebau added a comment. Created https://github.com/AppImage/libappimage/pull/71 as one approach to get this solved on libappimage side. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D18611 To: kossebau, broulik Cc: sitter, kde-frameworks-devel, kfm-devel, alex

D18450: Add extractor for AppImage files

kossebau updated this revision to Diff 51934. kossebau added a comment. - update to latest master - remove unused name() method REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18450?vs=50535&id=51934 BRANCH addappimageextractor REVISION DETAIL

D18450: Add extractor for AppImage files

kossebau added a comment. In D18450#402995 , @astippich wrote: > Just noticed, you never use the AppDataParser.name(). Is that intentional? Good catch, was left over from first code drafts, before I aligned the data mapping with what I h

D19107: Write valid UTF8 characters without escaping.

vandenoever created this revision. vandenoever added reviewers: dfaure, arichardson, apol. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vandenoever requested review of this revision. REVISION SUMMARY commit 6a18528

D19020: [breeze-icons] Revamp system.svgz

rooty added a comment. In D19020#414231 , @trickyricky26 wrote: > As they are now it's long, short, long (exact same length as rectangle number 1), shorter than height (which looks bad imo). There are no medium lengths and the same length is us

D19103: Middle-elide very long filenames in error strings

ngraham updated this revision to Diff 51931. ngraham added a comment. Make the length a variable REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19103?vs=51919&id=51931 BRANCH squeeze-very-long-filenames (branched from master) REVISION DETAIL https://phabr

D19020: [breeze-icons] Revamp system.svgz

trickyricky26 added a comment. As they are now it's long, short, long (exact same length as rectangle number 1), shorter than height (which looks bad imo). There are no medium lengths and the same length is used twice. I would suggest giving every bar a different length. If you're going

D18968: Word-wrap KMessageWidget text

This revision was automatically updated to reflect the committed changes. Closed by commit R318:cf2da56c5e76: Word-wrap KMessageWidget text (authored by ngraham). REPOSITORY R318 Dolphin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18968?vs=51554&id=51930 REVISION DETAIL https:/

D19020: [breeze-icons] Revamp system.svgz

rooty added a comment. In D19020#414224 , @trickyricky26 wrote: > I like it! > > I think the "Type User" Icon would look better if the bars acting as placeholder text were a bit less regular in width and would not be shorter than they are t

D19020: [breeze-icons] Revamp system.svgz

trickyricky26 added a comment. I like it! I think the "Type User" Icon would look better if the bars acting as placeholder text were a bit less regular in width and would not be shorter than they are tall (which is the case for the rightmost rectangle). Also, can the usernames in the t

D19075: Fix FindEGL

hausmann accepted this revision. hausmann added a comment. This revision is now accepted and ready to land. Thank you:) REPOSITORY R240 Extra CMake Modules BRANCH master REVISION DETAIL https://phabricator.kde.org/D19075 To: tcberner, #automotive, hausmann, #freebsd Cc: kde-frameworks

D19087: Add standalone conversion functions for PropertyMap to Json and vice versa

bruns marked an inline comment as done. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D19087 To: bruns, #baloo, #frameworks, ngraham, poboiko, astippich Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D19087: Add standalone conversion functions for PropertyMap to Json and vice versa

bruns updated this revision to Diff 51928. bruns marked an inline comment as done. bruns added a comment. Add `double` test case Fix double conversion Fix nitpicks ('*') REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19087?vs=51886&id=51928 BRANCH subm

D19102: Fix extraction of aspect ratio property

bruns added inline comments. INLINE COMMENTS > ffmpegextractortest.cpp:53 > QVERIFY(abs(result.properties().value(FrameRate).toDouble() - 23.976) < > 1e-4); > +QVERIFY(abs(result.properties().value(AspectRatio).toDouble() - 1.8) > < 1e-4); > } 16.0/9 REPOSITORY R286 KFileMetaD

D19101: Increase precision of frame rate property

bruns added inline comments. INLINE COMMENTS > ffmpegextractortest.cpp:52 > QCOMPARE(result.properties().value(Height).toInt(), 720); > +QVERIFY(abs(result.properties().value(FrameRate).toDouble() - 23.976) < > 1e-4); > } You can probably use `(24.0/1001)` for the exact value. REPOSI

D18968: Word-wrap KMessageWidget text

elvisangelaccio accepted this revision. REPOSITORY R318 Dolphin BRANCH word-wrap-long-kmessagewidget-text (branched from Applications/18.12) REVISION DETAIL https://phabricator.kde.org/D18968 To: ngraham, #dolphin, #frameworks, cfeck, elvisangelaccio Cc: elvisangelaccio, cfeck, kfm-devel,

D19103: Middle-elide very long filenames in error strings

elvisangelaccio added a comment. Please use a variable instead of hardcoding the length in multiple places. +1 otherwise. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D19103 To: ngraham, #frameworks, #dolphin Cc: elvisangelaccio, kde-frameworks-devel, michaelh, ng

D19100: Cleanup ffmpeg extractor

bruns accepted this revision. This revision is now accepted and ready to land. REPOSITORY R286 KFileMetaData BRANCH ffmpeg_cleanup REVISION DETAIL https://phabricator.kde.org/D19100 To: astippich, bruns, ngraham Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun

D19099: Add a test for ffmpeg extractor

bruns added inline comments. INLINE COMMENTS > ffmpegextractortest.cpp:45 > + > +QCOMPARE(result.properties().value(Title).toString(), > QStringLiteral("Title")); > +QCOMPARE(result.properties().value(Copyright).toString(), > QStringLiteral("Copyright")); I find it somewhat difficult t

D19020: [breeze-icons] Revamp system.svgz

rooty edited the summary of this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D19020 To: rooty, #vdg, #plasma, ngraham, abetts Cc: ndavis, broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D19020: [breeze-icons] Revamp system.svgz

rooty edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D19020 To: rooty, #vdg, #plasma, ngraham, abetts Cc: ndavis, broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D19020: [breeze-icons] Revamp system.svgz

rooty updated this revision to Diff 51920. rooty added a comment. Replace "Other..." icon with newer version REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19020?vs=51909&id=51920 BRANCH user-prompt-list-icons (branched from master) R

D19020: [breeze-icons] Revamp system.svgz

rooty edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D19020 To: rooty, #vdg, #plasma, ngraham, abetts Cc: ndavis, broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D18968: Word-wrap KMessageWidget text

ngraham added a comment. Yep, that works great. Did it in D19103: Middle-elide very long filenames in error strings . We'll still need this because word-wrapping the message is also an improvement. REPOSITORY R318 Dolphin BRANCH word-wrap-long-km

D19101: Increase precision of frame rate property

astippich added a dependency: D19100: Cleanup ffmpeg extractor. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D19101 To: astippich, bruns, ngraham Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D19101: Increase precision of frame rate property

astippich added a dependent revision: D19102: Fix extraction of aspect ratio property. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D19101 To: astippich, bruns, ngraham Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, brun

D19103: Middle-elide very long filenames in error strings

ngraham added a comment. Question: is 80 characters too few? Should I increase it to something higher? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D19103 To: ngraham, #frameworks, #dolphin Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19102: Fix extraction of aspect ratio property

astippich added a dependency: D19101: Increase precision of frame rate property. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D19102 To: astippich, bruns, ngraham Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abra

D19100: Cleanup ffmpeg extractor

astippich added a dependent revision: D19101: Increase precision of frame rate property. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D19100 To: astippich, bruns, ngraham Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, br

D19103: Middle-elide very long filenames in error strings

ngraham created this revision. ngraham added reviewers: Frameworks, Dolphin. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ngraham requested review of this revision. REVISION SUMMARY Middle-elide very long filenames used in error strings to prevent broken

D19100: Cleanup ffmpeg extractor

astippich added a dependency: D19099: Add a test for ffmpeg extractor. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D19100 To: astippich, bruns, ngraham Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D19099: Add a test for ffmpeg extractor

astippich added a dependent revision: D19100: Cleanup ffmpeg extractor. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D19099 To: astippich, bruns, ngraham, mgallien Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abr

D19102: Fix extraction of aspect ratio property

astippich created this revision. astippich added reviewers: bruns, ngraham. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. astippich requested review of this revision. REVISION SUMMARY The extraction of the aspect ratio was broken for multiple

D19101: Increase precision of frame rate property

astippich created this revision. astippich added reviewers: bruns, ngraham. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. astippich requested review of this revision. REVISION SUMMARY Some video files have frame rates of 23.976 or similar, req

D19100: Cleanup ffmpeg extractor

astippich created this revision. astippich added reviewers: bruns, ngraham. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. astippich requested review of this revision. REPOSITORY R286 KFileMetaData BRANCH ffmpeg_cleanup REVISION DETAIL http

D19099: Add a test for ffmpeg extractor

astippich created this revision. astippich added reviewers: bruns, ngraham, mgallien. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. astippich requested review of this revision. REVISION SUMMARY Test the ffmpegextractor using a test file. The f

D19097: Add a test and document PropertyMap/VariantMap conversion

astippich added a dependent revision: D19098: Add PropertyMap to QVariantMap conversion function using names. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D19097 To: astippich, bruns, ngraham Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich,

D19098: Add PropertyMap to QVariantMap conversion function using names

astippich created this revision. astippich added reviewers: bruns, ngraham. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. astippich requested review of this revision. REVISION SUMMARY Add a conversion function from a PropertyMap to a VariantMa

D19097: Add a test and document PropertyMap/VariantMap conversion

astippich created this revision. astippich added reviewers: bruns, ngraham. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. astippich requested review of this revision. REVISION SUMMARY Add a roundtrip test and document the conversion function.

D17816: Support for xattrs on kio copy/move

cochise added a comment. My vacancies ended and I'm making the annual planning for my classes, so I will be busy for at least two weeks, but I plan to work on the subjob bug as soon my schedule allows it. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17816 To: cochis

D18601: Rewrite taglib writer to use property interface

astippich added a comment. ping REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D18601 To: astippich, bruns, mgallien, broulik, cfeck Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D18826: Rewrite the taglib extractor to use the generic PropertyMap interface

astippich added a comment. ping. I know this is quite a large diff, but it fixes a potential crash REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D18826 To: astippich, ngraham, bruns, mgallien Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich

D17816: Support for xattrs on kio copy/move

ngraham added a comment. Where are we with this? Would be really nice to finally get this bug fixed for our users. :) REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17816 To: cochise, dfaure Cc: cfeck, bruns, phidrho, dhaumann, funkybomber, abika, pino, davidedmundson,

D18798: [KIO/drag and drop] Fix file and folder drag and drop popup menu transparency

ngraham added a comment. @Pino, can you help fix us the root cause then? The reason why we've resorted to these workarounds is because nobody's been able to adequately understand the root cause or implement a risk-free fix. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://ph

D19087: Add standalone conversion functions for PropertyMap to Json and vice versa

astippich added a comment. I was wondering if using QDataStream would be simpler, but the data size was over twice the amount compared to the size using JSON during my testing. But this would solve a lot of the limitations which JSON imposes, like handling int and doubles, qdatetime objects,

D19094: Use KCM name in KCM header

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Yep, that's the right fix. REPOSITORY R295 KCMUtils BRANCH master REVISION DETAIL https://phabricator.kde.org/D19094 To: GB_2, #plasma, #vdg, ngraham Cc: ngraham, #vdg, kde-framew

D19020: [breeze-icons] Revamp system.svgz

rooty added a comment. @abetts F6620144: image.png This is what I came up for the login/password field idea. What do you think? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D19020 To: rooty, #vdg,

KDE CI: Frameworks » baloo » kf5-qt5 SUSEQt5.10 - Build # 26 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20SUSEQt5.10/26/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sun, 17 Feb 2019 17:25:08 + Build duration: 11 min and counting BUILD ARTIFACTS abi-compatibility-resu

D19090: Hardcoding the Remaining Time Update Interval

ngraham added a comment. Arc uses the commit message in the web UI, not your local one. If you change the local commit message, you need to then send it up to the web UI with `arc diff --edit --verbatim` See https://community.kde.org/Infrastructure/Phabricator#Updating_the_summary_of_th

KDE CI: Frameworks » baloo » kf5-qt5 SUSEQt5.12 - Build # 19 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20SUSEQt5.12/19/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sun, 17 Feb 2019 17:25:08 + Build duration: 3 min 1 sec and counting BUILD ARTIFACTS abi-compatibility

D19090: Hardcoding the Remaining Time Update Interval

narvaez added a comment. In D19090#413998 , @bruns wrote: > Nitpick - "Hardcoding ..." -> "Hardcode" or better "Use a fixed interval for updating the Remaining Time" Huh, I updated my local commit to use that recommendation but arc still

D19074: [breeze-icons] Use new suspend, hibernate and switch user icons in Breeze icon theme

rooty edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D19074 To: rooty, #vdg, ngraham Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19090: Hardcoding the Remaining Time Update Interval

narvaez closed this revision. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D19090 To: narvaez, #baloo, bruns Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D19074: [breeze-icons] Use new suspend, hibernate and switch user icons in Breeze icon theme

rooty updated this revision to Diff 51910. rooty added a comment. Implement the newer versions of all three icons REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19074?vs=51889&id=51910 BRANCH arcpatch-D19074 REVISION DETAIL https://phabricator.kd

D19020: [breeze-icons] Revamp system.svgz

rooty updated this revision to Diff 51909. rooty added a comment. Add new switch user icons REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19020?vs=51821&id=51909 BRANCH user-prompt-list-icons (branched from master) REVISION DETAIL

D19094: Use KCM name in KCM header

GB_2 edited the summary of this revision. GB_2 edited the test plan for this revision. REPOSITORY R295 KCMUtils REVISION DETAIL https://phabricator.kde.org/D19094 To: GB_2, #plasma, #vdg Cc: #vdg, kde-frameworks-devel, #plasma, michaelh, ngraham, bruns

D19090: Hardcoding the Remaining Time Update Interval

bruns added a comment. Nitpick - "Hardcoding ..." -> "Hardcode" or better "Use a fixed interval for updating the Remaining Time" REPOSITORY R293 Baloo BRANCH monitor_hardcoded_interval REVISION DETAIL https://phabricator.kde.org/D19090 To: narvaez, #baloo, bruns Cc: kde-frameworks-d

D19090: Hardcoding the Remaining Time Update Interval

bruns accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH monitor_hardcoded_interval REVISION DETAIL https://phabricator.kde.org/D19090 To: narvaez, #baloo, bruns Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spooru

D19094: Use KCM name in KCM header

GB_2 created this revision. GB_2 added reviewers: Plasma, VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. GB_2 requested review of this revision. REVISION SUMMARY Change it for KCMs not opened through the system settings too, similar to D19006

D19080: [WIP] Make file overwrite a bit safer

dfaure added a comment. Ah I see, we copy to .part only when the destination actually exists. I had missed that in my earlier comment. Makes sense, actually. INLINE COMMENTS > file_unix.cpp:289 > +::unlink(_dest_backup.data()); > +orig_delete_a

D18883: Add PDF thumbnailer

dfaure added a comment. kio_thumbnail is a separate process (like all kioslaves) so a crash doesn't bring down the user-visible application. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D18883 To: broulik, dfaure, aacid, jtamate Cc: dhaumann, ngraham, pino, lto

D19092: Add bison minimum version of 2.4.1 due to %code

hindenburg created this revision. Herald added a project: Frameworks. hindenburg requested review of this revision. REVISION SUMMARY Some Mac OS versions have bison 2.3 even though it is very old. %code is first handled in bison version 2.4; gnu site has 2.4.1 as the earliest 2.4.x version.

D19090: Hardcoding the Remaining Time Update Interval

narvaez added a reviewer: Baloo. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D19090 To: narvaez, #baloo Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D19090: Hardcoding the Remaining Time Update Interval

narvaez created this revision. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. narvaez requested review of this revision. REVISION SUMMARY There is no relation between this number and the batch size of the scheduler. REPOSITORY R293 Baloo BR

D19007: Wait for DBus Reply Before Performing Computations

narvaez abandoned this revision. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D19007 To: narvaez, #baloo, bruns, astippich, poboiko Cc: davidedmundson, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D18997: Add functions returning all definitions for a mimetype or file name

cullmann reopened this revision. cullmann added a comment. This revision is now accepted and ready to land. I would propose: Use the m_sortedDefs as base for the searching. Return the vector after the bestCandidate did the sort. That would yield in my eyes the most useful sorting: a

D18968: Word-wrap KMessageWidget text

elvisangelaccio added a comment. That could also work, yes. @ngraham wanna give it a try? REPOSITORY R318 Dolphin BRANCH word-wrap-long-kmessagewidget-text (branched from Applications/18.12) REVISION DETAIL https://phabricator.kde.org/D18968 To: ngraham, #dolphin, #frameworks, cfeck C

D18798: [KIO/drag and drop] Fix file and folder drag and drop popup menu transparency

pino added a comment. In D18798#413803 , @ngraham wrote: > The workaround isn't required everywhere, just in a small number of places. It still is a workaround, and the fact that the places where this is "needed" are not many still does n