KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 22 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/22/ Project: kf5-qt5 SUSEQt5.10 Date of build: Tue, 19 Feb 2019 05:33:20 + Build duration: 13 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.12 - Build # 26 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.12/26/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Tue, 19 Feb 2019 05:33:21 + Build duration: 3 min 46 sec and counting JUnit Tests

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 14 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/14/ Project: kf5-qt5 SUSEQt5.12 Date of build: Tue, 19 Feb 2019 05:33:21 + Build duration: 2 min 46 sec and counting BUILD ARTIFACTS

D18986: [breeze-icons] Add video camera icons

rooty updated this revision to Diff 52021. rooty added a comment. Use side view for all three icon versions REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18986?vs=51970=52021 BRANCH video-camera-icon (branched from master) REVISION DETAIL

D19056: Tell people they should mostly be using KF5::AuthCore

This revision was automatically updated to reflect the committed changes. Closed by commit R283:1e3b43bfa0f3: Tell people they should mostly be using KF5::AuthCore (authored by aacid). REPOSITORY R283 KAuth CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19056?vs=51840=52019

D19056: Tell people they should mostly be using KF5::AuthCore

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R283 KAuth BRANCH arcpatch-D19056 (branched from master) REVISION DETAIL https://phabricator.kde.org/D19056 To: aacid, apol Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D19099: Add a test for ffmpeg extractor

bruns accepted this revision. This revision is now accepted and ready to land. REPOSITORY R286 KFileMetaData BRANCH ffmpeg_tests REVISION DETAIL https://phabricator.kde.org/D19099 To: astippich, bruns, ngraham, mgallien Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh,

D19098: Add PropertyMap to QVariantMap conversion function using names

bruns added a comment. In D19098#414729 , @astippich wrote: > It already does at two different places, because it fuses different information into a single QMap later on (xattr, file size etc...) >

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.12 - Build # 32 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.12/32/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Mon, 18 Feb 2019 22:06:27 + Build duration: 7 min 41 sec and counting JUnit Tests Name:

D19109: [Extractor] Add metadata to extractors

bruns added a comment. In D19109#414758 , @astippich wrote: > A few general remarks: > > - I really do not like that there are two lists of supported mimetypes now which have to be kept in sync I think this is trivial enough. Also

D18849: [KPropertiesDialog] Fix group combobox

This revision was automatically updated to reflect the committed changes. Closed by commit R241:2bba2c0795d7: [KPropertiesDialog] Fix group combobox (authored by cfeck). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18849?vs=51180=52017 REVISION DETAIL

D19107: Write valid UTF8 characters without escaping.

vandenoever updated this revision to Diff 52015. vandenoever added a comment. - Remove VALUE define. - Spelling fix. REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19107?vs=51933=52015 BRANCH utf8 REVISION DETAIL https://phabricator.kde.org/D19107

D19107: Write valid UTF8 characters without escaping.

vandenoever added inline comments. INLINE COMMENTS > dfaure wrote in kconfigtest.cpp:1774 > What's the purpose of this very short-lived define, compared to just inlining > this into the next line? Right, copy-paste leftover. I'll fix it. REPOSITORY R237 KConfig REVISION DETAIL

D19107: Write valid UTF8 characters without escaping.

vandenoever added a reviewer: thiago. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D19107 To: vandenoever, dfaure, arichardson, apol, #frameworks, thiago Cc: rapiteanu, kde-frameworks-devel, michaelh, ngraham, bruns

D19107: Write valid UTF8 characters without escaping.

dfaure added a comment. No objection from me, but I'm no utf-8 expert. Thiago's input would be very valuable... INLINE COMMENTS > kconfigtest.cpp:1774 > +#endif > +#define VALUE > "v1=Téléchargements\nv2=$¢ह€͈\nv3=\\xc2\\xe0\\xa4\\xf0\\x90\\x8d" > +QCOMPARE(fileBytes,

D19020: [breeze-icons] Revamp system.svgz

ngraham added a task: T10325: 5.16 Login screen redesign. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D19020 To: rooty, #vdg, #plasma, ngraham, abetts Cc: filipf, trickyricky26, ndavis, broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D19131: [RFC] DocumentPrivate: Fix "auto-rewrap" in static wrap mode

loh.tar created this revision. loh.tar added reviewers: cullmann, KTextEditor. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. loh.tar requested review of this revision. REVISION SUMMARY This patch is very similar to D17949

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 13 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/13/ Project: kf5-qt5 SUSEQt5.12 Date of build: Mon, 18 Feb 2019 19:44:02 + Build duration: 6 min 46 sec and counting BUILD ARTIFACTS

D19020: [breeze-icons] Revamp system.svgz

rooty added a dependent revision: D19129: [sddm-theme] Apply new username prompt and user list icons. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D19020 To: rooty, #vdg, #plasma, ngraham, abetts Cc: filipf, trickyricky26, ndavis, broulik,

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 21 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/21/ Project: kf5-qt5 SUSEQt5.10 Date of build: Mon, 18 Feb 2019 19:40:19 + Build duration: 5 min 39 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 12 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/12/ Project: kf5-qt5 SUSEQt5.12 Date of build: Mon, 18 Feb 2019 19:33:20 + Build duration: 10 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.12 - Build # 25 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.12/25/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Mon, 18 Feb 2019 19:35:59 + Build duration: 5 min 27 sec and counting JUnit Tests

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 20 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/20/ Project: kf5-qt5 SUSEQt5.10 Date of build: Mon, 18 Feb 2019 19:33:20 + Build duration: 6 min 58 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.12 - Build # 24 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.12/24/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Mon, 18 Feb 2019 19:33:20 + Build duration: 2 min 34 sec and counting JUnit Tests

D19074: [breeze-icons] Use new suspend, hibernate and switch user icons in Breeze icon theme

This revision was automatically updated to reflect the committed changes. Closed by commit R266:3b88babfed6c: [breeze-icons] Use new suspend, hibernate and switch user icons in Breeze icon… (authored by rooty). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE

D19020: [breeze-icons] Revamp system.svgz

rooty closed this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D19020 To: rooty, #vdg, #plasma, ngraham, abetts Cc: filipf, trickyricky26, ndavis, broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D19020: [breeze-icons] Revamp system.svgz

rooty added a comment. In D19020#414802 , @ngraham wrote: > I love it. Looks perfect to me now. Thanks :D Will be landing it shortly REPOSITORY R242 Plasma Framework (Library) BRANCH user-prompt-list-icons (branched from master)

D19020: [breeze-icons] Revamp system.svgz

ngraham accepted this revision. ngraham added a comment. I love it. Looks perfect to me now. REPOSITORY R242 Plasma Framework (Library) BRANCH user-prompt-list-icons (branched from master) REVISION DETAIL https://phabricator.kde.org/D19020 To: rooty, #vdg, #plasma, ngraham, abetts

D19074: [breeze-icons] Use new suspend, hibernate and switch user icons in Breeze icon theme

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. I love it. Looks perfect to me now. REPOSITORY R266 Breeze Icons BRANCH arcpatch-D19074 REVISION DETAIL https://phabricator.kde.org/D19074 To: rooty, #vdg, ngraham Cc:

D19020: [breeze-icons] Revamp system.svgz

rooty updated this revision to Diff 51997. rooty added a comment. Use more integers REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19020?vs=51993=51997 BRANCH user-prompt-list-icons (branched from master) REVISION DETAIL

D19074: [breeze-icons] Use new suspend, hibernate and switch user icons in Breeze icon theme

rooty updated this revision to Diff 51996. rooty added a comment. Make all the Z's bigger REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19074?vs=51986=51996 BRANCH arcpatch-D19074 REVISION DETAIL https://phabricator.kde.org/D19074 AFFECTED

D19074: [breeze-icons] Use new suspend, hibernate and switch user icons in Breeze icon theme

rooty added a comment. In D19074#414750 , @ngraham wrote: > Or they could all be a bit bigger, and the snowflake versions could simply take up a teensy bit more of the snowflake's top-right corner. Yeah I made all the Z's bigger, it

D19109: [Extractor] Add metadata to extractors

astippich added a comment. A few general remarks: - I really do not like that there are two lists of supported mimetypes now which have to be kept in sync - Do we really need versioning per mimetype? IMHO it is sufficient to have a version number per extractor. From my experience,

D19020: [breeze-icons] Revamp system.svgz

rooty updated this revision to Diff 51993. rooty added a comment. Make Z's larger REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19020?vs=51985=51993 BRANCH user-prompt-list-icons (branched from master) REVISION DETAIL

D19020: [breeze-icons] Revamp system.svgz

rooty edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) BRANCH user-prompt-list-icons (branched from master) REVISION DETAIL https://phabricator.kde.org/D19020 To: rooty, #vdg, #plasma, ngraham, abetts Cc: filipf, trickyricky26, ndavis, broulik,

D19074: [breeze-icons] Use new suspend, hibernate and switch user icons in Breeze icon theme

ngraham added a comment. Or they could all be a bit bigger, and the snowflake versions could simply take up a teensy bit more of the snowflake's top-right corner. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D19074 To: rooty, #vdg, ngraham Cc:

D19099: Add a test for ffmpeg extractor

astippich marked an inline comment as done. astippich added inline comments. INLINE COMMENTS > bruns wrote in ffmpegextractortest.cpp:45 > I find it somewhat difficult to grasp `Title` is > KFileMetaData::Property::Title. > You can use something like: > > namespace KFMProp =

D19099: Add a test for ffmpeg extractor

astippich updated this revision to Diff 51990. astippich added a comment. - emphasize test properties REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19099?vs=51915=51990 BRANCH ffmpeg_tests REVISION DETAIL https://phabricator.kde.org/D19099

D19098: Add PropertyMap to QVariantMap conversion function using names

astippich added a comment. It already does at two different places, because it fuses different information into a single QMap later on (xattr, file size etc...) https://phabricator.kde.org/source/baloo-widgets/browse/master/src/extractor.cpp$65

D19074: [breeze-icons] Use new suspend, hibernate and switch user icons in Breeze icon theme

rooty added a comment. F6621821: image.png I'm gonna edit system.svgz too, for consistency's sake REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D19074 To: rooty, #vdg, ngraham Cc: kde-frameworks-devel, michaelh,

D18986: [breeze-icons] Add video camera icons

rooty added a comment. In D18986#414687 , @ngraham wrote: > Getting there! I'm not sure the shadow on the top handle works though. Fixed it F6621810: image.png REPOSITORY R266 Breeze Icons

D19074: [breeze-icons] Use new suspend, hibernate and switch user icons in Breeze icon theme

ngraham added a comment. Just for the smaller versions. Yes, let's add Hibernate too. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D19074 To: rooty, #vdg, ngraham Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19074: [breeze-icons] Use new suspend, hibernate and switch user icons in Breeze icon theme

rooty added a comment. In D19074#414706 , @ngraham wrote: > That could work, yeah. Give it a try! 22 px or 32 px too? Because the 32 px version matches the desktop theme 32 px version as is P.S. What about hibernate? I don't

D18986: [breeze-icons] Add video camera icons

rooty added a comment. In D18986#414687 , @ngraham wrote: > Getting there! I'm not sure the shadow on the top handle works though. Oh that's just inkscape being difficult - that's not supposed to be there hahaha REPOSITORY R266 Breeze

D19074: [breeze-icons] Use new suspend, hibernate and switch user icons in Breeze icon theme

ngraham added a comment. That could work, yeah. Give it a try! REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D19074 To: rooty, #vdg, ngraham Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19074: [breeze-icons] Use new suspend, hibernate and switch user icons in Breeze icon theme

rooty added a comment. In D19074#414689 , @ngraham wrote: > The Zs look a bit small in Kickoff and especially Kicker when using a non-high-DPI display: > > F6621746: Screenshot_20190218_105639.png >

D19074: [breeze-icons] Use new suspend, hibernate and switch user icons in Breeze icon theme

rooty updated this revision to Diff 51986. rooty added a comment. Resize 22 px switch user icon REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19074?vs=51910=51986 BRANCH arcpatch-D19074 REVISION DETAIL https://phabricator.kde.org/D19074

D19074: [breeze-icons] Use new suspend, hibernate and switch user icons in Breeze icon theme

ngraham added a comment. The Zs look a bit small in Kickoff and especially Kicker when using a non-high-DPI display: F6621746: Screenshot_20190218_105639.png F6621748: Screenshot_20190218_105747.png

D19020: [breeze-icons] Revamp system.svgz

rooty added a comment. I actually did resize this one too because you can never be quite sure which 22 px icon will be used hahahah And I grazed the top margin a little bit but I actually managed to stay within all the other margins REPOSITORY R242 Plasma Framework (Library) BRANCH

D18986: [breeze-icons] Add video camera icons

ngraham added a comment. Getting there! I'm not sure the shadow on the top handle works though. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D18986 To: rooty, #vdg, hein, ndavis Cc: filipf, trickyricky26, ngraham, kde-frameworks-devel, michaelh, bruns

D19020: [breeze-icons] Revamp system.svgz

rooty updated this revision to Diff 51985. rooty added a comment. Resize 22 px switch user icon REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19020?vs=51982=51985 BRANCH user-prompt-list-icons (branched from master) REVISION DETAIL

D19020: [breeze-icons] Revamp system.svgz

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Actually those concerns should be in the icon theme patch, never mind. I'm good with this now! Thoughts, other #vdg people? Shall we land this?

D19020: [breeze-icons] Revamp system.svgz

ngraham added a comment. Oh and one more minor thing: the Zs look a bit small in Kickoff and especially Kicker when using a non-high-DPI display: F6621746: Screenshot_20190218_105639.png F6621748: Screenshot_20190218_105747.png

D19020: [breeze-icons] Revamp system.svgz

rooty updated this revision to Diff 51982. rooty added a comment. Remove second filled in user from 22 px switch user icon REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19020?vs=51954=51982 BRANCH user-prompt-list-icons (branched

D19020: [breeze-icons] Revamp system.svgz

ngraham added a comment. Almost perfect! I have one remaining visual nitpick: F6621734: Black.png Can we make the small version of the switch user icon have a body that's not filled in with Shade Black? That way it will match the small versions

D18986: [breeze-icons] Add video camera icons

rooty added a comment. More progress. How's this F6621740: image.png REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D18986 To: rooty, #vdg, hein, ndavis Cc: filipf, trickyricky26, ngraham, kde-frameworks-devel,

D19107: Write valid UTF8 characters without escaping.

ngraham added a reviewer: Frameworks. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D19107 To: vandenoever, dfaure, arichardson, apol, #frameworks Cc: rapiteanu, kde-frameworks-devel, michaelh, ngraham, bruns

D19107: Write valid UTF8 characters without escaping.

ngraham edited the summary of this revision. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D19107 To: vandenoever, dfaure, arichardson, apol Cc: rapiteanu, kde-frameworks-devel, michaelh, ngraham, bruns

D18986: [breeze-icons] Add video camera icons

ngraham added a comment. In D18986#414641 , @rooty wrote: > F6621699: image.png > > This is a rough draft of what a side view 64 px version would look like with a microphone on top (I can't stand film

D18986: [breeze-icons] Add video camera icons

rooty added a comment. In D18986#414635 , @ngraham wrote: > I will admit that the current head-on view is more attractive than the previous side view version. :) Tongue in cheek :D Which size are you talking about though? The

D19005: android: don't default to gcc anymore

vkrause added a comment. In D19005#414313 , @apol wrote: > In D19005#412258 , @vkrause wrote: > > > Actually having tested this, "deprecated_value" looks wrong there, shouldn't this be

D18986: [breeze-icons] Add video camera icons

ngraham added a comment. I will admit that the current head-on view is more attractive than the previous side view version. :) But I still worry about recognizability. Here's what the icon will look like in Kamoso, for example: F6621676: Video.png

D18986: [breeze-icons] Add video camera icons

filipf added a comment. It's perhaps not the most used video camera design, but I'm cool with this. I too wouldn't use the Plasma icon; it makes more sense to put some multimedia icon there. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D18986 To: rooty,

D18986: [breeze-icons] Add video camera icons

rooty added a comment. In D18986#414602 , @ngraham wrote: > Doesn't that logic also apply to a head-on-view icon for a video camera? It's not re-using the familiarity people generally have with the very common side-view video camera icons. A

D19098: Add PropertyMap to QVariantMap conversion function using names

bruns added a comment. Why would we want to use a QVariantMap in baloo-widgets, and not a KFM::PropertyMap? REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D19098 To: astippich, bruns, ngraham Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh,

D18853: Fix sharing files with spaces or quotes in names via Telegram

apol added a comment. Should they really be joined? It seems like this will fail with more than one url. I'd suggest changing arrayToList to provide quoted urls. REPOSITORY R495 Purpose Library REVISION DETAIL https://phabricator.kde.org/D18853 To: mikhailru, apol Cc:

D19094: Use KCM name in KCM header

This revision was automatically updated to reflect the committed changes. Closed by commit R295:a4041266241f: Use KCM name in KCM header (authored by GB_2). REPOSITORY R295 KCMUtils CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19094?vs=51906=51977 REVISION DETAIL

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.12 - Build # 31 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.12/31/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Mon, 18 Feb 2019 16:26:51 + Build duration: 8 min 37 sec and counting JUnit Tests Name:

D18952: new find module for Canberra

sitter updated this revision to Diff 51976. sitter added a comment. fix bad copy paste in compat setup REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18952?vs=51952=51976 BRANCH master REVISION DETAIL https://phabricator.kde.org/D18952

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.12 - Build # 30 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.12/30/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Mon, 18 Feb 2019 16:15:26 + Build duration: 8 min 16 sec and counting JUnit Tests Name:

D19020: [breeze-icons] Revamp system.svgz

filipf added a comment. I think the current revision is quite nice. We could always pick apart details and other potential solutions, but the icons get the point across and look good. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D19020 To:

D18883: Add PDF thumbnailer

bruns added a comment. In D18883#414517 , @broulik wrote: > However, you will get a Dr Konqi each time it encounters that file as it will try to generate a thumbnail for it every time you open the folder. Shouldn't this be covered

D18986: [breeze-icons] Add video camera icons

ngraham added a comment. In D18986#414556 , @rooty wrote: > I don't know... I've been mulling this over for the last couple of days and... I'm //not// sold on the side view, because any variant of a side view will look broadly different from

D18725: properly attempt to locate the kioslave bin in $libexec AND $libexec/kf5

This revision was automatically updated to reflect the committed changes. Closed by commit R241:d14f77b87dbe: properly attempt to locate the kioslave bin in $libexec AND $libexec/kf5 (authored by sitter). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

D18986: [breeze-icons] Add video camera icons

rooty updated this revision to Diff 51970. rooty added a comment. Use head-on versions of the 16 px and 22 px icons REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18986?vs=51636=51970 BRANCH video-camera-icon (branched from master) REVISION DETAIL

D18986: [breeze-icons] Add video camera icons

rooty edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D18986 To: rooty, #vdg, hein, ndavis Cc: trickyricky26, ngraham, kde-frameworks-devel, michaelh, bruns

D18986: [breeze-icons] Add video camera icons

rooty added a comment. I don't know... I've been mulling this over for the last couple of days and... I'm //not// sold on the side view, because any variant of a side view will look broadly different from the other camera icons we already have (probably because it's harder to flatten a side

D18793: Handle text completion with block selection mode

ahmadsamir added a comment. Ping? REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D18793 To: ahmadsamir, #ktexteditor, cullmann, dhaumann, #kdevelop Cc: kde-frameworks-devel, kwrite-devel, #ktexteditor, gennad, michaelh, ngraham, bruns, demsking, cullmann, sars,

D19111: Have ShareFileItemAction provide an output or an error if they are provided

ngraham added inline comments. INLINE COMMENTS > menu.cpp:84 > }); > +connect(this, ::finished, this, [this]{ qDebug() << "omgomgomg" << > this; }); > } Is this necessary? If so, maybe it should have a more descriptive string... REPOSITORY R495 Purpose Library REVISION DETAIL

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.10 - Build # 23 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.10/23/ Project: kf5-qt5 SUSEQt5.10 Date of build: Mon, 18 Feb 2019 14:16:30 + Build duration: 5 min 33 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.12 - Build # 18 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.12/18/ Project: kf5-qt5 SUSEQt5.12 Date of build: Mon, 18 Feb 2019 14:16:30 + Build duration: 4 min 37 sec and counting BUILD ARTIFACTS

D19108: [ExternalExtractor] Provide more helpful output when extractor fails

bruns marked an inline comment as done. bruns added inline comments. INLINE COMMENTS > lbeltrame wrote in externalextractor.cpp:120 > Will this block anything? At most 3 seconds (non gui task), also see the waitforfinished below ... REPOSITORY R286 KFileMetaData REVISION DETAIL

D19108: [ExternalExtractor] Provide more helpful output when extractor fails

This revision was automatically updated to reflect the committed changes. Closed by commit R286:36dafc3cb668: [ExternalExtractor] Provide more helpful output when extractor fails (authored by bruns). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE

D18883: Add PDF thumbnailer

broulik added a comment. However, you will get a Dr Konqi each time it encounters that file as it will try to generate a thumbnail for it every time you open the folder. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D18883 To: broulik, dfaure, aacid, jtamate

D19110: Don't show the tooltip when the drop-down menu is shown

This revision was automatically updated to reflect the committed changes. Closed by commit R169:368ed3bf3df8: Dont show the tooltip when the drop-down menu is shown (authored by apol). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19110?vs=51937=51959

D19110: Don't show the tooltip when the drop-down menu is shown

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R169 Kirigami BRANCH master REVISION DETAIL https://phabricator.kde.org/D19110 To: apol, #kirigami, #frameworks, mart Cc: plasma-devel, dkardarakos, apol, davidedmundson, mart, hein

D19030: Add 16 px and 22 px versions of the gamepad icon to devices/

rooty closed this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D19030 To: rooty, hein, #vdg Cc: ndavis, ngraham, kde-frameworks-devel, michaelh, bruns

D19030: Add 16 px and 22 px versions of the gamepad icon to devices/

hein accepted this revision. This revision is now accepted and ready to land. REPOSITORY R266 Breeze Icons BRANCH gamepad-icon-16-22-px (branched from master) REVISION DETAIL https://phabricator.kde.org/D19030 To: rooty, hein, #vdg Cc: ndavis, ngraham, kde-frameworks-devel, michaelh,

D19030: Add 16 px and 22 px versions of the gamepad icon to devices/

hein added a comment. LGTM, thanks! REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D19030 To: rooty, hein, #vdg Cc: ndavis, ngraham, kde-frameworks-devel, michaelh, bruns

D19020: [breeze-icons] Revamp system.svgz

rooty added a comment. In D19020#414339 , @ndavis wrote: > That last little square in the username bothers me. If only I could use text/lettering... REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL

D19020: [breeze-icons] Revamp system.svgz

rooty updated this revision to Diff 51954. rooty added a comment. Remove second square from username bar REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19020?vs=51938=51954 BRANCH user-prompt-list-icons (branched from master)

D19020: [breeze-icons] Revamp system.svgz

rooty edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D19020 To: rooty, #vdg, #plasma, ngraham, abetts Cc: trickyricky26, ndavis, broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D18952: new find module for Canberra

sitter updated this revision to Diff 51952. sitter added a comment. - pkgconfig is now quiet - variables are now camelcase - old variables are still set for compat - new imported target (also sets pkgconfig's cflags, which I presume is the sane thing to do) - set package description

D18952: new find module for Canberra

sitter marked 5 inline comments as done. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D18952 To: sitter, cgiboudeaux Cc: aacid, apol, kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D19001: katetextbuffer: refactor TextBuffer::save() to better separate code paths

mgerstner updated this revision to Diff 51951. mgerstner added a comment. Use a C++11 enum class with KDE style CamelCase identifiers. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19001?vs=51662=51951 REVISION DETAIL https://phabricator.kde.org/D19001 AFFECTED FILES

D18957: Use natural sorting in ActivityModel

This revision was automatically updated to reflect the committed changes. Closed by commit R6:b344bc2e3468: Use natural sorting in ActivityModel (authored by davidedmundson). REPOSITORY R6 KActivities CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18957?vs=51497=51948 REVISION

KDE CI: Frameworks » kio » kf5-qt5 WindowsMSVCQt5.11 - Build # 197 - Successful!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20WindowsMSVCQt5.11/197/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Mon, 18 Feb 2019 10:03:49 + Build duration: 6 min 4 sec and counting

KDE CI: Frameworks » kio » kf5-qt5 WindowsMSVCQt5.11 - Build # 196 - Aborted!

BUILD ABORTED Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20WindowsMSVCQt5.11/196/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Mon, 18 Feb 2019 09:55:37 + Build duration: 8 min 3 sec and counting

D19075: Fix FindEGL

bcooksley added a comment. If someone could please trigger all of the Dependency Builds for FreeBSD once this has been landed that would be appreciated: https://build.kde.org/view/Failing/ REPOSITORY R240 Extra CMake Modules BRANCH master REVISION DETAIL

D18853: Fix sharing files with spaces or quotes in names via Telegram

mikhailru added a comment. ping REPOSITORY R495 Purpose Library REVISION DETAIL https://phabricator.kde.org/D18853 To: mikhailru, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns

  1   2   >