D19500: [KDirModel] Fix job urls change signal connection

jtamate added a comment. +1. Just out of curiosity, Did you notice the problem because something was missing in execution? Unfortunately, neither the compiler nor I didn't noticed it. :-( REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D19500 To: broulik,

D19500: [KDirModel] Fix job urls change signal connection

broulik added a comment. > Just out of curiosity, Did you notice the problem because something was missing in execution? I was toying around with the transfer jobs visible feature in `KDirModel` and got a warning when I enabled it. It isn't used by Dolphin anymore and not supported by P

D19503: Improve code: Remove temp container just to iterate

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. So much better ;) REPOSITORY R283 KAuth BRANCH improve_checkForResultChanged (branched from master) REVISION DETAIL https://phabricator.kde.org/D19503 To: mlaurent, dfaure Cc: kde-f

D19504: Extend KHtmlView::print() to use a predefined QPrinter instance

habacker created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. habacker requested review of this revision. REVISION SUMMARY This is required to share printer settings inside an application. BUG:405011 TEST PLAN compile on linux REPOS

D18943: Add Fontconfig find modudle

vkrause added a comment. In D18943#424041 , @kossebau wrote: > In D18943#424029 , @vkrause wrote: > > > What I don't understand though is which FindFontconfig this used to find, there is non in plas

KDE CI: Frameworks » khtml » kf5-qt5 WindowsMSVCQt5.11 - Build # 31 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/khtml/job/kf5-qt5%20WindowsMSVCQt5.11/31/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Mon, 04 Mar 2019 06:01:39 + Build duration: 3 hr 40 min and counting JUnit Tests Name: p

D18793: Handle text completion with block selection mode

ahmadsamir added a comment. Do we still need a unit test for this? REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D18793 To: ahmadsamir, #ktexteditor, cullmann, dhaumann, #kdevelop, mwolff Cc: loh.tar, mwolff, kde-frameworks-devel, kwrite-devel, #ktexteditor, doms

D19476: Hopefully fix flaky remote access test

zzag accepted this revision. This revision is now accepted and ready to land. REPOSITORY R127 KWayland BRANCH master REVISION DETAIL https://phabricator.kde.org/D19476 To: davidedmundson, #kwin, zzag Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D11924: Add "SkipSwitcher" to API

zzag added a comment. @dfaure I'll take a look into this issue. REPOSITORY R278 KWindowSystem REVISION DETAIL https://phabricator.kde.org/D11924 To: sharvey, hein, graesslin Cc: zzag, dfaure, kde-frameworks-devel, #plasma, ngraham, graesslin, apol, michaelh, bruns

D19476: Hopefully fix flaky remote access test

This revision was automatically updated to reflect the committed changes. Closed by commit R127:f0152135b198: Hopefully fix flaky remote access test (authored by davidedmundson). REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19476?vs=52992&id=53107 REVISION

D19506: ECMGeneratePkgConfigFile: add variables used by pkg_check_modules

dfaure created this revision. dfaure added a reviewer: apol. Herald added projects: Frameworks, Build System. Herald added a subscriber: kde-frameworks-devel. dfaure requested review of this revision. REVISION SUMMARY If we ever end up in a situation where the generated .pc file is actually us

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.10 - Build # 25 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.10/25/ Project: kf5-qt5 SUSEQt5.10 Date of build: Mon, 04 Mar 2019 10:23:11 + Build duration: 5 min 49 sec and counting BUILD ARTIFACTS abi-compatibi

KDE CI: Frameworks » kwayland » kf5-qt5 FreeBSDQt5.12 - Build # 30 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20FreeBSDQt5.12/30/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Mon, 04 Mar 2019 10:23:11 + Build duration: 5 min 41 sec and counting JUnit Tests Name: proje

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.12 - Build # 19 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.12/19/ Project: kf5-qt5 SUSEQt5.12 Date of build: Mon, 04 Mar 2019 10:23:11 + Build duration: 17 min and counting BUILD ARTIFACTS abi-compatibility-r

D19508: [kconf_update] move from custom logging tech to qCDebug

sitter created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. sitter requested review of this revision. REVISION SUMMARY the previous logging tech got kind of defunct in 2014 (to the point where it was basically qCDebug). seeing as no one re

D19508: [kconf_update] move from custom logging tech to qCDebug

sitter added reviewers: apol, aacid. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D19508 To: sitter, apol, aacid Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19506: ECMGeneratePkgConfigFile: add variables used by pkg_check_modules

fazevedo accepted this revision. fazevedo added a comment. This revision is now accepted and ready to land. Works for me ! REPOSITORY R240 Extra CMake Modules BRANCH master REVISION DETAIL https://phabricator.kde.org/D19506 To: dfaure, apol, fazevedo Cc: fazevedo, kde-buildsystem, kde

D19506: ECMGeneratePkgConfigFile: add variables used by pkg_check_modules

cgiboudeaux requested changes to this revision. This revision now requires changes to proceed. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D19506 To: dfaure, apol, fazevedo, cgiboudeaux Cc: cgiboudeaux, fazevedo, kde-buildsystem, kde-frameworks-devel, mich

D19506: ECMGeneratePkgConfigFile: add variables used by pkg_check_modules

cgiboudeaux added a comment. The autotest has to be fixed as well The includedir value looks bogus, the test file contains includedir=/usr/KCoreAddons REPOSITORY R240 Extra CMake Modules BRANCH master REVISION DETAIL https://phabricator.kde.org/D19506 To: dfaure, apol, faz

D19506: ECMGeneratePkgConfigFile: add variables used by pkg_check_modules

cgiboudeaux added a comment. In D19506#424301 , @cgiboudeaux wrote: > The autotest has to be fixed as well Comment edited, the includedir value is correct for this test. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://ph

D19506: ECMGeneratePkgConfigFile: add variables used by pkg_check_modules

dfaure updated this revision to Diff 53114. dfaure added a comment. Update unittests, passes now REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19506?vs=53108&id=53114 BRANCH master REVISION DETAIL https://phabricator.kde.org/D19506 AFFEC

D19506: ECMGeneratePkgConfigFile: add variables used by pkg_check_modules

cgiboudeaux accepted this revision. cgiboudeaux added a comment. This revision is now accepted and ready to land. Thanks. REPOSITORY R240 Extra CMake Modules BRANCH master REVISION DETAIL https://phabricator.kde.org/D19506 To: dfaure, apol, fazevedo, cgiboudeaux Cc: cgiboudeaux, fazev

D19503: Improve code: Remove temp container just to iterate

This revision was automatically updated to reflect the committed changes. Closed by commit R283:d044788ac38d: Improve code: Remove temp container just to iterate (authored by mlaurent). REPOSITORY R283 KAuth CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19503?vs=53098&id=53116 REVI

D19506: ECMGeneratePkgConfigFile: add variables used by pkg_check_modules

dfaure closed this revision. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D19506 To: dfaure, apol, fazevedo, cgiboudeaux Cc: cgiboudeaux, fazevedo, kde-buildsystem, kde-frameworks-devel, michaelh, ngraham, bruns

D19338: New location for KNSRC files

leinir updated this revision to Diff 53117. leinir added a comment. Since 5.57, not 5.56 REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19338?vs=52607&id=53117 REVISION DETAIL https://phabricator.kde.org/D19338 AFFECTED FILES KF5NewStuffCoreConfig.c

D19508: [kconf_update] move from custom logging tech to qCDebug

apol added a comment. +1 makes sense to me REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D19508 To: sitter, apol, aacid Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19508: [kconf_update] move from custom logging tech to qCDebug

apol added a reviewer: Frameworks. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D19508 To: sitter, apol, aacid, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19511: ViewPrivate: Disable read-only mode action when doc is modified

loh.tar created this revision. loh.tar added a reviewer: KTextEditor. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. loh.tar requested review of this revision. REVISION SUMMARY It's somehow pointless to activate the read-only mode when the

D19512: KateStatusBar: Show lock icon on modified label when in read-only mode

loh.tar created this revision. loh.tar added a reviewer: KTextEditor. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. loh.tar requested review of this revision. REVISION SUMMARY This may not needed because the information is already shown as

D19512: KateStatusBar: Show lock icon on modified label when in read-only mode

loh.tar added a comment. You will notice that not all possible switch cases are checked. Should you like this patch in general I will review this depending on D19511 . REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D19512 To:

D19514: Add support for detecting avahi crash - cleanup invalid dbus objects in that case

jpalecek created this revision. Herald added a project: Frameworks. jpalecek requested review of this revision. REVISION SUMMARY This is a first take at tackling a problem caused by avahi going out of service -- usually its restart during an upgrade. In the current state, these things happen:

D19514: Add support for detecting avahi crash - cleanup invalid dbus objects in that case

jpalecek edited the summary of this revision. jpalecek edited the test plan for this revision. REPOSITORY R272 KDNSSD REVISION DETAIL https://phabricator.kde.org/D19514 To: jpalecek Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19514: Add support for detecting avahi crash - cleanup invalid dbus objects in that case

broulik added a reviewer: sitter. REPOSITORY R272 KDNSSD REVISION DETAIL https://phabricator.kde.org/D19514 To: jpalecek, sitter Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19514: Add support for detecting avahi crash - cleanup invalid dbus objects in that case

jpalecek edited the test plan for this revision. REPOSITORY R272 KDNSSD REVISION DETAIL https://phabricator.kde.org/D19514 To: jpalecek, sitter Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19514: Add support for detecting avahi crash - cleanup invalid dbus objects in that case

jpalecek added inline comments. INLINE COMMENTS > avahi-publicservice_p.h:42 > PublicServicePrivate(PublicService *parent, const QString &name, const > QString &type, const QString &domain, unsigned int port) : > -QObject(), ServiceBasePrivate(name, type, domain, QString(), port),

D19514: Add support for detecting avahi crash - cleanup invalid dbus objects in that case

jpalecek edited the summary of this revision. REPOSITORY R272 KDNSSD REVISION DETAIL https://phabricator.kde.org/D19514 To: jpalecek, sitter Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19517: DocumentPrivate: Auto reload in read-only mode

loh.tar created this revision. loh.tar added a reviewer: KTextEditor. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. loh.tar requested review of this revision. REVISION SUMMARY This patch auto reload the document only when it was not alread

D19517: DocumentPrivate: Auto reload in read-only mode

loh.tar edited the summary of this revision. loh.tar edited the test plan for this revision. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D19517 To: loh.tar, #ktexteditor Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, domson, michaelh, ngraham, bruns, demski

D19514: Add support for detecting avahi crash - cleanup invalid dbus objects in that case

sitter added a comment. I haven't had a proper look, so only style complaints for now... but... Isn't the problem rather that the daemon shouldn't be randomly restarted on a live system? I.e. this ultimately is an integration issue on the distro-level. I doubt many if any avahi clients

D19517: DocumentPrivate: Auto reload in read-only mode

loh.tar edited the summary of this revision. loh.tar edited the test plan for this revision. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D19517 To: loh.tar, #ktexteditor Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, domson, michaelh, ngraham, bruns, demski

D19517: DocumentPrivate: Auto reload in read-only mode

loh.tar added a comment. I would like to expand this patch by "auto reload when file is empty" Sometimes I have the case that a session is opened where some files are gone due to work on a different branch. Switching the branch then caused to ask unneeded. REPOSITORY R39 KTextEditor REV

KDE CI: Frameworks » kdeclarative » kf5-qt5 FreeBSDQt5.12 - Build # 18 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kdeclarative/job/kf5-qt5%20FreeBSDQt5.12/18/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Mon, 04 Mar 2019 17:05:51 + Build duration: 1 min 32 sec and counting JUnit Tests Name: pr

KDE CI: Frameworks » kdeclarative » kf5-qt5 SUSEQt5.10 - Build # 17 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kdeclarative/job/kf5-qt5%20SUSEQt5.10/17/ Project: kf5-qt5 SUSEQt5.10 Date of build: Mon, 04 Mar 2019 17:05:51 + Build duration: 3 min 1 sec and counting BUILD ARTIFACTS abi-compati

KDE CI: Frameworks » kdeclarative » kf5-qt5 SUSEQt5.12 - Build # 14 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kdeclarative/job/kf5-qt5%20SUSEQt5.12/14/ Project: kf5-qt5 SUSEQt5.12 Date of build: Mon, 04 Mar 2019 17:05:51 + Build duration: 9 min 45 sec and counting BUILD ARTIFACTS acc/KF5Dec

KDE CI: Frameworks » kdeclarative » kf5-qt5 SUSEQt5.10 - Build # 18 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kdeclarative/job/kf5-qt5%20SUSEQt5.10/18/ Project: kf5-qt5 SUSEQt5.10 Date of build: Mon, 04 Mar 2019 17:08:54 + Build duration: 7 min 22 sec and counting JUnit Tests Name: (root) F

D17949: ViewPrivate: Make 'Apply Word Wrap' more comfortable

cullmann accepted this revision. cullmann added a comment. Given we have a test, the code is documented and nobody raises large objections since long over the latest implementation, I think this shall go in :=) REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D1794

D17949: ViewPrivate: Make 'Apply Word Wrap' more comfortable

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R39:5339a32c1214: ViewPrivate: Make 'Apply Word Wrap' more comfortable (authored by loh.tar, committed by cullmann). REPOSI

D19131: [RFC] DocumentPrivate: Fix "auto-rewrap" in static wrap mode

cullmann added a comment. :=) Perhaps I read this diff to fast, but I can not really tell if it does what it should. I can understand from the description it tries to keep auto-wrapped things in balance during editing. I think to better understand the behavior, one needs to have tes

D19511: ViewPrivate: Disable read-only mode action when doc is modified

cullmann added a comment. Hmm, two things: 1. implementation wise: don't we have a problem here that the connect(document(), &KTextEditor::DocumentPrivate::modifiedChanged, [=] { m_toggleWriteLock->setEnabled(!doc()->isModified()); }); will not be unconnected if the view dies and we cal

D19461: Logcat: fix dsError color with underline="0"

cullmann added a comment. Question: I just applied this but adjust the hl back to For me the tests still work and I see no underline. Is the patch then at all needed for current master? REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D194

D18793: Handle text completion with block selection mode

cullmann requested changes to this revision. cullmann added a comment. This revision now requires changes to proceed. I don't like the change to call typeChars. 1. that needs a valid view, activeView() might be null. 2. replaceText is not interactive per-default, but typeChars is. A

D19517: DocumentPrivate: Auto reload in read-only mode

cullmann requested changes to this revision. cullmann added a comment. This revision now requires changes to proceed. I think in principle the idea is sound. But e.g., if you have have some file where one process writes to "fast" and it is "large" this will instantly lock up the applicati

D19512: KateStatusBar: Show lock icon on modified label when in read-only mode

cullmann requested changes to this revision. cullmann added a comment. This revision now requires changes to proceed. I think the lock icon won't hurt. For the implementation: isn't it enough to watch for the readWriteChanged(...) signal of the document and trigger the modifiedChanged()

D19511: ViewPrivate: Disable read-only mode action when doc is modified

cullmann requested changes to this revision. cullmann added a comment. This revision now requires changes to proceed. Thought about it bit more, actually like the "I can save even thought not modified" I think the "I can set read-only thought modified" is ok and actually no bug but a feature.

D15002: Allow to install syntax files instead of having them in a resource

cullmann closed this revision. cullmann added a comment. If somebody has an fix for the CMake thingy, please open a new diffusion for that. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D15002 To: cullmann, vkrause, dhaumann Cc: kfunk, dhaumann, kwrite-

D19491: generic config interface

cullmann added a comment. Any input? We could give this a go "after" the next frameworks release is out. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D19491 To: cullmann, #ktexteditor, dhaumann, loh.tar Cc: kwrite-devel, kde-frameworks-devel, domson, michaelh,

D19416: Restore the search wrapped message to its former type and position.

This revision was automatically updated to reflect the committed changes. Closed by commit R39:ac35dba35988: Restore the search wrapped message to its former type and position. (authored by rjvbb, committed by cullmann). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricato

D19506: ECMGeneratePkgConfigFile: add variables used by pkg_check_modules

kossebau added a comment. FWIW, this still results in inproper pc files, from what I heard recently. The `prefix` variable can be overriden from outside when calling `pkg-config` (cmp. `pkg-config --help`) to allow for relocatable installations. Same like CMake Config files also allow reloca

D7909: Add syntax support for Crystal Programming Language

cullmann added a comment. ;=) Any updates? REPOSITORY R40 Kate REVISION DETAIL https://phabricator.kde.org/D7909 To: faguilar, dhaumann, vkrause, #framework_syntax_highlighting, #kate, mwolff, cullmann Cc: kwrite-devel, oprypin, mwolff, cullmann, ngraham, #kate, #frameworks, faguilar,

D19367: [RFC]SearchBar: Don't block GUI when enter incremental pattern

cullmann added a comment. The batch processing approach is sane. My real issue here is: What to do with multi-line expressions that might span more than one line? Won't we miss matches if the ranges just overlap at that locations? REPOSITORY R39 KTextEditor REVISION DETAIL https://pha

D19367: [RFC]SearchBar: Don't block GUI when enter incremental pattern

cullmann added reviewers: dhaumann, cullmann. cullmann added a comment. Perhaps Dominik has some ideas, too :P REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D19367 To: loh.tar, #ktexteditor, dhaumann, cullmann Cc: cullmann, kwrite-devel, kde-frameworks-devel, #kt

D19367: [RFC]SearchBar: Don't block GUI when enter incremental pattern

cullmann added a comment. My proposal would be: 1. not compute the batch ranges beforehand but just remember the complete range and compute the range for the next scan. 2. after scan is done without a hit, not start behind the range but start in the middle of the current range with aga

D17857: DocumentPrivate: Don't scroll view when add auto-bracket at end of file

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. I can not reproduce this, but I think one setCursorPosition less is always good :P REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D17857 To: loh.tar, #ktex

D17857: DocumentPrivate: Don't scroll view when add auto-bracket at end of file

This revision was automatically updated to reflect the committed changes. Closed by commit R39:65e3b5462f1c: DocumentPrivate: Don't scroll view when add auto-bracket at end of file (authored by loh.tar, committed by cullmann). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phab

D17241: WIP:Disable highlighting after 512 characters on a line.

cullmann requested changes to this revision. cullmann added a comment. This revision now requires changes to proceed. I think we shall count the number of ranges on the line to judge the limit, otherwise this is a sound idea. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator

KDE CI: Frameworks » ktexteditor » kf5-qt5 FreeBSDQt5.12 - Build # 47 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20FreeBSDQt5.12/47/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Mon, 04 Mar 2019 19:08:08 + Build duration: 5 min 18 sec and counting JUnit Tests Name: pr

KDE CI: Frameworks » ktexteditor » kf5-qt5 SUSEQt5.12 - Build # 29 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20SUSEQt5.12/29/ Project: kf5-qt5 SUSEQt5.12 Date of build: Mon, 04 Mar 2019 19:08:08 + Build duration: 5 min 36 sec and counting BUILD ARTIFACTS abi-compat

D17857: DocumentPrivate: Don't scroll view when add auto-bracket at end of file

cullmann reopened this revision. cullmann added a comment. This revision is now accepted and ready to land. Unfortunately that kills some indenter tests. https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20FreeBSDQt5.12/47/ REPOSITORY R39 KTextEditor REVISION DETAIL h

D19367: [RFC]SearchBar: Don't block GUI when enter incremental pattern

loh.tar added a comment. > The batch processing approach is sane. hm, thanks > My real issue here is: What to do with multi-line expressions that might span more than one line? Won't we miss matches if the ranges just overlap at that locations? Well, yes...that should be the ca

D17857: DocumentPrivate: Don't scroll view when add auto-bracket at end of file

cullmann requested changes to this revision. This revision now requires changes to proceed. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D17857 To: loh.tar, #ktexteditor, cullmann Cc: swestersund, cullmann, dhaumann, kwrite-devel, kde-frameworks-devel, #ktexteditor

D17857: DocumentPrivate: Don't scroll view when add auto-bracket at end of file

cullmann added a comment. Diffs like: - /usr/home/jenkins/workspace/Frameworks/ktexteditor/kf5-qt5 FreeBSDQt5.12/autotests/input/indent/cstyle/openpar12/expected 2019-03-04 16:49:58.559736000 + +++ /usr/home/jenkins/workspace/Frameworks/ktexteditor/kf5-qt5 FreeBSDQt5.12/autot

D19367: [RFC]SearchBar: Don't block GUI when enter incremental pattern

cullmann added a comment. In D19367#424714 , @loh.tar wrote: > > The batch processing approach is sane. > > hm, thanks > > > My real issue here is: What to do with multi-line expressions that might span more than one line? Won't we miss m

KDE CI: Frameworks » ktexteditor » kf5-qt5 FreeBSDQt5.12 - Build # 48 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20FreeBSDQt5.12/48/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Mon, 04 Mar 2019 19:16:38 + Build duration: 6 min 28 sec and counting JUnit Tests Name: pro

KDE CI: Frameworks » ktexteditor » kf5-qt5 SUSEQt5.12 - Build # 30 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20SUSEQt5.12/30/ Project: kf5-qt5 SUSEQt5.12 Date of build: Mon, 04 Mar 2019 19:16:38 + Build duration: 7 min 10 sec and counting BUILD ARTIFACTS abi-compati

KDE CI: Frameworks » ktexteditor » kf5-qt5 SUSEQt5.10 - Build # 43 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20SUSEQt5.10/43/ Project: kf5-qt5 SUSEQt5.10 Date of build: Mon, 04 Mar 2019 19:08:08 + Build duration: 18 min and counting BUILD ARTIFACTS abi-compatibilit

D19511: ViewPrivate: Disable read-only mode action when doc is modified

loh.tar added a subscriber: ngraham. loh.tar added a comment. There is some reason why I came to this idea. ATM is that thought not so sharp present :-/ But it was related to the auto-reload patch and the lock icon in the bar. @ngraham what do you think in general? Make a read only sett

KDE CI: Frameworks » ktexteditor » kf5-qt5 SUSEQt5.10 - Build # 44 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20SUSEQt5.10/44/ Project: kf5-qt5 SUSEQt5.10 Date of build: Mon, 04 Mar 2019 19:26:44 + Build duration: 21 min and counting BUILD ARTIFACTS abi-compatibility

D18894: [RFC] General config interface

loh.tar abandoned this revision. loh.tar added a comment. In favor of D19491 REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D18894 To: loh.tar, cullmann, dhaumann Cc: mwolff, kwrite-devel, kde-frameworks-devel, #ktexteditor, do

D19486: Add UDev find module

This revision was automatically updated to reflect the committed changes. Closed by commit R240:8999b7bd6f6d: Add UDev find module (authored by vkrause). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D19486?vs=53055&id=53160#toc REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UP

D19514: Add support for detecting avahi crash - cleanup invalid dbus objects in that case

bruns added a comment. In D19514#424501 , @sitter wrote: > I haven't had a proper look, so only style complaints for now... but... > > Isn't the problem rather that the daemon shouldn't be randomly restarted on a live system? I.e. this ultima

D19514: Add support for detecting avahi crash - cleanup invalid dbus objects in that case

bruns added a comment. I think some repetitive code can be avoided when the `T*` inside the FooPrivate classes are replaced by e.g. `QScopedPointer` or `std::unique_ptr`. REPOSITORY R272 KDNSSD REVISION DETAIL https://phabricator.kde.org/D19514 To: jpalecek, sitter Cc: bruns, kde-frame

D19527: Remove find modules provided by ECM

vkrause created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vkrause requested review of this revision. REVISION SUMMARY This matters specifically here as kdelibs4support installs them and adds them to the module search path, which can int

D19287: [ExtractorCollection] Load extractor plugins lazily

bruns added a comment. Ping! REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D19287 To: bruns, #baloo, #frameworks, ngraham, astippich, poboiko Cc: kde-frameworks-devel, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D19491: generic config interface

dhaumann added a comment. Currently, one cannot 'unset' a value, but I guess that is ok, since we did not have that before In general this approach is OK. Some thoughts on this: - is it as fast as before, if you start Kate with e.g. 100 documents open? - will this allow easy access

D19530: Avoid fractionals in GridDelegate sizes and alignments

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. davidedmundson requested review of this revision. REVISION SUMMARY The thumbnail object within the Delegate is offset by float amoun

D19432: [text thumbnailer] Use KSyntaxHighlighting for text rendering

kossebau added a comment. So, from my side I am fine with the current patch. While the change to QTextDocument (& syntax highlighting?) results in a marginal bigger linespacing and as result up to one line less text rendered in the preview, I find the newer linespacing actually better to rea

D19432: [text thumbnailer] Use KSyntaxHighlighting for text rendering

kossebau added a reviewer: cfeck. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D19432 To: kossebau, broulik, cfeck Cc: vkrause, cfeck, kde-frameworks-devel, kfm-devel, alexde, feverfew, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanue

D19532: Don't crash when no contexts are present

davispuh created this revision. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. davispuh requested review of this revision. TEST PLAN 1. Compiled 2. Placed malformed XML in ~/.local/share/katepart5/syntax/ 3. Opened a file which uses tha

D19530: Avoid fractionals in GridDelegate sizes and alignments

filipf added a comment. David this really does fix it! Previews are nice and sharp everywhere now. See before: F6657490: Screenshot_20190304_173527.png And after: F6657492: Screenshot_20190304_231358.png

D19532: Don't crash when no contexts are present

davispuh added reviewers: cullmann, dhaumann, vandenoever. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D19532 To: davispuh, cullmann, dhaumann, vandenoever Cc: kwrite-devel, kde-frameworks-devel, domson, michaelh, ngraham, bruns, demsking, cullmann, sars,

D19432: [text thumbnailer] Use KSyntaxHighlighting for text rendering

cfeck accepted this revision. This revision is now accepted and ready to land. REPOSITORY R320 KIO Extras BRANCH addsyntaxhighlighttotextpreview REVISION DETAIL https://phabricator.kde.org/D19432 To: kossebau, broulik, cfeck Cc: vkrause, cfeck, kde-frameworks-devel, kfm-devel, alexde, fev

D19532: Don't crash when no contexts are present

davispuh added a comment. Creating a syntax highlighting file with few unclosed tags made Kate to crash. No matter how malformed XML it loads, editor should never crash as it can cause loss of unsaved work. Crash is caused by Context* DefinitionData::initialContext() const {

D19532: Don't crash when no contexts are present

davispuh updated this revision to Diff 53175. davispuh added a comment. Actually fix it REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19532?vs=53170&id=53175 BRANCH context REVISION DETAIL https://phabricator.kde.org/D19532 AFFECTED FILE

D18883: Add PDF thumbnailer

aacid added a comment. Also do we have a way to limit thumbnailers to run say for X seconds? There's some files in which poppler will run "forever" REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D18883 To: broulik, dfaure, aacid, jtamate Cc: bruns, dhaumann, ngra

D19508: [kconf_update] move from custom logging tech to qCDebug

aacid added a comment. Don't see anything obviously wrong, but i personally don't feel like i have enough knowledge on the file to say "yep go ahead and commit", but maybe noone feels like that so i'd say if after one or two weeks noone does, do a quick ping and the commit :D REPOSITORY R

D19533: Don't crash on malformed syntax highlighting files

davispuh created this revision. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. davispuh requested review of this revision. TEST PLAN 1. Create malformed syntax highlighting file with missing end tags 2. Place it in ~/.local/share/katepart

D19532: Don't crash when no contexts are present

davispuh added a dependent revision: D19533: Don't crash on malformed syntax highlighting files. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D19532 To: davispuh, cullmann, dhaumann, vandenoever Cc: kwrite-devel, kde-frameworks-devel, domson, michaelh, ngr

D19533: Don't crash on malformed syntax highlighting files

davispuh added reviewers: cullmann, dhaumann. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D19533 To: davispuh, cullmann, dhaumann Cc: kwrite-devel, kde-frameworks-devel, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D19533: Don't crash on malformed syntax highlighting files

davispuh added a dependency: D19532: Don't crash when no contexts are present. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D19533 To: davispuh, cullmann, dhaumann Cc: kwrite-devel, kde-frameworks-devel, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, d

T10554: KDiff3 to join Applications

aacid added a comment. Did anyone tell you to create a task in phabricator and subscribe frameworks developers to it? I mean this is not about frameworks developement so it seems to me you're asking the wrong people. On the topic of KDiff3 joining KDE Applications where was discussed? I

  1   2   >