D19965: kactivities: remove unused variable

This revision was automatically updated to reflect the committed changes. Closed by commit R6:cfdb14b01898: kactivities: remove unused variable (authored by carneirogustavo, committed by patrickelectric). REPOSITORY R6 KActivities CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19965?

KDE CI: Frameworks » knotifications » kf5-qt5 WindowsMSVCQt5.11 - Build # 50 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/knotifications/job/kf5-qt5%20WindowsMSVCQt5.11/50/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Wed, 20 Mar 2019 12:42:44 + Build duration: 2 days 12 hr and counting JUnit Tests

D19551: [knotifications] compile without foreach

hindenburg added a comment. In D19551#436264 , @kossebau wrote: > This sadly breaks build with at least older versions of Phonon, as they have foreach loop in their public headers. Ditto, the Mac build fails here now as well due to this.

D19986: Install .desktop file for kded5

ivan accepted this revision. This revision is now accepted and ready to land. REPOSITORY R297 KDED BRANCH master REVISION DETAIL https://phabricator.kde.org/D19986 To: davidedmundson, ivan Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19986: Install .desktop file for kded5

davidedmundson created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. davidedmundson requested review of this revision. REVISION SUMMARY This is useful as on wayland setting a path to a desktop file is mandatory for icons on any windows. Qt

D19952: Added 2 icons (1 16px and 1 22px) named "input-num-on" that shows a num-lock key

ndavis added a comment. Here's my attempt: F6711669: montage-breeze-Background.png F6711673: input-numlock-on.16.svg F6711674: input-numlock-on.22.svg REPOSITORY R2

D19985: [KStatusNotifierItem] Send desktop-entry hint

broulik created this revision. broulik added a reviewer: Framework: Syntax Highlighting. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY This allows the notification service to know where the `showMe

D19985: [KStatusNotifierItem] Send desktop-entry hint

broulik edited reviewers, added: Frameworks; removed: Framework: Syntax Highlighting. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D19985 To: broulik, #frameworks, #framework_syntax_highlighting Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19979: Don't create thumbnails for encrypted Vaults

ivan edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D19979 To: ivan, davidedmundson, dfaure Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19445: Handle variant list in formatting functions

bruns requested changes to this revision. bruns added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > propertyinfo.cpp:634 > +if (d->valueType == QVariant::StringList || d->valueType == > QVariant::String ) { > +return FormatStrings::joinStri

D19979: Don't create thumbnails for encrypted Vaults

ivan retitled this revision from "Don't create thumbnails for encrypted drives (Vaults)" to "Don't create thumbnails for encrypted Vaults". REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D19979 To: ivan, davidedmundson, dfaure Cc: kde-frameworks-devel, michaelh, ngraham, br

D18601: Rewrite taglib writer to use property interface

bruns requested changes to this revision. This revision now requires changes to proceed. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D18601 To: astippich, bruns, mgallien, broulik, cfeck Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh,

D19979: Don't create thumbnails for encrypted drives (Vaults)

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D19979 To: ivan, davidedmundson, dfaure Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19979: Don't create thumbnails for encrypted drives (Vaults)

ivan updated this revision to Diff 54582. ivan added a comment. Incorporated David's advice REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19979?vs=54577&id=54582 REVISION DETAIL https://phabricator.kde.org/D19979 AFFECTED FILES src/widgets/previewjob.cpp

D19965: kactivities: remove unused variable

carneirogustavo edited the summary of this revision. REPOSITORY R6 KActivities BRANCH remove_unused_variable REVISION DETAIL https://phabricator.kde.org/D19965 To: carneirogustavo, #kactivities, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19979: Don't create thumbnails for encrypted drives (Vaults)

davidedmundson added a comment. There's a findByPath method on the list https://api.kde.org/frameworks/kio/html/classKMountPoint_1_1List.html#add38a82921d203856e1d1f9ddb9adbe6 It's a bit smarter as it resolves symlinks and such. REPOSITORY R241 KIO REVISION DETAIL https://phabricato

D19979: Don't create thumbnails for encrypted drives (Vaults)

ivan created this revision. ivan added reviewers: davidedmundson, dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ivan requested review of this revision. REVISION SUMMARY This patch makes PreviewJob skip thumbnail generation on fuse.encfs and fuse.cr

D19952: Added 2 icons (1 16px and 1 22px) named "input-num-on" that shows a num-lock key

taskf added a comment. In D19952#436429 , @arvidhansson wrote: > Nice! This icons are really good! Thanks. > Well, I think you (Taskf) know what to do, just tell us if you need a hand. Well, first I need an info which version yo

D19952: Added 2 icons (1 16px and 1 22px) named "input-num-on" that shows a num-lock key

arvidhansson added a comment. In D19952#436427 , @ndavis wrote: > In D19952#436425 , @taskf wrote: > > > Hi, I created some icons a week ago, just didn't post them as @arvidhansson was already on the

D19952: Added 2 icons (1 16px and 1 22px) named "input-num-on" that shows a num-lock key

taskf added a comment. Yes, the cross is a bit twisted as with a 45° angle it crosses right through the '1' and makes it not that readable. F6711431: image.png REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D19952 To: ar

D19952: Added 2 icons (1 16px and 1 22px) named "input-num-on" that shows a num-lock key

ndavis added a comment. In D19952#436425 , @taskf wrote: > Hi, I created some icons a week ago, just didn't post them as @arvidhansson was already on the task. > > They are not polished as you can see from the screenshot. The left version sy

D19952: Added 2 icons (1 16px and 1 22px) named "input-num-on" that shows a num-lock key

taskf added a comment. Hi, I created some icons a week ago, just didn't post them as @arvidhansson was already on the task. They are not polished as you can see from the screenshot. The left version symbolizes a lock, while the right one, which I like more, symbolizes a keyboard key.

D19961: Properly fix copy constructor

davidedmundson added inline comments. INLINE COMMENTS > resultiterator.cpp:53 > { > -qWarning("ResultIterator copy constructor being used. This is crashy"); > +d->results = rhs.d->results; > } why not pos? REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D19961

D19978: Allow to set custom hints for notifications

broulik added a comment. +1 REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D19978 To: nicolasfella, broulik Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19978: Allow to set custom hints for notifications

nicolasfella updated this revision to Diff 54573. nicolasfella added a comment. - fix stuff REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19978?vs=54570&id=54573 BRANCH hints REVISION DETAIL https://phabricator.kde.org/D19978 AFFECTED FILES

D19978: Allow to set custom hints for notifications

nicolasfella updated this revision to Diff 54570. nicolasfella added a comment. - const'ify REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19978?vs=54569&id=54570 BRANCH hints REVISION DETAIL https://phabricator.kde.org/D19978 AFFECTED FILES

D19978: Allow to set custom hints for notifications

nicolasfella created this revision. nicolasfella added a reviewer: broulik. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY Allow to send custom hints to the notification implementation. REPOSI

KDE CI: Frameworks » baloo » kf5-qt5 SUSEQt5.12 - Build # 34 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20SUSEQt5.12/34/ Project: kf5-qt5 SUSEQt5.12 Date of build: Fri, 22 Mar 2019 16:11:50 + Build duration: 11 min and counting BUILD ARTIFACTS abi-compatibility-resu

D19961: Properly fix copy constructor

This revision was automatically updated to reflect the committed changes. Closed by commit R293:ccb9b19e1e74: Properly fix copy constructor (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19961?vs=54525&id=54566 REVISION DETAIL https://pha

KDE CI: Frameworks » baloo » kf5-qt5 FreeBSDQt5.12 - Build # 41 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20FreeBSDQt5.12/41/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Fri, 22 Mar 2019 16:11:50 + Build duration: 1 min 52 sec and counting JUnit Tests Name: projectr

D19967: [kpeople] make it compile without foreach

mlaurent updated this revision to Diff 54563. mlaurent added a comment. Remove duplicate call REPOSITORY R307 KPeople CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19967?vs=54552&id=54563 BRANCH compile_without_foreach (branched from master) REVISION DETAIL https://phabrica

D19972: [krunners] compile without foreach

This revision was automatically updated to reflect the committed changes. Closed by commit R308:509e5132babf: [krunners] compile without foreach (authored by mlaurent). REPOSITORY R308 KRunner CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19972?vs=54553&id=54562 REVISION DETAIL h

D15763: Set correct image attributes on directory thumbnail

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D15763 To: broulik, #frameworks, dfaure, anthonyfieroni, jtamate, ngraham Cc: ngraham, kde-frameworks-devel, kfm-devel, alexde, feverfew, me

D19974: Add extensions to groovy highlighting

apushnov created this revision. apushnov added a reviewer: Framework: Syntax Highlighting. apushnov added a project: Framework: Syntax Highlighting. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. apushnov requested review of this revision. RE

KDE CI: Frameworks » knotifications » kf5-qt5 AndroidQt5.12 - Build # 14 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/knotifications/job/kf5-qt5%20AndroidQt5.12/14/ Project: kf5-qt5 AndroidQt5.12 Date of build: Fri, 22 Mar 2019 13:40:19 + Build duration: 3 min 46 sec and counting

D19972: [krunners] compile without foreach

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R308 KRunner BRANCH compile_without_foreach (branched from master) REVISION DETAIL https://phabricator.kde.org/D19972 To: mlaurent, dfaure, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19967: [kpeople] make it compile without foreach

apol added inline comments. INLINE COMMENTS > matchessolver.cpp:63 > +QList::const_iterator it = > destinationResolver.keys(urlB).constBegin(); > +const QList::const_iterator end = > destinationResolver.keys(urlB).constEnd(); > +for (; it != end; ++it) { You

D5111: Provide demo/preview for checkable menu items

anthonyfieroni removed a reviewer: anthonyfieroni. Herald added a project: Plasma. REPOSITORY R113 Oxygen Theme REVISION DETAIL https://phabricator.kde.org/D5111 To: rjvbb, hpereiradacosta, jriddell, zhigalin Cc: ltoscano, kde-mac, #frameworks, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesli

D19965: kactivities: remove unused variable

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R6 KActivities BRANCH remove_unused_variable REVISION DETAIL https://phabricator.kde.org/D19965 To: carneirogustavo, #kactivities, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15763: Set correct image attributes on directory thumbnail

anthonyfieroni added a comment. What happen to this? Put it to 19.04 for testing. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D15763 To: broulik, #frameworks, dfaure, anthonyfieroni, jtamate Cc: ngraham, kde-frameworks-devel, kfm-devel, alexde, feverfew, meven,

D19298: Make it compile without foreach

hindenburg added a comment. On Mac, this change gives this error (after removing -DQT_NO_FOREACH) - the recent changes did not fix the error below - f9b835c66a1facfcd6257fe84d3c7e8ead508353 builds fine. Undefin

D19551: [knotifications] compile without foreach

kossebau added a comment. This sadly breaks build with at least older versions of Phonon, as they have foreach loop in their public headers. So this either needs a bump of the current find_package(Phonon4Qt5 4.6.60 NO_MODULE) or adding the `QT_NO_FOREACH` only if a newer work

D19784: Avoid calling QT_LSTAT and accessing recent documents

hoffmannrobert added a comment. In D19784#434564 , @hoffmannrobert wrote: > In D19784#431683 , @ngraham wrote: > > > Nice, kinda sounds like this fixes https://bugs.kde.org/show_bug.cgi?id=373352.

D19972: [krunners] compile without foreach

mlaurent created this revision. mlaurent added a reviewer: dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mlaurent requested review of this revision. REVISION SUMMARY compile without foreach TEST PLAN autotest ok REPOSITORY R308 KRunner BRANCH

D19967: [kpeople] make it compile without foreach

mlaurent updated this revision to Diff 54552. mlaurent added a comment. q! REPOSITORY R307 KPeople CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19967?vs=54537&id=54552 BRANCH compile_without_foreach (branched from master) REVISION DETAIL https://phabricator.kde.org/D19967

D19961: Properly fix copy constructor

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH fix_copy_constructor REVISION DETAIL https://phabricator.kde.org/D19961 To: bruns, #baloo, #frameworks, ngraham, poboiko Cc: kde-frameworks-devel, gennad, domson, ashaposhnikov, m

D19812: Add a web page to view and compare icons of different sizes

guoyunhe updated this revision to Diff 54546. guoyunhe added a comment. Improve bash script REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19812?vs=54535&id=54546 BRANCH master REVISION DETAIL https://phabricator.kde.org/D19812 AFFECTED FILES

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 40 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/40/ Project: kf5-qt5 SUSEQt5.12 Date of build: Fri, 22 Mar 2019 10:36:18 + Build duration: 12 min and counting BUILD ARTIFACTS abi-compati

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 48 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/48/ Project: kf5-qt5 SUSEQt5.10 Date of build: Fri, 22 Mar 2019 10:36:18 + Build duration: 11 min and counting BUILD ARTIFACTS abi-compati

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 46 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/46/ Project: kf5-qt5 SUSEQt5.12 Date of build: Fri, 22 Mar 2019 10:20:23 + Build duration: 26 min and counting BUILD ARTIFACTS abi-compatibility-result

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.10 - Build # 60 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.10/60/ Project: kf5-qt5 SUSEQt5.10 Date of build: Fri, 22 Mar 2019 10:20:23 + Build duration: 24 min and counting BUILD ARTIFACTS abi-compatibility-result

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.12 - Build # 52 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.12/52/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Fri, 22 Mar 2019 10:36:18 + Build duration: 6 min 28 sec and counting JUnit Tests Nam

D19743: FrameSvgItem: catch margin changes of FrameSvg also outside own methods

This revision was automatically updated to reflect the committed changes. Closed by commit R242:5f4f88ad66f9: FrameSvgItem: catch margin changes of FrameSvg also outside own methods (authored by kossebau). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricat

D19812: Add a web page to view and compare icons of different sizes

guoyunhe added a comment. In D19812#436154 , @pino wrote: > - please harden the script using at least -e and -u flags for set: this way, it will not keep executing when a command fails, and undeclared variables are not silently expanded to empty

D19743: FrameSvgItem: catch margin changes of FrameSvg also outside own methods

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH catchSvgFrameMarginChangesOnThemeChange REVISION DETAIL https://phabricator.kde.org/D19743 To: kossebau, #plasma, mart Cc: kde-frameworks-devel, michaelh, ngraha

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.12 - Build # 64 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.12/64/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Fri, 22 Mar 2019 10:20:23 + Build duration: 6 min 31 sec and counting JUnit Tests Name: projectroo

D19786: Fix WebDAV directory renaming if KeepAlive is off

This revision was automatically updated to reflect the committed changes. Closed by commit R241:c6b5750b9527: Fix WebDAV directory renaming if KeepAlive is off (authored by hoffmannrobert, committed by sitter). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19786?

D19786: Fix WebDAV directory renaming if KeepAlive is off

hoffmannrobert added a comment. No, thanks, I have a sponsor, but I don't have commit access. Please push it for me. REPOSITORY R241 KIO BRANCH fix_webdav_rename_directory REVISION DETAIL https://phabricator.kde.org/D19786 To: hoffmannrobert, #frameworks, #dolphin, dfaure, sitter Cc:

D19786: Fix WebDAV directory renaming if KeepAlive is off

sitter accepted this revision. sitter added a comment. This revision is now accepted and ready to land. Fair enough. LGTM :) Do you need sponsoring or do you have commit access? REPOSITORY R241 KIO BRANCH fix_webdav_rename_directory REVISION DETAIL https://phabricator.kde.org/D197

D19812: Add a web page to view and compare icons of different sizes

pino added a comment. Few notes on the new `generate_web_data.sh` script: - please quote the paths properly, otherwise it will break when either the source directory or the build directory contain e.g. spaces - it does not seem using any bash-specific features, so make it using `/bin/s

D19967: [kpeople] make it compile without foreach

pino added inline comments. INLINE COMMENTS > matchessolver.cpp:62-64 > +const QList keys = destinationResolver.keys(urlB); > +for (const QString &key : keys) { > destinationResolver[key] = urlA; iterators, please REPOSITORY R307 KPeople REVISION DETA

D19945: Update link to fsearch project

This revision was automatically updated to reflect the committed changes. Closed by commit R304:2a3cea27ea58: Update link to fsearch project (authored by meven). REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19945?vs=54536&id=54539 REVISION DETAIL https:

D19966: [kauth] fix last foreach

This revision was automatically updated to reflect the committed changes. Closed by commit R283:ec3c94b7a77a: [kauth] fix last foreach (authored by mlaurent). REPOSITORY R283 KAuth CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19966?vs=54534&id=54538 REVISION DETAIL https://phabr

D19967: [kpeople] make it compile without foreach

mlaurent created this revision. mlaurent added a reviewer: dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mlaurent requested review of this revision. REVISION SUMMARY compile without foreach TEST PLAN autotest ok REPOSITORY R307 KPeople BRANCH

D19945: Update link to fsearch project

meven updated this revision to Diff 54536. meven added a comment. Redoing the commit to set full name in the commit REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19945?vs=54494&id=54536 BRANCH fixed-arcpatch-D19945 REVISION DETAIL https://phabricat

D19966: [kauth] fix last foreach

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R283 KAuth BRANCH fix_mac_foreach (branched from master) REVISION DETAIL https://phabricator.kde.org/D19966 To: mlaurent, dfaure, hindenburg Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19812: Add a web page to view and compare icons of different sizes

guoyunhe updated this revision to Diff 54535. guoyunhe added a comment. Add search function REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19812?vs=54533&id=54535 BRANCH master REVISION DETAIL https://phabricator.kde.org/D19812 AFFECTED FILES

D19966: [kauth] fix last foreach

mlaurent created this revision. mlaurent added reviewers: dfaure, hindenburg. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mlaurent requested review of this revision. REVISION SUMMARY port last foreach TEST PLAN autotest ok REPOSITORY R283 KAuth BRA