D20226: Add "notifications" and "notifications-disabled" icons

This revision was automatically updated to reflect the committed changes. Closed by commit R266:47af5254b039: Add notifications and notifications-disabled icons (authored by GB_2). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20226?vs=55420=55451

D20197: Fix desktop link to file or directory

ngraham added a comment. This is the right way to show a directory chooser dialog: https://cgit.kde.org/plasma-workspace.git/tree/wallpapers/image/image.cpp#n356 REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D20197 To: hoffmannrobert, #frameworks, ngraham Cc: ngraham,

D15872: Fix Oxygen background gradient for QML modules

ngraham reopened this revision. ngraham added a comment. This revision is now accepted and ready to land. Oh, I think I misunderstood your comment, @davidedmundson. You were saying we should merge this //after// tagging, duh. Reverted for now, and I'll re-merge it after tagging. REPOSITORY

D15872: Fix Oxygen background gradient for QML modules

This revision was automatically updated to reflect the committed changes. Closed by commit R295:3fe124c7f411: Fix Oxygen background gradient for QML modules (authored by hwti, committed by ngraham). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D15872?vs=42644=55450#toc REPOSITORY

D20226: Add "notifications" and "notifications-disabled" icons

ndavis accepted this revision. ndavis added a comment. Those curves are perfect  REPOSITORY R266 Breeze Icons BRANCH add-notifications-and-notifications-disabled-icons (branched from master) REVISION DETAIL https://phabricator.kde.org/D20226 To: GB_2, #plasma, #vdg, ngraham, ndavis

KDE CI: Frameworks » solid » kf5-qt5 FreeBSDQt5.12 - Build # 19 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20FreeBSDQt5.12/19/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Fri, 05 Apr 2019 00:00:11 + Build duration: 1 min 38 sec and counting JUnit Tests Name:

D20230: Allow building without UDev on Linux

This revision was automatically updated to reflect the committed changes. Closed by commit R245:124760e1a383: Allow building without UDev on Linux (authored by apol). REPOSITORY R245 Solid CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20230?vs=55353=55448 REVISION DETAIL

D15872: Fix Oxygen background gradient for QML modules

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. We are really bad at letting reviews get lost and unnoticed. I'm really sorry! Tagging is on Saturday, so best to merge next week for proper testing. REPOSITORY R295

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.12 - Build # 61 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.12/61/ Project: kf5-qt5 SUSEQt5.12 Date of build: Thu, 04 Apr 2019 21:52:50 + Build duration: 6 min 26 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.10 - Build # 67 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.10/67/ Project: kf5-qt5 SUSEQt5.10 Date of build: Thu, 04 Apr 2019 21:52:50 + Build duration: 5 min 19 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kfilemetadata » kf5-qt5 FreeBSDQt5.12 - Build # 67 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20FreeBSDQt5.12/67/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Thu, 04 Apr 2019 21:52:50 + Build duration: 1 min 42 sec and counting JUnit Tests Name:

D20033: Default string formatting test to C locale, add localized run

This revision was automatically updated to reflect the committed changes. Closed by commit R286:a5130d940fb4: Default string formatting test to C locale, add localized run (authored by bruns). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE

D15872: Fix Oxygen background gradient for QML modules

filipf added a reviewer: Plasma. REPOSITORY R295 KCMUtils REVISION DETAIL https://phabricator.kde.org/D15872 To: hwti, mart, #vdg, #plasma Cc: filipf, kde-frameworks-devel, michaelh, ngraham, bruns

D15872: Fix Oxygen background gradient for QML modules

filipf added a comment. Ping. Is this actually what's been causing the following problem? F6753947: image.png REPOSITORY R295 KCMUtils REVISION DETAIL https://phabricator.kde.org/D15872 To: hwti, mart, #vdg Cc: filipf,

D20244: [AppletInterface] Check for corona before accessing it

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D20244 To: broulik, #plasma, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20033: Default string formatting test to C locale, add localized run

astippich accepted this revision. astippich added a comment. This revision is now accepted and ready to land. works nicely! REPOSITORY R286 KFileMetaData BRANCH i18n REVISION DETAIL https://phabricator.kde.org/D20033 To: bruns, #baloo, #frameworks, ngraham, astippich Cc:

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.10 - Build # 66 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.10/66/ Project: kf5-qt5 SUSEQt5.10 Date of build: Thu, 04 Apr 2019 17:09:20 + Build duration: 2 min 51 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.12 - Build # 60 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.12/60/ Project: kf5-qt5 SUSEQt5.12 Date of build: Thu, 04 Apr 2019 17:04:37 + Build duration: 6 min 9 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.10 - Build # 65 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.10/65/ Project: kf5-qt5 SUSEQt5.10 Date of build: Thu, 04 Apr 2019 17:00:08 + Build duration: 9 min 10 sec and counting BUILD ARTIFACTS

D19087: Add standalone conversion functions for PropertyMap to Json and vice versa

astippich added inline comments. INLINE COMMENTS > propertydata.cpp:88 > +if (it.value().isArray()) { > +const auto values = it.value().toArray(); > +for (const auto val : values) { Can you return arrays as lists here so that current behavior is unchanged, and

KDE CI: Frameworks » kfilemetadata » kf5-qt5 FreeBSDQt5.12 - Build # 66 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20FreeBSDQt5.12/66/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Thu, 04 Apr 2019 17:03:39 + Build duration: 1 min 2 sec and counting JUnit Tests Name:

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.12 - Build # 59 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.12/59/ Project: kf5-qt5 SUSEQt5.12 Date of build: Thu, 04 Apr 2019 16:58:43 + Build duration: 5 min 53 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kfilemetadata » kf5-qt5 FreeBSDQt5.12 - Build # 65 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20FreeBSDQt5.12/65/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Thu, 04 Apr 2019 17:02:13 + Build duration: 1 min 21 sec and counting JUnit Tests Name:

D18665: Cleanup taglib writer test

This revision was automatically updated to reflect the committed changes. Closed by commit R286:452edb1b4c80: Cleanup taglib writer test (authored by astippich). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18665?vs=50711=55429 REVISION DETAIL

D18604: Implement support for writing rating information for taglib writer

This revision was automatically updated to reflect the committed changes. Closed by commit R286:8e79f7ce2b7c: Implement support for writing rating information for taglib writer (authored by astippich). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.10 - Build # 64 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.10/64/ Project: kf5-qt5 SUSEQt5.10 Date of build: Thu, 04 Apr 2019 16:57:01 + Build duration: 3 min 6 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kfilemetadata » kf5-qt5 FreeBSDQt5.12 - Build # 64 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20FreeBSDQt5.12/64/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Thu, 04 Apr 2019 16:58:18 + Build duration: 1 min 26 sec and counting JUnit Tests Name:

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.12 - Build # 58 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.12/58/ Project: kf5-qt5 SUSEQt5.12 Date of build: Thu, 04 Apr 2019 16:52:48 + Build duration: 5 min 54 sec and counting BUILD ARTIFACTS

D18603: Implement more tags for taglib writer

This revision was automatically updated to reflect the committed changes. Closed by commit R286:926c70460edc: Implement more tags for taglib writer (authored by astippich). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18603?vs=55126=55427 REVISION

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.10 - Build # 63 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.10/63/ Project: kf5-qt5 SUSEQt5.10 Date of build: Thu, 04 Apr 2019 16:52:48 + Build duration: 4 min 11 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kfilemetadata » kf5-qt5 FreeBSDQt5.12 - Build # 63 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20FreeBSDQt5.12/63/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Thu, 04 Apr 2019 16:52:48 + Build duration: 1 min 33 sec and counting JUnit Tests Name:

D18601: Rewrite taglib writer to use property interface

This revision was automatically updated to reflect the committed changes. Closed by commit R286:982ebe58b3c8: Rewrite taglib writer to use property interface (authored by astippich). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D18601?vs=55125=55426#toc REPOSITORY R286 KFileMetaData

D20121: Test ffmpeg extractor using mime type helper

This revision was automatically updated to reflect the committed changes. Closed by commit R286:25eca3185ffa: Test ffmpeg extractor using mime type helper (authored by astippich). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20121?vs=55301=55425

KDE CI: Frameworks » qqc2-desktop-style » kf5-qt5 SUSEQt5.12 - Build # 25 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/qqc2-desktop-style/job/kf5-qt5%20SUSEQt5.12/25/ Project: kf5-qt5 SUSEQt5.12 Date of build: Thu, 04 Apr 2019 16:49:08 + Build duration: 56 sec and counting CONSOLE OUTPUT

D20197: Fix desktop link to file or directory

hoffmannrobert added a comment. Is there a different decided directory chooser than QFileDialog? It's the way QFileDialog handles directories. If you click a directory, it not added to the selection, other than a file, which is. So, if QFileDialog::selectedUrls() is called, nothing is

D20197: Fix desktop link to file or directory

ngraham added a comment. Hmm, that's confusing. I would recommend using the decided directory chooser rather than rolling your own. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D20197 To: hoffmannrobert, #frameworks, ngraham Cc: ngraham, kde-frameworks-devel,

D20226: Add "notifications" and "notifications-disabled" icons

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Much nicer! This is a winner IMO. REPOSITORY R266 Breeze Icons BRANCH add-notifications-and-notifications-disabled-icons (branched from master) REVISION DETAIL

D19686: don't scale when we are in AA_UseHighDpiPixmaps

mart abandoned this revision. REPOSITORY R302 KIconThemes REVISION DETAIL https://phabricator.kde.org/D19686 To: mart, #plasma, #frameworks Cc: broulik, ngraham, bruns, fvogt, kde-frameworks-devel, michaelh

D20226: Add "notifications" and "notifications-disabled" icons

GB_2 edited the summary of this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D20226 To: GB_2, #plasma, #vdg Cc: bruns, ndavis, abetts, ngraham, #vdg, kde-frameworks-devel, #plasma, michaelh

D20226: Add "notifications" and "notifications-disabled" icons

GB_2 updated this revision to Diff 55420. GB_2 added a comment. Remake icons REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20226?vs=55347=55420 BRANCH add-notifications-and-notifications-disabled-icons (branched from master) REVISION DETAIL

D20197: Fix desktop link to file or directory

hoffmannrobert added a comment. You need to double click the directory, so you enter the directory, then click Open. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D20197 To: hoffmannrobert, #frameworks, ngraham Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D20197: Fix desktop link to file or directory

ngraham added a comment. Interesting solution. However the directory use case still doesn't work. If I use the directory chooser to choose `/home/nate/Pictures`, the path fiels says `/home/nate/` and the file name field says `file:///home/nate/` REPOSITORY R241 KIO REVISION DETAIL

D19446: DocumentPrivate: Support auto bracket in block selection mode

loh.tar added a comment. In D19446#442303 , @loh.tar wrote: > >> Feature or bug? Select in block mode from right->left on a single line after last char a block. The brackets are exchanged )( and placed at the end of the block > > > > Hmm,

D20197: Fix desktop link to file or directory

hoffmannrobert added a comment. In D20197#442358 , @ngraham wrote: > This doesn't work. Try creating a symlink to a directory. In the file picker dialog, the Open button doesn't work. > > See https://bugs.kde.org/show_bug.cgi?id=357171 for

D20197: Fix desktop link to file or directory

hoffmannrobert retitled this revision from "Fix desktop link filter" to "Fix desktop link to file or directory". hoffmannrobert edited the summary of this revision. hoffmannrobert edited the test plan for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D20197

D20197: Fix desktop link filter

hoffmannrobert updated this revision to Diff 55409. hoffmannrobert added a comment. - Add file/directory selection REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20197?vs=55259=55409 BRANCH fix_desktop_link_filter REVISION DETAIL

D20238: device: include reapplyConnection() in the interface

jgrulich accepted this revision. This revision is now accepted and ready to land. REPOSITORY R282 NetworkManagerQt REVISION DETAIL https://phabricator.kde.org/D20238 To: aleksanderm, jgrulich, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20238: device: include reapplyConnection() in the interface

aleksanderm marked an inline comment as done. REPOSITORY R282 NetworkManagerQt REVISION DETAIL https://phabricator.kde.org/D20238 To: aleksanderm, jgrulich, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20238: device: include reapplyConnection() in the interface

aleksanderm updated this revision to Diff 55395. aleksanderm retitled this revision from "device: include Reapply() in the interface" to "device: include reapplyConnection() in the interface". REPOSITORY R282 NetworkManagerQt CHANGES SINCE LAST UPDATE

D20244: [AppletInterface] Check for corona before accessing it

broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY On plasmashell shutdown when the panels are destroyed, the available screen geometry