D20493: Introduce and use KArchiveDirectory::addEntryV2

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R243 KArchive BRANCH arcpatch-D20493 REVISION DETAIL https://phabricator.kde.org/D20493 To: aacid, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20264: Add test for "Auto Reload Document" option

loh.tar added a comment. I spend a couple of time for this stuff. Would be nice someone else could try it or do some investigation with tools I'm not familiar with, and don't want to be atm. Without feedback I will push it in the next few days. REVISION DETAIL

KDE CI: Frameworks » ktexteditor » kf5-qt5 SUSEQt5.10 - Build # 83 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20SUSEQt5.10/83/ Project: kf5-qt5 SUSEQt5.10 Date of build: Fri, 12 Apr 2019 22:34:10 + Build duration: 29 min and counting BUILD ARTIFACTS

D20477: Avoid indirection when inserting basic data

This revision was automatically updated to reflect the committed changes. Closed by commit R824:06a75822671b: Avoid indirection when inserting basic data (authored by bruns). REPOSITORY R824 Baloo Widgets CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20477?vs=56026=56106 REVISION

KDE CI: Frameworks » ktexteditor » kf5-qt5 SUSEQt5.12 - Build # 69 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20SUSEQt5.12/69/ Project: kf5-qt5 SUSEQt5.12 Date of build: Fri, 12 Apr 2019 22:34:10 + Build duration: 8 min 50 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » ktexteditor » kf5-qt5 FreeBSDQt5.12 - Build # 86 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20FreeBSDQt5.12/86/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Fri, 12 Apr 2019 22:34:10 + Build duration: 7 min 9 sec and counting JUnit Tests Name:

D19608: DocumentPrivate: Make bracket handling smart

This revision was automatically updated to reflect the committed changes. Closed by commit R39:8f0813f6c7ed: DocumentPrivate: Make bracket handling smart (authored by loh.tar). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D19608?vs=53444=56105#toc REPOSITORY R39 KTextEditor CHANGES

D17500: Get mobipocket extractor up-to-date, but keep disabled

aacid added a comment. Sure, this code is not compiled, if you think it's better just commit it (IMHO, not kfilemedata specialist) REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D17500 To: astippich, bruns Cc: ltoscano, mgallien, aacid, kde-frameworks-devel,

D19691: ViewInternal: Review drop event

This revision was automatically updated to reflect the committed changes. Closed by commit R39:1a0da40ae3da: ViewInternal: Review drop event (authored by loh.tar). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D19691?vs=53702=56103#toc REPOSITORY R39 KTextEditor CHANGES SINCE LAST

D20499: Support gzipping of svgz also on windows, using 7z

vonreth added a comment. 7z will be around as it is the second core (craft) dep after wget REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D20499 To: kossebau, #plasma, #windows Cc: vonreth, cullmann, kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » plasma-framework » kf5-qt5 WindowsMSVCQt5.11 - Build # 157 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20WindowsMSVCQt5.11/157/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Fri, 12 Apr 2019 20:49:32 + Build duration: 17 min and counting JUnit Tests

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 65 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/65/ Project: kf5-qt5 SUSEQt5.12 Date of build: Fri, 12 Apr 2019 20:49:32 + Build duration: 11 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 72 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/72/ Project: kf5-qt5 SUSEQt5.10 Date of build: Fri, 12 Apr 2019 20:49:32 + Build duration: 5 min 13 sec and counting BUILD ARTIFACTS

D20499: Support gzipping of svgz also on windows, using 7z

cullmann added a comment. I glanced at it, thought I have at home no Windows machine at hand to test if the command line works as planned. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D20499 To: kossebau, #plasma, #windows Cc: cullmann,

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.12 - Build # 75 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.12/75/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Fri, 12 Apr 2019 20:49:31 + Build duration: 2 min 27 sec and counting JUnit Tests

D20499: Support gzipping of svgz also on windows, using 7z

kossebau added a comment. Given CI is currently broken for Windows, going for try & error, as usually windows experts to review are hard to find. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D20499 To: kossebau, #plasma, #windows Cc:

D20499: Support gzipping of svgz also on windows, using 7z

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R242:78bec83b222f: Support gzipping of svgz also on windows, using 7z (authored by kossebau). REPOSITORY R242 Plasma

Re: Unannounced Dependency Change - plasma-framework

Am Freitag, 12. April 2019, 20:47:51 CEST schrieb Ben Cooksley: > Hi all, > > Recently builds of plasma-framework have started failing on Windows > due to the absence of "gzip", which was added as a Dependency without > any announcement as is required of all new dependencies. > > With regards to

D20499: Support gzipping of svgz also on windows, using 7z

kossebau added reviewers: Plasma, Windows. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D20499 To: kossebau, #plasma, #windows Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20499: Support gzipping of svgz also on windows, using 7z

kossebau updated this revision to Diff 56097. kossebau added a comment. search both 7z.exe & 7za.exe REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20499?vs=56096=56097 BRANCH supportgziponwindows REVISION DETAIL

KDE CI: Frameworks » syntax-highlighting » kf5-qt5 WindowsMSVCQt5.11 - Build # 170 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/syntax-highlighting/job/kf5-qt5%20WindowsMSVCQt5.11/170/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Fri, 12 Apr 2019 20:10:25 + Build duration: 6 min 39 sec and counting JUnit

D20166: Keep desktoptheme SVG files uncompressed in repo, install svgz

kossebau added a comment. In D20166#448914 , @cullmann wrote: > The CI is a bit unhappy with the gzip depedency on Windows. > Might one just write a minimal KArchive based gzip'er for this? gzip isn't there on any normal Windows machine, even

D20499: Support gzipping of svgz also on windows, using 7z

kossebau created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. kossebau requested review of this revision. REPOSITORY R242 Plasma Framework (Library) BRANCH supportgziponwindows REVISION DETAIL https://phabricator.kde.org/D20499

D19511: ViewPrivate: Disable read-only mode action when doc is modified

cullmann added a comment. I still think we should stay with status quo, can you drop this request? REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D19511 To: loh.tar, #ktexteditor, cullmann Cc: ngraham, cullmann, kwrite-devel, kde-frameworks-devel, #ktexteditor,

KDE CI: Frameworks » syntax-highlighting » kf5-qt5 WindowsMSVCQt5.11 - Build # 169 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/syntax-highlighting/job/kf5-qt5%20WindowsMSVCQt5.11/169/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Fri, 12 Apr 2019 19:38:32 + Build duration: 31 min and counting JUnit Tests

D20166: Keep desktoptheme SVG files uncompressed in repo, install svgz

cullmann added a comment. The CI is a bit unhappy with the gzip depedency on Windows. Might one just write a minimal KArchive based gzip'er for this? gzip isn't there on any normal Windows machine, even if you have libz. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL

Re: Unannounced Dependency Change - plasma-framework

On 2019-04-12 20:47, Ben Cooksley wrote: Hi all, Recently builds of plasma-framework have started failing on Windows due to the absence of "gzip", which was added as a Dependency without any announcement as is required of all new dependencies. With regards to Windows in particular, usually

D19608: DocumentPrivate: Make bracket handling smart

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Works for me, beside that the patch no longer cleanly applies. But with some false removed and the later parts skipped, it did work as advertised. REPOSITORY R39 KTextEditor

D20264: Add test for "Auto Reload Document" option

cullmann accepted this revision. cullmann added a comment. I think this can go in as is, as long as the test works determinstically, which I assume it does. REVISION DETAIL https://phabricator.kde.org/D20264 To: loh.tar, dhaumann, cullmann Cc: cullmann, kwrite-devel, kde-frameworks-devel,

D19691: ViewInternal: Review drop event

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. +1, nice Played a bit here with the new behavior, MUCH better than the old one. For the block selection stuff: yes, tabs + spaces + block selection is messy, thought I think

KDE CI: Frameworks » kcrash » kf5-qt5 WindowsMSVCQt5.11 - Build # 36 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcrash/job/kf5-qt5%20WindowsMSVCQt5.11/36/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Fri, 12 Apr 2019 19:35:46 + Build duration: 3 min 15 sec and counting JUnit Tests

D20233: Add syntax highlighting for fish shell

This revision was automatically updated to reflect the committed changes. Closed by commit R216:0e2d7e61a256: Add syntax highlighting for fish shell (authored by cullmann). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20233?vs=55361=56093

D20221: AppArmor: don't highlight variable assignments and alias rules within profiles

This revision was automatically updated to reflect the committed changes. Closed by commit R216:1726c4f868f6: AppArmor: dont highlight variable assignments and alias rules within profiles (authored by nibags, committed by cullmann). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST

D20467: Allow to close a document whose file was deleted on disk

This revision was automatically updated to reflect the committed changes. Closed by commit R39:2a0cf7044f75: Allow to close a document whose file was deleted on disk (authored by meven, committed by cullmann). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE

KDE CI: Frameworks » kcrash » kf5-qt5 WindowsMSVCQt5.11 - Build # 35 - Aborted!

BUILD ABORTED Build URL https://build.kde.org/job/Frameworks/job/kcrash/job/kf5-qt5%20WindowsMSVCQt5.11/35/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Thu, 11 Apr 2019 18:29:43 + Build duration: 1 day 1 hr and counting

KCrash - test_crasher spins in a loop on Windows

Hi all, Currently we have an issue where the test_crasher test will endlessly fork itself while trying to setup it's conditions to run. This leads to an issue where it will occupy a single CPU core of a builder indefinitely until it's killed (and when killed there are always two test_crasher.exe

D20467: Allow to close a document whose file was deleted on disk

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. I think this should go in. For application supporting the interface, the document is removed. For application not supporting the interface, at least the file is closed and you

Unannounced Dependency Change - plasma-framework

Hi all, Recently builds of plasma-framework have started failing on Windows due to the absence of "gzip", which was added as a Dependency without any announcement as is required of all new dependencies. With regards to Windows in particular, usually Craft based systems will make use of 7-Zip

D20498: Change namespace of MobileCursor

dkardarakos edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D20498 To: dkardarakos, mart Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20498: Change namespace of MobileCursor

dkardarakos created this revision. dkardarakos added a reviewer: mart. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. dkardarakos requested review of this revision. REVISION SUMMARY Looking for MobileCursor in the Private namespace, results TextField and

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.12 - Build # 74 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.12/74/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Fri, 12 Apr 2019 17:37:46 + Build duration: 11 min and counting JUnit Tests Name:

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 64 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/64/ Project: kf5-qt5 SUSEQt5.12 Date of build: Fri, 12 Apr 2019 17:37:46 + Build duration: 10 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.12 - Build # 84 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.12/84/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Fri, 12 Apr 2019 17:05:44 + Build duration: 40 min and counting JUnit Tests Name: projectroot

KDE CI: Frameworks » plasma-framework » kf5-qt5 WindowsMSVCQt5.11 - Build # 156 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20WindowsMSVCQt5.11/156/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Fri, 12 Apr 2019 17:37:46 + Build duration: 2 min 46 sec and counting CONSOLE

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 71 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/71/ Project: kf5-qt5 SUSEQt5.10 Date of build: Fri, 12 Apr 2019 17:37:46 + Build duration: 5 min 12 sec and counting BUILD ARTIFACTS

D20496: Air/Oxygen desktoptheme: fix hand offsets with hint-*-rotation-center-offset

This revision was automatically updated to reflect the committed changes. Closed by commit R242:37a1845bc40a: Air/Oxygen desktoptheme: fix hand offsets with hint-*-rotation-center-offset (authored by kossebau). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D20496?vs=56077=56086#toc

D20496: Air/Oxygen desktoptheme: fix hand offsets with hint-*-rotation-center-offset

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH fixairclock REVISION DETAIL https://phabricator.kde.org/D20496 To: kossebau, #plasma, mart, ngraham Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20477: Avoid indirection when inserting basic data

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. lol REPOSITORY R824 Baloo Widgets BRANCH master REVISION DETAIL https://phabricator.kde.org/D20477 To: bruns, #baloo, #frameworks, astippich, ngraham Cc: gennad, domson,

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.10 - Build # 85 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.10/85/ Project: kf5-qt5 SUSEQt5.10 Date of build: Fri, 12 Apr 2019 17:05:45 + Build duration: 9 min 38 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 72 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/72/ Project: kf5-qt5 SUSEQt5.12 Date of build: Fri, 12 Apr 2019 17:05:45 + Build duration: 9 min 14 sec and counting BUILD ARTIFACTS

D20424: [KUrlNavigator] Fix URL navigation when exiting archive with krarc and Dolphin

This revision was automatically updated to reflect the committed changes. Closed by commit R241:0cb9fe93e190: [KUrlNavigator] Fix URL navigation when exiting archive with krarc and Dolphin (authored by nhiga, committed by ngraham). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

D20424: [KUrlNavigator] Fix URL navigation when exiting archive with krarc and Dolphin

ngraham added a comment. Since the hardcoded list of affected protocols is already there, let's add the new one for now. In the future we'll look into moving this information into a more appropriate place. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D20424 To:

D20209: Add support for KBookmarkOwner to communicate if it has tabs open

ngraham added reviewers: cfeck, dfaure. REPOSITORY R294 KBookmarks REVISION DETAIL https://phabricator.kde.org/D20209 To: hallas, #frameworks, ngraham, cfeck, dfaure Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20426: Improve "widget-alternatives" icon

GB_2 added a dependent revision: D17410: Add alternatives button to applet configuration in panel edit mode. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D20426 To: GB_2, #vdg Cc: kde-frameworks-devel, #vdg, michaelh, ngraham, bruns

D18824: Implement wl_eglstream_controller Server Interface

ekurzinger marked 2 inline comments as done. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D18824 To: ekurzinger, romangg, davidedmundson, #kwin Cc: zzag, ngraham, mati865, schernikov, guilhermesi, kde-frameworks-devel, michaelh, bruns

D18824: Implement wl_eglstream_controller Server Interface

ekurzinger updated this revision to Diff 56078. ekurzinger added a comment. Changed the dynamic_cast in create() to static_cast. Since the Private is created in the constructor of EglStreamControllerInterface, it should be safe to assume it is of the correct type. Also marked Private as

D18824: Implement wl_eglstream_controller Server Interface

zzag added inline comments. INLINE COMMENTS > eglstream_controller_interface.cpp:103 > +{ > +dynamic_cast(*d).create(); > +} Can we avoid dynamic casting a reference? Is it possible to use static_cast instead? > eglstream_controller_interface_p.h:33 > + > +class

D20496: Air/Oxygen desktoptheme: fix hand offsets with hint-*-rotation-center-offset

kossebau retitled this revision from "Air desktoptheme: fix offset of hands with hint-*-rotation-center-offset" to "Air/Oxygen desktoptheme: fix hand offsets with hint-*-rotation-center-offset". kossebau edited the summary of this revision. REPOSITORY R242 Plasma Framework (Library) REVISION

D20496: Air desktoptheme: fix offset of hands with hint-*-rotation-center-offset

kossebau updated this revision to Diff 56077. kossebau added a comment. Oxygen clock has the same issue REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20496?vs=56076=56077 BRANCH fixairclock REVISION DETAIL

D18824: Implement wl_eglstream_controller Server Interface

ekurzinger marked an inline comment as done. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D18824 To: ekurzinger, romangg, davidedmundson, #kwin Cc: ngraham, mati865, schernikov, guilhermesi, kde-frameworks-devel, michaelh, bruns

D18824: Implement wl_eglstream_controller Server Interface

ekurzinger updated this revision to Diff 56075. ekurzinger added a comment. Ok, now we will bail out early during create() if we fail to dynamically load the interface (before calling wl_global_create). The compositor can then use isValid() to check if whether creating the interface

D20496: Air desktoptheme: fix offset of hands with hint-*-rotation-center-offset

kossebau added a comment. Looks like this with Plasma 5.16: F6768883: Screenshot_20190412_174053.png which gets us again to what it looked originally, cmp. https://kde.org/announcements/4.3/images/kde430-desktop.png REPOSITORY R242 Plasma

D20496: Air desktoptheme: fix offset of hands with hint-*-rotation-center-offset

kossebau created this revision. kossebau added reviewers: Plasma, mart. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. kossebau requested review of this revision. REVISION SUMMARY The hands of the clock still relied on the KDE4 times rule that the

D20264: Add test for "Auto Reload Document" option

loh.tar added a comment. In D20264#448583 , @dhaumann wrote: > I think KateViewInternal::updateView is called for cursor blinking for instance. May that be an issue? Regarding ... > KateViewInternal::updateView is very often called

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 63 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/63/ Project: kf5-qt5 SUSEQt5.12 Date of build: Fri, 12 Apr 2019 14:47:22 + Build duration: 17 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.12 - Build # 73 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.12/73/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Fri, 12 Apr 2019 14:47:21 + Build duration: 5 min 39 sec and counting JUnit Tests

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 70 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/70/ Project: kf5-qt5 SUSEQt5.10 Date of build: Fri, 12 Apr 2019 14:47:23 + Build duration: 5 min 23 sec and counting BUILD ARTIFACTS

D18824: Implement wl_eglstream_controller Server Interface

ekurzinger marked an inline comment as done. ekurzinger added a comment. In D18824#448597 , @romangg wrote: > In the first revision the interface failed to create when the dynamically loaded library was not present (we said the class should

KDE CI: Frameworks » plasma-framework » kf5-qt5 WindowsMSVCQt5.11 - Build # 155 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20WindowsMSVCQt5.11/155/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Fri, 12 Apr 2019 14:47:23 + Build duration: 3 min 21 sec and counting CONSOLE

D20495: KateIconBorder: Fix folding popup width and height

loh.tar created this revision. loh.tar added a reviewer: KTextEditor. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. loh.tar requested review of this revision. REVISION SUMMARY - Now take the popup the whole width of the view instead of

D20417: Add invokable public API for emitting contextualActionsAboutToShow

This revision was automatically updated to reflect the committed changes. Closed by commit R242:83d85dc2288c: Add invokable public API for emitting contextualActionsAboutToShow (authored by davidedmundson). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE

D18824: Implement wl_eglstream_controller Server Interface

davidedmundson added a comment. > Now it just fails silently on bind. Why is it ok to fail silently on bind? We wouldn't get that far. If the library didn't load then we wouldn't have sent an interface to wl_global_create I don't know how that behaves, but we would have either

D18824: Implement wl_eglstream_controller Server Interface

davidedmundson accepted this revision. davidedmundson added inline comments. INLINE COMMENTS > eglstream_controller_interface.h:49 > +public: > +virtual ~EglStreamControllerInterface(); > + pedantically that should be: ~EglStreamControllerInterface() override; REPOSITORY R127 KWayland

D18824: Implement wl_eglstream_controller Server Interface

ekurzinger updated this revision to Diff 56067. ekurzinger added a comment. Re-added protocol XML file to diff and corrected version in display.h REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18824?vs=56009=56067 REVISION DETAIL

D20493: Introduce and use KArchiveDirectory::addEntryV2

aacid updated this revision to Diff 56065. aacid added a comment. remove friend, don't need it with this current approach REPOSITORY R243 KArchive CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20493?vs=56064=56065 BRANCH arcpatch-D20493 REVISION DETAIL

D20493: Introduce and use KArchiveDirectory::addEntryV2

aacid created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. aacid requested review of this revision. REVISION SUMMARY The original addEntry can delete the entry that is passed in, but we have no way to know about it, so when that happens

D20489: [KIO] Make it compile without foreach (Step 1)

mlaurent retitled this revision from "[KIO] Make to compile without foreach (Step 1)" to "[KIO] Make it compile without foreach (Step 1)". mlaurent edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D20489 To: mlaurent, dfaure Cc:

D20489: [KIO] Make to compile without foreach (Step 1)

cgiboudeaux added a comment. In D20489#448703 , @mlaurent wrote: > what is the problem with title ? "Make to compile without foreach" it's missing words or some have to be changed. The summary also lacks explanations *why* this

D20489: [KIO] Make to compile without foreach (Step 1)

mlaurent added a comment. what is the problem with title ? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D20489 To: mlaurent, dfaure Cc: cgiboudeaux, kde-frameworks-devel, michaelh, ngraham, bruns

D20467: Allow to close a document whose file was deleted on disk

meven edited the summary of this revision. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D20467 To: meven, cullmann, #kate, #frameworks, dhaumann Cc: dhaumann, ngraham, kwrite-devel, kde-frameworks-devel, gennad, domson, michaelh, bruns, demsking, cullmann, sars

D20467: Allow to close a document whose file was deleted on disk

meven added a comment. kdevelop supports this interface already https://cgit.kde.org/kdevelop.git/tree/shell/ktexteditorpluginintegration.h?id=e2bcd581bb8a9bb0005a9fcdce3167fc6be77e40#n56 But not kile as far as greping kile source for KTextEditor::Application has shown. REPOSITORY

D20489: [KIO] Make to compile without foreach (Step 1)

cgiboudeaux added a comment. Please fix the summary REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D20489 To: mlaurent, dfaure Cc: cgiboudeaux, kde-frameworks-devel, michaelh, ngraham, bruns

D20484: Mark archive and directory as const

aacid added a comment. In D20484#448629 , @apol wrote: > The patch is fine, I wonder how you ended up deciding this was a change to be done. :P That's coming up next ;) REPOSITORY R301 KEmoticons REVISION DETAIL

D20484: Mark archive and directory as const

This revision was automatically updated to reflect the committed changes. Closed by commit R301:808e4463afb1: Mark archive and directory as const (authored by aacid). REPOSITORY R301 KEmoticons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20484?vs=56039=56062 REVISION DETAIL

D20489: [KIO] Make to compile without foreach (Step 1)

mlaurent created this revision. mlaurent added a reviewer: dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mlaurent requested review of this revision. REVISION SUMMARY Port a lot of foreach/FOREACH (still 220 items) TEST PLAN autotest ok

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.10 - Build # 84 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.10/84/ Project: kf5-qt5 SUSEQt5.10 Date of build: Fri, 12 Apr 2019 10:40:40 + Build duration: 34 min and counting BUILD ARTIFACTS

D20484: Mark archive and directory as const

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. The patch is fine, I wonder how you ended up deciding this was a change to be done. :P REPOSITORY R301 KEmoticons BRANCH master REVISION DETAIL https://phabricator.kde.org/D20484 To:

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.12 - Build # 83 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.12/83/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Fri, 12 Apr 2019 10:40:40 + Build duration: 6 min 15 sec and counting JUnit Tests Name:

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 71 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/71/ Project: kf5-qt5 SUSEQt5.12 Date of build: Fri, 12 Apr 2019 10:40:40 + Build duration: 1 min 19 sec and counting CONSOLE OUTPUT [...truncated 524

D20465: [KDynamicJobTracker] When kuiserver isn't available, also fall back to widget dialog

This revision was automatically updated to reflect the committed changes. Closed by commit R241:580fec7c0b20: [KDynamicJobTracker] When kuiserver isnt available, also fall back to widget… (authored by broulik). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

D20462: [KUiServerJobTracker] Track kuiserver service life time and re-register jobs if needed

This revision was automatically updated to reflect the committed changes. Closed by commit R288:130809f97e6f: [KUiServerJobTracker] Track kuiserver service life time and re-register jobs if… (authored by broulik). REPOSITORY R288 KJobWidgets CHANGES SINCE LAST UPDATE

D20467: Allow to close a document whose file was deleted on disk

cullmann added a comment. The current implementation at least closes the file, in all applications. It just doesn't remove in in all of them from the document list. I think that is ok enough, more can't be done in KTextEditor. Extra reviews for extending the applications are welcome.

D18824: Implement wl_eglstream_controller Server Interface

romangg added a comment. The xml file is missing form the diff now. Don't forget to add it when pushing. In the first revision the interface failed to create when the dynamically loaded library was not present. Now it just fails silently on bind. Why is this ok? INLINE COMMENTS >

KDE CI: Frameworks » plasma-framework » kf5-qt5 WindowsMSVCQt5.11 - Build # 154 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20WindowsMSVCQt5.11/154/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Fri, 12 Apr 2019 09:21:52 + Build duration: 30 min and counting CONSOLE OUTPUT

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 62 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/62/ Project: kf5-qt5 SUSEQt5.12 Date of build: Fri, 12 Apr 2019 09:21:52 + Build duration: 16 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.12 - Build # 72 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.12/72/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Fri, 12 Apr 2019 09:21:52 + Build duration: 5 min 46 sec and counting JUnit Tests

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 69 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/69/ Project: kf5-qt5 SUSEQt5.10 Date of build: Fri, 12 Apr 2019 09:21:52 + Build duration: 4 min 48 sec and counting BUILD ARTIFACTS

D20264: Add test for "Auto Reload Document" option

dhaumann added a comment. I think KateViewInternal::updateView is called for cursor blinking for instance. May that be an issue? REVISION DETAIL https://phabricator.kde.org/D20264 To: loh.tar, dhaumann Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, gennad, domson, michaelh,

D20478: Breeze desktoptheme clock: support hand shadow offset hint of Plasma 5.16

This revision was automatically updated to reflect the committed changes. Closed by commit R242:417a82b1b947: Breeze desktoptheme clock: support hand shadow offset hint of Plasma 5.16 (authored by kossebau). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE

D20467: Allow to close a document whose file was deleted on disk

dhaumann added a comment. Hm, the correct fix is to implement this function for KWrite. And: There is also KDevelop and Kile... Having only a half-working solution sounds suboptimal to me. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D20467 To: meven,

  1   2   >