D20693: Remove pixelated border

anthonyfieroni added a comment. Will be good see how it looks in dark theme, especially dark pictures. REPOSITORY R304 KNewStuff BRANCH no-pixelated-border (branched from master) REVISION DETAIL https://phabricator.kde.org/D20693 To: leinir, #knewstuff, ngraham, sitter, #vdg Cc: antho

D20209: Add support for KBookmarkOwner to communicate if it has tabs open

hallas added a comment. In D20209#455579 , @aacid wrote: > @hallas but tests are still failing since your previous commit. Can you have a look? https://build.kde.org/job/Frameworks/job/kbookmarks/job/kf5-qt5%20SUSEQt5.10/21/testReport/ @

Re: MacOS Builds - KArchive & KDocTools

On Thu, Apr 25, 2019 at 11:36 AM Luigi Toscano wrote: > > Ben Cooksley ha scritto: > > Hi all, > > > > While getting Mac builds back on their feet this morning we've run > > into a rather terminal build failure issue, centering around KArchive > > and KDocTools. > > > > The issue is struck during

Re: MacOS Builds - KArchive & KDocTools

Ben Cooksley ha scritto: Hi all, While getting Mac builds back on their feet this morning we've run into a rather terminal build failure issue, centering around KArchive and KDocTools. The issue is struck during the build of KDocTools, when the linking of libKF5DocTools.dylib fails with the fol

MacOS Builds - KArchive & KDocTools

Hi all, While getting Mac builds back on their feet this morning we've run into a rather terminal build failure issue, centering around KArchive and KDocTools. The issue is struck during the build of KDocTools, when the linking of libKF5DocTools.dylib fails with the following message: Undefined

D20693: Remove pixelated border

ngraham added a comment. Looks great, though I would put the search field on top. It's a lot like the new GridView KCMs; maybe we can even use that template for it. The current Colors KCM looks a lot like that. REPOSITORY R304 KNewStuff BRANCH no-pixelated-border (branched from master)

D20209: Add support for KBookmarkOwner to communicate if it has tabs open

aacid added a comment. @hallas but tests are still failing since your previous commit. Can you have a look? https://build.kde.org/job/Frameworks/job/kbookmarks/job/kf5-qt5%20SUSEQt5.10/21/testReport/ REPOSITORY R294 KBookmarks REVISION DETAIL https://phabricator.kde.org/D20209 To: hall

KDE CI: Frameworks » kbookmarks » kf5-qt5 SUSEQt5.10 - Build # 21 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kbookmarks/job/kf5-qt5%20SUSEQt5.10/21/ Project: kf5-qt5 SUSEQt5.10 Date of build: Wed, 24 Apr 2019 20:33:36 + Build duration: 2 min 34 sec and counting BUILD ARTIFACTS acc/KF5Book

KDE CI: Frameworks » kbookmarks » kf5-qt5 SUSEQt5.12 - Build # 18 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kbookmarks/job/kf5-qt5%20SUSEQt5.12/18/ Project: kf5-qt5 SUSEQt5.12 Date of build: Wed, 24 Apr 2019 20:33:36 + Build duration: 2 min 47 sec and counting BUILD ARTIFACTS acc/KF5Book

KDE CI: Frameworks » kbookmarks » kf5-qt5 FreeBSDQt5.12 - Build # 20 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kbookmarks/job/kf5-qt5%20FreeBSDQt5.12/20/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Wed, 24 Apr 2019 20:33:36 + Build duration: 49 sec and counting JUnit Tests Name: projectro

D20209: Add support for KBookmarkOwner to communicate if it has tabs open

aacid added a comment. I just fixed it FWIW REPOSITORY R294 KBookmarks REVISION DETAIL https://phabricator.kde.org/D20209 To: hallas, #frameworks, ngraham, cfeck, dfaure Cc: aacid, kde-frameworks-devel, michaelh, ngraham, bruns

D20693: Remove pixelated border

mmustac added a comment. @ngraham: Fo sure, I will add my post from the forum here for better reference. > Today I thougtht about the design of the "Get new Hot Stuff" dialog. I think there is some room for improvements and to get a better overview. > I tried to put my thought into a

D20209: Add support for KBookmarkOwner to communicate if it has tabs open

aacid added a comment. @hallas you seem to have broken compilation https://build.kde.org/job/Frameworks/job/kbookmarks/job/kf5-qt5%20SUSEQt5.10/20/ REPOSITORY R294 KBookmarks REVISION DETAIL https://phabricator.kde.org/D20209 To: hallas, #frameworks, ngraham, cfeck, dfaure Cc: aacid, kd

D20791: Rename "edit-remove" icon to "edit-delete-remove" to support Oxygen and other icon themes

This revision was automatically updated to reflect the committed changes. Closed by commit R266:2cbbfe2351a6: Rename "edit-remove" icon to "edit-delete-remove" to support Oxygen and other… (authored by GB_2). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D20791?vs=56905&id=56907#toc REPO

D20791: Rename "edit-remove" icon to "edit-delete-remove" to support Oxygen and other icon themes

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R266 Breeze Icons BRANCH master REVISION DETAIL https://phabricator.kde.org/D20791 To: GB_2, #vdg, ngraham Cc: kde-frameworks-devel, #vdg, michaelh, ngraham, bruns

D20693: Remove pixelated border

ngraham accepted this revision. ngraham added a subscriber: mmustac. ngraham added a comment. This revision is now accepted and ready to land. In D20693#455251 , @leinir wrote: > i'm afraid the "it works" is an illusion brought on by looking at co

D20791: Rename "edit-remove" icon to "edit-delete-remove" to support Oxygen and other icon themes

GB_2 created this revision. GB_2 added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. GB_2 requested review of this revision. REVISION SUMMARY Icon themes that don't have the icon will now fall back to `edit-delete`. TEST PLAN Search for

D19812: Add a web page to view and compare icons of different sizes

ngraham added subscribers: GB_2, trickyricky26. ngraham added a comment. TBH I wonder how useful this actually is. Hopefully some of the other folks involved in making icons (@ndavis, @GB_2, @trickyricky26) can comment on whether or not this would be useful for them. REPOSITORY R266 Breeze

D20626: Refactor and cleanup

shubham added a comment. @dfaure Ping? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D20626 To: shubham, dfaure Cc: pino, kde-frameworks-devel, michaelh, ngraham, bruns

D20626: Refactor and cleanup

shubham edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D20626 To: shubham, dfaure Cc: pino, kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » kbookmarks » kf5-qt5 FreeBSDQt5.12 - Build # 19 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kbookmarks/job/kf5-qt5%20FreeBSDQt5.12/19/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Wed, 24 Apr 2019 14:41:46 + Build duration: 22 min and counting JUnit Tests Name: projectro

KDE CI: Frameworks » kbookmarks » kf5-qt5 SUSEQt5.12 - Build # 17 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kbookmarks/job/kf5-qt5%20SUSEQt5.12/17/ Project: kf5-qt5 SUSEQt5.12 Date of build: Wed, 24 Apr 2019 14:41:46 + Build duration: 3 min 59 sec and counting BUILD ARTIFACTS acc/KF5Book

KDE CI: Frameworks » kbookmarks » kf5-qt5 SUSEQt5.10 - Build # 20 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kbookmarks/job/kf5-qt5%20SUSEQt5.10/20/ Project: kf5-qt5 SUSEQt5.10 Date of build: Wed, 24 Apr 2019 14:41:46 + Build duration: 2 min 17 sec and counting CONSOLE OUTPUT [...truncated

D20209: Add support for KBookmarkOwner to communicate if it has tabs open

hallas closed this revision. REPOSITORY R294 KBookmarks REVISION DETAIL https://phabricator.kde.org/D20209 To: hallas, #frameworks, ngraham, cfeck, dfaure Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20196: Add Notify capability to KConfigXT

This revision was automatically updated to reflect the committed changes. Closed by commit R237:5d2ed13479a4: Add Notify capability to KConfigXT (authored by broulik). REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20196?vs=55730&id=56898 REVISION DETAIL ht

KDE CI: Frameworks » ktexteditor » kf5-qt5 SUSEQt5.10 - Build # 100 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20SUSEQt5.10/100/ Project: kf5-qt5 SUSEQt5.10 Date of build: Wed, 24 Apr 2019 13:42:41 + Build duration: 21 min and counting BUILD ARTIFACTS acc/KF5TextEdito

KDE CI: Frameworks » ktexteditor » kf5-qt5 FreeBSDQt5.12 - Build # 102 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20FreeBSDQt5.12/102/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Wed, 24 Apr 2019 13:42:41 + Build duration: 21 min and counting JUnit Tests Name: projectr

KDE CI: Frameworks » ktexteditor » kf5-qt5 SUSEQt5.12 - Build # 85 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20SUSEQt5.12/85/ Project: kf5-qt5 SUSEQt5.12 Date of build: Wed, 24 Apr 2019 13:42:41 + Build duration: 9 min 49 sec and counting BUILD ARTIFACTS acc/KF5Text

D20697: Review IconBorder

This revision was automatically updated to reflect the committed changes. Closed by commit R39:0d70744ed67b: Fix broken InlineNoteTest (authored by loh.tar). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D20697?vs=56843&id=56895#toc REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE

D19812: Add a web page to view and compare icons of different sizes

guoyunhe added a comment. Hi @ngraham @pino @bcooksley , I have updated the script/configuration. Can you give some further opinion? REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D19812 To: guoyunhe, ngraham, #vdg, ndavis, #breeze Cc: pino, bcooksley, ngraham,

D20628: Add CriticalNotification window type to PlasmaShellSurface protocol

broulik updated this revision to Diff 56884. broulik edited the test plan for this revision. broulik added a comment. - do proper versioning REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20628?vs=56422&id=56884 REVISION DETAIL https://phabricator.kde.o

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 85 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/85/ Project: kf5-qt5 SUSEQt5.10 Date of build: Wed, 24 Apr 2019 09:55:33 + Build duration: 7 min 53 sec and counting BUILD ARTIFACTS acc/K

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 78 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/78/ Project: kf5-qt5 SUSEQt5.12 Date of build: Wed, 24 Apr 2019 09:55:33 + Build duration: 7 min 21 sec and counting BUILD ARTIFACTS acc/K

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.12 - Build # 88 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.12/88/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Wed, 24 Apr 2019 09:55:33 + Build duration: 5 min 49 sec and counting JUnit Tests Nam

D20735: [KPropertiesDialog] Add octal permissions

mmustac added a comment. We could also make the permissions interactive and explaining at the same time. I could imagine something like this: F6790404: permissions.png REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D20735 To: s

D20693: Remove pixelated border

leinir added a comment. In D20693#454874 , @ngraham wrote: > To show that a thumbnail clickable, switching to the pointing hand cursor when hovering over a thumbnail could work. > > However I notice that the actual list delegates in the brows

D20748: Fix wrong "Unable to find service type" warnings

dfaure updated this revision to Diff 56867. dfaure added a comment. Improve unittest - which no longer prints a warning about example/servicetype REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20748?vs=56770&id=56867 BRANCH master REVISION DETAIL

D20697: Review IconBorder

cullmann reopened this revision. cullmann added a comment. This revision is now accepted and ready to land. loh.tar, can you take a look? If it is too complex to fix easily, we can still revert this and apply it again later together with a fix. Thanks for pointing the CI fail out David! R

D20697: Review IconBorder

cullmann added a comment. :( Sorry, I didn't run them again, just tried out if it works in KDevelop. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D20697 To: loh.tar, #ktexteditor, dhaumann, cullmann Cc: dfaure, cullmann, dhaumann, kwrite-devel, kde-frameworks-de

D20697: Review IconBorder

dfaure added a comment. This commit appears to have introduced a unittest regression FAIL! : InlineNoteTest::testInlineNote() Compared values are not the same Actual (newCoordCol04): QPoint(51,1) Expected (coordCol04) : QPoint(33,1) Loc: [/home/jenkins/workspace/Framewo

KDE CI: Frameworks » ktexteditor » kf5-qt5 SUSEQt5.10 - Build # 99 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20SUSEQt5.10/99/ Project: kf5-qt5 SUSEQt5.10 Date of build: Wed, 24 Apr 2019 06:58:35 + Build duration: 6 min 3 sec and counting BUILD ARTIFACTS acc/KF5Text