KDE CI: Frameworks » kcoreaddons » kf5-qt5 WindowsMSVCQt5.11 - Build # 79 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20WindowsMSVCQt5.11/79/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Mon, 06 May 2019 22:18:25 + Build duration: 3 min 55 sec and counting JUnit Tests

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.12 - Build # 45 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.12/45/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Mon, 06 May 2019 22:18:25 + Build duration: 1 min 51 sec and counting JUnit Tests Name:

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.12 - Build # 44 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.12/44/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Mon, 06 May 2019 22:11:25 + Build duration: 1 min 48 sec and counting JUnit Tests Name:

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.12 - Build # 43 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.12/43/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Mon, 06 May 2019 22:02:49 + Build duration: 2 min 37 sec and counting JUnit Tests Name:

KDE CI: Frameworks » kcoreaddons » kf5-qt5 WindowsMSVCQt5.11 - Build # 78 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20WindowsMSVCQt5.11/78/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Mon, 06 May 2019 22:11:25 + Build duration: 1 min 23 sec and counting CONSOLE OUTPUT

KDE CI: Frameworks » kcoreaddons » kf5-qt5 WindowsMSVCQt5.11 - Build # 77 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20WindowsMSVCQt5.11/77/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Mon, 06 May 2019 22:02:49 + Build duration: 1 min 38 sec and counting CONSOLE OUTPUT

D20958: New menu of syntax highlighting in the status bar

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Thanks, this is now perfect from my UI perspective. I'll let the KTextEditor folks do the code review part. :) REPOSITORY R39 KTextEditor BRANCH new-mode-menu REVISION DETAIL

D20833: Simpler check for flatpak

jgrulich added a comment. Lookgs good to me, I'll wait for Kai to approve this since he is the maintainer. One thing to consider maybe, did /.flatpak-info always exist or is it something new? I always assumed there is just one flatpak-info file in $XDG_RUNTIME_DIR. Just to be sure it will

D20995: [Fstab] Add support for non-network filesystems

bruns added inline comments. INLINE COMMENTS > hallas wrote in fstabhandling.cpp:126 > Yes indeed :D I was just wondering why it was made the way it is? Is there a > reason for the limit or was it just because we were only targeting vault type > mounts? fuse filesystems are just to different

D21041: [Fstab] Use folder-decrypted icon for encrypting fuse mounts

bruns marked 2 inline comments as done. bruns added inline comments. INLINE COMMENTS > hallas wrote in fstabdevice.cpp:62 > Would it make sense to wrap this in a function with a more expressive name > like: isEncryptedFilesystem or isValutFilesystem? Then we could use the same > function in

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.12 - Build # 42 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.12/42/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Mon, 06 May 2019 17:49:14 + Build duration: 1 min 58 sec and counting JUnit Tests Name:

D20007: Add GetProcessList for retrieving the list of currently active processes

hallas added a comment. Thanks for the review! Landing it now. REPOSITORY R244 KCoreAddons BRANCH adds_kprocesslist (branched from master) REVISION DETAIL https://phabricator.kde.org/D20007 To: hallas, davidedmundson, broulik Cc: vonreth, adridg, elvisangelaccio,

KDE CI: Frameworks » kcoreaddons » kf5-qt5 WindowsMSVCQt5.11 - Build # 76 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20WindowsMSVCQt5.11/76/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Mon, 06 May 2019 17:49:14 + Build duration: 1 min 33 sec and counting CONSOLE OUTPUT

D20007: Add GetProcessList for retrieving the list of currently active processes

hallas closed this revision. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D20007 To: hallas, davidedmundson, broulik Cc: vonreth, adridg, elvisangelaccio, kde-frameworks-devel, michaelh, ngraham, bruns

D20007: Add GetProcessList for retrieving the list of currently active processes

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R244 KCoreAddons BRANCH adds_kprocesslist (branched from master) REVISION DETAIL https://phabricator.kde.org/D20007 To: hallas, davidedmundson, broulik Cc: vonreth, adridg, elvisangelaccio,

D20007: Add GetProcessList for retrieving the list of currently active processes

hallas added a comment. @davidedmundson - ping ? REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D20007 To: hallas, davidedmundson, broulik Cc: vonreth, adridg, elvisangelaccio, kde-frameworks-devel, michaelh, ngraham, bruns

D20938: Add Mounts Backend

hallas added a comment. This patch has been superseeded by the wotk @bruns has done in D20995 - so closing this one :D REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D20938 To: hallas, #frameworks, ngraham, elvisangelaccio,

D20938: Add Mounts Backend

hallas abandoned this revision. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D20938 To: hallas, #frameworks, ngraham, elvisangelaccio, broulik, bruns Cc: svuorela, nicolasfella, ivan, kde-frameworks-devel, michaelh, ngraham, bruns

D21041: [Fstab] Use folder-decrypted icon for encrypting fuse mounts

hallas added inline comments. INLINE COMMENTS > fstabdevice.cpp:62 > } > +if ((fstype == QLatin1String("fuse.encfs")) || > +(fstype == QLatin1String("fuse.cryfs"))) { Would it make sense to wrap this in a function with a more expressive name like:

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.12 - Build # 101 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.12/101/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Mon, 06 May 2019 16:15:57 + Build duration: 9 min 28 sec and counting JUnit Tests Name:

D20964: [FileWidget] Replace "Filter:" with "File type:" when saving with a limited list of mimetypes

This revision was automatically updated to reflect the committed changes. Closed by commit R241:f066660f: [FileWidget] Replace Filter: with File type: when saving with a limited… (authored by ngraham). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

Re: New framework: KCalCore

On Tue, Apr 30, 2019 at 8:52 PM Allen Winter wrote: > > Clazy is complaining about missing assign operators. Do we care? > If so, I can take a look at adding them or if anyone else wants to do that. > -Allen That will be fixed in Qt. Regards, Sergio Martins

D20838: Allow to drop one file or one folder on KDirOperator

ngraham edited the summary of this revision. REPOSITORY R241 KIO BRANCH arcpatch-D20838 REVISION DETAIL https://phabricator.kde.org/D20838 To: meven, ngraham Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D20838: Allow to drop one file or one folder on KDirOperator

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. LGTM! INLINE COMMENTS > meven wrote in kdiroperator.cpp:418 > Any idea where I should add this information ? > An example would suffice. You already did, in the inline function

D20995: [Fstab] Add support for non-network filesystems

hallas added inline comments. INLINE COMMENTS > ngraham wrote in fstabhandling.cpp:126 > Now that the refactoring's been done, it should be easy to add support for > those or remove the conditional. Yes indeed :D I was just wondering why it was made the way it is? Is there a reason for the

D21041: [Fstab] Use folder-decrypted icon for encrypting fuse mounts

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R245 Solid BRANCH fstab_generic REVISION DETAIL https://phabricator.kde.org/D21041 To: bruns, #frameworks, ngraham, hallas Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D20995: [Fstab] Add support for non-network filesystems

ngraham added inline comments. INLINE COMMENTS > hallas wrote in fstabhandling.cpp:126 > Why do we limit to these two filesystems? I think it would be really useful > to show all kinds of fuse based filesystems, e.g. isofs, sshfs and > xrdp-chansrv. Now that the refactoring's been done, it

D20995: [Fstab] Add support for non-network filesystems

hallas added inline comments. INLINE COMMENTS > fstabhandling.cpp:126 > +{ > +if (fstype == "fuse.encfs" || > +fstype == "fuse.cryfs") { Why do we limit to these two filesystems? I think it would be really useful to show all kinds of fuse based filesystems, e.g. isofs, sshfs and

D17071: Don't include any directory sizes in DirectorySizeJob

dfaure added a comment. I don't object to the patch, but maybe the properties dialog (and other users of this job) should indicate that the number being shown is "sum of file sizes, not actual disk space usage, which is larger" (blocks, inodes, directory sizes...) REPOSITORY R241 KIO

D21041: [Fstab] Use folder-decrypted icon for encrypting fuse mounts

bruns added a comment. In D21041#461446 , @broulik wrote: > Looks like we need a symbolic icon for that in breeze #vdg ^ Preferably yes, though thats orthogonal to this change. REPOSITORY

D15076: Build failures with KSyntaxHighlighting 5.49

tcanabrava resigned from this revision. REPOSITORY R55 Cantor REVISION DETAIL https://phabricator.kde.org/D15076 To: asemke, #kde_edu, #cantor, #frameworks Cc: bcooksley, elvisangelaccio, dfaure, cgiboudeaux, mpyne, cullmann, kde-edu, narvaez, apol

D19956: ki18n: updating memory manager and removing compile warnings

tcanabrava resigned from this revision. REPOSITORY R249 KI18n REVISION DETAIL https://phabricator.kde.org/D19956 To: carneirogustavo, andreagenor, patrickelectric Cc: aacid, kde-frameworks-devel, michaelh, ngraham, bruns

D20838: Allow to drop one file or one folder on KDirOperator

meven updated this revision to Diff 57636. meven edited the test plan for this revision. meven added a comment. Fix drag^Ciltering, add mime filtering to the drag filtering REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20838?vs=57625=57636 BRANCH

D20838: Allow to drop one file or one folder on KDirOperator

meven planned changes to this revision. meven added a comment. An eventFilter must return true when the event has been processed and prevent further event handling. This prevent the drag filtering to not work (multiple files for instance). The code does not do that currently, I am on it.

D20838: Allow to drop one file or one folder on KDirOperator

meven edited the summary of this revision. meven edited the test plan for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D20838 To: meven, ngraham Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D21041: [Fstab] Use folder-decrypted icon for encrypting fuse mounts

broulik added a comment. Looks like we need a symbolic icon for that in breeze REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D21041 To: bruns, #frameworks, ngraham, hallas Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns