D21179: FrameSvgItem: emit maskChanged always from doUpdate()

kossebau created this revision. kossebau added a reviewer: Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. kossebau requested review of this revision. REVISION SUMMARY In that method we can assue a high chance that the mask is also affected. Instead

KDE CI: Frameworks » kpeople » kf5-qt5 WindowsMSVCQt5.11 - Build # 39 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kpeople/job/kf5-qt5%20WindowsMSVCQt5.11/39/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Mon, 13 May 2019 04:53:58 + Build duration: 12 min and counting JUnit Tests Name: proj

KDE CI: Frameworks » kdelibs4support » kf5-qt5 FreeBSDQt5.12 - Build # 26 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20FreeBSDQt5.12/26/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Mon, 13 May 2019 04:51:33 + Build duration: 5 min 11 sec and counting JUnit Tests Name

D21174: FrameSvg: make hasElementPrefix() also handle prefix with trailing -

kossebau added a comment. The other option would be to fix the places which call `hasElementPrefix` but given that the ones known all rely on `prefix()` and `actualPrefix()`, it seems less code to fix this in one place and change behaviour a bit to be more grateful with the argument passed.

D21175: FrameSvgPrivate::generateBackground: generate background also if reqp != p

kossebau created this revision. kossebau added a reviewer: Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. kossebau requested review of this revision. REVISION SUMMARY d8a1a9eb084b19e552c789244267f7346e1b27a8

D21174: FrameSvg: make hasElementPrefix() also handle prefix with trailing -

kossebau created this revision. kossebau added a reviewer: Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. kossebau requested review of this revision. REVISION SUMMARY there are a few places which potentially pass a prefix with a trailing -, e.g. if

D21173: API dox: note for FrameSvg::prefix()/actualPrefix() the trailing '-'

kossebau created this revision. kossebau added a reviewer: Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. kossebau requested review of this revision. REPOSITORY R242 Plasma Framework (Library) BRANCH fixdoxofprefix REVISION DETAIL https://phabr

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 97 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/97/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sun, 12 May 2019 23:14:25 + Build duration: 17 min and counting BUILD ARTIFACTS acc/KF5Plas

D21172: FrameSvg: also clear mask cache on clearCache()

kossebau created this revision. kossebau added a reviewer: Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. kossebau requested review of this revision. REVISION SUMMARY It can be unexpected that those are not reset when clearCache() was called. Wi

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 90 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/90/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sun, 12 May 2019 23:14:25 + Build duration: 4 min 28 sec and counting BUILD ARTIFACTS acc/K

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.12 - Build # 100 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.12/100/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sun, 12 May 2019 23:14:25 + Build duration: 2 min 48 sec and counting JUnit Tests Na

D18222: Don't hardcode dbus policy install dir

This revision was automatically updated to reflect the committed changes. Closed by commit R283:34501bceed1d: Don't hardcode dbus policy install dir (authored by arojas). REPOSITORY R283 KAuth CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18222?vs=57942&id=57959 REVISION DETAIL h

D21169: Add app icon for the Kirogi Drone control app

apol added a comment. Let's add it when the application exists? REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D21169 To: trickyricky26, hein, #vdg Cc: apol, kde-frameworks-devel, hein, michaelh, ngraham, bruns

D18222: Don't hardcode dbus policy install dir

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R283 KAuth REVISION DETAIL https://phabricator.kde.org/D18222 To: arojas, #frameworks, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D21149: KAr::openArchive: Protect against Heap-buffer-overflow in broken files

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. Q_ISUNLIKELY? I have no idea if it's a hot path, probably not, yet it could make sense as a way to say this is crazy-town error detection. REPOSITORY R243 KArchive BRANCH master REVI

D21169: Add app icon for the Kirogi Drone control app

trickyricky26 edited the test plan for this revision. trickyricky26 added a reviewer: VDG. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D21169 To: trickyricky26, hein, #vdg Cc: kde-frameworks-devel, hein, michaelh, ngraham, bruns

D21169: Add app icon for the Kirogi Drone control app

trickyricky26 created this revision. trickyricky26 added a reviewer: hein. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. trickyricky26 requested review of this revision. REVISION SUMMARY Adds an app icon for @hein's upcoming Kirogi app. REPOSITORY R266 B

T3689: Add abi compliance checker to CI

knauss added a revision: D21168: create-abi-dump: Handle clang/*/include directories.. TASK DETAIL https://phabricator.kde.org/T3689 To: knauss Cc: danders, davidedmundson, dfaure, kde-frameworks-devel, bcooksley, sysadmin, scarlettclark, aacid, knauss, alexeymin, kaning, blazquez

D21155: Truncate long filname before creating a link

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D21155 To: chinmoyr, dfaure Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18222: Don't hardcode dbus policy install dir

arojas retitled this revision from "Install dbus configuration files under DATADIR by default" to "Don't hardcode dbus policy install dir". arojas edited the summary of this revision. REPOSITORY R283 KAuth REVISION DETAIL https://phabricator.kde.org/D18222 To: arojas, #frameworks Cc: kde-fr

D18222: Install dbus configuration files under DATADIR by default

arojas updated this revision to Diff 57942. arojas added a comment. Use non-deprecated variable REPOSITORY R283 KAuth CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18222?vs=49376&id=57942 REVISION DETAIL https://phabricator.kde.org/D18222 AFFECTED FILES cmake/KF5AuthMacros.

D21155: Truncate long filname before creating a link

chinmoyr created this revision. chinmoyr added a reviewer: dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. chinmoyr requested review of this revision. REVISION SUMMARY URL of a website can exceed 255 characters. Consequently we cannot create a link t

D21146: KProcessInfoList -- add proclist backend for FreeBSD

tcberner marked an inline comment as done. tcberner added a comment. Gargh, the code `kdelibs` code formatter changed a lot more in `kprocesslist_unix_proc.cpp` than wanted :/ REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D21146 To: tcberner, #freebsd, adridg,

D21146: KProcessInfoList -- add proclist backend for FreeBSD

tcberner updated this revision to Diff 57921. tcberner added a comment. - Switch to 2-Clause - Move procstat backend into its own file - Remove now unnecessary config-kprocesslist.cmake REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21146?vs=57915&i

D21149: KAr::openArchive: Protect against Heap-buffer-overflow in broken files

aacid created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. aacid requested review of this revision. REVISION SUMMARY If size is negative there's no need to continue, file is broken REPOSITORY R243 KArchive BRANCH master REVISION DETAI

D17302: Add test for adding properties to result

astippich added a comment. ping! REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D17302 To: astippich, #baloo, bruns Cc: kde-frameworks-devel, gennad, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams