KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 109 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/109/ Project: kf5-qt5 SUSEQt5.12 Date of build: Fri, 24 May 2019 05:19:25 + Build duration: 35 min and counting BUILD ARTIFACTS

D20197: Fix desktop link to file or directory

This revision was automatically updated to reflect the committed changes. Closed by commit R241:95d0b44a3837: Fix desktop link to file or directory (authored by hoffmannrobert, committed by ngraham). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

D21313: Create specific directory for kdebugsettings categories file

mlaurent added a comment. Ping ? REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D21313 To: mlaurent, dfaure, cgiboudeaux Cc: kde-frameworks-devel, kde-buildsystem, bencreasy, michaelh, ngraham, bruns

D19771: Use placeholder instead of label

ngraham added a comment. Hmm, now that you mention it, I agree. Maybe we can use placeholder text only for the quick find feature, but use labels for the advanced find-and-replace version? REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D19771 To: ognarb,

D20197: Fix desktop link to file or directory

ngraham edited the test plan for this revision. REPOSITORY R241 KIO BRANCH fix_desktop_link_filter REVISION DETAIL https://phabricator.kde.org/D20197 To: hoffmannrobert, #frameworks, ngraham, dfaure Cc: bruns, michaelweghorn, ngraham, kde-frameworks-devel, michaelh

D21235: Add handling of fuseiso filesystem type

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. +1, @broulik's comments make sense as a nice-to-have INLINE COMMENTS > hallas wrote in fstabdevice.cpp:99 > I don't know if this is the best icon to use, but I think it should be >

D21354: Port to new connect syntax

ngraham marked 10 inline comments as done. ngraham added a comment. Yep, totally works without that connect(). REPOSITORY R432 File Sharing (Samba) integration REVISION DETAIL https://phabricator.kde.org/D21354 To: ngraham, #frameworks, apol Cc: bruns, aacid

D21354: Port to new connect syntax

ngraham updated this revision to Diff 58568. ngraham added a comment. Address review comments REPOSITORY R432 File Sharing (Samba) integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21354?vs=58513=58568 BRANCH port-to-new-connect-symtax (branched from master) REVISION

D21369: [WIP] Add AbstractContact properties for KContact::PhoneNumber objects

sredman edited the summary of this revision. REPOSITORY R307 KPeople REVISION DETAIL https://phabricator.kde.org/D21369 To: sredman, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D21369: [WIP] Add AbstractContact properties for KContact::PhoneNumber objects

sredman updated this revision to Diff 58565. sredman added a comment. - Hack on QMetaType support REPOSITORY R307 KPeople CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21369?vs=58561=58565 BRANCH kcontacts-phonenumber REVISION DETAIL https://phabricator.kde.org/D21369

D21369: [WIP] Add AbstractContact properties for KContact::PhoneNumber objects

sredman added a dependent revision: D21374: WIP: Add support for KContacts::PhoneNumber-related custom data fields. REPOSITORY R307 KPeople REVISION DETAIL https://phabricator.kde.org/D21369 To: sredman, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19771: Use placeholder instead of label

ognarb added a comment. Hi, I try to find time to look into it this weekend ;). REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D19771 To: ognarb, #ktexteditor, #vdg Cc: dhaumann, cullmann, cfeck, loh.tar, ngraham, kwrite-devel, kde-frameworks-devel, domson,

D21369: [WIP] Add AbstractContact properties for KContact::PhoneNumber objects

sredman updated this revision to Diff 58561. sredman added a comment. - Add link_library target to backends as well REPOSITORY R307 KPeople CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21369?vs=58556=58561 BRANCH kcontacts-phonenumber REVISION DETAIL

D21369: [WIP] Add AbstractContact properties for KContact::PhoneNumber objects

sredman added a reviewer: apol. REPOSITORY R307 KPeople REVISION DETAIL https://phabricator.kde.org/D21369 To: sredman, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D21369: [WIP] Add AbstractContact properties for KContact::PhoneNumber objects

sredman updated this revision to Diff 58556. sredman added a comment. - Move KF5::Contacts to PUBLIC library REPOSITORY R307 KPeople CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21369?vs=58553=58556 BRANCH kcontacts-phonenumber REVISION DETAIL

D21367: kioexec: change the scary debug messages for delayed deletion

elvisangelaccio added inline comments. INLINE COMMENTS > main.cpp:261-263 > // it will have time to start up and read the file before it > gets deleted. #130709. > -qDebug() << "sleeping..."; > +qDebug() << "sleeping for 3 minutes before deleting file..."; >

D21369: [WIP] Add AbstractContact properties for KContact::PhoneNumber objects

sredman created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. sredman requested review of this revision. REVISION SUMMARY - Add phone number getters to PersonData - Add KContact::PhoneNumber properties to AbstractContact Does not

D21354: Port to new connect syntax

bruns added inline comments. INLINE COMMENTS > ngraham wrote in delegate.cpp:46 > Nope, same issue I'm afraid. GCC 8.3.1 gives me a helpful error message: ...samba/filepropertiesplugin/delegate.cpp: In lambda function: ...samba/filepropertiesplugin/delegate.cpp:48:58: error: passing ‘const

D20815: Ensure highlighted folding marker after unfold

This revision was automatically updated to reflect the committed changes. Closed by commit R39:e539697f5cbd: Ensure highlighted range begin/end marker after unfold (authored by loh.tar). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D20815?vs=57002=58551#toc REPOSITORY R39 KTextEditor

D20197: Fix desktop link to file or directory

ngraham added a comment. Ah, that's true. REPOSITORY R241 KIO BRANCH fix_desktop_link_filter REVISION DETAIL https://phabricator.kde.org/D20197 To: hoffmannrobert, #frameworks, ngraham, dfaure Cc: bruns, michaelweghorn, ngraham, kde-frameworks-devel, michaelh

D21368: Add syntax definition for the Common Intermediate Language

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Why not, better bit highlighting than none. REPOSITORY R216 Syntax Highlighting BRANCH master REVISION DETAIL https://phabricator.kde.org/D21368 To: vkrause, cullmann Cc:

D21354: Port to new connect syntax

ngraham added inline comments. INLINE COMMENTS > aacid wrote in delegate.cpp:46 > without having tried it, you probably still need the QOverload to say which > activated version you want, so > > connect(comboBox, QOverload::of(::activated), this, [this, > comboBox] { emit

D21368: Add syntax definition for the Common Intermediate Language

vkrause created this revision. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. vkrause requested review of this revision. REVISION SUMMARY Nothing fancy, a lot of details could probably improved, e.g. regarding the use of '.' as delimiter

D21367: kioexec: change the scary debug messages for delayed deletion

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D21367 To: Lekensteyn, elvisangelaccio, dfaure Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D21367: kioexec: change the scary debug messages for delayed deletion

Lekensteyn created this revision. Lekensteyn added reviewers: elvisangelaccio, dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. Lekensteyn requested review of this revision. REVISION SUMMARY After resuming my laptop, I found this scary message in

D20815: Ensure highlighted folding marker after unfold

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Hmm, I am fine with the change beside with the delete m_foldingPreview;, I think that is there to ensure the preview is directly hidden if one toggles a folding. It will be later

D19585: [CopyJob] Report results after finishing copy

broulik edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D19585 To: broulik, dfaure, chinmoyr Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20815: Ensure highlighted folding marker after unfold

loh.tar added a comment. > And why is the delete not useful? After one month, no idea on first sight, sorry. Guess it is deleted prior or later anyway/already. > is it intentional that the folding start/end tokens are only sometimes highlighted on folding, still? I don't

D19677: WIP: Port UDisks to using DBus ObjectManager

bruns added a comment. In the old code, the backend was created lazily, as the associated DBus connection was expensive, this is no longer the case. I am wondering if creating the backend immediately/always would not solve a number of structural problems here (though this is already *much*

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 102 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/102/ Project: kf5-qt5 SUSEQt5.12 Date of build: Thu, 23 May 2019 11:19:20 + Build duration: 16 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.12 - Build # 112 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.12/112/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Thu, 23 May 2019 11:19:20 + Build duration: 9 min 11 sec and counting JUnit Tests

D19677: WIP: Port UDisks to using DBus ObjectManager

bruns added inline comments. INLINE COMMENTS > udisksdevicebackend.cpp:146 > if (m_propertyCache.contains(key)) { > return; > } not necessary > udisksdevicebackend.h:74 > > QDBusInterface *m_device; > no longer used REPOSITORY R245 Solid REVISION DETAIL

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 109 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/109/ Project: kf5-qt5 SUSEQt5.10 Date of build: Thu, 23 May 2019 11:19:20 + Build duration: 5 min 13 sec and counting BUILD ARTIFACTS

D21099: Use locale currency for donate icon

This revision was automatically updated to reflect the committed changes. Closed by commit R265:80cc612a50e9: Use locale currency for donate icon (authored by broulik). REPOSITORY R265 KConfigWidgets CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21099?vs=57806=58540 REVISION

D21235: Add handling of fuseiso filesystem type

broulik added a comment. Right. +1 INLINE COMMENTS > fstabdevice.cpp:88 > } else { > m_description = QCoreApplication::translate("", "%1 (%2)", > "%1 is mountpoint, %2 is fs type").arg(m_product, m_vendor); Can we maybe give it a better description then?

D21235: Add handling of fuseiso filesystem type

bruns added a comment. In D21235#468929 , @broulik wrote: > I had iso images shown as loop devices through udisks already, why is this needed? Patch looks fine, just curious. I think udisks only shows the disk image if it is using a

D21235: Add handling of fuseiso filesystem type

broulik added a comment. I had iso images shown as loop devices through udisks already, why is this needed? Patch looks fine, just curious. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D21235 To: hallas, bruns, ngraham Cc: broulik, kde-frameworks-devel, michaelh,

D21339: Block a bit less when introspecting udisks

broulik added a comment. Please see D19677 REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D21339 To: apol, #frameworks, bruns Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D19771: Use placeholder instead of label

dhaumann added a comment. In D19771#468881 , @loh.tar wrote: > > Hi, any more feedback on this? > > When in power mode, and the fields are filled, it is not clear what which field is. I think this is a valid concern... REPOSITORY

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.12 - Build # 118 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.12/118/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Thu, 23 May 2019 07:11:24 + Build duration: 7 min 41 sec and counting JUnit Tests Name: