D21411: YAML: only comments after spaces and other improvements/fixes

nibags closed this revision. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D21411 To: nibags, dhaumann, cullmann, #framework_syntax_highlighting Cc: kwrite-devel, kde-frameworks-devel, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D17372: [componentchooser KCM] Make KIO browser option the fallback only and remove from the UI

dfaure added a comment. Writing into the user's home dir is a "hack". There are better ways for distros to set defaults (such as the global mimeapps.list) but it seems KIO ignores that... (to be checked...) REPOSITORY R119 Plasma Desktop REVISION DETAIL

D17372: [componentchooser KCM] Make KIO browser option the fallback only and remove from the UI

ngraham planned changes to this revision. ngraham added a comment. I don't think it's a "distro hack" to set a default browser, which is why they all do it. Not having a default browser set seems like an error condition to me. However I see what you meanabout the bugginess and will work on

D17372: [componentchooser KCM] Make KIO browser option the fallback only and remove from the UI

dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed. I agree that we shouldn't remove the underlying feature, in fact it's still used on other protocols than http. But we have to ensure the default behaviour matches the KCM and

D21265: Add Bluez API to DBus XML parser/generator

This revision was automatically updated to reflect the committed changes. Closed by commit R269:bfe94dface00: Add Bluez API to DBus XML parser/generator (authored by mweichselbaumer). Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. REPOSITORY R269 BluezQt

D17372: [componentchooser KCM] Make KIO browser option the fallback only and remove from the UI

ngraham added reviewers: Frameworks, dfaure. ngraham added a comment. I'm still not sure whether the feature needs to be removed entirely. I feel that this minimal patch probably stands on its own well enough as-is. REPOSITORY R119 Plasma Desktop REVISION DETAIL

D21313: Create specific directory for Qt logging categories file

This revision was automatically updated to reflect the committed changes. Closed by commit R240:0c95c9f799cd: Create specific directory for Qt logging categories file (authored by mlaurent). REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE

D21313: Create specific directory for Qt logging categories file

mlaurent retitled this revision from "Create specific directory for kdebugsettings categories file" to "Create specific directory for Qt logging categories file". REPOSITORY R240 Extra CMake Modules BRANCH add_specific_kdebugsetting_directory REVISION DETAIL

D21313: Create specific directory for kdebugsettings categories file

mlaurent updated this revision to Diff 58952. mlaurent added a comment. Fix typo REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21313?vs=58746=58952 BRANCH add_specific_kdebugsetting_directory REVISION DETAIL

D21511: Make falkon icon a real SVG

This revision was automatically updated to reflect the committed changes. Closed by commit R266:ac701bd091cf: Make falkon icon a real SVG (authored by ndavis). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21511?vs=58944=58948 REVISION DETAIL

D21511: Make falkon icon a real SVG

abetts added a comment. +1 REPOSITORY R266 Breeze Icons BRANCH falkon (branched from master) REVISION DETAIL https://phabricator.kde.org/D21511 To: ndavis, #vdg, #falkon, abetts, drosca Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D21511: Make falkon icon a real SVG

drosca accepted this revision. This revision is now accepted and ready to land. REPOSITORY R266 Breeze Icons BRANCH falkon (branched from master) REVISION DETAIL https://phabricator.kde.org/D21511 To: ndavis, #vdg, #falkon, abetts, drosca Cc: ngraham, kde-frameworks-devel, michaelh,

D21511: Make falkon icon a real SVG

ngraham added a comment. LGTM REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D21511 To: ndavis, #vdg, #falkon, abetts Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D21511: Make falkon icon a real SVG

ngraham added a reviewer: abetts. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D21511 To: ndavis, #vdg, #falkon, abetts Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D21511: Make falkon icon a real SVG

ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D21511 To: ndavis, #vdg, #falkon Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D21411: YAML: only comments after spaces and other improvements/fixes

nibags added a comment. > Could one adapt the theme and remove the color later? Yes, it would be ideal, so there is consistency among all the themes REPOSITORY R216 Syntax Highlighting BRANCH improve-yaml REVISION DETAIL https://phabricator.kde.org/D21411 To: nibags, dhaumann,

D21411: YAML: only comments after spaces and other improvements/fixes

cullmann added a comment. Hmm, ok, anyways, this change looks ok =) Could one adapt the theme and remove the color later? REPOSITORY R216 Syntax Highlighting BRANCH improve-yaml REVISION DETAIL https://phabricator.kde.org/D21411 To: nibags, dhaumann, cullmann,

D21411: YAML: only comments after spaces and other improvements/fixes

nibags added a comment. > Btw., would it be possible to remove the hardcoded color here: That I added it in a previous commit; use hard background color to mark indentation with Tabs in some situations (specifically, in the indentation capture with dynamic rules), since YAML uses

D21411: YAML: only comments after spaces and other improvements/fixes

cullmann accepted this revision. cullmann added a comment. Screenshots look better! Btw., would it be possible to remove the hardcoded color here: REPOSITORY R216 Syntax Highlighting BRANCH improve-yaml REVISION DETAIL https://phabricator.kde.org/D21411 To: nibags, dhaumann,

D21508: Jam: various improvements and fixes

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. (the hard coded color was already there, therefore this doesn't block this request) REPOSITORY R216 Syntax Highlighting BRANCH fix_jam (branched from master) REVISION DETAIL

D21508: Jam: various improvements and fixes

cullmann added a comment. Looks reasonable + test case, nice. Btw., would it be possible to remove the last remaining hard coded color here, too? REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D21508 To: jpoelen, #framework_syntax_highlighting,

D21411: YAML: only comments after spaces and other improvements/fixes

nibags edited the summary of this revision. REPOSITORY R216 Syntax Highlighting BRANCH improve-yaml REVISION DETAIL https://phabricator.kde.org/D21411 To: nibags, dhaumann, cullmann, #framework_syntax_highlighting Cc: kwrite-devel, kde-frameworks-devel, domson, michaelh, ngraham, bruns,

D21411: YAML: only comments after spaces and other improvements/fixes

nibags updated this revision to Diff 58936. nibags added a comment. - Some fixes in attributes and update test file REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21411?vs=58663=58936 BRANCH improve-yaml REVISION DETAIL

KDE CI: Frameworks » solid » kf5-qt5 FreeBSDQt5.12 - Build # 36 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20FreeBSDQt5.12/36/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Fri, 31 May 2019 10:48:15 + Build duration: 16 min and counting JUnit Tests Name: projectroot

D21379: [UDev Backend] Narrow device queried for

broulik added a comment. For some reason here my `udev_enumerate_add_match_property("ID_MEDIA_PLAYER", null)` doesn't work. If I check for "1" it works but `null` doesn't find any devices. Since the systemd code uses `fnmatch`, we can probably just pass `*` to it to match anything.

D21379: [UDev Backend] Narrow device queried for

broulik reopened this revision. broulik added a comment. This revision is now accepted and ready to land. I just reverted it as it indeed causes problems with initial device lookup. Not just in plasmashell but also in Dolphin. Since Frameworks tagging is tomrrow, better leave it for now and

D21509: [baloo_file] Index renamed folders inside UnindexedFileIndexer

poboiko created this revision. poboiko added reviewers: Frameworks, Baloo, bruns. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. poboiko requested review of this revision. REVISION SUMMARY If some folder was renamed while `baloo_file` was not running,

D21313: Create specific directory for kdebugsettings categories file

cgiboudeaux added a comment. Maybe also update the commit message to 'Create specific directory for Qt logging categories file' REPOSITORY R240 Extra CMake Modules BRANCH add_specific_kdebugsetting_directory REVISION DETAIL https://phabricator.kde.org/D21313 To: mlaurent, dfaure,

D21313: Create specific directory for kdebugsettings categories file

cgiboudeaux accepted this revision. cgiboudeaux added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > KDEInstallDirs.cmake:132 > +# ``LOGGINGCATEGORIESDIR`` > +# qt logging categories files directory > (``DATAROOTDIR/qlogging-categories5``) Since 5.59.0 >

D21459: Always save view settings when switching from one view mode to another

meven marked an inline comment as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D21459 To: meven, #frameworks, ngraham Cc: kde-frameworks-devel, michaelh, ngraham, bruns