KDE CI: Frameworks » bluez-qt » kf5-qt5 SUSEQt5.10 - Build # 21 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/bluez-qt/job/kf5-qt5%20SUSEQt5.10/21/ Project: kf5-qt5 SUSEQt5.10 Date of build: Wed, 05 Jun 2019 06:32:05 + Build duration: 10 min and counting BUILD ARTIFACTS abi-compatibility-re

KDE CI: Frameworks » bluez-qt » kf5-qt5 SUSEQt5.12 - Build # 21 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/bluez-qt/job/kf5-qt5%20SUSEQt5.12/21/ Project: kf5-qt5 SUSEQt5.12 Date of build: Wed, 05 Jun 2019 06:32:05 + Build duration: 6 min 21 sec and counting BUILD ARTIFACTS abi-compatibil

KDE CI: Frameworks » bluez-qt » kf5-qt5 FreeBSDQt5.12 - Build # 21 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/bluez-qt/job/kf5-qt5%20FreeBSDQt5.12/21/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Wed, 05 Jun 2019 06:32:06 + Build duration: 1 min 52 sec and counting JUnit Tests Name: projec

D21583: [FilteredDirIterator] Combine all suffixes into one large RegExp

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. All right, sounds good for now then. We can refactor the config file later. REPOSITORY R293 Baloo BRANCH submit_unindexed REVISION DETAIL https://phabricator.kde.org/D21583 To: br

D21587: Lua: update for Lua54 and end of function as Keyword rather than Control

This revision was automatically updated to reflect the committed changes. Closed by commit R216:602bbc7b7397: Lua: update for Lua54 and end of function as Keyword rather than Control (authored by jpoelen). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.

D21508: Jam: various improvements and fixes

This revision was automatically updated to reflect the committed changes. Closed by commit R216:6864c25f1d54: Jam: various improvements and fixes (authored by jpoelen). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21508?vs=59150&id=59164 REVISIO

D21585: C++: update for C++20

This revision was automatically updated to reflect the committed changes. Closed by commit R216:9ba02971123d: C++: update for C++20 (authored by jpoelen). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21585?vs=59156&id=59162 REVISION DETAIL http

D21583: [FilteredDirIterator] Combine all suffixes into one large RegExp

bruns added a comment. In D21583#474266 , @ngraham wrote: > Would it be make more sense to just have a single file type regex in the config file rather than parsing the existing data and re-processing it in the code? The config is quite

D21587: Lua: update for Lua54 and end of function as Keyword rather than Control

dhaumann accepted this revision. dhaumann added a comment. This revision is now accepted and ready to land. Lgtm REPOSITORY R216 Syntax Highlighting BRANCH lua54 (branched from master) REVISION DETAIL https://phabricator.kde.org/D21587 To: jpoelen, #framework_syntax_highlighting, dhau

D21508: Jam: various improvements and fixes

dhaumann accepted this revision. REPOSITORY R216 Syntax Highlighting BRANCH fix_jam (branched from master) REVISION DETAIL https://phabricator.kde.org/D21508 To: jpoelen, #framework_syntax_highlighting, dhaumann, cullmann Cc: kde-frameworks-devel, kwrite-devel, LeGast00n, domson, michaelh

D21585: C++: update for C++20

dhaumann accepted this revision. dhaumann added a comment. This revision is now accepted and ready to land. Thanks for the update! REPOSITORY R216 Syntax Highlighting BRANCH cpp2a (branched from master) REVISION DETAIL https://phabricator.kde.org/D21585 To: jpoelen, #framework_syntax_

D21585: C++: update for C++20

jpoelen updated this revision to Diff 59156. jpoelen added a comment. oops, missing version increase REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21585?vs=59152&id=59156 BRANCH cpp2a (branched from master) REVISION DETAIL https://phabric

D21587: Lua: update for Lua54 and end of function as Keyword rather than Control

jpoelen edited the summary of this revision. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D21587 To: jpoelen, #framework_syntax_highlighting, dhaumann, cullmann Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, gennad, bmortimer, domson, michaelh, genetho

D21587: Lua: update for Lua54 and end of function as Keyword rather than Control

jpoelen created this revision. jpoelen added reviewers: Framework: Syntax Highlighting, dhaumann, cullmann. jpoelen added projects: Framework: Syntax Highlighting, Kate, Frameworks. jpoelen requested review of this revision. REVISION SUMMARY function foo() if x then end <--- Control F

D21584: Add LE Advertising and GATT APIs

mweichselbaumer added a reviewer: drosca. REPOSITORY R269 BluezQt REVISION DETAIL https://phabricator.kde.org/D21584 To: mweichselbaumer, drosca Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21586: Add syntax definition for ninja build

jpoelen created this revision. jpoelen added reviewers: Framework: Syntax Highlighting, dhaumann, cullmann. jpoelen added projects: Framework: Syntax Highlighting, Kate, Frameworks. jpoelen requested review of this revision. REPOSITORY R216 Syntax Highlighting BRANCH ninja (branched from mast

D21585: C++: update for C++20

jpoelen created this revision. jpoelen added reviewers: Framework: Syntax Highlighting, dhaumann, cullmann. jpoelen added projects: Framework: Syntax Highlighting, Kate, Frameworks. jpoelen requested review of this revision. REVISION SUMMARY - new attributes: assert, ensures and expects - new

D21584: Add LE Advertising and GATT APIs

mweichselbaumer created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mweichselbaumer requested review of this revision. REPOSITORY R269 BluezQt BRANCH ble_gatt REVISION DETAIL https://phabricator.kde.org/D21584 AFFECTED FILES autote

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.12 - Build # 127 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.12/127/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Tue, 04 Jun 2019 17:52:45 + Build duration: 1 hr 15 min and counting JUnit Tests Name: projectroo

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.12 - Build # 123 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.12/123/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Tue, 04 Jun 2019 17:47:09 + Build duration: 1 hr 12 min and counting JUnit Tests Nam

D21508: Jam: various improvements and fixes

jpoelen updated this revision to Diff 59150. jpoelen added a comment. - fix module - remove hard coded color REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21508?vs=58930&id=59150 BRANCH fix_jam (branched from master) REVISION DETAIL htt

D21581: Detect valgrind, avoid database removal when using valgrind

bcooksley added a comment. This changes breaks the build on Windows/MSVC because 'valgrind.h' doesn't support MSVC. Can you please correct this / disable this check on Windows? REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D21581 To: bruns, #baloo, ngraham, astippi

KDE CI: Frameworks » baloo » kf5-qt5 WindowsMSVCQt5.11 - Build # 176 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20WindowsMSVCQt5.11/176/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Tue, 04 Jun 2019 18:10:03 + Build duration: 21 min and counting CONSOLE OUTPUT [...trunc

D21583: [FilteredDirIterator] Combine all suffixes into one large RegExp

ngraham added a comment. Would it be make more sense to just have a single file type regex in the config file rather than parsing the existing data and re-processing it in the code? REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D21583 To: bruns, #baloo, ngraham, pob

D21583: [FilteredDirIterator] Combine all suffixes into one large RegExp

bruns updated this revision to Diff 59148. bruns added a comment. replace one QLatin1String with QStringLiteral REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21583?vs=59146&id=59148 BRANCH submit_unindexed REVISION DETAIL https://phabricator.kde.org/D2

D15739: [Places panel] Don't show Root by default

meven added a comment. gentle ping @ngraham How ironic ;) Unless you would rather let someone else take care of this. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D15739 To: ngraham, #dolphin, #vdg, tcanabrava Cc: meven, elvisangelaccio, Codezela, davidc, tcana

KDE CI: Frameworks » baloo » kf5-qt5 WindowsMSVCQt5.11 - Build # 175 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20WindowsMSVCQt5.11/175/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Tue, 04 Jun 2019 17:58:39 + Build duration: 10 min and counting CONSOLE OUTPUT [...trunc

D21577: [UnindexedFileIndexer] Skip filetime checks for new files

bruns updated this revision to Diff 59147. bruns added a comment. remove leftover double timeinfo fetch rebase REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21577?vs=59128&id=59147 BRANCH master REVISION DETAIL https://phabricator.kde.org/D21577 AFF

D21583: [FilteredDirIterator] Combine all suffixes into one large RegExp

bruns created this revision. bruns added reviewers: Baloo, ngraham, poboiko. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY Most of the about 50 default filters are suffix matches, which can be

D21579: [FilteredDirIterator] Avoid RegExp overhead for exact matches

This revision was automatically updated to reflect the committed changes. Closed by commit R293:be59ea539ba8: [FilteredDirIterator] Avoid RegExp overhead for exact matches (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21579?vs=59132&id=5914

D21578: [UnindexedFileIterator] Delay mimetype determination until it is needed

This revision was automatically updated to reflect the committed changes. Closed by commit R293:cdcad139a529: [UnindexedFileIterator] Delay mimetype determination until it is needed (authored by bruns). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D21578?vs=59129&id=59144#toc REPOSITORY

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 117 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/117/ Project: kf5-qt5 SUSEQt5.12 Date of build: Tue, 04 Jun 2019 17:52:44 + Build duration: 8 min 46 sec and counting BUILD ARTIFACTS acc/KF5KIO-5.59.0.

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 113 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/113/ Project: kf5-qt5 SUSEQt5.12 Date of build: Tue, 04 Jun 2019 17:47:09 + Build duration: 13 min and counting BUILD ARTIFACTS abi-compat

D21576: [UnindexedFileIndexer] Do not try to add nonexistant file to index

This revision was automatically updated to reflect the committed changes. Closed by commit R293:7ab4cc5611a3: [UnindexedFileIndexer] Do not try to add nonexistant file to index (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21576?vs=59127&id

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 120 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/120/ Project: kf5-qt5 SUSEQt5.10 Date of build: Tue, 04 Jun 2019 17:47:09 + Build duration: 5 min 43 sec and counting BUILD ARTIFACTS abi-

D21415: Fix the alignment of the label of the toolbutton

This revision was automatically updated to reflect the committed changes. Closed by commit R242:cd8b6b71cebc: Fix the alignment of the label of the toolbutton (authored by dkardarakos). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21415?vs

D21577: [UnindexedFileIndexer] Skip filetime checks for new files

bruns marked an inline comment as done. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D21577 To: bruns, #baloo, ngraham, astippich, poboiko Cc: kde-frameworks-devel, LeGast00n, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D21577: [UnindexedFileIndexer] Skip filetime checks for new files

bruns marked an inline comment as done. bruns added inline comments. INLINE COMMENTS > poboiko wrote in unindexedfileiterator.cpp:109 > Why do we need it here? leftover REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D21577 To: bruns, #baloo, ngraham, astippich, poboiko

D21577: [UnindexedFileIndexer] Skip filetime checks for new files

bruns added a comment. In D21577#474212 , @poboiko wrote: > I didn't know `QFileInfo` fetches information on demand (and caches it). That is the reason for this change, right? > I think it would be nice to elaborate on that in summary, or mayb

KDE CI: Frameworks » bluez-qt » kf5-qt5 SUSEQt5.12 - Build # 20 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/bluez-qt/job/kf5-qt5%20SUSEQt5.12/20/ Project: kf5-qt5 SUSEQt5.12 Date of build: Tue, 04 Jun 2019 17:18:44 + Build duration: 19 min and counting BUILD ARTIFACTS acc/KF5BluezQt-5.59

D21579: [FilteredDirIterator] Avoid RegExp overhead for exact matches

poboiko added inline comments. INLINE COMMENTS > regexpcache.cpp:60 > +} > f.replace(QLatin1Char('.'), QStringLiteral("\\.")); > f.replace(QLatin1Char('?'), QLatin1Char('.')); A quick note for future. There is `QRegularExpression::wildcardToRegularExpression()`, which

D21578: [UnindexedFileIterator] Delay mimetype determination until it is needed

ngraham accepted this revision. ngraham added a comment. Makes perfect sense. REPOSITORY R293 Baloo BRANCH submit_unindexed REVISION DETAIL https://phabricator.kde.org/D21578 To: bruns, #baloo, ngraham, astippich, poboiko Cc: kde-frameworks-devel, LeGast00n, domson, ashaposhnikov, mic

D21579: [FilteredDirIterator] Avoid RegExp overhead for exact matches

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Brilliant! REPOSITORY R293 Baloo BRANCH submit_unindexed REVISION DETAIL https://phabricator.kde.org/D21579 To: bruns, #baloo, ngraham, astippich, poboiko, broulik Cc: kde-framewo

KDE CI: Frameworks » bluez-qt » kf5-qt5 FreeBSDQt5.12 - Build # 20 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/bluez-qt/job/kf5-qt5%20FreeBSDQt5.12/20/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Tue, 04 Jun 2019 17:18:44 + Build duration: 17 min and counting JUnit Tests Name: projectroot

D21576: [UnindexedFileIndexer] Do not try to add nonexistant file to index

ngraham accepted this revision. ngraham added a comment. Buh! REPOSITORY R293 Baloo BRANCH submit_unindexed REVISION DETAIL https://phabricator.kde.org/D21576 To: bruns, #baloo, ngraham, astippich, poboiko Cc: kde-frameworks-devel, LeGast00n, domson, ashaposhnikov, michaelh, astippic

D21578: [UnindexedFileIterator] Delay mimetype determination until it is needed

poboiko accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH submit_unindexed REVISION DETAIL https://phabricator.kde.org/D21578 To: bruns, #baloo, ngraham, astippich, poboiko Cc: kde-frameworks-devel, LeGast00n, domson, ashaposhnikov, mich

D21577: [UnindexedFileIndexer] Skip filetime checks for new files

poboiko added a comment. I didn't know `QFileInfo` fetches information on demand (and caches it). That is the reason for this change, right? I think it would be nice to elaborate on that in summary, or maybe as a brief comment in the code. INLINE COMMENTS > unindexedfileiterator.cpp:109 >

KDE CI: Frameworks » bluez-qt » kf5-qt5 SUSEQt5.10 - Build # 20 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/bluez-qt/job/kf5-qt5%20SUSEQt5.10/20/ Project: kf5-qt5 SUSEQt5.10 Date of build: Tue, 04 Jun 2019 17:18:44 + Build duration: 3 min 35 sec and counting BUILD ARTIFACTS acc/KF5BluezQ

D21576: [UnindexedFileIndexer] Do not try to add nonexistant file to index

poboiko accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH submit_unindexed REVISION DETAIL https://phabricator.kde.org/D21576 To: bruns, #baloo, ngraham, astippich, poboiko Cc: kde-frameworks-devel, LeGast00n, domson, ashaposhnikov, mich

KDE CI: Frameworks » baloo » kf5-qt5 WindowsMSVCQt5.11 - Build # 174 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20WindowsMSVCQt5.11/174/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Tue, 04 Jun 2019 16:32:48 + Build duration: 4 min 15 sec and counting CONSOLE OUTPUT [..

D21581: Detect valgrind, avoid database removal when using valgrind

This revision was automatically updated to reflect the committed changes. Closed by commit R293:446aeb07d922: Detect valgrind, avoid database removal when using valgrind (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21581?vs=59137&id=59139

D21581: Detect valgrind, avoid database removal when using valgrind

ngraham accepted this revision. ngraham added a comment. Hah, wow REPOSITORY R293 Baloo BRANCH master REVISION DETAIL https://phabricator.kde.org/D21581 To: bruns, #baloo, ngraham, astippich, poboiko, broulik, mgallien Cc: mgallien, kde-frameworks-devel, LeGast00n, domson, ashaposhnik

D21581: Detect valgrind, avoid database removal when using valgrind

mgallien accepted this revision. mgallien added a comment. This revision is now accepted and ready to land. Very nice. Thank you REPOSITORY R293 Baloo BRANCH master REVISION DETAIL https://phabricator.kde.org/D21581 To: bruns, #baloo, ngraham, astippich, poboiko, broulik, mgallien Cc:

D21581: Detect valgrind, avoid database removal when using valgrind

bruns updated this revision to Diff 59137. bruns added a comment. rebase REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21581?vs=59136&id=59137 BRANCH master REVISION DETAIL https://phabricator.kde.org/D21581 AFFECTED FILES src/engine/database.cpp

D21581: Detect valgrind, avoid database removal when using valgrind

bruns edited the summary of this revision. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D21581 To: bruns, #baloo, ngraham, astippich, poboiko, broulik Cc: kde-frameworks-devel, LeGast00n, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D21581: Detect valgrind, avoid database removal when using valgrind

bruns created this revision. bruns added reviewers: Baloo, ngraham, astippich, poboiko, broulik. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY The mmap size supported by valgrind is set at valg

D21574: Update KBruch icon

ndavis added a comment. In D21574#474173 , @ognarb wrote: > Sorry it arc who also uploaded the png that I created for the review, I will fix it. Ah, fair enough. Easy mistake to make. REPOSITORY R266 Breeze Icons REVISION DETAIL htt

D21574: Update KBruch icon

ognarb added a comment. In D21574#474171 , @ndavis wrote: > Wait, is this a PNG? This needs to be just an SVG. We don't ship PNGs in breeze-icons. Sorry it arc who also uploaded the png that I created for the review, I will fix it. REPO

D21574: Update KBruch icon

ndavis added a comment. Once you're done with the SVG, make sure you clean it: https://community.kde.org/Guidelines_and_HOWTOs/Icon_Workflow_Tips#SVG_optimization REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D21574 To: ognarb, #vdg, ndavis Cc: ndavis, ngraham

D21574: Update KBruch icon

ndavis added a comment. Wait, is this a PNG? This needs to be an SVG. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D21574 To: ognarb, #vdg, ndavis Cc: ndavis, ngraham, kde-frameworks-devel, LeGast00n, michaelh, bruns

D21574: Update KBruch icon

ndavis requested changes to this revision. ndavis added a comment. This revision now requires changes to proceed. There needs to be a copy in breeze dark as well. Nice job though! REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D21574 To: ognarb, #vdg, ndavis Cc:

D21579: [FilteredDirIterator] Avoid RegExp overhead for exact matches

bruns created this revision. bruns added reviewers: Baloo, ngraham, astippich, poboiko, broulik. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY Quite a few of the filter strings are exact matche

D21574: Update KBruch icon

ognarb updated this revision to Diff 59131. ognarb added a comment. Add shadow REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21574?vs=59123&id=59131 BRANCH kbruch REVISION DETAIL https://phabricator.kde.org/D21574 AFFECTED FILES icons/apps/48

D21578: [UnindexedFileIterator] Delay mimetype determination until it is needed

bruns created this revision. bruns added reviewers: Baloo, ngraham, astippich, poboiko. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY The mimetype is only required if all the other checks pass,

D21577: [UnindexedFileIndexer] Skip filetime checks for new files

bruns created this revision. bruns added reviewers: Baloo, ngraham, astippich, poboiko. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY In case a file is not in the index, either because it is ne

D21576: [UnindexedFileIndexer] Do not try to add nonexistant file to index

bruns created this revision. bruns added reviewers: Baloo, ngraham, astippich, poboiko. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY A file may be deleted after it has been picked up by the it

D17595: Upstream Dolphin's file rename dialog

ngraham added a comment. Thanks so much! \o/ REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17595 To: ngraham, #frameworks, #dolphin, broulik Cc: ltoscano, bruns, meven, dhaumann, pino, kde-frameworks-devel, LeGast00n, michaelh, ngraham

D12647: Move the inline preview button into the menu

ngraham added a comment. Oops, sorry I missed your comments! Yes, removing it from the task description makes sense. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12647 To: ngraham, #frameworks Cc: meven, kde-frameworks-devel, anemeth, LeGast00n, michaelh, ngraham, br

D21574: Update KBruch icon

ngraham added a comment. Nice! A line of dark pixels on the bottom would help it fit the style even better too. See https://hig.kde.org/style/icon.html#shadows REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D21574 To: ognarb, #vdg Cc: ngraham, kde-frameworks-de

D21574: Update KBruch icon

ognarb edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D21574 To: ognarb, #vdg Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21574: Update KBruch icon

ognarb edited the test plan for this revision. ognarb added a reviewer: VDG. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D21574 To: ognarb, #vdg Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21574: Update KBruch icon

ognarb created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ognarb requested review of this revision. REVISION SUMMARY Inspired from application-edu and cantor icon TEST PLAN Screenshot comming REPOSITORY R266 Breeze Icons BRANCH kb

D21204: Ensure no trailing slash in mountpoint read from fstab file.

meven added a comment. I have tested the new patch. It is a bit a workaround but does not edit any udi. What do you think ? REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D21204 To: meven, bruns, #frameworks Cc: ngraham, bruns, apol, kde-frameworks-devel, LeGast00n

D19771: Use placeholder instead of label

ognarb abandoned this revision. ognarb added a comment. I don't have time and the motivation for this revision anymore. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D19771 To: ognarb, #ktexteditor, #vdg Cc: dhaumann, cullmann, cfeck, loh.tar, ngraham, kwrite-dev

KDE CI: Frameworks » purpose » kf5-qt5 SUSEQt5.10 - Build # 52 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/purpose/job/kf5-qt5%20SUSEQt5.10/52/ Project: kf5-qt5 SUSEQt5.10 Date of build: Tue, 04 Jun 2019 11:30:23 + Build duration: 12 min and counting BUILD ARTIFACTS abi-compatibility-re

D21565: phabricator: Fix fallthrough in switch

This revision was automatically updated to reflect the committed changes. Closed by commit R495:a520d9ea1800: phabricator: Fix fallthrough in switch (authored by aspotashev). REPOSITORY R495 Purpose Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21565?vs=59080&id=59122 REVIS

D21459: Always save view settings when switching from one view mode to another

meven edited the summary of this revision. REPOSITORY R241 KIO BRANCH arcpatch-D21459 REVISION DETAIL https://phabricator.kde.org/D21459 To: meven, #frameworks, ngraham Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

KDE CI: Frameworks » baloo » kf5-qt5 FreeBSDQt5.12 - Build # 86 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20FreeBSDQt5.12/86/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Tue, 04 Jun 2019 08:58:26 + Build duration: 5 min 8 sec and counting JUnit Tests Name: projectroo

D21572: [UnindexedFileIndexer] Loop optimizations (avoid detach, invariants)

This revision was automatically updated to reflect the committed changes. Closed by commit R293:4fcc08d86881: [UnindexedFileIndexer] Loop optimizations (avoid detach, invariants) (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21572?vs=59117&

D21572: [UnindexedFileIndexer] Loop optimizations (avoid detach, invariants)

broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH master REVISION DETAIL https://phabricator.kde.org/D21572 To: bruns, #baloo, ngraham, astippich, poboiko, broulik Cc: kde-frameworks-devel, LeGast00n, domson, ashaposhnikov, micha

D21572: [UnindexedFileIndexer] Loop optimizations (avoid detach, invariants)

bruns created this revision. bruns added reviewers: Baloo, ngraham, astippich, poboiko. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY Avoid detach of QStringList in for loop. Move invariant I

D17595: Upstream Dolphin's file rename dialog

meven added a comment. In D17595#473826 , @ngraham wrote: > Would you be interested in doing that and taking over this patch? I'm afraid I don't think I have the time right now for the kind of deep dive that it requires. If not, that's okay. :)