KDE CI: Frameworks » kunitconversion » kf5-qt5 FreeBSDQt5.13 - Build # 4 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kunitconversion/job/kf5-qt5%20FreeBSDQt5.13/4/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Wed, 17 Jul 2019 02:04:05 + Build duration: 2 hr 15 min and counting JUnit Tests Name: p

D20181: Add Binary Data units (bits, kilobytes, kibibytes ... yottabytes)

ngraham added a comment. Very nice first patch, too. May it be the first of many! :) REPOSITORY R292 KUnitConversion REVISION DETAIL https://phabricator.kde.org/D20181 To: JJRcop, broulik, #plasma, ngraham Cc: abetts, cfeck, apol, aacid, ngraham, kde-frameworks-devel, LeGast00n, sberger

D20181: Add Binary Data units (bits, kilobytes, kibibytes ... yottabytes)

This revision was automatically updated to reflect the committed changes. Closed by commit R292:6c193856f9f4: Add Binary Data units (bits, kilobytes, kibibytes ... yottabytes) (authored by JJRcop, committed by ngraham). REPOSITORY R292 KUnitConversion CHANGES SINCE LAST UPDATE https://phabri

D20181: Add Binary Data units (bits, kilobytes, kibibytes ... yottabytes)

ngraham accepted this revision. ngraham added a comment. Thanks for your patience here! REPOSITORY R292 KUnitConversion REVISION DETAIL https://phabricator.kde.org/D20181 To: JJRcop, broulik, #plasma, ngraham Cc: abetts, cfeck, apol, aacid, ngraham, kde-frameworks-devel, LeGast00n, sber

D20181: Add Binary Data units (bits, kilobytes, kibibytes ... yottabytes)

ngraham edited the summary of this revision. REPOSITORY R292 KUnitConversion REVISION DETAIL https://phabricator.kde.org/D20181 To: JJRcop, broulik, #plasma, ngraham Cc: abetts, cfeck, apol, aacid, ngraham, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, bruns

Re: New framework: KCalCore

On Tue, Jul 16, 2019 at 6:10 PM Volker Krause wrote: > > On Monday, 15 July 2019 18:43:42 CEST Aleix Pol wrote: > > On Fri, Jul 12, 2019 at 9:03 PM Allen Winter wrote: > > > On Friday, July 12, 2019 12:23:58 PM EDT Volker Krause wrote: > > > > With the 19.08 release approaching (and thus the dead

D20181: Add Binary Data units (bits, kilobytes, kibibytes ... yottabytes)

JJRcop updated this revision to Diff 61883. JJRcop added a comment. Updated @since to 5.61. @ngraham REPOSITORY R292 KUnitConversion CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20181?vs=61526&id=61883 REVISION DETAIL https://phabricator.kde.org/D20181 AFFECTED FILES READM

D19986: Install .desktop file for kded5

rjvbb added a comment. It seems to me there's a way to tell the translators that a string shouldn't be translated. Why not use that, or put a name that doesn't require translation (like `name=kded5.desktop`)? NB: I replaced "SystemService" with "Service" in my copy, and haven't seen tha

D16882: [KDevelop/Shell] prevent duplicate added contextmenu actions

kossebau added a comment. In D16882#494867 , @rjvbb wrote: > I could try your solution, of course, but what annoys me is that it comes months after I worked on mine. I think we all share the feeling that this should have already been hand

D20181: Add Binary Data units (bits, kilobytes, kibibytes ... yottabytes)

aacid added a comment. Ok, you will need to update your @since when landing this REPOSITORY R292 KUnitConversion REVISION DETAIL https://phabricator.kde.org/D20181 To: JJRcop, broulik, #plasma, ngraham Cc: abetts, cfeck, apol, aacid, ngraham, kde-frameworks-devel, LeGast00n, sbergeron,

D21002: Remove kde4 migration agent completely

aacid accepted this revision. aacid added a comment. This revision is now accepted and ready to land. i guess 🤷 REPOSITORY R311 KWallet BRANCH master REVISION DETAIL https://phabricator.kde.org/D21002 To: bruns, #frameworks, cfeck, ngraham, aacid Cc: aacid, lbeltrame, kde-frameworks-d

D19986: Install .desktop file for kded5

davidedmundson added a comment. Sorry, I missed your message. INLINE COMMENTS > dfaure wrote in org.kde.kded5.desktop:4 > What does SystemService mean? > > I'm seeing a warning from the kservice framework: > The desktop entry file "/share/applications/org.kde.kded5.desktop" > has Type= "Sy

D22477: With auto completion don't show completions that don't match from beginning of typed word

brauch added a comment. Also here, looks good to me, but I would wait for feedback from somebody else in addition. Thank you for working on this! REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D22477 To: ahmadsamir, #ktexteditor, cullmann, dhaumann, #kdevelop, ko

D22477: With auto completion don't show completions that don't match from beginning of typed word

brauch added inline comments. INLINE COMMENTS > brauch wrote in katecompletionmodel.cpp:2029 > Maybe you want to set the flag here too? Actually no, probably not. ;) REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D22477 To: ahmadsamir, #ktexteditor, cullmann, dhaum

D22477: With auto completion don't show completions that don't match from beginning of typed word

brauch added inline comments. INLINE COMMENTS > katecompletionmodel.cpp:2029 > if (matchesAbbreviation(m_nameColumn, match, > model->matchCaseSensitivity())) { > matchCompletion = AbbreviationMatch; > } Maybe you want to set the flag here too? REPOSITORY R39 KT

D22488: invoke QIcon::setFallbackThemeName a bit later

aacid added a comment. I don't think this is going to work. Who is going to create a KIconTheme when running Okular on gnome shell? From what i can see we do create one in okular/part.cpp:386 because we happen to call KParts::Part::iconLoader() there, but that's too late, there has b

Re: kdewebkit tarball gone missing?!

El dimarts, 16 de juliol de 2019, a les 19:30:52 CEST, René J.V. Bertin va escriure: > Hi, > > A few days ago I downloaded the 5.60.0 kdewebkit tarball from its usual > location on downloads.kde.org (= among the other FW tarballs), today it > appears to be gone? > > Has it moved or is this an

D22500: Make keyword completion model return HideListIfAutomaticInvocation by default

brauch added a comment. Independent of anything else I think this is a very sensible change, and seems like an oversight / bug. One of the more core kate guys should approve, but +1 from me. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D22500 To: ahmadsami

D22477: With auto completion don't show completions that don't match from beginning of typed word

ahmadsamir added a comment. In D22477#496214 , @brauch wrote: > I'm not sure if this solves the right problem. > > Where I notice this issue a lot is when typing "return". The keyword completion suggests "return", and when I want a newline, I

D22477: With auto completion don't show completions that don't match from beginning of typed word

ahmadsamir updated this revision to Diff 61882. ahmadsamir edited the summary of this revision. ahmadsamir added a comment. Take 2 REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22477?vs=61881&id=61882 BRANCH less-trigger-happy-completions (branched f

D22477: With auto completion don't show completions that don't match from beginning of typed word

ahmadsamir updated this revision to Diff 61881. ahmadsamir retitled this revision from "Add a config to only show completions matching word beginning" to "With auto completion don't show completions that don't match from beginning of typed word". ahmadsamir edited the summary of this revision. ah

D22500: Make keyword completion model return HideListIfAutomaticInvocation by default

ahmadsamir created this revision. ahmadsamir added reviewers: KTextEditor, KDevelop, cullmann, dhaumann, brauch. Herald added projects: Kate, Frameworks. ahmadsamir requested review of this revision. REVISION SUMMARY Change KateKeywordCompletionModel::matchingItem to return HideListIfAutomatic

D22477: Add a config to only show completions matching word beginning

ahmadsamir updated this revision to Diff 61879. ahmadsamir added a comment. Change the diff altogether to not show the menu with "ContainsMatch" REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22477?vs=61807&id=61879 BRANCH less-trigger-happy-completio

D19986: Install .desktop file for kded5

rjvbb added inline comments. INLINE COMMENTS > dfaure wrote in org.kde.kded5.desktop:4 > What does SystemService mean? > > I'm seeing a warning from the kservice framework: > The desktop entry file "/share/applications/org.kde.kded5.desktop" > has Type= "SystemService" instead of "Application

D22083: introduce concept of header and footer for kpageview

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Lovely. Looks perfect in Dolphin, Kate, Konsole, Okular, Gwenview, and Kile. Ark and Spectacle also need to be adapted, like kcmshell. Anything not using KPageView properly will need

D21672: [PowerStateMonitor] Be conservative when determining power state

ngraham added a comment. > Let's not argue but investigate and fix why this seemingly innocent patch caused the behavior described. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D21672 To: bruns, #baloo, ngraham, astippich, poboiko Cc: broulik, romangg, kde-framework

D22488: invoke QIcon::setFallbackThemeName a bit later

ngraham edited the summary of this revision. REPOSITORY R302 KIconThemes REVISION DETAIL https://phabricator.kde.org/D22488 To: mart, #frameworks, #plasma Cc: mlaurent, broulik, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

kdewebkit tarball gone missing?!

Hi, A few days ago I downloaded the 5.60.0 kdewebkit tarball from its usual location on downloads.kde.org (= among the other FW tarballs), today it appears to be gone? Has it moved or is this an error? Thanks, R.

Re: New framework: KContacts

On Saturday, 6 April 2019 18:01:09 CEST Volker Krause wrote: > Hi, > > I'd like to propose KContacts for review to move from KDE PIM to KF5. > > KContacts is essentially an implementation of the vCard standard, covering > the data model as well as parsing and creating of vCard files. As the > rec

Re: New framework: KCalCore

On Monday, 15 July 2019 18:43:42 CEST Aleix Pol wrote: > On Fri, Jul 12, 2019 at 9:03 PM Allen Winter wrote: > > On Friday, July 12, 2019 12:23:58 PM EDT Volker Krause wrote: > > > With the 19.08 release approaching (and thus the deadline for > > > incompatible > > > changes if we go ahead with th

D22144: Add kio recentlyused:/ to access KactivitytStats data

ngraham added a comment. So interestingly enough, accessing `recentlyused:/` in Dolphin's URL navigator works great, but doing `recentlyused:/?limit=100` causes it to crash on an assert: $ dolphin org.kde.kactivities.lib.core: Setting the title: "" ASSERT: "!name.isEmpty()" in

D22144: Add kio recentlyused:/ to access KactivitytStats data

ngraham added a comment. Aha, that was the fix that made it work for me! Thanks a bunch. I will conduct a more thorough review soon. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D22144 To: meven, ivan, #frameworks, ngraham Cc: elvisangelaccio, kde-frameworks-de

D22488: invoke QIcon::setFallbackThemeName a bit later

mlaurent added a comment. will it fix this bug "https://bugs.kde.org/show_bug.cgi?id=407600"; ? REPOSITORY R302 KIconThemes REVISION DETAIL https://phabricator.kde.org/D22488 To: mart, #frameworks, #plasma Cc: mlaurent, broulik, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngra

D22144: Add kio recentlyused:/ to access KactivitytStats data

meven added a comment. @ngraham I just fixed an issue in the recentlyused.json file, this should work much easier. I encounter some instabilities with kactivitiymanagerd. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D22144 To: meven, ivan, #frameworks, ngr

D22144: Add kio recentlyused:/ to access KactivitytStats data

meven updated this revision to Diff 61860. meven added a comment. Fix json file REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22144?vs=60886&id=61860 BRANCH arcpatch-D22144 REVISION DETAIL https://phabricator.kde.org/D22144 AFFECTED FILES CMake

D22339: Make sure solid backends are reentrant

bruns added a comment. I would have preferred this to only land when D22333 had been addressed fully, I assumed this required no further notice. So from a pure technical view, this indeed seems to be correct, but from an architectural view this seems

D22419: Fix cant enter directory error on Android FTP servers

aacid added a comment. Why is uppercase only better compatibility if the spec clearly says that case doesn't matter ? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D22419 To: nxiss7, #frameworks Cc: aacid, svuorela, kde-frameworks-devel, LeGast00n, sbergeron, michaelh,

KDE CI: Frameworks » kpackage » kf5-qt5 FreeBSDQt5.13 - Build # 5 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20FreeBSDQt5.13/5/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Tue, 16 Jul 2019 11:55:01 + Build duration: 1 hr 25 min and counting JUnit Tests Name: project

D22488: invoke QIcon::setFallbackThemeName a bit later

mart updated this revision to Diff 61857. mart added a comment. - nitialize REPOSITORY R302 KIconThemes CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22488?vs=61855&id=61857 BRANCH phab/qqcicons REVISION DETAIL https://phabricator.kde.org/D22488 AFFECTED FILES src/kicont

D22488: invoke QIcon::setFallbackThemeName a bit later

mart edited the summary of this revision. REPOSITORY R302 KIconThemes REVISION DETAIL https://phabricator.kde.org/D22488 To: mart, #frameworks, #plasma Cc: broulik, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22488: invoke QIcon::setFallbackThemeName a bit later

mart marked an inline comment as done. REPOSITORY R302 KIconThemes REVISION DETAIL https://phabricator.kde.org/D22488 To: mart, #frameworks, #plasma Cc: broulik, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22488: invoke QIcon::setFallbackThemeName a bit later

mart updated this revision to Diff 61855. mart added a comment. - use a local static REPOSITORY R302 KIconThemes CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22488?vs=61854&id=61855 BRANCH phab/qqcicons REVISION DETAIL https://phabricator.kde.org/D22488 AFFECTED FILES s

D22488: invoke QIcon::setFallbackThemeName a bit later

broulik added inline comments. INLINE COMMENTS > kicontheme.cpp:267 > +#if QT_VERSION >= QT_VERSION_CHECK(5, 12, 0) > +if (!d->fallbackThemeInitialized) { > +QIcon::setFallbackThemeName(QStringLiteral("breeze")); I guess you can just do a static s_fallbackThemeInitialized = false;

D22339: Make sure solid backends are reentrant

apol added a comment. In D22339#495116 , @lbeltrame wrote: > Why was this committed when changes were requested? Wasn't that the whole point of having reviews? Sorry, I thought all doubts had been resolved. No changes were requested. RE

D22488: invoke QIcon::setFallbackThemeName a bit later

mart created this revision. mart added reviewers: Frameworks, Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mart requested review of this revision. REVISION SUMMARY invoking QIcon::setFallbackThemeName at QCoreApplication ctor with Q_COREAPP_START

D22487: Offer metadata.json when requesting the package metadata

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R290 KPackage BRANCH master REVISION DETAIL https://phabricator.kde.org/D22487 To: apol, #frameworks, davidedmundson Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

Re: kbuildsycoca global in a modern world

In profiling, I've seen parsing desktop files is expensive. Even something like KProtocolInfo registers highly in most application logs. Parts of plasma do various complex lookups of application desktop files. We definitely need some cache in some form of those desktop files for use from within pl

D22487: Offer metadata.json when requesting the package metadata

apol created this revision. apol added a reviewer: Frameworks. apol added a project: Frameworks. apol requested review of this revision. REVISION SUMMARY Otherwise we'd end up using the slow path when using Package::metadata(). TEST PLAN metadata still gets loaded but using the faster path.

D22475: Use metadata.json when creating the metadata from KPackage::metadata()

apol added a comment. In D22475#496132 , @davidedmundson wrote: > That was less than 5 hours from posting to give up on a review! > > We're not in a rush. Ugh yeah, I didn't mean to land the patch. >.< REPOSITORY R290 KPackage REV

D22419: Fix cant enter directory error on Android FTP servers

nxiss7 added a comment. Instead of sending another command, should we refactor all FTP commands to upper case for better compatibility (as suggested by muesli) ? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D22419 To: nxiss7, #frameworks Cc: svuorela, kde-frameworks-d

D21672: [PowerStateMonitor] Be conservative when determining power state

romangg added a comment. The bug report was online for two weeks and it was categorized as Baloo bug. You had more than enough time to notice it. I hoped I wouldn't need to waste any more time on this issue besides the time I already had to spent for working around this bug for two weeks

kbuildsycoca global in a modern world

Hey! I was wondering if kbuildsycoca's global code still has a reason to exist. The way I read the code a local kbuildsycoca would only reuse the global sycoca iff languages, prefixes and signatures are a match. But prefixes are not ever the same in any "default" or even reasonable scenario. Spec

D21672: [PowerStateMonitor] Be conservative when determining power state

bruns added a comment. In D21672#496232 , @broulik wrote: > > Why don't you notify the relevant people first > > He kinda did by writing a bug report, but let's not argue but investigate and fix why this seemingly innocent patch caused the be

D21672: [PowerStateMonitor] Be conservative when determining power state

broulik added a comment. > Why don't you notify the relevant people first He kinda did by writing a bug report, but let's not argue but investigate and fix why this seemingly innocent patch caused the behavior described. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.

D21672: [PowerStateMonitor] Be conservative when determining power state

bruns added a comment. In D21672#496217 , @romangg wrote: > Reverted by d6d86cb86c on master. See https://bugs.kde.org/show_bug.cgi?id=409405 for more info. Possibly a

D22419: Fix cant enter directory error on Android FTP servers

bcooksley changed the visibility from "All Users" to "Public (No Login Required)". REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D22419 To: nxiss7, #frameworks Cc: svuorela, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22083: introduce concept of header and footer for kpageview

mart added a comment. this makes it look almost pixel perfect F7031708: Screenshot_20190716_115035.png tough introduces a behavior change: moves the responsibility of adding margins from the outer layout to the internal one, making some users loo

D22083: introduce concept of header and footer for kpageview

mart updated this revision to Diff 61844. mart added a comment. - introduce concept of header and footer for kpageview - adress code style comments - use rowspan and colspan to add margins in the right places REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE https://phabricator

D21672: [PowerStateMonitor] Be conservative when determining power state

romangg added a comment. Reverted by d6d86cb86c on master. See https://bugs.kde.org/show_bug.cgi?id=409405 for more info. Possibly a critical problem in released 5.60 @bruns. REPOSITORY R293 Baloo REVISION DETAIL

D22477: Add a config to only show completions matching word beginning

brauch added a comment. I'm not sure if this solves the right problem. Where I notice this issue a lot is when typing "return". The keyword completion suggests "return", and when I want a newline, I complete the "return" first. This doesn't affect C++ (because of the trailing ";"), but i

D22477: Add a config to only show completions matching word beginning

ahmadsamir added a comment. In D22477#496059 , @kossebau wrote: > Default is `false,` so does not change behaviour unless someone toggles the switch, right? > > I would rename the option to `WordCompletionMatchFromWordStartOnly` though, as f

D21659: add .vscode to .gitignore

zzag added a comment. Heh, I usually put .vscode and compile_commands.json (for clangd) in .git/info/exclude. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D21659 To: brute4s99, broulik, nicolasfella Cc: zzag, kde-frameworks-devel, LeGast00n, sbergeron, mich