KDE CI: Frameworks » purpose » kf5-qt5 FreeBSDQt5.13 - Build # 6 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/purpose/job/kf5-qt5%20FreeBSDQt5.13/6/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Thu, 18 Jul 2019 03:20:16 + Build duration: 2 min 32 sec and counting JUnit Tests Name:

KDE CI: Frameworks » kwallet » kf5-qt5 SUSEQt5.12 - Build # 30 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kwallet/job/kf5-qt5%20SUSEQt5.12/30/ Project: kf5-qt5 SUSEQt5.12 Date of build: Wed, 17 Jul 2019 23:52:04 + Build duration: 9 min 4 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kwallet » kf5-qt5 SUSEQt5.13 - Build # 5 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kwallet/job/kf5-qt5%20SUSEQt5.13/5/ Project: kf5-qt5 SUSEQt5.13 Date of build: Wed, 17 Jul 2019 23:52:05 + Build duration: 7 min 57 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kwallet » kf5-qt5 FreeBSDQt5.13 - Build # 4 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kwallet/job/kf5-qt5%20FreeBSDQt5.13/4/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Wed, 17 Jul 2019 23:52:05 + Build duration: 2 min 11 sec and counting JUnit Tests Name:

D21002: Remove kde4 migration agent completely

bruns added a comment. It tried to install the no longer existing DBus service file. Fixup pushed. REPOSITORY R311 KWallet REVISION DETAIL https://phabricator.kde.org/D21002 To: bruns, #frameworks, cfeck, ngraham, aacid Cc: aacid, lbeltrame, kde-frameworks-devel, damjang, LeGast00n,

D21661: add snoretoast backend for KNotifications on Windows

nicolasfella added inline comments. INLINE COMMENTS > CMakeLists.txt:48 > + ) > + find_package(Qt5Network REQUIRED) > + list(APPEND knotifications_SRCS notifybysnore.cpp) find_package calls are usually in the toplevel CMakeLists.txt > knotification.cpp:382 > +#elif defined(Q_OS_WIN) > +

D21002: Remove kde4 migration agent completely

aacid added a comment. It seems you broke the build https://build.kde.org/job/Frameworks/job/kwallet/ is all read REPOSITORY R311 KWallet REVISION DETAIL https://phabricator.kde.org/D21002 To: bruns, #frameworks, cfeck, ngraham, aacid Cc: aacid, lbeltrame,

Re: kdewebkit tarball gone missing?!

Albert Astals Cid wrote: > https://download.kde.org/stable/frameworks/5.60/portingAids/ Ah, thanks, I must have missed the announcement of its promotion. So what kind of tier is kdesigner-plugin now - I still have it categorised as a tier3 but those are supposed to depend only on tier1, tier2

KDE CI: Frameworks » kwallet » kf5-qt5 SUSEQt5.12 - Build # 29 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kwallet/job/kf5-qt5%20SUSEQt5.12/29/ Project: kf5-qt5 SUSEQt5.12 Date of build: Wed, 17 Jul 2019 22:34:13 + Build duration: 4 min 51 sec and counting JUnit Tests Name: (root)

KDE CI: Frameworks » kwallet » kf5-qt5 FreeBSDQt5.13 - Build # 3 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kwallet/job/kf5-qt5%20FreeBSDQt5.13/3/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Wed, 17 Jul 2019 22:34:13 + Build duration: 5 min 35 sec and counting CONSOLE OUTPUT

KDE CI: Frameworks » kwallet » kf5-qt5 SUSEQt5.13 - Build # 4 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kwallet/job/kf5-qt5%20SUSEQt5.13/4/ Project: kf5-qt5 SUSEQt5.13 Date of build: Wed, 17 Jul 2019 22:34:13 + Build duration: 2 min 11 sec and counting JUnit Tests Name: (root)

D21002: Remove kde4 migration agent completely

This revision was automatically updated to reflect the committed changes. Closed by commit R311:dc5c7229bc4f: Remove kde4 migration agent completely (authored by bruns). REPOSITORY R311 KWallet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21002?vs=57489=61943 REVISION DETAIL

D22520: Remove Growl support

nicolasfella edited the summary of this revision. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D22520 To: nicolasfella, #frameworks, broulik Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22520: Remove Growl support

nicolasfella updated this revision to Diff 61942. nicolasfella added a comment. - Remove unneeded include REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22520?vs=61941=61942 BRANCH growl REVISION DETAIL https://phabricator.kde.org/D22520

D22520: Remove Growl support

nicolasfella created this revision. nicolasfella added reviewers: Frameworks, broulik. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY We're about to get proper backends for Windows and macOS.

D22265: KPluginMetaData: use Q_DECLARE_METATYPE

elvisangelaccio added a comment. In D22265#491249 , @kossebau wrote: > This runs the chance to break some 3rd-party software which also calls the Q_DECLARE_METATYPE(KPluginMetaData) macro. > Any chance this could be moved to the place that

D22515: Add support for additional QML keywords not part of JavaScript

dhaumann accepted this revision. dhaumann added a comment. This revision is now accepted and ready to land. Please commit. REPOSITORY R216 Syntax Highlighting BRANCH master REVISION DETAIL https://phabricator.kde.org/D22515 To: vkrause, dhaumann Cc: dhaumann, broulik, kwrite-devel,

D21660: remove dbus for windows build and change audio dep logic

nicolasfella accepted this revision. This revision is now accepted and ready to land. REPOSITORY R289 KNotifications BRANCH arcpatch-D21660_1 REVISION DETAIL https://phabricator.kde.org/D21660 To: brute4s99, broulik, nicolasfella Cc: bcooksley, apol, nicolasfella, kde-frameworks-devel,

D22500: Make keyword completion model return HideListIfAutomaticInvocation by default

ahmadsamir added a comment. FWIW, the combined effect of this patch and D22477 , hopefully you'll no longer see the Q_RETRUN_ARG and co. completions unless the menu is manually invoked with the mode set to C++. REPOSITORY R39 KTextEditor REVISION

D22500: Make keyword completion model return HideListIfAutomaticInvocation by default

This revision was automatically updated to reflect the committed changes. Closed by commit R39:e852d990eb5a: Make keyword completion model return HideListIfAutomaticInvocation by default (authored by ahmadsamir, committed by cullmann). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE

D22500: Make keyword completion model return HideListIfAutomaticInvocation by default

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Ok, there I can see a difference and the new behavior is better. Thanks! REPOSITORY R39 KTextEditor BRANCH ahmad/keyword-auto-completion (branched from master) REVISION DETAIL

D22500: Make keyword completion model return HideListIfAutomaticInvocation by default

ahmadsamir updated this revision to Diff 61932. ahmadsamir edited the test plan for this revision. ahmadsamir added a comment. Fix test plan :/ REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22500?vs=61880=61932 BRANCH ahmad/keyword-auto-completion

D22500: Make keyword completion model return HideListIfAutomaticInvocation by default

ahmadsamir added a comment. I messed up the test plan; try with the mode set to Python. It looks like a corner case where if there's only one exact match, the completions menu doesn't get auto hidden. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D22500 To:

D22500: Make keyword completion model return HideListIfAutomaticInvocation by default

cullmann added a comment. Hmm, does that really work this way? At least for me, even with and without that patch, I get with C++ more proposals than just return on typing return. And for other things like the completion already now disappears. REPOSITORY R39 KTextEditor REVISION DETAIL

D22144: Add kio recentlyused:/ to access KactivitytStats data

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. LGTM! REPOSITORY R320 KIO Extras BRANCH arcpatch-D22144 REVISION DETAIL https://phabricator.kde.org/D22144 To: meven, ivan, #frameworks, ngraham Cc: elvisangelaccio,

D22502: [FileIndexerConfig] skip invalid entries from included/excludedFolders

poboiko added a comment. In D22502#496812 , @bruns wrote: > The correct fix is to check the returned/calculated ID in the IndexCleaner, otherwise its racy. I think both can be implemented. I had in mind the case when folder was

D22144: Add kio recentlyused:/ to access KactivitytStats data

meven marked 6 inline comments as done. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D22144 To: meven, ivan, #frameworks, ngraham Cc: elvisangelaccio, kde-frameworks-devel, kfm-devel, aprcela, fprice, LeGast00n, sbergeron, fbampaloukas, alexde, feverfew, meven,

D22144: Add kio recentlyused:/ to access KactivitytStats data

meven updated this revision to Diff 61929. meven added a comment. Fix typos, missing space... REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22144?vs=61860=61929 BRANCH arcpatch-D22144 REVISION DETAIL https://phabricator.kde.org/D22144 AFFECTED

D22515: Add support for additional QML keywords not part of JavaScript

vkrause edited the summary of this revision. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D22515 To: vkrause Cc: broulik, kwrite-devel, kde-frameworks-devel, LeGast00n, sbergeron, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D22515: Add support for additional QML keywords not part of JavaScript

vkrause updated this revision to Diff 61927. vkrause added a comment. I am blind, the QtObject type is already there (no idea why it wasn't highlighting correctly...). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22515?vs=61926=61927 BRANCH

D22515: Add support for additional QML keywords not part of JavaScript

broulik added inline comments. INLINE COMMENTS > qml.xml:41 >Timer >QtObject >Item It's already there REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D22515 To: vkrause Cc: broulik, kwrite-devel, kde-frameworks-devel, LeGast00n,

D22515: Add support for additional QML keywords not part of JavaScript

vkrause created this revision. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. vkrause requested review of this revision. REVISION SUMMARY Also, add the QtObject type while we are at it. REPOSITORY R216 Syntax Highlighting BRANCH

D22511: Minimap: Do not grab left mouse click over up/down arrows

This revision was automatically updated to reflect the committed changes. Closed by commit R39:2d941799251c: Minimap: Do not grab the left-mmouse-button-click on up/down buttons (authored by sars). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE

D22511: Minimap: Do not grab left mouse click over up/down arrows

brauch accepted this revision. brauch added a comment. This revision is now accepted and ready to land. LGTM, thank you! REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D22511 To: sars, brauch Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, sbergeron, domson,

D22144: Add kio recentlyused:/ to access KactivitytStats data

ngraham added a comment. Indeed, it was a database issue. Looks like that's on kactivitymanagerd, not you! It's probably too late to get this into 19.08 unfortunately. In my experience big new features like this shouldn't be merged right before the deadline. In addition to the

D22511: Minimap: Do not grab left mouse click over up/down arrows

sars created this revision. sars added a reviewer: brauch. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. sars requested review of this revision. REVISION SUMMARY The arrow buttons stopped working when we implemented "jump to position" in

D22510: Added dialog to set execute permission for executable file when trying to run it.

mdlubakowski added a comment. In D22510#496804 , @ngraham wrote: > If the use case you're targeting is specifically AppImage files, it might make sense to coordinate with upstream, where they're working on ways to improve this:

D22502: [FileIndexerConfig] skip invalid entries from included/excludedFolders

bruns requested changes to this revision. This revision now requires changes to proceed. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D22502 To: poboiko, #baloo, bruns, ngraham Cc: kde-frameworks-devel, LeGast00n, sbergeron, fbampaloukas, domson, ashaposhnikov,

D22502: [FileIndexerConfig] skip invalid entries from included/excludedFolders

bruns added a comment. The correct fix is to check the returned/calculated ID in the IndexCleaner, otherwise its racy. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D22502 To: poboiko, #baloo, bruns, ngraham Cc: kde-frameworks-devel, LeGast00n, sbergeron,

D22510: Added dialog to set execute permission for executable file when trying to run it.

broulik added a comment. Doesn't AppImageLauncher take care of this? When I download an AppImage, I click on it in Dolphin and I get prompted whether to integrate it or run once. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D22510 To: mdlubakowski, #frameworks Cc:

D22510: Added dialog to set execute permission for executable file when trying to run it.

mdlubakowski edited the summary of this revision. mdlubakowski added a reviewer: Frameworks. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D22510 To: mdlubakowski, #frameworks Cc: ngraham, probono, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, bruns

D22510: Added dialog to set execute permission for executable file when trying to run it.

ngraham added subscribers: probono, ngraham. ngraham added a comment. If the use case you're targeting is specifically AppImage files, it might make sense to coordinate with upstream, where they're working on ways to improve this: https://github.com/AppImage/appimaged/issues/30. There's a

D22510: Added dialog to set execute permission for executable file when trying to run it.

mdlubakowski updated this revision to Diff 61918. mdlubakowski added a comment. One of the commits did not upload REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22510?vs=61917=61918 BRANCH make-executable-prompt REVISION DETAIL

D22510: Added dialog to set execute permission for executable file when trying to run it.

mdlubakowski created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mdlubakowski requested review of this revision. REVISION SUMMARY Currently if you try to run executable file for which you don't have execute permission, KRun will either

D10747: Implement zwp_linux_dmabuf_v1

romangg added a comment. If there are no objections I would push this soon. There is one remaining annoyance I have with the current version: the name of the class inside the interface the compositor has to subclass for interfacing with KWayland. I changed the name from Bridge to Impl

D10747: Implement zwp_linux_dmabuf_v1

romangg updated this revision to Diff 61912. romangg added a comment. - Rebase on master - Use packaged dma-buf xml REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10747?vs=60654=61912 BRANCH dmaBuf REVISION DETAIL

D21660: remove dbus for windows build and change audio dep logic

brute4s99 marked 8 inline comments as done. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D21660 To: brute4s99, broulik, nicolasfella Cc: bcooksley, apol, nicolasfella, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D21721: [WIP] Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)

leinir updated this revision to Diff 61905. leinir added a comment. - Don't use outdated code (e.g. the Kirigami Label component) - Update NewStuffList to the new model API - Explicit operator= implementations (for less warnings) REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 133 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/133/ Project: kf5-qt5 SUSEQt5.12 Date of build: Wed, 17 Jul 2019 09:58:12 + Build duration: 22 min and counting BUILD ARTIFACTS

D22061: Add a logging category for logs warnings

meven updated this revision to Diff 61897. meven added a comment. Add a logging categorie, add context to logs REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22061?vs=60610=61897 BRANCH arcpatch-D22061 REVISION DETAIL

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.13 - Build # 10 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.13/10/ Project: kf5-qt5 SUSEQt5.13 Date of build: Wed, 17 Jul 2019 09:58:12 + Build duration: 8 min 9 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.13 - Build # 6 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.13/6/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Wed, 17 Jul 2019 09:58:12 + Build duration: 3 min 41 sec and counting JUnit Tests

D22061: Add a logging category for logs warnings

meven edited the test plan for this revision. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D22061 To: meven, #frameworks Cc: mikeroyal, apol, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22143: Add proper logging using ECMQtDeclareLoggingCategory

meven added inline comments. INLINE COMMENTS > meven wrote in CMakeLists.txt:21 > While it is true, the solution here is not ideal, it is quite commonly used > in kde projects and anyone opening the CMakeLists.txt should come up pretty > quickly that this file is being generated elsewhere. > I

D17595: Upstream Dolphin's file rename dialog

meven added a subscriber: mitchell. meven added a comment. In D17595#481526 , @ngraham wrote: > Who's left? Only three now : Jeff Mitchell @mitchell , Frank Reininghaus and Peter Penz. But Peter Penz is the most important one as

D20838: Allow to drop one file or one folder on KDirOperator

meven added a comment. In D20838#492751 , @dfaure wrote: > Strange, I'm pretty sure I was able to reproduce it locally before I wrote my comment here. But now I can't anymore. OK, to be further investigated when either of us have time.

D22502: [FileIndexerConfig] skip invalid entries from included/excludedFolders

poboiko created this revision. poboiko added reviewers: Baloo, bruns, ngraham. Herald added projects: Frameworks, Baloo. poboiko requested review of this revision. REVISION SUMMARY It is possible to create an invalid entry inside includedFolders, for example: by creating some folder, adding

D22144: Add kio recentlyused:/ to access KactivitytStats data

meven added a comment. In D22144#496414 , @ngraham wrote: > So interestingly enough, accessing `recentlyused:/` in Dolphin's URL navigator works great, but doing `recentlyused:/?limit=100` causes it to crash on an assert: > > $ dolphin

D22083: introduce concept of header and footer for kpageview

mart added a comment. In D22083#496446 , @ngraham wrote: > Lovely. Looks perfect in Dolphin, Kate, Konsole, Okular, Gwenview, and Kile. > > Ark and Spectacle also need to be adapted, like kcmshell. Anything not using KPageView properly will