D22653: Add view-qrcode icons

ndavis added a comment. In D22653#500427 , @mbruchert wrote: > The blue corners are supposed to indicate that the QR-Code can be scanned. But aren't QR codes normally scannable? REPOSITORY R266 Breeze Icons REVISION DETAIL

D22653: Add view-qrcode icons

ndavis added a comment. In D22653#500471 , @broulik wrote: > How about `view-barcode-qr`? then we could potentially have specific `view-barcode-aztec` and also a fallback to `view-barcode` +1 REPOSITORY R266 Breeze Icons REVISION

D22670: Change Highlight to ButtonFocus, improve stylesheet support

ndavis created this revision. ndavis added reviewers: VDG, Plasma, Breeze. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ndavis requested review of this revision. REVISION SUMMARY Changed Highlight to Button focus so that these SVGs wouldn't use the same

D21660: remove dbus for windows build and change audio dep logic

aspotashev added a comment. This broke some public APIs on Windows: since Qt5DBus is not being "imported" by CMake, a group of .cpp files is not being compiled, see e.g. https://cgit.kde.org/knotifications.git/tree/src/CMakeLists.txt#n25 . Thus e.g. class KStatusNotifierItem implementation

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.13 - Build # 6 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.13/6/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Tue, 23 Jul 2019 00:42:41 + Build duration: 7 min 13 sec and counting JUnit Tests Name:

D22667: Make the default build type "Debug" when compiling a git checkout.

apol added a comment. +1 Makes a lot of sense to me. In KDevelop we are already setting Debug by default. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D22667 To: dfaure, kde-buildsystem Cc: apol, kde-frameworks-devel, LeGast00n, sbergeron, bencreasy,

D22667: Make the default build type "Debug" when compiling a git checkout.

dfaure created this revision. dfaure added a reviewer: kde-buildsystem. Herald added projects: Frameworks, Build System. Herald added a subscriber: kde-frameworks-devel. dfaure requested review of this revision. REVISION SUMMARY The idea comes from

D22586: KRun QML proxy: fix path/URL confusion

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R296 KDeclarative BRANCH D22586 REVISION DETAIL https://phabricator.kde.org/D22586 To: dfaure, davidedmundson, apol Cc: apol, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22657: Use non-deprecated suggestName

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R495 Purpose Library BRANCH nd REVISION DETAIL https://phabricator.kde.org/D22657 To: nicolasfella, apol Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 148 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/148/ Project: kf5-qt5 SUSEQt5.12 Date of build: Mon, 22 Jul 2019 21:38:46 + Build duration: 31 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 147 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/147/ Project: kf5-qt5 SUSEQt5.12 Date of build: Mon, 22 Jul 2019 21:03:49 + Build duration: 34 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kservice » kf5-qt5 FreeBSDQt5.13 - Build # 7 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kservice/job/kf5-qt5%20FreeBSDQt5.13/7/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Mon, 22 Jul 2019 21:33:40 + Build duration: 1 min 37 sec and counting JUnit Tests Name:

KDE CI: Frameworks » kdelibs4support » kf5-qt5 SUSEQt5.12 - Build # 35 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20SUSEQt5.12/35/ Project: kf5-qt5 SUSEQt5.12 Date of build: Mon, 22 Jul 2019 21:04:59 + Build duration: 24 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.13 - Build # 16 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.13/16/ Project: kf5-qt5 SUSEQt5.13 Date of build: Mon, 22 Jul 2019 21:18:07 + Build duration: 8 min 10 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 10 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/10/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Mon, 22 Jul 2019 21:16:40 + Build duration: 8 min 42 sec and counting JUnit Tests Name:

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 9 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/9/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Mon, 22 Jul 2019 21:03:49 + Build duration: 12 min and counting JUnit Tests Name: projectroot

KDE CI: Frameworks » kdelibs4support » kf5-qt5 FreeBSDQt5.13 - Build # 5 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20FreeBSDQt5.13/5/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Mon, 22 Jul 2019 21:04:59 + Build duration: 7 min 4 sec and counting JUnit Tests Name:

D22658: Use non-deprecated suggestName

This revision was automatically updated to reflect the committed changes. Closed by commit R239:36a409210949: Use non-deprecated suggestName (authored by nicolasfella). REPOSITORY R239 KDELibs4Support CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22658?vs=62333=62355 REVISION

D22637: Deprecate suggestName

This revision was automatically updated to reflect the committed changes. Closed by commit R241:4cdf7f01c191: Deprecate suggestName (authored by nicolasfella). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D22637?vs=62325=62354#toc REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

D22656: Replace implementation of suggestName with KFileUtils::suggestName

This revision was automatically updated to reflect the committed changes. Closed by commit R241:65010677ff35: Replace implementation of suggestName with KFileUtils::suggestName (authored by nicolasfella). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

Re: kbuildsycoca global in a modern world

On Sun, Jul 21, 2019 at 5:38 PM David Faure wrote: > > On mardi 16 juillet 2019 13:08:02 CEST Harald Sitter wrote: > > I was wondering if kbuildsycoca's global code still has a reason to exist. > > I wondered the same when I redesigned most of ksycoca some time ago, > and I chose to keep the

D22653: Add view-qrcode icons

broulik added a comment. How about `view-barcode-qr`? then we could potentially have specific `view-barcode-aztec` and also a fallback to `view-barcode` REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D22653 To: mbruchert, #breeze, ndavis Cc: broulik, ndavis,

D22586: KRun QML proxy: fix path/URL confusion

dfaure added a comment. @davidedmundson @apol patch OK now? REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D22586 To: dfaure, davidedmundson Cc: apol, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22658: Use non-deprecated suggestName

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R239 KDELibs4Support BRANCH nd REVISION DETAIL https://phabricator.kde.org/D22658 To: nicolasfella, dfaure Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22656: Replace implementation of suggestName with KFileUtils::suggestName

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH internal REVISION DETAIL https://phabricator.kde.org/D22656 To: nicolasfella, dfaure Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22637: Deprecate suggestName

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH depre REVISION DETAIL https://phabricator.kde.org/D22637 To: nicolasfella, dfaure Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22659: Fix bracket

vonreth added a comment. Applications/19.08 was branched before the commit introducing this issue REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D22659 To: vonreth, brute4s99 Cc: ltoscano, kde-frameworks-devel, kfm-devel, aprcela, fprice, LeGast00n, sbergeron,

D22659: Fix bracket

ltoscano added a comment. This should be backported to Applications/19.08. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D22659 To: vonreth, brute4s99 Cc: ltoscano, kde-frameworks-devel, kfm-devel, aprcela, fprice, LeGast00n, sbergeron, fbampaloukas, alexde,

D22662: Add common GLSL file extensions (.vs, .gs, .fs)

smokris added a reviewer: Framework: Syntax Highlighting. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D22662 To: smokris, #framework_syntax_highlighting Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, sbergeron, domson, michaelh, ngraham, bruns,

D22662: Add common GLSL file extensions (.vs, .gs, .fs)

smokris created this revision. smokris added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. smokris requested review of this revision. REVISION SUMMARY These 2-letter extensions are used by, for example: -

D22653: Add view-qrcode icons

mbruchert added a comment. The blue corners are supposed to indicate that the QR-Code can be scanned. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D22653 To: mbruchert, #breeze, ndavis Cc: ndavis, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham,

D22653: Add view-qrcode icons

mbruchert updated this revision to Diff 62346. mbruchert added a comment. Add icons to breeze-dark REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22653?vs=62344=62346 BRANCH master REVISION DETAIL https://phabricator.kde.org/D22653 AFFECTED

D22653: Add view-qrcode icons

mbruchert updated this revision to Diff 62344. mbruchert added a comment. Remove accidentially committed changes REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22653?vs=62343=62344 BRANCH master REVISION DETAIL https://phabricator.kde.org/D22653

D22653: Add view-qrcode icons

mbruchert updated this revision to Diff 62343. mbruchert added a comment. Optimize and use css theme colors REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22653?vs=62318=62343 BRANCH master REVISION DETAIL https://phabricator.kde.org/D22653

D22659: Fix bracket

This revision was automatically updated to reflect the committed changes. Closed by commit R320:872083cefb55: Fix bracket (authored by vonreth). REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22659?vs=62336=62342 REVISION DETAIL

D22659: Fix bracket

brute4s99 accepted this revision. This revision is now accepted and ready to land. REPOSITORY R320 KIO Extras BRANCH master REVISION DETAIL https://phabricator.kde.org/D22659 To: vonreth, brute4s99 Cc: kde-frameworks-devel, kfm-devel, aprcela, fprice, LeGast00n, sbergeron, fbampaloukas,

D22659: Fix bracket

brute4s99 added a comment. thanks Hannah! REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D22659 To: vonreth, brute4s99 Cc: kde-frameworks-devel, kfm-devel, aprcela, fprice, LeGast00n, sbergeron, fbampaloukas, alexde, feverfew, meven, michaelh, spoorun,

D22659: Fix bracket

vonreth added a reviewer: brute4s99. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D22659 To: vonreth, brute4s99 Cc: kde-frameworks-devel, kfm-devel, aprcela, fprice, LeGast00n, sbergeron, fbampaloukas, alexde, feverfew, meven, michaelh, spoorun, navarromorales,

D22659: Fix bracket

vonreth created this revision. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. vonreth requested review of this revision. REPOSITORY R320 KIO Extras BRANCH master REVISION DETAIL https://phabricator.kde.org/D22659 AFFECTED FILES

D22617: Add view-pages-* icons, as needed in Okular for page layout selection

ndavis added a comment. In D22617#500369 , @davidhurka wrote: > Making the parts with background color transparent would be better, right? That would even work on systems which don’t access the stylesheet. Not necessarily. In Breeze,

D22617: Add view-pages-* icons, as needed in Okular for page layout selection

davidhurka added a comment. In D22617#500361 , @ndavis wrote: > In D22617#500346 , @davidhurka wrote: > > > - Why does the stylesheet need a background? > > > You only need to add the classes

D22617: Add view-pages-* icons, as needed in Okular for page layout selection

ndavis added a comment. In D22617#500346 , @davidhurka wrote: > By the way, the suggested stylesheet in https://community.kde.org/Guidelines_and_HOWTOs/Icon_Workflow_Tips#Breeze does not follow https://hig.kde.org/style/icon.html as far as I

D22617: Add view-pages-* icons, as needed in Okular for page layout selection

ngraham added a comment. These versions look great to me now. :) REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D22617 To: davidhurka, #vdg, ndavis Cc: #okular, kde-frameworks-devel, ngraham, LeGast00n, sbergeron, michaelh, bruns

D22617: Add view-pages-* icons, as needed in Okular for page layout selection

davidhurka added a comment. By the way, the suggested stylesheet in https://community.kde.org/Guidelines_and_HOWTOs/Icon_Workflow_Tips#Breeze does not follow https://hig.kde.org/style/icon.html as far as I can understand it. - Why does the stylesheet need a background? - How are the

D22658: Use non-deprecated suggestName

nicolasfella created this revision. nicolasfella added a reviewer: dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. TEST PLAN Builds REPOSITORY R239 KDELibs4Support BRANCH nd REVISION DETAIL

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 146 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/146/ Project: kf5-qt5 SUSEQt5.12 Date of build: Mon, 22 Jul 2019 16:45:03 + Build duration: 28 min and counting BUILD ARTIFACTS

D22617: Add view-pages-* icons, as needed in Okular for page layout selection

davidhurka updated this revision to Diff 62332. davidhurka added a comment. - Adapt view-pages-facing and -facing-first-centered to use ndavis' suggested files REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22617?vs=62294=62332 BRANCH

D22657: Use non-deprecated suggestName

nicolasfella created this revision. nicolasfella added a reviewer: apol. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. TEST PLAN Builds REPOSITORY R495 Purpose Library BRANCH nd REVISION DETAIL

D22617: Add view-pages-* icons, as needed in Okular for page layout selection

davidhurka retitled this revision from "Add icons for pagelayout options, as needed in Okular" to "Add view-pages-* icons, as needed in Okular for page layout selection". davidhurka edited the summary of this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL

D22656: Replace implementation of suggestName with KFileUtils::suggestName

nicolasfella created this revision. nicolasfella added a reviewer: dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY This way we avoid having duplicate code. Also remove the now unneeded

D22617: Add icons for pagelayout options, as needed in Okular

davidhurka edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D22617 To: davidhurka, #vdg, ndavis Cc: #okular, kde-frameworks-devel, ngraham, LeGast00n, sbergeron, michaelh, bruns

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.13 - Build # 14 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.13/14/ Project: kf5-qt5 SUSEQt5.13 Date of build: Mon, 22 Jul 2019 16:45:03 + Build duration: 20 min and counting BUILD ARTIFACTS

D22653: Add view-qrcode icons

ndavis requested changes to this revision. This revision now requires changes to proceed. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D22653 To: mbruchert, #breeze, ndavis Cc: ndavis, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 8 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/8/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Mon, 22 Jul 2019 16:45:03 + Build duration: 13 min and counting JUnit Tests Name: projectroot

D22653: Add view-qrcode icons

ndavis added a comment. Hi! Thanks for the patch. There are few things I'd like you to change before I accept this. The icons need optimization and colorscheme support (see workflow tips). If you have questions or need help, feel free to ask. 16px version: The margins are a pixel

D22637: Deprecate suggestName

nicolasfella updated this revision to Diff 62325. nicolasfella added a comment. - Include deprecated since - Don't build with KIOCORE_NO_DEPRECATED REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22637?vs=62271=62325 BRANCH depre REVISION DETAIL

D22638: Port internal usage of KIO::suggestName

This revision was automatically updated to reflect the committed changes. Closed by commit R241:23e5b099b0e9: Port internal usage of KIO::suggestName (authored by nicolasfella). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22638?vs=62272=62323 REVISION DETAIL

D22557: [IndexCleaner] ignore non-existent entries inside config

poboiko closed this revision. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D22557 To: poboiko, #baloo, bruns, ngraham Cc: kde-frameworks-devel, LeGast00n, sbergeron, fbampaloukas, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D22653: Add view-qrcode icons

mbruchert added a reviewer: Breeze. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D22653 To: mbruchert, #breeze Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22653: Add view-qrcode icons

mbruchert created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mbruchert requested review of this revision. REPOSITORY R266 Breeze Icons BRANCH master REVISION DETAIL https://phabricator.kde.org/D22653 AFFECTED FILES

D22647: Change Highlight to ButtonFocus in stylesheets

This revision was automatically updated to reflect the committed changes. Closed by commit R266:822b3ae3f88a: Change Highlight to ButtonFocus in stylesheets (authored by ndavis). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22647?vs=62303=62316

D22617: Add icons for pagelayout options, as needed in Okular

davidhurka added a comment. In D22617#500212 , @ndavis wrote: > In D22617#500031 , @davidhurka wrote: > > > I can’t follow you here. Centering the first page is a feature / technical detail of

D22617: Add icons for pagelayout options, as needed in Okular

ndavis added a comment. In D22617#500168 , @davidhurka wrote: > Other icons with fold in the bottom I could find: > > - document-duplicate > - document-revert-symbolic[-rtl] > - kt-restore-defaults > - password-copy > - viewpdf > -

D22617: Add icons for pagelayout options, as needed in Okular

ndavis added a comment. In D22617#500031 , @davidhurka wrote: > Makes sense, so I’m flipping snap-page now. Is that written down somewhere? Nope, it was recently decided, but I've had that in the back of my mind for a while. >

D22617: Add icons for pagelayout options, as needed in Okular

ngraham added a comment. In D22617#500141 , @davidhurka wrote: > In D22617#500131 , @ndavis wrote: > > > I'll give the latest changes a proper review in a little while. > > > > In D22617#500046

D22647: Change Highlight to ButtonFocus in stylesheets

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Yeah, and that seems like a sensible practice in general. All right, ship it! REPOSITORY R266 Breeze Icons BRANCH focus-color (branched from master) REVISION DETAIL

D22609: Add expanding spacers as a customization option for toolbars

dfaure added a comment. OK, if you don't think there is a use case, let's leave fixed-width spacers aside for now. I was wondering abour the lowercase thing, too. It looks weird. Maybe Separator should become uppercase so they can both be? REPOSITORY R263 KXmlGui BRANCH master

D22637: Deprecate suggestName

dfaure added inline comments. INLINE COMMENTS > global.h:144 > * @since 5.0 > + * @deprecated Use KFileUtils::suggestName() from KCoreAddons > */ I like it when we say when something got deprecated, like this - @deprecated since 5.61, use KFileUtils::suggestName() from KCoreAddons

D22638: Port internal usage of KIO::suggestName

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH nodeprecated REVISION DETAIL https://phabricator.kde.org/D22638 To: nicolasfella, dfaure Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22617: Add icons for pagelayout options, as needed in Okular

davidhurka added a comment. In D22617#499767 , @ndavis wrote: > Nice work! > > I know a lot of monochrome icons currently use the bottom right position for the folded corner, but I think we should start using the top right. The bottom right

D22645: [Busy Indicator] Match duration of QQC2-desktop-style version

This revision was automatically updated to reflect the committed changes. Closed by commit R236:2a7ce9862942: [Busy Indicator] Match duration of QQC2-desktop-style version (authored by ngraham). REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE

D22617: Add icons for pagelayout options, as needed in Okular

davidhurka added a comment. In D22617#500131 , @ndavis wrote: > I'll give the latest changes a proper review in a little while. > > In D22617#500046 , @davidhurka wrote: > > > What is the

D22645: [Busy Indicator] Match duration of QQC2-desktop-style version

sitter accepted this revision. This revision is now accepted and ready to land. REPOSITORY R236 KWidgetsAddons BRANCH match-duration (branched from master) REVISION DETAIL https://phabricator.kde.org/D22645 To: ngraham, sitter, #vdg Cc: kde-frameworks-devel, cfeck, LeGast00n, sbergeron,

D22647: Change Highlight to ButtonFocus in stylesheets

ndavis added a comment. In D22647#500137 , @ngraham wrote: > Right, I see that there's actually no regression. In principle, can you describe what a color scheme needs to do to avoid this situation? Use a selection background color that

D22647: Change Highlight to ButtonFocus in stylesheets

ngraham added a comment. Right, I see that there's actually no regression. In principle, can you describe what a color scheme needs to do to avoid this situation? REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D22647 To: ndavis, #vdg, ngraham Cc: ngraham,

D22647: Change Highlight to ButtonFocus in stylesheets

ndavis added a comment. In D22647#500117 , @ngraham wrote: > Whoa, huge diff. All the more reason why we need to find a way to have all the icons use a single external stylesheet. > > This will require documentation changes as well on

D22617: Add icons for pagelayout options, as needed in Okular

ndavis added a comment. I'll give the latest changes a proper review in a little while. In D22617#500046 , @davidhurka wrote: > What is the icons-dark directory good for? The icons in there are mostly just the same as in icons.

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.13 - Build # 18 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.13/18/ Project: kf5-qt5 SUSEQt5.13 Date of build: Mon, 22 Jul 2019 13:58:42 + Build duration: 11 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 141 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/141/ Project: kf5-qt5 SUSEQt5.12 Date of build: Mon, 22 Jul 2019 13:58:42 + Build duration: 11 min and counting BUILD ARTIFACTS

D22647: Change Highlight to ButtonFocus in stylesheets

ngraham requested changes to this revision. This revision now requires changes to proceed. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D22647 To: ndavis, #vdg, ngraham Cc: ngraham, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, bruns

D22647: Change Highlight to ButtonFocus in stylesheets

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Whoa, huge diff. All the more reason why we need to find a way to have all the icons use a single external stylesheet. This will require documentation changes as well on

D22647: Change Highlight to ButtonFocus in stylesheets

ndavis retitled this revision from "Change Highlight to ViewFocus in stylesheets" to "Change Highlight to ButtonFocus in stylesheets". REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D22647 To: ndavis, #vdg Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh,

D22647: Change Highlight to ViewFocus in stylesheets

ndavis updated this revision to Diff 62303. ndavis added a comment. Change ViewFocus to ButtonFocus to match some elements in the Breeze desktop theme REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22647?vs=62299=62303 BRANCH focus-color (branched

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.13 - Build # 14 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.13/14/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Mon, 22 Jul 2019 13:58:42 + Build duration: 4 min 18 sec and counting JUnit Tests

D22647: Change Highlight to ViewFocus in stylesheets

ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D22647 To: ndavis, #vdg Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22646: [Busy Indicator] Match duration of QQC2-desktop-style version

This revision was automatically updated to reflect the committed changes. Closed by commit R242:28bc0f3ea1c1: [Busy Indicator] Match duration of QQC2-desktop-style version (authored by ngraham). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE

D22647: Change Highlight to ViewFocus in stylesheets

ndavis created this revision. ndavis added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ndavis requested review of this revision. REVISION SUMMARY This fixes an issue where changing the selection background color in the colorscheme also

D22144: Add kio recentlyused:/ to access KactivitytStats data

meven updated this revision to Diff 62298. meven added a comment. Disallow getting mimetype or stating non root path REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22144?vs=61929=62298 BRANCH arcpatch-D22144 REVISION DETAIL

D22646: [Busy Indicator] Match duration of QQC2-desktop-style version

broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH match-duration (branched from master) REVISION DETAIL https://phabricator.kde.org/D22646 To: ngraham, broulik, #vdg Cc: kde-frameworks-devel, LeGast00n,

D22645: [Busy Indicator] Match duration of QQC2-desktop-style version

ngraham retitled this revision from "[Busy Indicator] Match duration of QML version" to "[Busy Indicator] Match duration of QQC2-desktop-style version". REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D22645 To: ngraham, sitter, #vdg Cc: kde-frameworks-devel,

D22646: [Busy Indicator] Match duration of QQC2-desktop-style version

ngraham created this revision. ngraham added reviewers: broulik, VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ngraham requested review of this revision. REVISION SUMMARY Match the duration (2 seconds) that was set in D22630

D22645: [Busy Indicator] Match duration of QML version

ngraham created this revision. ngraham added reviewers: sitter, VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ngraham requested review of this revision. REVISION SUMMARY Match the duration (2 seconds) that was set in D22630

D22617: Add icons for pagelayout options, as needed in Okular

davidhurka added a comment. What is the icons-dark directory good for? The icons in there are mostly just the same as in icons. And I’m a bit concerned that scour-icon removes the id="currentColorScheme" attribute from the stylesheet. How do I avoid that? REPOSITORY R266 Breeze Icons

D22617: Add icons for pagelayout options, as needed in Okular

davidhurka updated this revision to Diff 62294. davidhurka added a comment. - Rename pagelayout-* to view-pages-* REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22617?vs=62293=62294 BRANCH add-icons-for-pagelayouts REVISION DETAIL

D22617: Add icons for pagelayout options, as needed in Okular

davidhurka updated this revision to Diff 62293. davidhurka added a comment. - Remove 24px icons - Flip snap-page icons vertically, so the corner fold is at the top-right - Make pagelayout-single link to snap-page - Flip pagelayout-* icons, except pagelayout-single REPOSITORY R266

D22617: Add icons for pagelayout options, as needed in Okular

davidhurka added a comment. In D22617#499767 , @ndavis wrote: > Nice work! > > I know a lot of monochrome icons currently use the bottom right position for the folded corner, but I think we should start using the top right. The bottom

D22636: Don't persist authentication

This revision was automatically updated to reflect the committed changes. Closed by commit R39:95016c51cfc3: Dont persist authentication (authored by broulik). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D22636?vs=62270=62290#toc REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE

D22609: Add expanding spacers as a customization option for toolbars

felixernst retitled this revision from "Add spacers as a customization option for toolbars" to "Add expanding spacers as a customization option for toolbars". REPOSITORY R263 KXmlGui BRANCH master REVISION DETAIL https://phabricator.kde.org/D22609 To: felixernst, dfaure Cc: ngraham,

D22609: Add spacers as a customization option for toolbars

felixernst added a comment. You all are too kind! > Code looks fine. First try \o/ I'll put the comments that aren't directly related into another revision. I'll rename it to "--- expanding spacer ---" then. So I'll keep it lowercase and in the same style as "--- seperator

D22638: Port internal usage of KIO::suggestName

nicolasfella created this revision. nicolasfella added a reviewer: dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. TEST PLAN Builds REPOSITORY R241 KIO BRANCH nodeprecated REVISION DETAIL

  1   2   >