D22723: Fix RunnerManager::queryFinished()

fvogt added a comment. In D22723#501907 , @apol wrote: > In D22723#501690 , @fvogt wrote: > > > Looks like a hack still, with two Job objects for each job... > > > > What about just merging `QObje

D22717: Add Date term to KActivities Stats to filter on resource event date

meven updated this revision to Diff 62520. meven added a comment. Optionaly join with ResourceEvent when date filtering is being used, review feedback REPOSITORY R159 KActivities Statistics CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22717?vs=62473&id=62520 BRANCH master R

D22717: Add Date term to KActivities Stats to filter on resource event date

meven marked an inline comment as done. meven added inline comments. INLINE COMMENTS > ivan wrote in resultset.cpp:182 > setDate above is by value, here it is const-ref. Check for the size of the > type and decide on one of these. QDate size is 8 byte, so on most systems nowadays it will equal

D22717: Add Date term to KActivities Stats to filter on resource event date

meven marked 2 inline comments as done. REPOSITORY R159 KActivities Statistics REVISION DETAIL https://phabricator.kde.org/D22717 To: meven, ivan, #frameworks Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D21760: Add KListOpenFiles::listProcessesWithOpenFiles

dfaure added inline comments. INLINE COMMENTS > broulik wrote in klistopenfiles.cpp:39 > Or just make the `pidList` `const` which it should be anyway Not possible, due to the removeDuplicates() line. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D21760 To: hallas

D22717: Add Date term to KActivities Stats to filter on resource event date

meven updated this revision to Diff 62522. meven added a comment. Add an automated test on date filtering REPOSITORY R159 KActivities Statistics CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22717?vs=62520&id=62522 BRANCH master REVISION DETAIL https://phabricator.kde.org/D

D22717: Add Date term to KActivities Stats to filter on resource event date

meven edited the test plan for this revision. REPOSITORY R159 KActivities Statistics REVISION DETAIL https://phabricator.kde.org/D22717 To: meven, ivan, #frameworks Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22717: Add Date term to KActivities Stats to filter on resource event date

meven marked an inline comment as done. REPOSITORY R159 KActivities Statistics REVISION DETAIL https://phabricator.kde.org/D22717 To: meven, ivan, #frameworks Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22143: Add proper logging using ECMQtDeclareLoggingCategory

meven added a comment. @ivan What are you thoughts about this ? REPOSITORY R159 KActivities Statistics REVISION DETAIL https://phabricator.kde.org/D22143 To: meven, ivan, #frameworks Cc: kossebau, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22143: Add proper logging using ECMQtDeclareLoggingCategory

meven updated this revision to Diff 62526. meven marked 5 inline comments as done. meven added a comment. Better category name REPOSITORY R159 KActivities Statistics CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22143?vs=60786&id=62526 BRANCH arcpatch-D22143 REVISION DETAIL

D22737: xcb: Fix setStrut() for High-DPI scaling

volkov created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. volkov requested review of this revision. REVISION SUMMARY In addition to _NET_WM_STRUT setStrut() also sets _NET_WM_STRUT_PARTIAL, which requires screen's geometry in device pixe

D22737: xcb: Fix setStrut() for High-DPI scaling

volkov added a reviewer: Frameworks. REPOSITORY R278 KWindowSystem REVISION DETAIL https://phabricator.kde.org/D22737 To: volkov, #frameworks Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22723: Fix RunnerManager::queryFinished()

apol added a dependent revision: D22514: Show if KRunner is still searching for more things. REPOSITORY R308 KRunner REVISION DETAIL https://phabricator.kde.org/D22723 To: apol, #frameworks, fvogt, davidedmundson Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22714: Add missing KIOWIDGETS_NO_DEPRECTAED check

This revision was automatically updated to reflect the committed changes. Closed by commit R241:22179dfeb576: Add missing KIOWIDGETS_NO_DEPRECTAED check (authored by nicolasfella). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22714?vs=62467&id=62532 REVISION DE

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 13 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/13/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Thu, 25 Jul 2019 12:09:26 + Build duration: 9 min 25 sec and counting JUnit Tests Name: projectroo

D22580: Notify users when not using KDE_INSTALL_USE_QT_SYS_PATHS about prefix.sh

This revision was automatically updated to reflect the committed changes. Closed by commit R240:685959c3fa78: Notify users when not using KDE_INSTALL_USE_QT_SYS_PATHS about prefix.sh (authored by apol). REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org

KDE CI: Frameworks » kpackage » kf5-qt5 FreeBSDQt5.13 - Build # 6 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20FreeBSDQt5.13/6/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Thu, 25 Jul 2019 12:29:35 + Build duration: 48 sec and counting JUnit Tests Name: projectroot

D22737: xcb: Fix setStrut() for High-DPI scaling

apol added inline comments. INLINE COMMENTS > kwindowsystem.cpp:75 > +const qreal dpr = screen->devicePixelRatio(); > +region += QRect(geometry.topLeft() * dpr, geometry.size() * dpr); > } I don't think that it makes sense to multiply topLeft by dpr, since dpr is

D22737: xcb: Fix setStrut() for High-DPI scaling

volkov added inline comments. INLINE COMMENTS > apol wrote in kwindowsystem.cpp:75 > I don't think that it makes sense to multiply topLeft by dpr, since dpr is > local to the screen you're treating. > > How have you tested this? Only on a single screen. Thanks for notice. REPOSITORY R278 KW

D22737: xcb: Fix setStrut() for High-DPI scaling

volkov updated this revision to Diff 62536. volkov added a comment. fixed REPOSITORY R278 KWindowSystem CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22737?vs=62531&id=62536 BRANCH master REVISION DETAIL https://phabricator.kde.org/D22737 AFFECTED FILES src/platforms/xcb

D22487: Offer metadata.json when requesting the package metadata

This revision was automatically updated to reflect the committed changes. Closed by commit R290:40556d1ceae6: Offer metadata.json when requesting the package metadata (authored by apol). REPOSITORY R290 KPackage CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22487?vs=61851&id=62537

Re: Qt dependency policy

On Sun, Jul 21, 2019 at 12:55 PM David Faure wrote: > > Taking into account the feedback from the SUSE packagers > (about how dropping support for Qt 5.9 LTS the very month Qt 5.12 LTS comes > out is a problem since not everyone can upgrade to Qt 5.12 LTS right away) > I have modified the policy t

D22733: Delete redundant and monochrome versions of applications-internet

ngraham added a comment. Good idea. I'll submit patches for them and get them in before this lands. REPOSITORY R266 Breeze Icons BRANCH only-colorful-applications-intetnet-icon (branched from master) REVISION DETAIL https://phabricator.kde.org/D22733 To: ngraham, #vdg, ndavis Cc: kde-

D22083: introduce concept of header and footer for kpageview

This revision was automatically updated to reflect the committed changes. Closed by commit R236:b581c5f990a6: introduce concept of header and footer for kpageview (authored by mart). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D22083?vs=61844&id=62554#toc REPOSITORY R236 KWidgetsAddo

D22083: introduce concept of header and footer for kpageview

mart added a comment. In D22083#498499 , @hpereiradacosta wrote: > Looking into kcmultidialog, it seems there is some internal handling of margins in there, for a reason unknown to me. Maybe you want to investigate there too (in a different pat

D22717: Add Date term to KActivities Stats to filter on resource event date

ivan added inline comments. INLINE COMMENTS > resultset.cpp:293 > SELECT > -rl.targettedResource as resource > - , SUM(rsc.cachedScore) as score > - , MIN(rsc.firstUpdate) as firstUpdate > - , MAX(rsc.lastUpdate) as lastUpdate >

D22143: Add proper logging using ECMQtDeclareLoggingCategory

ivan added a comment. If @kossebau is satisfied, go for it REPOSITORY R159 KActivities Statistics REVISION DETAIL https://phabricator.kde.org/D22143 To: meven, ivan, #frameworks Cc: kossebau, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22143: Add proper logging using ECMQtDeclareLoggingCategory

ivan added a reviewer: kossebau. REPOSITORY R159 KActivities Statistics REVISION DETAIL https://phabricator.kde.org/D22143 To: meven, ivan, #frameworks, kossebau Cc: kossebau, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22143: Add proper logging using ECMQtDeclareLoggingCategory

kossebau added a comment. Nope, current solution does not satisfy my personal standards, sorry :) Relying on undocumented names of generated sources files does not get my +1. That needs someone else to take responsibility :) If transfering the name via variables s not possible, I would

D22717: Add Date term to KActivities Stats to filter on resource event date

meven marked 3 inline comments as done. meven added inline comments. INLINE COMMENTS > ivan wrote in resultset.cpp:293 > Any reason for the rename? It is so that the ResourceEvent join in resourceEventJoinClause works with every sql request. Other wise I would have needed a parameter or multip

D22717: Add Date term to KActivities Stats to filter on resource event date

meven marked 2 inline comments as done. REPOSITORY R159 KActivities Statistics REVISION DETAIL https://phabricator.kde.org/D22717 To: meven, ivan, #frameworks Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22708: [WIP] Add a kded module infra for fuse mount services

andriusr added inline comments. INLINE COMMENTS > CMakeLists.txt:19 > add_subdirectory(kcms) > +add_subdirectory(mountserviced) > should we restrict platforms here? (e.g.: NOT WIN32, NOT ANDROID). There are fuse wrappers such as winfsp's or dokany's, but possibly those should not work there

D22747: Fix KCMulti sidebar margins

ngraham created this revision. ngraham added a reviewer: mart. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ngraham requested review of this revision. REVISION SUMMARY Just need to set the face type to `List`. TEST PLAN F7096922: kcmulti.png

D22143: Add proper logging using ECMQtDeclareLoggingCategory

meven added a comment. > Relying on undocumented names of generated sources files does not get my +1. That needs someone else to take responsibility :) Well this kind of file generation is common and is indirectly documented through the ecm_qt_declare_logging_category macro. I don

D22143: Add proper logging using ECMQtDeclareLoggingCategory

kossebau added a comment. In D22143#502314 , @meven wrote: > > Relying on undocumented names of generated sources files does not get my +1. That needs someone else to take responsibility :) > > Well this kind of file generation is common an

metadata editor (and API) for KDE save file dialog?

Hi, Has it ever been considered to add a (pop-up) widget to the save file dialog that would allow to specify metadata key/value pairs when saving a file, plus the corresponding API so apps can set it too? For instance, when a browser downloads a file on Mac it will add a Spotlight attribute (r

D22723: Fix RunnerManager::queryFinished()

aacid added a comment. I honestly don't see the problem with this patch, one may argue that the ThreadWeaver API is awkward, ok, but this is using it correctly AFAICS, i.e. have a ThreadWeaver::QObjectDecorator, give it a ThreadWeaver::Job on its constructor, and go on from there. REPOSITOR

D22750: CMakeLists.txt: Allow setting UDEV_RULES_INSTALL_DIR when building

alistairf created this revision. alistairf added a reviewer: drosca. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. alistairf requested review of this revision. REVISION SUMMARY Allow the user to overwrite UDEV_RULES_INSTALL_DIR when building. This allows

D22751: KTar::openArchive: Remove "bad" assert

aacid created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. aacid requested review of this revision. REVISION SUMMARY There's nothing the caller of this function can do to control the assert condition, so asserting is "too rude", and on top

D22750: CMakeLists.txt: Allow setting UDEV_RULES_INSTALL_DIR when building

arojas added a comment. Why is this needed? This is working already as is (that's what the CACHE flag is for) REPOSITORY R269 BluezQt REVISION DETAIL https://phabricator.kde.org/D22750 To: alistairf, drosca Cc: arojas, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22750: CMakeLists.txt: Allow setting UDEV_RULES_INSTALL_DIR when building

alistairf added a comment. Ah, you are right. I didn't realise that. This appears to not be needed. REPOSITORY R269 BluezQt REVISION DETAIL https://phabricator.kde.org/D22750 To: alistairf, drosca Cc: arojas, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22750: CMakeLists.txt: Allow setting UDEV_RULES_INSTALL_DIR when building

alistairf abandoned this revision. alistairf added a comment. Not required REPOSITORY R269 BluezQt REVISION DETAIL https://phabricator.kde.org/D22750 To: alistairf, drosca Cc: arojas, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22755: [platforms/xcb] Use XRES extension to get real window PID

davidedmundson created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. davidedmundson requested review of this revision. REVISION SUMMARY It's increasingly common for apps to be in their own PID namespace. If this is the case, they report a b

D22747: Fix KCMulti sidebar margins

apol added a comment. KPageDialog says that with Auto it will behave like a List if just a List of pages are passed. Maybe it's a problem there? REPOSITORY R295 KCMUtils REVISION DETAIL https://phabricator.kde.org/D22747 To: ngraham, mart Cc: apol, kde-frameworks-devel, LeGast00n, sberg

D22751: KTar::openArchive: Remove "bad" assert

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R243 KArchive BRANCH master REVISION DETAIL https://phabricator.kde.org/D22751 To: aacid, apol Cc: dfaure, kde-frameworks-devel, apol, LeGast00n, sbergeron, michaelh, ngraham, bruns