D23034: implicit fallthough if there is fallthoughContext

dhaumann requested changes to this revision. dhaumann added a comment. I like this change a lot, but there is a huge (theoretical) backwards compatibility issue with this. Before, the code ignored `fallthroughContext` if `m_fallthrough` was explicitly set to `false`. So you could have: f

D23034: implicit fallthough if there is fallthoughContext

cullmann added a comment. Hmm, isn't any file with some fallthrough=false but a fallthrough context just buggy? Did any of our files have that? REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D23034 To: jpoelen, #framework_syntax_highlighting, dhaumann, c

D23019: Make notification icons look like bells

broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH notification-icons (branched from master) REVISION DETAIL https://phabricator.kde.org/D23019 To: ndavis, #vdg, #plasma, broulik, ngraham Cc: ngraham, broulik,

D23019: Make notification icons look like bells

This revision was automatically updated to reflect the committed changes. Closed by commit R242:134b2ac331d3: Make notification icons look like bells (authored by ndavis, committed by ngraham). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D

KDE CI: Frameworks » solid » kf5-qt5 FreeBSDQt5.13 - Build # 8 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20FreeBSDQt5.13/8/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Fri, 09 Aug 2019 13:46:45 + Build duration: 6 min 57 sec and counting JUnit Tests Name: projectro

D22884: [RFC] Don't show title on page by default

GB_2 accepted this revision. GB_2 added a comment. In D22884#507052 , @ngraham wrote: > This patch simply adjusts the defaults. If we decide to do this, KCMShell can be adjusted to show the title on the page when showing a single KCM. But even t

D23047: Properly turn real into integer

apol created this revision. apol added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. apol requested review of this revision. REPOSITORY R302 KIconThemes BRANCH master REVISION DETAIL https://phabricator.kde.org/D23047 AFFECTED

D23034: implicit fallthough if there is fallthoughContext

nibags added a comment. I think it's an improvement, but the ideal would be to maintain support for `fallthrough="bool"`. That is, if the `fallthroughContext` attribute is present, assume `fallthrough="true"`, unless "fallthrough=" is explicitly written. What I don't agree with is modif

D23051: Make file bookmark names consistent

guoyunhe created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. guoyunhe requested review of this revision. REVISION SUMMARY Other bookmarks don't have "Files", like "Videos", "Documents". So "Audio Files" should be changed to "Audio". REPOS

D23034: implicit fallthough if there is fallthoughContext

cullmann added a comment. Sounds like a reasonable solution. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D23034 To: jpoelen, #framework_syntax_highlighting, dhaumann, cullmann Cc: nibags, kwrite-devel, kde-frameworks-devel, univerz, LeGast00n, domson,

D23051: Make file bookmark names consistent

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D23051 To: guoyunhe, ngraham Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D23051: Make file bookmark names consistent

This revision was automatically updated to reflect the committed changes. Closed by commit R241:b8a4c2223453: Make file bookmark names consistent (authored by Guo Yunhe ). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23051?vs=63431&id=63441 RE

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 25 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/25/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Fri, 09 Aug 2019 18:08:31 + Build duration: 8 min 33 sec and counting JUnit Tests Name: projectroo

D23061: Possiblity to change Definition data after loading

sirgienko created this revision. sirgienko added reviewers: dhaumann, cullmann. sirgienko added a project: Framework: Syntax Highlighting. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. sirgienko requested review of this revision. REPOSITORY

D23061: Possiblity to change Definition data after loading

sirgienko added inline comments. INLINE COMMENTS > keywordlist_p.h:73 > +m_keywords.removeAll(keyword); > +initLookupForCaseSensitivity(m_caseSensitive); > +} Not sure about this realization, I think, we could modify it without lookuping all data. REPOSITORY R216 Syntax H

D23061: Possiblity to change Definition data after loading

cullmann added a comment. Actually, wouldn't it make more sense to just provide a way to set the full keyword list? You can get the QStringlist will all keywords already with keywordList, a setKeywordList(...) would make more sense to me than this modifiers. That would allow to alter it l

D23062: Disable KCONFIG_USE_DBUS on Android

nicolasfella created this revision. nicolasfella added reviewers: apol, vkrause. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY Since DBus is not available on Android we don't ever want it enab

D23061: Possiblity to change Definition data after loading

sirgienko added a comment. In D23061#509540 , @cullmann wrote: > Actually, wouldn't it make more sense to just provide a way to set the full keyword list? > You can get the QStringlist will all keywords already with keywordList, a setKeywordL

D23034: implicit fallthough if there is fallthoughContext

jpoelen added a comment. I will hand over the original xml files, that seems preferable to me too. I did not see `fallthrough="false"` nor `fallthrough="0"`. But after checking, `brightscript.xml` uses` fallthroughContext` twice without `fallthrough`. in my opinion, it's an oblivion with

D23034: implicit fallthough if there is fallthoughContext

jpoelen updated this revision to Diff 63455. jpoelen added a comment. - don't modify the *.xml files to maintain the compatibility in older versions of KF5 - langauge.xsd: accept only 1 or true for fallthrough attribute REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE http

D23034: implicit fallthough if there is fallthoughContext

dhaumann accepted this revision. dhaumann added a comment. I think this is much better. For KF6, we can remove it in the xml files as well or so... Besides that: why does the diff show so many changes even though it's just about fall through? It makes the review harder (especially on a s