D24490: Make kconfig_compiler generate ctors with the optional parent arg

2019-10-10 Thread Kevin Ottens
ervin added a comment. Ah I see what you meant now. I'd rather not do this, it's IMO better if we remove the setting completely when KF6 comes. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D24490 To: ervin, #plasma, #frameworks, dfaure, mart, apol Cc: kossebau, ap

D24554: Don't build static library when BUILD_TESTING=OFF

2019-10-10 Thread Antonio Rojas
arojas created this revision. arojas added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. arojas requested review of this revision. REVISION SUMMARY Since the static library is only used for autotests, don't waste CPU cycles when not

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.13 - Build # 136 - Fixed!

2019-10-10 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.13/136/ Project: kf5-qt5 SUSEQt5.13 Date of build: Fri, 11 Oct 2019 02:48:54 + Build duration: 1 hr 39 min and counting BUILD ARTIFACTS acc/KF5KIO-5.63.0.x

KDE CI: Frameworks » kcmutils » kf5-qt5 SUSEQt5.13 - Build # 25 - Fixed!

2019-10-10 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kcmutils/job/kf5-qt5%20SUSEQt5.13/25/ Project: kf5-qt5 SUSEQt5.13 Date of build: Fri, 11 Oct 2019 02:49:04 + Build duration: 1 hr 36 min and counting BUILD ARTIFACTS abi-compatibili

KDE CI: Frameworks » baloo » kf5-qt5 FreeBSDQt5.13 - Build # 27 - Fixed!

2019-10-10 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20FreeBSDQt5.13/27/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Fri, 11 Oct 2019 02:25:32 + Build duration: 1 hr 56 min and counting JUnit Tests Name: projectroo

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 123 - Still Unstable!

2019-10-10 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/123/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Fri, 11 Oct 2019 02:25:29 + Build duration: 1 hr 52 min and counting JUnit Tests Name: projectroo

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.13 - Build # 24 - Unstable!

2019-10-10 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.13/24/ Project: kf5-qt5 SUSEQt5.13 Date of build: Fri, 11 Oct 2019 02:48:54 + Build duration: 1 hr 27 min and counting BUILD ARTIFACTS abi-compatibil

KDE CI: Frameworks » purpose » kf5-qt5 SUSEQt5.13 - Build # 62 - Fixed!

2019-10-10 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/purpose/job/kf5-qt5%20SUSEQt5.13/62/ Project: kf5-qt5 SUSEQt5.13 Date of build: Fri, 11 Oct 2019 03:32:12 + Build duration: 42 min and counting BUILD ARTIFACTS acc/KF5Purpose-5.63.0

KDE CI: Frameworks » kwayland » kf5-qt5 FreeBSDQt5.13 - Build # 23 - Still Unstable!

2019-10-10 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20FreeBSDQt5.13/23/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Fri, 11 Oct 2019 02:25:28 + Build duration: 1 hr 46 min and counting JUnit Tests Name: projec

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.13 - Build # 41 - Still Unstable!

2019-10-10 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.13/41/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Fri, 11 Oct 2019 02:25:27 + Build duration: 1 hr 33 min and counting JUnit Tests Name: pro

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.13 - Build # 44 - Unstable!

2019-10-10 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.13/44/ Project: kf5-qt5 SUSEQt5.13 Date of build: Fri, 11 Oct 2019 02:48:50 + Build duration: 59 min and counting BUILD ARTIFACTS abi-compatibilit

KDE CI: Frameworks » purpose » kf5-qt5 SUSEQt5.12 - Build # 127 - Unstable!

2019-10-10 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/purpose/job/kf5-qt5%20SUSEQt5.12/127/ Project: kf5-qt5 SUSEQt5.12 Date of build: Fri, 11 Oct 2019 03:32:12 + Build duration: 9 min 37 sec and counting BUILD ARTIFACTS acc/KF5Purpos

KDE CI: Frameworks » solid » kf5-qt5 FreeBSDQt5.13 - Build # 25 - Still Unstable!

2019-10-10 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20FreeBSDQt5.13/25/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Fri, 11 Oct 2019 02:25:06 + Build duration: 57 min and counting JUnit Tests Name: projectroot Fa

KDE CI: Frameworks » purpose » kf5-qt5 SUSEQt5.13 - Build # 61 - Still Unstable!

2019-10-10 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/purpose/job/kf5-qt5%20SUSEQt5.13/61/ Project: kf5-qt5 SUSEQt5.13 Date of build: Fri, 11 Oct 2019 02:48:15 + Build duration: 28 min and counting BUILD ARTIFACTS acc/KF5Purpose-5.63.

KDE CI: Frameworks » kpty » kf5-qt5 FreeBSDQt5.13 - Build # 14 - Still Unstable!

2019-10-10 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kpty/job/kf5-qt5%20FreeBSDQt5.13/14/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Fri, 11 Oct 2019 02:24:35 + Build duration: 39 min and counting JUnit Tests Name: projectroot Fai

KDE CI: Frameworks » kimageformats » kf5-qt5 FreeBSDQt5.13 - Build # 14 - Still Unstable!

2019-10-10 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kimageformats/job/kf5-qt5%20FreeBSDQt5.13/14/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Fri, 11 Oct 2019 02:24:32 + Build duration: 32 min and counting JUnit Tests Name: projec

KDE CI: Frameworks » kpackage » kf5-qt5 FreeBSDQt5.13 - Build # 18 - Still Unstable!

2019-10-10 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20FreeBSDQt5.13/18/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Fri, 11 Oct 2019 02:24:29 + Build duration: 26 min and counting JUnit Tests Name: projectroot

KDE CI: Frameworks » kservice » kf5-qt5 FreeBSDQt5.13 - Build # 37 - Still Unstable!

2019-10-10 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kservice/job/kf5-qt5%20FreeBSDQt5.13/37/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Fri, 11 Oct 2019 02:24:29 + Build duration: 22 min and counting JUnit Tests Name: projectroot

KDE CI: Frameworks » kcalendarcore » kf5-qt5 FreeBSDQt5.13 - Build # 13 - Still Unstable!

2019-10-10 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcalendarcore/job/kf5-qt5%20FreeBSDQt5.13/13/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Fri, 11 Oct 2019 02:24:28 + Build duration: 15 min and counting JUnit Tests Name: projec

KDE CI: Frameworks » kdelibs4support » kf5-qt5 FreeBSDQt5.13 - Build # 34 - Still Unstable!

2019-10-10 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20FreeBSDQt5.13/34/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Fri, 11 Oct 2019 02:24:28 + Build duration: 12 min and counting JUnit Tests Name: proj

KDE CI: Frameworks » kdesu » kf5-qt5 FreeBSDQt5.13 - Build # 12 - Still Unstable!

2019-10-10 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kdesu/job/kf5-qt5%20FreeBSDQt5.13/12/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Fri, 11 Oct 2019 02:24:26 + Build duration: 2 min 34 sec and counting JUnit Tests Name: projectr

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.13 - Build # 40 - Still Unstable!

2019-10-10 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.13/40/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Fri, 11 Oct 2019 01:22:07 + Build duration: 3 min 58 sec and counting JUnit Tests Name: pr

KDE CI: Frameworks » kcoreaddons » kf5-qt5 AndroidQt5.13 - Build # 41 - Fixed!

2019-10-10 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20AndroidQt5.13/41/ Project: kf5-qt5 AndroidQt5.13 Date of build: Fri, 11 Oct 2019 01:22:07 + Build duration: 1 min 14 sec and counting

KDE CI: Frameworks » kdelibs4support » kf5-qt5 FreeBSDQt5.13 - Build # 33 - Still Unstable!

2019-10-10 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20FreeBSDQt5.13/33/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Fri, 11 Oct 2019 00:21:58 + Build duration: 3 min 32 sec and counting JUnit Tests Name

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.13 - Build # 135 - Unstable!

2019-10-10 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.13/135/ Project: kf5-qt5 SUSEQt5.13 Date of build: Thu, 10 Oct 2019 23:05:48 + Build duration: 26 min and counting BUILD ARTIFACTS acc/KF5KIO-5.63.0.xmllo

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 252 - Unstable!

2019-10-10 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/252/ Project: kf5-qt5 SUSEQt5.12 Date of build: Thu, 10 Oct 2019 23:05:48 + Build duration: 19 min and counting BUILD ARTIFACTS acc/KF5KIO-5.63.0.xmllo

D22362: Port keystates to use QtWayland's generator

2019-10-10 Thread Aleix Pol Gonzalez
apol updated this revision to Diff 67671. apol added a comment. Unnecessary change REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22362?vs=67670&id=67671 BRANCH arcpatch-D22362 REVISION DETAIL https://phabricator.kde.org/D22362 AFFECTED FILES CMak

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 122 - Still Unstable!

2019-10-10 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/122/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Thu, 10 Oct 2019 23:05:47 + Build duration: 11 min and counting JUnit Tests Name: projectroot Fai

D22362: Port keystates to use QtWayland's generator

2019-10-10 Thread Aleix Pol Gonzalez
apol updated this revision to Diff 67670. apol added a comment. Just don't use KWayland::Global Lets generated code do its thing already REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22362?vs=61478&id=67670 BRANCH arcpatch-D22362 REVISION DETAIL

D22362: Port keystates to use QtWayland's generator

2019-10-10 Thread Aleix Pol Gonzalez
apol added a comment. In D22362#493722 , @davidedmundson wrote: > As some background: > > At a recent Plasma sprint, one comment was that adding protocols to KWayland was an absolute pain involving writing a tonne of boiler plate. My experi

D24465: Use ECMGenerateExportHeader to manage deprecated API better

2019-10-10 Thread Friedrich W. H. Kossebau
kossebau added inline comments. INLINE COMMENTS > zzag wrote in netwm_def.h:336-339 > This one should be wrapped in `#if KWINDOWSYSTEM_ENABLE_DEPRECATED_SINCE(5, > 0)`, right? Hmm... I should have checked the patch after uploading. IIRC I initially had this guarded here, same with the Override

D24465: Use ECMGenerateExportHeader to manage deprecated API better

2019-10-10 Thread Vlad Zahorodnii
zzag added inline comments. INLINE COMMENTS > netwm_def.h:336-339 > /** > @deprecated has unclear meaning and is KDE-only > **/ > Override = 6, // NON STANDARD This one should be wrapped in `#if KWINDOWSYSTEM_ENABLE_DEPRECATED_SINCE(5, 0)`, right? REP

D23800: Use ECMGenerateExportHeader to manage deprecated API better

2019-10-10 Thread Friedrich W. H. Kossebau
This revision was automatically updated to reflect the committed changes. Closed by commit R244:76d89c91e05f: Use ECMGenerateExportHeader to manage deprecated API better (authored by kossebau). REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23800?vs=67221&

KDE CI: Frameworks » knotifications » kf5-qt5 WindowsMSVCQt5.13 - Build # 22 - Aborted!

2019-10-10 Thread CI System
BUILD ABORTED Build URL https://build.kde.org/job/Frameworks/job/knotifications/job/kf5-qt5%20WindowsMSVCQt5.13/22/ Project: kf5-qt5 WindowsMSVCQt5.13 Date of build: Sun, 06 Oct 2019 09:37:25 + Build duration: 4 days 11 hr and counting

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.13 - Build # 39 - Still Unstable!

2019-10-10 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.13/39/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Thu, 10 Oct 2019 21:06:56 + Build duration: 12 min and counting JUnit Tests Name: projectr

D23802: Use ECMGenerateExportHeader to manage deprecated API better

2019-10-10 Thread Friedrich W. H. Kossebau
kossebau added a comment. If no-one objects, would be pushing on Monday evening, Oct. 14th. REPOSITORY R309 KService REVISION DETAIL https://phabricator.kde.org/D23802 To: kossebau, #frameworks, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24465: Use ECMGenerateExportHeader to manage deprecated API better

2019-10-10 Thread Friedrich W. H. Kossebau
kossebau added a comment. If no-one objects, would be pushing on Monday evening, Oct. 14th. REPOSITORY R278 KWindowSystem REVISION DETAIL https://phabricator.kde.org/D24465 To: kossebau, #frameworks, #kwin, dfaure, zzag Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24466: Use ECMGenerateExportHeader to manage deprecated API better

2019-10-10 Thread Friedrich W. H. Kossebau
kossebau added a comment. If no-one objects, would be pushing on Monday evening, Oct. 14th. REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D24466 To: kossebau, #frameworks, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24467: Use ECMGenerateExportHeader to manage deprecated API better

2019-10-10 Thread Friedrich W. H. Kossebau
kossebau added a comment. If no-one objects, would be pushing on Monday evening, Oct. 14th. REPOSITORY R306 KParts REVISION DETAIL https://phabricator.kde.org/D24467 To: kossebau, #frameworks, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24468: Use ECMGenerateExportHeader to manage deprecated API better

2019-10-10 Thread Friedrich W. H. Kossebau
kossebau added a comment. If no-one objets, would be pushing on Monday evening, Oct. 14th. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D24468 To: kossebau, #frameworks, cfeck Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kcoreaddons » kf5-qt5 AndroidQt5.13 - Build # 40 - Failure!

2019-10-10 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20AndroidQt5.13/40/ Project: kf5-qt5 AndroidQt5.13 Date of build: Thu, 10 Oct 2019 21:06:55 + Build duration: 51 sec and counting CONSOLE OUTPUT [...truncate

D23802: Use ECMGenerateExportHeader to manage deprecated API better

2019-10-10 Thread Friedrich W. H. Kossebau
kossebau updated this revision to Diff 67655. kossebau added a comment. tests no longer need to unset KSERVICE_DEPRECATED REPOSITORY R309 KService CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23802?vs=67222&id=67655 BRANCH useECMGenerateExportHeader REVISION DETAIL https:/

D23789: Add ECMGenerateExportHeader, for improved handling of deprecated API

2019-10-10 Thread Friedrich W. H. Kossebau
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R240:7b15c20dafc9: Add ECMGenerateExportHeader, for improved handling of deprecated API (authored by kossebau). CHANGED PRI

D23789: Add ECMGenerateExportHeader, for improved handling of deprecated API

2019-10-10 Thread Friedrich W. H. Kossebau
kossebau added a comment. To keep the momentum, now going to merge, given there was no objection when I pointed out the plan to move forward both here and in the email to frameworks-devel. I assume no-one has time enough to wrap their brain around this as well and/or too many other competi

D24540: [Database] Disable read-ahead to reduce thrashing

2019-10-10 Thread Nathaniel Graham
ngraham added a reviewer: bruns. ngraham added a subscriber: bruns. ngraham added a comment. @bruns, does this make sense to you? REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D24540 To: hurikhan77, ngraham, #baloo, bruns Cc: bruns, kde-frameworks-devel, ngraham, #bal

D24539: [Database] Rework handling environment flags

2019-10-10 Thread Nathaniel Graham
ngraham added a comment. This doesn't apply cleanly on master. Can you rebase it? Also it would be nice to use `arc` to submit patches: https://community.kde.org/Infrastructure/Phabricator#Using_Arcanist REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D24539 To: h

D22365: KNotification macOS native support by NSNotificationCenter

2019-10-10 Thread Weixuan Xiao
Inoki closed this revision. Inoki added a comment. Landed: https://cgit.kde.org/knotifications.git/commit/?id=58caf6ad5b48aa573a6d3b8d3e23e07afce8a03f REVISION DETAIL https://phabricator.kde.org/D22365 To: Inoki, rjvbb, nicolasfella Cc: lnj, nicolasfella, broulik, kde-frameworks-devel, L

D24540: [Database] Disable read-ahead to reduce thrashing

2019-10-10 Thread Kai Krakow
hurikhan77 added a reviewer: Baloo. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D24540 To: hurikhan77, ngraham, #baloo Cc: kde-frameworks-devel, ngraham, #baloo, hurikhan77, lots0logs, LeGast00n, fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun,

D24539: [Database] Rework handling environment flags

2019-10-10 Thread Kai Krakow
hurikhan77 added a reviewer: Baloo. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D24539 To: hurikhan77, ngraham, #baloo Cc: kde-frameworks-devel, ngraham, #baloo, hurikhan77, lots0logs, LeGast00n, fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun,

D24537: Icons for windy weather

2019-10-10 Thread Nathaniel Graham
ngraham added a dependent revision: D24483: [Weather data engine] Handle windy conditions in NOAA backend. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D24537 To: cblack, #vdg Cc: kossebau, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D24537: Icons for windy weather

2019-10-10 Thread Nathaniel Graham
ngraham added a comment. That was my impression too, but upon further examination, the `noaa_i18n.dat` file has strings that indicate windyness in addition to other conditions, and if I add a complex conditional to the data engine, I can see that the windy + cloudy condition is getting hit (

D24537: Icons for windy weather

2019-10-10 Thread Friedrich W. H. Kossebau
kossebau added a comment. Thanks for the icon work. I fear some info here though has been lost: what is needed is an icon which describes "windy weather" in general, where we have no other info about whether it is cloudy, sunny or not. At least by what I understood from D24483

D24537: Icons for windy weather

2019-10-10 Thread Nathaniel Graham
ngraham added a comment. Also one more thing, sorry: `-wind` should go before `-night` in the night versions. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D24537 To: cblack, #vdg Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D24537: Icons for windy weather

2019-10-10 Thread Nathaniel Graham
ngraham added a comment. Nice! Looks like there are some gaps in the windy overcast icon: F7568360: gaps.png Also I wonder if the wind gust lines might look better if they were moved two pixels to the right. When there are clouds, the right-mos

D24537: Icons for windy weather

2019-10-10 Thread Nathaniel Graham
ngraham edited the summary of this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D24537 To: cblack, #vdg Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24540: [Database] Disable read-ahead to reduce thrashing

2019-10-10 Thread Kai Krakow
hurikhan77 added a dependency: D24539: [Database] Rework handling environment flags. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D24540 To: hurikhan77, ngraham Cc: kde-frameworks-devel, ngraham, #baloo, lots0logs, LeGast00n, fbampaloukas, GB_2, domson, ashaposhnikov,

D24539: [Database] Rework handling environment flags

2019-10-10 Thread Kai Krakow
hurikhan77 added a dependent revision: D24540: [Database] Disable read-ahead to reduce thrashing. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D24539 To: hurikhan77, ngraham Cc: kde-frameworks-devel, ngraham, #baloo, lots0logs, LeGast00n, fbampaloukas, GB_2, domson, as

D24540: [Database] Disable read-ahead to reduce thrashing

2019-10-10 Thread Kai Krakow
hurikhan77 created this revision. hurikhan77 added a reviewer: ngraham. hurikhan77 added a project: Baloo. Herald added a project: Frameworks. Herald added subscribers: Baloo, kde-frameworks-devel. hurikhan77 requested review of this revision. REVISION SUMMARY Prevent filesystem thrashing in low

D24539: [Database] Rework handling environment flags

2019-10-10 Thread Kai Krakow
hurikhan77 created this revision. hurikhan77 added a reviewer: ngraham. hurikhan77 added a project: Baloo. Herald added a project: Frameworks. Herald added subscribers: Baloo, kde-frameworks-devel. hurikhan77 requested review of this revision. REVISION SUMMARY This will keep the code of the foll

D24538: [Database] Disable read-ahead to prevent thrashing

2019-10-10 Thread Kai Krakow
hurikhan77 abandoned this revision. hurikhan77 added a comment. My submission didn't work as expected... REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D24538 To: hurikhan77, ngraham Cc: kde-frameworks-devel, ngraham, #baloo, lots0logs, LeGast00n, fbampaloukas, GB_2,

D24538: [Database] Disable read-ahead to prevent thrashing

2019-10-10 Thread Kai Krakow
hurikhan77 updated this revision to Diff 67627. hurikhan77 retitled this revision from "[Database] Rework handling environment flags" to "[Database] Disable read-ahead to prevent thrashing". hurikhan77 edited the summary of this revision. hurikhan77 added a comment. Prevent filesystem thrashin

D24538: [Database] Rework handling environment flags

2019-10-10 Thread Kai Krakow
hurikhan77 created this revision. hurikhan77 added a reviewer: ngraham. hurikhan77 added a project: Baloo. Herald added a project: Frameworks. Herald added subscribers: Baloo, kde-frameworks-devel. hurikhan77 requested review of this revision. REVISION SUMMARY This will keep the code of the foll

D24537: Icons for windy weather

2019-10-10 Thread Carson Black
cblack edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D24537 To: cblack, #vdg Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24537: Icons for windy weather

2019-10-10 Thread Carson Black
cblack created this revision. cblack added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. cblack requested review of this revision. REVISION SUMMARY There are now icons to represent windy weather. REPOSITORY R266 Breeze Icons BRANCH wi

Re: Akonadi SchemaVersionTable is broken with PostgreSQL Version 12 changes

2019-10-10 Thread Stuart
Thanks, Done. bug 412818 https://bugs.kde.org/show_bug.cgi?id=412818 On Thu, Oct 10, 2019 at 11:53 AM Harald Sitter wrote: > Hey, > > Please file bug reports about issues: > https://bugs.kde.org/enter_bug.cgi?product=Akonadi > > On Thu, Oct 10, 2019 at 12:29 AM Stuart wrote: > > > > Dear devel

D24355: TypeScript: update grammar and fixes

2019-10-10 Thread Nibaldo González
This revision was automatically updated to reflect the committed changes. Closed by commit R216:c6f2bd8ba96d: TypeScript: update grammar and fixes (authored by nibags). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24355?vs=67588&id=67624 REVISIO

D23789: Add ECMGenerateExportHeader, for improved handling of deprecated API

2019-10-10 Thread Friedrich W. H. Kossebau
kossebau updated this revision to Diff 67620. kossebau marked an inline comment as done. kossebau added a comment. switch to do generation-time decision about deprecated(text) attribute usage GCC/Clang are mostly ABI-compatible, so mixing and linking of artifacts from both compilers can

D23789: Add ECMGenerateExportHeader, for improved handling of deprecated API

2019-10-10 Thread Friedrich W. H. Kossebau
kossebau retitled this revision from "Add ECMGenerateExportHeaders, for improved handling of deprecated API" to "Add ECMGenerateExportHeader, for improved handling of deprecated API". REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D23789 To: kossebau, #fram

D24490: Make kconfig_compiler generate ctors with the optional parent arg

2019-10-10 Thread Aleix Pol Gonzalez
apol added a comment. #if FRAMEWORK_VERSION < 6 defaultValue = false #else defaultValue = true #endif Or at least #if FRAMEWORK_VERSION >= 6 #pragma message Consider enabling ParentInConstructor by default #endif It's just a thought, not necessary. REPOSITORY R237 KCo

D24494: Add convenience for defaults/dirty states to KCoreConfigSkeleton

2019-10-10 Thread Kevin Ottens
ervin updated this revision to Diff 67597. ervin added a comment. Add the KF6 comment REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24494?vs=67522&id=67597 REVISION DETAIL https://phabricator.kde.org/D24494 AFFECTED FILES autotests/kconfigskeletontes

D24490: Make kconfig_compiler generate ctors with the optional parent arg

2019-10-10 Thread Kevin Ottens
ervin added a comment. In D24490#544599 , @apol wrote: > It could make sense to tweak it so in KF6 `ParentInConstructor=true` it's true by default. What do you mean by tweak? REPOSITORY R237 KConfig REVISION DETAIL https://phabricat

D24494: Add convenience for defaults/dirty states to KCoreConfigSkeleton

2019-10-10 Thread Aleix Pol Gonzalez
apol added a comment. Looks better, it could make sense to add a KF6 TODO/Warning. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D24494 To: ervin, #plasma, #frameworks, dfaure, mart Cc: apol, kossebau, davidedmundson, kde-frameworks-devel, LeGast00n, GB_2, michaelh

D24490: Make kconfig_compiler generate ctors with the optional parent arg

2019-10-10 Thread Aleix Pol Gonzalez
apol accepted this revision. apol added a comment. It could make sense to tweak it so in KF6 `ParentInConstructor=true` it's true by default. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D24490 To: ervin, #plasma, #frameworks, dfaure, mart, apol Cc: kossebau, apol

D24453: [RFC] Unify style of new Kirigami.ListSectionHeader and CategoryDrawer

2019-10-10 Thread Jarosław Staniek
staniek removed a reviewer: KEXI. REPOSITORY R276 KItemViews BRANCH newcategorystyle (branched from master) REVISION DETAIL https://phabricator.kde.org/D24453 To: davidre, #frameworks, #vdg, #konversation, #kde_edu, #kde_pim, #kpublictransport, #amarok, ngraham, #kexi Cc: ndavis, ognarb,

Re: Akonadi SchemaVersionTable is broken with PostgreSQL Version 12 changes

2019-10-10 Thread Harald Sitter
Hey, Please file bug reports about issues: https://bugs.kde.org/enter_bug.cgi?product=Akonadi On Thu, Oct 10, 2019 at 12:29 AM Stuart wrote: > > Dear development team, > > As per the PostgreSQL release documents: > E.1. Release 12 > https://www.postgresql.org/docs/12/release-12.html#id-1.11.6.5.

D23835: Add TabKCM

2019-10-10 Thread Kai Uwe Broulik
broulik added a comment. Don't use ECMAScript 6 stuff in KDeclarative or plasma-framework! It is a Framework which has a minimum version version support of Qt 5.11 (last three, 5.13, 5.12, 5.11). ECMAScript 6 is only in Qt 5.12 REPOSITORY R296 KDeclarative REVISION DETAIL https://phabri

D24453: [RFC] Unify style of new Kirigami.ListSectionHeader and CategoryDrawer

2019-10-10 Thread Noah Davis
ndavis added a comment. In D24453#543063 , @ngraham wrote: > Nice. Is there any way to make it touch the edges of its parent view rather than having those small margins? I would like this. I'm not aware of any place where we use margins a

D24453: [RFC] Unify style of new Kirigami.ListSectionHeader and CategoryDrawer

2019-10-10 Thread Noah Davis
ndavis added a comment. Why do the gray rectangles have margins around them? I don't like the look very much. REPOSITORY R276 KItemViews BRANCH newcategorystyle (branched from master) REVISION DETAIL https://phabricator.kde.org/D24453 To: davidre, #frameworks, #vdg, #konversation, #k