D24898: Add KLocalizedString::untranslatedText

ngraham added a comment. Makes sense to me. REPOSITORY R249 KI18n BRANCH master REVISION DETAIL https://phabricator.kde.org/D24898 To: aacid, ilic Cc: ngraham, apol, ilic, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D24898: Add KLocalizedString::untranslatedText

ilic accepted this revision. This revision is now accepted and ready to land. REPOSITORY R249 KI18n BRANCH master REVISION DETAIL https://phabricator.kde.org/D24898 To: aacid, ilic Cc: apol, ilic, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25102: VHDL: all keywords are insensitive

nibags closed this revision. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D25102 To: nibags, #framework_syntax_highlighting, dhaumann, cullmann Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, ngraham, bruns, demsking, cullmann,

D25102: VHDL: all keywords are insensitive

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Yep, I think this is better, thanks! REPOSITORY R216 Syntax Highlighting BRANCH fix-vhdl REVISION DETAIL https://phabricator.kde.org/D25102 To: nibags,

D25107: Add install dir for systemd units

davidedmundson created this revision. Herald added projects: Frameworks, Build System. Herald added subscribers: kde-buildsystem, kde-frameworks-devel. davidedmundson requested review of this revision. REVISION SUMMARY Like we have for other FD.O projects like DBus service files TEST PLAN

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 165 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/165/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Fri, 01 Nov 2019 16:11:08 + Build duration: 16 min and counting JUnit Tests Name: projectroot

D25039: Fix Clazy performance issues, const

kossebau added a comment. In D25039#557609 , @meven wrote: > Feel free to do the code removal, Done now, as I had the files still open. REPOSITORY R241 KIO BRANCH arcpatch-D25039 REVISION DETAIL https://phabricator.kde.org/D25039

D25039: Fix Clazy performance issues, const

meven added a comment. In D25039#557579 , @kossebau wrote: > Not tested, only read code. Looks good to me. > Please remove the newInstance method in a direct commit before, and drop change from this patch. (If you prefer, can do the remove

D25106: Also allow invoking session restoration logic when apps are manually launched

ngraham added a dependent revision: D11382: Add an option to show tabs from last time when Dolphin starts. REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D25106 To: ngraham, davidedmundson, #frameworks Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25106: Also allow invoking session restoration logic when apps are manually launched

ngraham created this revision. ngraham added reviewers: davidedmundson, Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ngraham requested review of this revision. REVISION SUMMARY Right now session restoration logic only ever gets invoked when

D23801: Port kpac from QtScript

kossebau added inline comments. INLINE COMMENTS > carewolf wrote in script.cpp:316 > Sure, as I said, I only write it this way because a copy should be taken, and > while Qt can work around declaring an async argument as a reference, I still > consider it bad style to make that mistake. > >

D25084: Allow a Multiple instances to become Unique

tcanabrava added a subscriber: GB_2. tcanabrava added a comment. https://invent.kde.org/kde/konsole/merge_requests/45 But it’s not related to this path, it’s just another bug REPOSITORY R271 KDBusAddons BRANCH multiple_to_unique REVISION DETAIL https://phabricator.kde.org/D25084

D25039: Fix Clazy performance issues, const

kossebau accepted this revision. kossebau added a comment. This revision is now accepted and ready to land. Not tested, only read code. Looks good to me. Please remove the newInstance method in a direct commit before, and drop change from this patch. (If you prefer, can do the remove commit

D25084: Allow a Multiple instances to become Unique

davidedmundson added a comment. > I think I just need to verify if the name would be the same as the name minus the uuid. because if you open an app on ::Multiple and later the same app on ::Unique, merging them seems sane. Could you link your konsole patch, I don't yet see why we

D25084: Allow a Multiple instances to become Unique

tcanabrava added a comment. Yes, that's exactly what would happen, I think I just need to verify if the name would be the same as the name minus the uuid. because if you open an app on ::Multiple and later the same app on ::Unique, merging them seems sane. REPOSITORY R271 KDBusAddons

D25084: Allow a Multiple instances to become Unique

adridg added a comment. Now you (@davidedmundson ) mention it, yeah .. I've only tested positively, to see if konsole then does what I want. You're right that this could have surprising effects when multiple unique applications share a prefix (e.g. org.kde.plasma.something and

Re: KSyntaxHighlighting: My changes to data files don’t seem to affect test outputs

What does `ldd build/bin/syntax/testhighlighter_test` tell you? [adrian@pondal build]$ ldd bin/testhighlighter_test | grep libKF5SyntaxHighlighting.so.5 libKF5SyntaxHighlighting.so.5 => /home/adrian/proxectos/syntax-highlighting/build/bin/libKF5SyntaxHighlighting.so.5 (0x7f40a371)

KDE CI: Frameworks » ktexteditor » kf5-qt5 FreeBSDQt5.13 - Build # 139 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20FreeBSDQt5.13/139/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Fri, 01 Nov 2019 10:22:46 + Build duration: 8 min 50 sec and counting JUnit Tests Name:

D24983: KateModeMenuList: improve word wrap

nibags closed this revision. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D24983 To: nibags, #ktexteditor, cullmann, dhaumann Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D25102: VHDL: all keywords are insensitive

nibags created this revision. nibags added reviewers: Framework: Syntax Highlighting, dhaumann, cullmann. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. nibags requested review of this revision. REVISION SUMMARY BUG: 413409 In the

D24983: KateModeMenuList: improve word wrap

nibags updated this revision to Diff 69150. nibags added a comment. - Increase the menu size according to the font size, to improve the display This achieves a better visualization if the user increases the font size in the Plasma preferences. REPOSITORY R39 KTextEditor CHANGES SINCE

D24980: Port ssl_cert_errors meta data from KSslError to QSslError

vkrause added a comment. ping? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24980 To: vkrause Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24726: Fix null pointer reference when extraction fails

This revision was automatically updated to reflect the committed changes. Closed by commit R243:8222caed9367: Fix null pointer reference when extraction fails (authored by pvuorela). REPOSITORY R243 KArchive CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24726?vs=69086=69148