D25117: file ioslave: stop copying as soon as the ioslave is killed

apol added a comment. +1 makes a lot of sense overall. INLINE COMMENTS > filecopyjob.h:74 > bool doResume() override; > -bool doKill() override; > I don't think this change is ABI compatible (though after reading the docs, I'm not 100% sure).

D25115: Add guard for missing kirigami

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R295 KCMUtils BRANCH master REVISION DETAIL https://phabricator.kde.org/D25115 To: davidedmundson, #plasma, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25113: ftp ioslave: remove redundant variable

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D25113 To: meven, #frameworks, kossebau, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25107: Add install dir for systemd units

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R240 Extra CMake Modules BRANCH master REVISION DETAIL https://phabricator.kde.org/D25107 To: davidedmundson, apol Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, bencreasy, michaelh,

D24621: [RFC] New Konsole and Yakuake icons

mglb abandoned this revision. mglb added a comment. Yakuake icon moved to: https://phabricator.kde.org/D25123 Abandoning this one. If I decide to come back with Konsole icon I'll do it in dedicated task. REPOSITORY R266 Breeze Icons REVISION DETAIL

D25123: [WIP] New yakuake logo/icon

mglb created this revision. mglb added reviewers: VDG, Yakuake. mglb added projects: Frameworks, Yakuake. mglb requested review of this revision. REVISION SUMMARY Split from: https://phabricator.kde.org/D24621 This is my proposition for new yakuake logo and icon. The logo mixes a well

D23384: [WIP] Adding support for mounting KIOFuse URLs for applications that don't use KIO

feverfew added a comment. @dfaure Just to give you a bit of context. KIOFuse is about to enter KDE Review, but at the same time, KIOFuse is most useful when integrated to KIO via this patch. So we'd like to get this reviewed early to save a bit of effort; instead of getting it passed KDE

D23384: [WIP] Adding support for mounting KIOFuse URLs for applications that don't use KIO

feverfew edited the summary of this revision. feverfew edited the test plan for this revision. feverfew edited reviewers, added: davidedmundson, dfaure, ngraham; removed: chinmoyr. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D23384 To: feverfew, fvogt, davidedmundson,

D23384: [WIP] Adding support for mounting KIOFuse URLs for applications that don't use KIO

feverfew updated this revision to Diff 69201. feverfew added a comment. Don't use KIOFuse with mtp/gdrive REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23384?vs=68931=69201 BRANCH KDEDModule (branched from master) REVISION DETAIL

D25015: Update breeze theme shadows

manueljlin added a comment. I hope this gets approved so T10470 doesn't look awkward with thin and dark shadows REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D25015 To: niccolove, #vdg Cc: manueljlin,

D25119: KF5::BreezeIcons shared library to have all breeze/breeze-dark icons and default to breeze icons set

cullmann added a comment. This patch by itself will not make the dark mode work, but e.g. Kate will be able to use it as the color theme chooser will set breeze-dark as theme and the icons will be "there". Beside this, it avoids loading 20MB of data, as before the resource file got loaded

D25119: KF5::BreezeIcons shared library to have all breeze/breeze-dark icons and default to breeze icons set

ndavis added a comment. I'm not sure if my review is really necessary since I lack the technical expertise to know what the right solution is, but +1 to light and dark Breeze icon support on other platforms. REPOSITORY R266 Breeze Icons REVISION DETAIL

D25122: embedd trigrams.map into shared library

cullmann added reviewers: dfaure, vonreth, Frameworks. cullmann added a comment. Easier to deploy, we just need the shared libs and no extra data files (at least not for sonnet itself). REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D25122 To: cullmann, dfaure,

D25122: embedd trigrams.map into shared library

cullmann created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. cullmann requested review of this revision. REVISION SUMMARY Easier to deploy sonnet: just install the libraries TEST PLAN make && make test REPOSITORY R246 Sonnet BRANCH

D25119: KF5::BreezeIcons shared library to have all breeze/breeze-dark icons and default to breeze icons set

ngraham added reviewers: ndavis, mart, alex-l. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D25119 To: cullmann, #frameworks, vonreth, dfaure, rempt, ndavis, mart, alex-l Cc: broulik, rempt, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25119: KF5::BreezeIcons shared library to have all breeze/breeze-dark icons and default to breeze icons set

cullmann added a comment. At the moment, the hack in kiconthemes only allows to load one theme. This means you have just "breeze". If you e.g. want to switch to "breeze-dark" this fails as the icons will not be found. REPOSITORY R266 Breeze Icons REVISION DETAIL

D24621: [RFC] New Konsole and Yakuake icons

mglb added a comment. I'll do the split today or tomorrow. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D24621 To: mglb, #vdg, #konsole, #yakuake, trickyricky26 Cc: ngraham, trickyricky26, ndavis, cblack, kde-frameworks-devel, LeGast00n, GB_2, michaelh,

D25119: KF5::BreezeIcons shared library to have all breeze/breeze-dark icons and default to breeze icons set

broulik added a comment. Can you expand on that dark theme issue? We just colorize the same SVGs as needed. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D25119 To: cullmann, #frameworks, vonreth, dfaure, rempt Cc: broulik, rempt, kde-frameworks-devel,

D25119: KF5::BreezeIcons shared library to have all breeze/breeze-dark icons and default to breeze icons set

cullmann added a comment. At the moment this patch will only create the shared lib if we have binary resources configured. One could always create the lib and only compile in the resources if wanted. That would allow e.g. applications like Kate to always link against this on all

D25119: KF5::BreezeIcons shared library to have all breeze/breeze-dark icons and default to breeze icons set

cullmann added a reviewer: rempt. cullmann added a subscriber: rempt. cullmann added a comment. Perhaps @rempt has some input on this, for the cross-platform aspects. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D25119 To: cullmann, #frameworks, vonreth,

D25119: KF5::BreezeIcons shared library to have all breeze/breeze-dark icons and default to breeze icons set

cullmann added reviewers: Frameworks, vonreth, dfaure. cullmann added a comment. Some reviewers. I am not sure this is the "perfect" solution, but it will make deploying applications a lot easier given just linking against this library provides the icons most of them will need. And

D24989: support multiple rcc files with icons themes

cullmann added a comment. See https://phabricator.kde.org/D25119 for the replacement idea. REPOSITORY R302 KIconThemes REVISION DETAIL https://phabricator.kde.org/D24989 To: cullmann, #frameworks, vonreth, dfaure Cc: dfaure, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham,

D25119: KF5::BreezeIcons shared library to have all breeze/breeze-dark icons and default to breeze icons set

cullmann created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. cullmann requested review of this revision. REVISION SUMMARY At the moment, one big problem for non-unices is the deployment of icons Close to all things in KDE stuff relies on

D24989: support multiple rcc files with icons themes

cullmann abandoned this revision. cullmann added a comment. I think I retract this. I have a nicer way to have this seamless integrated without KIconThemes. REPOSITORY R302 KIconThemes REVISION DETAIL https://phabricator.kde.org/D24989 To: cullmann, #frameworks, vonreth, dfaure Cc:

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.12 - Build # 77 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.12/77/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 02 Nov 2019 13:22:20 + Build duration: 46 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » solid » kf5-qt5 FreeBSDQt5.13 - Build # 33 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20FreeBSDQt5.13/33/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sat, 02 Nov 2019 13:06:10 + Build duration: 10 min and counting JUnit Tests Name: projectroot

KDE CI: Frameworks » solid » kf5-qt5 FreeBSDQt5.13 - Build # 32 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20FreeBSDQt5.13/32/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sat, 02 Nov 2019 11:49:06 + Build duration: 1 hr 17 min and counting JUnit Tests Name:

KDE CI: Frameworks » kwayland » kf5-qt5 FreeBSDQt5.13 - Build # 30 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20FreeBSDQt5.13/30/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sat, 02 Nov 2019 11:48:01 + Build duration: 57 min and counting JUnit Tests Name:

D24962: [DeleteJob] Use a separate worker thread to run actual IO operation

meven added inline comments. INLINE COMMENTS > dfaure wrote in deletejob.cpp:67 > Seems negligible to me. If you remove the argument, you'll have to > "reconstruct" the URL from files.first()/symlinks.first()? Or [ab]use > m_currentURL? > The "no premature optimization" rule says: don't change

KDE CI: Frameworks » kservice » kf5-qt5 FreeBSDQt5.13 - Build # 48 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kservice/job/kf5-qt5%20FreeBSDQt5.13/48/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sat, 02 Nov 2019 11:46:42 + Build duration: 47 min and counting JUnit Tests Name:

D24898: Add KLocalizedString::untranslatedText

aacid closed this revision. REPOSITORY R249 KI18n REVISION DETAIL https://phabricator.kde.org/D24898 To: aacid, ilic Cc: ngraham, apol, ilic, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D24938: Fix memory leak in KXzFilter::init

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R243:38b2ca728c83: Fix memory leak in KXzFilter::init (authored by aacid). REPOSITORY R243 KArchive CHANGES SINCE LAST

KDE CI: Frameworks » kpty » kf5-qt5 FreeBSDQt5.13 - Build # 17 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kpty/job/kf5-qt5%20FreeBSDQt5.13/17/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sat, 02 Nov 2019 11:46:40 + Build duration: 46 min and counting JUnit Tests Name: projectroot

KDE CI: Frameworks » kpackage » kf5-qt5 FreeBSDQt5.13 - Build # 25 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20FreeBSDQt5.13/25/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sat, 02 Nov 2019 11:46:24 + Build duration: 42 min and counting JUnit Tests Name:

D25117: file ioslave: stop copying as soon as the ioslave is killed

meven created this revision. meven added reviewers: Frameworks, dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. meven requested review of this revision. REVISION SUMMARY Previously when cancelling a copy the ioslave would continue. The file copy

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 167 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/167/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sat, 02 Nov 2019 11:45:35 + Build duration: 39 min and counting JUnit Tests Name: projectroot

KDE CI: Frameworks » kimageformats » kf5-qt5 FreeBSDQt5.13 - Build # 18 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kimageformats/job/kf5-qt5%20FreeBSDQt5.13/18/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sat, 02 Nov 2019 11:45:00 + Build duration: 31 min and counting JUnit Tests Name:

KDE CI: Frameworks » kdelibs4support » kf5-qt5 FreeBSDQt5.13 - Build # 39 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20FreeBSDQt5.13/39/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sat, 02 Nov 2019 11:43:47 + Build duration: 24 min and counting JUnit Tests Name:

KDE CI: Frameworks » kdesu » kf5-qt5 FreeBSDQt5.13 - Build # 18 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kdesu/job/kf5-qt5%20FreeBSDQt5.13/18/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sat, 02 Nov 2019 11:43:58 + Build duration: 22 min and counting JUnit Tests Name: projectroot

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.13 - Build # 55 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.13/55/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sat, 02 Nov 2019 11:43:26 + Build duration: 18 min and counting JUnit Tests Name:

KDE CI: Frameworks » kcalendarcore » kf5-qt5 FreeBSDQt5.13 - Build # 21 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcalendarcore/job/kf5-qt5%20FreeBSDQt5.13/21/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sat, 02 Nov 2019 11:42:45 + Build duration: 13 min and counting JUnit Tests Name:

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.13 - Build # 32 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.13/32/ Project: kf5-qt5 SUSEQt5.13 Date of build: Sat, 02 Nov 2019 11:31:29 + Build duration: 22 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.13 - Build # 180 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.13/180/ Project: kf5-qt5 SUSEQt5.13 Date of build: Sat, 02 Nov 2019 11:33:32 + Build duration: 8 min 43 sec and counting BUILD ARTIFACTS

D24962: [DeleteJob] Use a separate worker thread to run actual IO operation

dfaure added inline comments. INLINE COMMENTS > meven wrote in deletejob.cpp:67 > I am hesitant to remove `const QUrl& url` from this signal, it could save > some space in message passing. Seems negligible to me. If you remove the argument, you'll have to "reconstruct" the URL from

D25115: Add guard for missing kirigami

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. davidedmundson requested review of this revision. REVISION SUMMARY We rely on the component being created correctly later in the

T11627: Improve KIO asynchronicity

meven added a revision: D24962: [DeleteJob] Use a separate worker thread to run actual IO operation. TASK DETAIL https://phabricator.kde.org/T11627 To: meven Cc: broulik, ognarb, #dolphin, #frameworks, meven, dfaure, pberestov, iasensio, fprice, LeGast00n, MrPepe, fbampaloukas, alexde, GB_2,

D24962: [DeleteJob] Use a separate worker thread to run actual IO operation

meven edited the summary of this revision. REPOSITORY R241 KIO BRANCH arcpatch-D24962 REVISION DETAIL https://phabricator.kde.org/D24962 To: meven, dfaure, #frameworks Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24962: [DeleteJob] Use a separate worker thread to run actual IO operation

meven added a task: T11627: Improve KIO asynchronicity. REPOSITORY R241 KIO BRANCH arcpatch-D24962 REVISION DETAIL https://phabricator.kde.org/D24962 To: meven, dfaure, #frameworks Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24962: [DeleteJob] Use a separate worker thread to run actual IO operation

meven added a reviewer: Frameworks. REPOSITORY R241 KIO BRANCH arcpatch-D24962 REVISION DETAIL https://phabricator.kde.org/D24962 To: meven, dfaure, #frameworks Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

T11627: Improve KIO asynchronicity

meven added a revision: D25079: [CopyJob] Increase the amount of data sendfile can copy at once. TASK DETAIL https://phabricator.kde.org/T11627 To: meven Cc: broulik, ognarb, #dolphin, #frameworks, meven, dfaure, pberestov, iasensio, fprice, LeGast00n, MrPepe, fbampaloukas, alexde, GB_2,

D25079: [CopyJob] Increase the amount of data sendfile can copy at once

meven added a task: T11627: Improve KIO asynchronicity. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D25079 To: meven, dfaure, #frameworks, davidedmundson Cc: ahmadsamir, sitter, apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25010: [StatJob] Use A QFlag to specify the details returned by StatJob

meven updated this revision to Diff 69181. meven added a comment. Allow retro-compatibility with old details both ways : old kio or old app, update comments to ready patch for KF 5.65 REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25010?vs=69023=69181 BRANCH

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 166 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/166/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sat, 02 Nov 2019 07:17:57 + Build duration: 10 min and counting JUnit Tests Name: projectroot

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.13 - Build # 179 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.13/179/ Project: kf5-qt5 SUSEQt5.13 Date of build: Sat, 02 Nov 2019 07:17:57 + Build duration: 9 min 7 sec and counting BUILD ARTIFACTS

D25113: ftp ioslave: remove redundant variable

meven created this revision. meven added reviewers: Frameworks, kossebau. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. meven requested review of this revision. TEST PLAN builds REPOSITORY R241 KIO BRANCH master REVISION DETAIL

D25039: Fix Clazy performance issues, const

This revision was automatically updated to reflect the committed changes. Closed by commit R241:f2a3a78972b2: Fix Clazy performance issues, const (authored by meven). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25039?vs=69178=69179 REVISION DETAIL

D25039: Fix Clazy performance issues, const

meven updated this revision to Diff 69178. meven added a comment. Rebasing on master REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25039?vs=69121=69178 BRANCH arcpatch-D25039 REVISION DETAIL https://phabricator.kde.org/D25039 AFFECTED FILES