KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 174 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/174/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Fri, 08 Nov 2019 04:32:42 + Build duration: 20 min and counting JUnit Tests Name: projectroot

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.13 - Build # 189 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.13/189/ Project: kf5-qt5 SUSEQt5.13 Date of build: Fri, 08 Nov 2019 04:32:42 + Build duration: 18 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 305 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/305/ Project: kf5-qt5 SUSEQt5.12 Date of build: Fri, 08 Nov 2019 04:32:42 + Build duration: 18 min and counting BUILD ARTIFACTS

D21004: [UserMetaData] Shortcut attribute queries for the common case

This revision was automatically updated to reflect the committed changes. Closed by commit R824:4fdb2048f25d: [UserMetaData] Shortcut attribute queries for the common case (authored by bruns). REPOSITORY R824 Baloo Widgets CHANGES SINCE LAST UPDATE

D21004: [UserMetaData] Shortcut attribute queries for the common case

bruns updated this revision to Diff 69416. bruns edited the summary of this revision. bruns added a comment. KF5_MIN_VERSION bump to 5.60 REPOSITORY R824 Baloo Widgets CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21004?vs=57507=69416 BRANCH arcpatch-D21004 REVISION DETAIL

D25194: Use modern for

aacid closed this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D25194 To: aacid, vkrause Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 173 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/173/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Thu, 07 Nov 2019 21:47:48 + Build duration: 9 min 43 sec and counting JUnit Tests Name:

D25195: use modern for syntax

aacid closed this revision. REPOSITORY R278 KWindowSystem REVISION DETAIL https://phabricator.kde.org/D25195 To: aacid, davidedmundson Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25015: Update breeze theme shadows

ndavis added a comment. I see the difference now as well. @niccolove BTW, the top right corner is a bit messed up. It's rising above the rest of the shadow on the top edge. Rather than painstakingly making shadows by hand in Inkscape, perhaps we should be using KWin for the shadows?

KDE CI: Frameworks » kcalendarcore » kf5-qt5 FreeBSDQt5.13 - Build # 24 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcalendarcore/job/kf5-qt5%20FreeBSDQt5.13/24/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Thu, 07 Nov 2019 18:22:36 + Build duration: 42 min and counting JUnit Tests Name:

KDE CI: Frameworks » kcalendarcore » kf5-qt5 FreeBSDQt5.13 - Build # 23 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcalendarcore/job/kf5-qt5%20FreeBSDQt5.13/23/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Thu, 07 Nov 2019 14:51:32 + Build duration: 3 hr 30 min and counting JUnit Tests Name:

D25195: use modern for syntax

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R278 KWindowSystem BRANCH master REVISION DETAIL https://phabricator.kde.org/D25195 To: aacid, davidedmundson Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25115: Add guard for missing kirigami

This revision was automatically updated to reflect the committed changes. Closed by commit R295:6f8610a1431a: Add guard for missing kirigami (authored by davidedmundson). REPOSITORY R295 KCMUtils CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25115?vs=69183=69404 REVISION DETAIL

D25194: Use modern for

vkrause accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D25194 To: aacid, vkrause Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24980: Port ssl_cert_errors meta data from KSslError to QSslError

vkrause added a comment. anyone? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24980 To: vkrause Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

Re: Quick Charts in KDE Review

On 07-11-2019 15:34, Friedrich W. H. Kossebau wrote: Am Montag, 21. Oktober 2019, 15:22:23 CET schrieb Arjen Hiemstra: Hi, Quick Charts has been moved to KDE review. The intent is to make it a Tier 1 framework. Any chance the official name can be "KQuickCharts"? "Quick Charts" is a generic

D25015: Update breeze theme shadows

ngraham added a comment. Ah, pixel-perfect before-and-after images make it much easier to see. I will reiterate my belief that the shadows now need to be bigger if we're going to make them lighter and weaker. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL

D25197: Show a "Loading more..." busy indicator when loading view data

ngraham added a comment. Cool, I'm okay with that. The "Loading more" indicator is aligned to the top, not centered like the other loading indicator is. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D25197 To: leinir, #knewstuff, #frameworks, #plasma,

D25149: Add a new template for KCMs

ngraham retitled this revision from "Add a new Template for KCM's." to "Add a new template for KCMs". REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D25149 To: tcanabrava Cc: yurchor, davidedmundson, ognarb, ervin, kde-frameworks-devel, LeGast00n,

D25149: Add a new Template for KCM's.

tcanabrava added a comment. In D25149#559075 , @davidedmundson wrote: > A very sensible idea. ++ > > > templates/kcm-qml/qml-plasmoid.png > > What's this about? We need a better icon. it's the icon for the `Plasmoid` template.

D25149: Add a new Template for KCM's.

tcanabrava updated this revision to Diff 69400. tcanabrava added a comment. - Add KConfigXT REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25149?vs=69296=69400 BRANCH arcpatch-D25149 REVISION DETAIL

D25170: make the libssh finder ensure the new ssh target is set

asn added a comment. Thanks Harald, this is an awesome idea! https://www.libssh.org/2019/11/07/libssh-0-9-2/ REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D25170 To: sitter Cc: asn, heikobecker, kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice,

D25173: Give some more pretty feedback in NewStuff::Page while the Engine is loading

leinir updated this revision to Diff 69399. leinir added a comment. - Merge branch 'master' into be-more-friendly-during-initial-load - Add a bit of @since REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25173?vs=69383=69399 BRANCH

D25197: Show a "Loading more..." busy indicator when loading view data

leinir updated this revision to Diff 69398. leinir added a comment. - Add some @since REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25197?vs=69397=69398 BRANCH reduce-some-noise (branched from master) REVISION DETAIL

D25197: Show a "Loading more..." busy indicator when loading view data

leinir edited the test plan for this revision. leinir added reviewers: KNewStuff, Frameworks, Plasma, ngraham. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D25197 To: leinir, #knewstuff, #frameworks, #plasma, ngraham Cc: kde-frameworks-devel, LeGast00n, GB_2,

D25197: Show a "Loading more..." busy indicator when loading view data

leinir added a dependency: D25173: Give some more pretty feedback in NewStuff::Page while the Engine is loading. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D25197 To: leinir, #knewstuff, #frameworks, #plasma, ngraham Cc: kde-frameworks-devel, LeGast00n, GB_2,

D25173: Give some more pretty feedback in NewStuff::Page while the Engine is loading

leinir added a dependent revision: D25197: Show a "Loading more..." busy indicator when loading view data. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D25173 To: leinir, #knewstuff, #frameworks, ngraham, #vdg Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh,

D25197: Show a "Loading more..." busy indicator when loading view data

leinir created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. leinir requested review of this revision. REVISION SUMMARY Add an isFetching property to the QML ItemsModel, and use that to show a busy indicator with a label at the end of the

D25193: use more modern for construct

aacid closed this revision. REPOSITORY R303 KInit REVISION DETAIL https://phabricator.kde.org/D25193 To: aacid, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25192: Replace for with maths with range for

aacid closed this revision. REPOSITORY R302 KIconThemes REVISION DETAIL https://phabricator.kde.org/D25192 To: aacid, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25195: use modern for syntax

aacid created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. aacid requested review of this revision. REPOSITORY R278 KWindowSystem BRANCH master REVISION DETAIL https://phabricator.kde.org/D25195 AFFECTED FILES

Re: Quick Charts in KDE Review

On 07-11-2019 15:24, Alexander Potashev wrote: чт, 7 нояб. 2019 г. в 13:53, Arjen Hiemstra : On 21-10-2019 15:22, Arjen Hiemstra wrote: > Hi, > > Quick Charts has been moved to KDE review. The intent is to make it a > Tier 1 framework. > > Quick Charts is a QML module that implements a set of

Re: Quick Charts in KDE Review

Am Montag, 21. Oktober 2019, 15:22:23 CET schrieb Arjen Hiemstra: > Hi, > > Quick Charts has been moved to KDE review. The intent is to make it a > Tier 1 framework. Any chance the official name can be "KQuickCharts"? "Quick Charts" is a generic name which only asks for being misunderstood, is

Re: Quick Charts in KDE Review

Approved in general, but we will cover that and any ported applets effectively ported from KDeclarative::Plotter in relevant separate review processes. David

Re: Quick Charts in KDE Review

чт, 7 нояб. 2019 г. в 13:53, Arjen Hiemstra : > > On 21-10-2019 15:22, Arjen Hiemstra wrote: > > Hi, > > > > Quick Charts has been moved to KDE review. The intent is to make it a > > Tier 1 framework. > > > > Quick Charts is a QML module that implements a set of > > high-performance, GPU

D25193: use more modern for construct

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R303 KInit BRANCH master REVISION DETAIL https://phabricator.kde.org/D25193 To: aacid, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25173: Give some more pretty feedback in NewStuff::Page while the Engine is loading

leinir added a comment. In D25173#559588 , @ngraham wrote: > I still see "Loading Data" in a passiveNotification as well as in text under the loading indicator. i'm seeing a couple of bits which really probably want to be turned into

D25194: Use modern for

aacid created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. aacid requested review of this revision. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D25194 AFFECTED FILES

D25192: Replace for with maths with range for

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R302 KIconThemes BRANCH master REVISION DETAIL https://phabricator.kde.org/D25192 To: aacid, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25193: use more modern for construct

aacid created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. aacid requested review of this revision. REPOSITORY R303 KInit BRANCH master REVISION DETAIL https://phabricator.kde.org/D25193 AFFECTED FILES src/kdeinit/kinit.cpp To:

D25192: Replace for with maths with range for

aacid created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. aacid requested review of this revision. REPOSITORY R302 KIconThemes BRANCH master REVISION DETAIL https://phabricator.kde.org/D25192 AFFECTED FILES

D25189: Add an overlay component for item activity feedback

leinir added inline comments. INLINE COMMENTS > ngraham wrote in FeedbackOverlay.qml:63 > Bonus points for showing a link that actually takes you to > https://bugs.kde.org/enter_bug.cgi?product=frameworks-knewstuff when this > error condition is present Couple of places where that wants to

D25189: Add an overlay component for item activity feedback

This revision was automatically updated to reflect the committed changes. Closed by commit R304:24ffb9cb9c11: Add an overlay component for item activity feedback (authored by leinir). REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25189?vs=69384=69391

D25189: Add an overlay component for item activity feedback

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Good stuff. INLINE COMMENTS > FeedbackOverlay.qml:63 > +} else { > +statusLabel.text = i18nc("Label for the busy indicator > which should only be

D25173: Give some more pretty feedback in NewStuff::Page while the Engine is loading

ngraham added a comment. I still see "Loading Data" in a passiveNotification as well as in text under the loading indicator. Do we really need the passiveNotifications at all? I think we can probably improve the user experience vy removing them entirely. For example instead of "Loading one

D25010: [StatJob] Use A QFlag to specify the details returned by StatJob

meven added a comment. I feel the code is ready for review toward merging. INLINE COMMENTS > global.h:321 > +/// Filename, access, type, size, linkdest > +StatBasic = 0x1, > +/// uid, gid Naming should be explicit enough now. I still wonder about granularity if I should expose

D25010: [StatJob] Use A QFlag to specify the details returned by StatJob

meven updated this revision to Diff 69385. meven marked an inline comment as done. meven added a comment. Add Stat prefix to enum values of KIO::StatDetail REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25010?vs=69261=69385 BRANCH arcpatch-D25010 REVISION

D25184: Define property X-Plasma-MainScript for Plasma/Wallpaper

zzag abandoned this revision. zzag added a comment. Okay, I see. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D25184 To: zzag, #plasma Cc: davidedmundson, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25189: Add an overlay component for item activity feedback

leinir edited the test plan for this revision. leinir added reviewers: KNewStuff, Frameworks, Plasma, ngraham. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D25189 To: leinir, #knewstuff, #frameworks, #plasma, ngraham Cc: kde-frameworks-devel, LeGast00n, GB_2,

D25189: Add an overlay component for item activity feedback

leinir created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. leinir requested review of this revision. REVISION SUMMARY This is the very first steps toward allowing for better, more involved feedback on what is happening with the items

D25184: Define property X-Plasma-MainScript for Plasma/Wallpaper

davidedmundson added a comment. From wallpaper interface: m_qmlObject->setSource(m_pkg.fileUrl("mainscript")); packages.cpp void QmlWallpaperPackage::initPackage(Plasma::Package *package) { package->addFileDefinition("mainscript", QStringLiteral("ui/main.qml"),

D25173: Give some more pretty feedback in NewStuff::Page while the Engine is loading

leinir updated this revision to Diff 69383. leinir added a comment. - Merge branch 'master' into be-more-friendly-during-initial-load - Don't show the passive notification for already shown messages REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE

Re: Quick Charts in KDE Review

On 21-10-2019 15:22, Arjen Hiemstra wrote: Hi, Quick Charts has been moved to KDE review. The intent is to make it a Tier 1 framework. Quick Charts is a QML module that implements a set of high-performance, GPU accelerated charts. Currently the main user of it is a new KSysGuard UI I have been

D25165: Only show DownloadItemsSheet if there's more than one download item

This revision was automatically updated to reflect the committed changes. Closed by commit R304:7de5ad66fd89: Only show DownloadItemsSheet if theres more than one download item (authored by leinir). REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE

D25168: Use the pointing hand cursor for the single-clickable delegates

This revision was automatically updated to reflect the committed changes. Closed by commit R304:728f01f064ab: Use the pointing hand cursor for the single-clickable delegates (authored by leinir). REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE