D25149: Add a new template for KCMs

ervin added inline comments. INLINE COMMENTS > kcm.cpp:37 > +KAboutData* about = new KAboutData( > +QStringLiteral("kcm_%{APPNAMELC}"), i18n("%{APPNAME} Configuration > Module"), > +QStringLiteral("0.1"), QString(), KAboutLicense::GPL, Nitpick: indentation looks broken here, I think

D18610: Introduce KF5AuthCore

volkov added a comment. What about qmake? I came across the following error: g++ -Wl,-z,relro -o ... /usr/lib/x86_64-linux-gnu/libQt5Gui.so /usr/lib/x86_64-linux-gnu/libKF5Auth.so /usr/lib/x86_64-linux-gnu/libKF5CoreAddons.so /usr/lib/x86_64-linux-gnu/libQt5Core.so /usr/lib/x86_64-l

D25394: support Qt File selectors in KPackage

mart created this revision. mart added a reviewer: Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mart requested review of this revision. REVISION SUMMARY support for things like contents/ui/+phone/main.qml right now in qml based packages qml file

D25394: support Qt File selectors in KPackage

mart updated this revision to Diff 69980. mart added a comment. - directly delete REPOSITORY R290 KPackage CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25394?vs=69979&id=69980 BRANCH phab/selectors REVISION DETAIL https://phabricator.kde.org/D25394 AFFECTED FILES src/kp

D25394: support Qt File selectors in KPackage

broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R290 KPackage BRANCH phab/selectors REVISION DETAIL https://phabricator.kde.org/D25394 To: mart, #plasma, broulik Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25394: support Qt File selectors in KPackage

This revision was automatically updated to reflect the committed changes. Closed by commit R290:2fa9f54224d7: support Qt File selectors in KPackage (authored by mart). REPOSITORY R290 KPackage CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25394?vs=69980&id=69981 REVISION DETAIL h

KDE CI: Frameworks » kpackage » kf5-qt5 FreeBSDQt5.13 - Build # 29 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20FreeBSDQt5.13/29/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Tue, 19 Nov 2019 11:15:02 + Build duration: 1 min 36 sec and counting JUnit Tests Name: proje

D25396: Make the docs reflect that setIconName should be preferred over setPixmap when possible

nicolasfella created this revision. nicolasfella added reviewers: Plasma, broulik. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REPOSITORY R289 KNotifications BRANCH doc REVISION DETAIL https://phabrica

D25397: Install .pri file for KAuthCore

volkov created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. volkov requested review of this revision. REVISION SUMMARY And fix dependencies in .pri file for KAuth. This commit amends 65db21c6fc5369ad498b959b08ab8de19b73c5c4

D18610: Introduce KF5AuthCore

volkov added a comment. Fix for .pri: D25397 REPOSITORY R283 KAuth REVISION DETAIL https://phabricator.kde.org/D18610 To: aacid, apol Cc: volkov, rikmills, sitter, apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25397: Install .pri file for KAuthCore

volkov added a reviewer: aacid. REPOSITORY R283 KAuth REVISION DETAIL https://phabricator.kde.org/D25397 To: volkov, aacid Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kpackage » kf5-qt5 FreeBSDQt5.13 - Build # 30 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20FreeBSDQt5.13/30/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Tue, 19 Nov 2019 11:53:14 + Build duration: 4 min 48 sec and counting JUnit Tests Name: proje

D25389: Verify modes of the session config file

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Sounds reasonable, code looks better, too! Thanks! REPOSITORY R39 KTextEditor BRANCH verify-session-modes REVISION DETAIL https://phabricator.kde.org/D25389 To: nibags, #ktext

D25396: Make the docs reflect that setIconName should be preferred over setPixmap when possible

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R289 KNotifications BRANCH doc REVISION DETAIL https://phabricator.kde.org/D25396 To: nicolasfella, #plasma, broulik, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25396: Make the docs reflect that setIconName should be preferred over setPixmap when possible

This revision was automatically updated to reflect the committed changes. Closed by commit R289:ec2e765242f5: Make the docs reflect that setIconName should be preferred over setPixmap when… (authored by nicolasfella). REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricat

D25401: Fix deprecation syntax in ktcpsocket.h

dfaure created this revision. dfaure added reviewers: vkrause, kossebau. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. dfaure requested review of this revision. REVISION SUMMARY gcc (7.4.1 here) says: ktcpsocket.h:171:22: warning: attribute ignored in dec

D25401: Fix deprecation syntax in ktcpsocket.h

kossebau added a comment. One thing I saw with the Qt deprecation tags is that deprecation attributes were only added to constructor calls, not the class itself. Which to me made some sense, as one should be warned when creating instances of that class. But once you are passed an instance d

D24990: KDEFrameworkCompilerSettings: enable all Qt % KF deprecation warnings

kossebau added a comment. Hm, only noticed now that this actually has an unwanted sideeffects: it triggers deprecation warnings for all deprecated warning also inside each library itself. Which is not what one wants. Because so far FOO_DISABLE_DEPRECATED_BEFORE_AND_AT as set while buildi

D24990: KDEFrameworkCompilerSettings: enable all Qt % KF deprecation warnings

dfaure added a comment. So we need to set FOO_DISABLE_DEPRECATED_BEFORE_AND_AT to N-1 while building FOO itself, right? Either magically here, or manually in every module... REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D24990 To: kossebau, #frameworks,

D24990: KDEFrameworkCompilerSettings: enable all Qt % KF deprecation warnings

kossebau added a comment. In D24990#564670 , @dfaure wrote: > So we need to set FOO_DISABLE_DEPRECATED_BEFORE_AND_AT to N-1 while building FOO itself, right? Either magically here, or manually in every module... Nono, FOO_DISABLE_DEPRECA

D25397: Install .pri file for KAuthCore

aacid added a comment. I don't know much about creating pri files but looks sensible. Do you know what is the "core" that moved from the DEPS on KF5Auth to KF5AuthCore? REPOSITORY R283 KAuth REVISION DETAIL https://phabricator.kde.org/D25397 To: volkov, aacid Cc: kde-frameworks-dev

D25397: Install .pri file for KAuthCore

volkov added a comment. Qt Core > cat qt_lib_widgets.pri | grep depends QT.widgets.depends = core gui REPOSITORY R283 KAuth REVISION DETAIL https://phabricator.kde.org/D25397 To: volkov, aacid Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25401: Fix deprecation syntax in ktcpsocket.h

dfaure added a comment. As a data point: this commit changes things for kimap, which has code saying src/imapstreamparser.cpp:493:} else if (KTcpSocket *socket = qobject_cast(m_socket)) { src/imapstreamparser.cpp-494-qWarning() << "No incoming packet for

Re: Bulk replacement of projects.kde.org on Frameworks modules

On samedi 16 novembre 2019 16:25:37 CET Luigi Toscano wrote: > Luigi Toscano ha scritto: > > Hi, > > basically all Frameworks components reference the ECM website > > using the old projects.kde.org URL, which is long gone and > > it is just a (partial) redirect. > > > > See for example: > > > > s

D25308: when kioslave5 couldn't be found in libexec-ish locations try $PATH

This revision was automatically updated to reflect the committed changes. Closed by commit R241:eab483fa2eab: when kioslave5 couldn't be found in libexec-ish locations try $PATH (authored by sitter). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D25308?vs=69757&id=69995#toc REPOSITORY

D25340: Added background colors to active and inactive icon view

manueljlin added a comment. Please, consider using 3px highlight so tabs don't look like this. This one is from the kickoff task but it would also happen in Audio Volume. F7771606: IMG_20191119_151319.jpg REPOSITORY R242 Plasma Framework (Library)

D25084: Allow a Multiple instances to become Unique

dfaure added a comment. > Just speculating, if an app opens as multiple and then another instance tries to open as unique, it should reuse the existing one or merge? With a konsole state of mind, I can see how this would possibly make sense indeed. But it would break DBus-activation of

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 188 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/188/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Tue, 19 Nov 2019 14:14:57 + Build duration: 8 min 9 sec and counting JUnit Tests Name: projectroo

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 319 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/319/ Project: kf5-qt5 SUSEQt5.12 Date of build: Tue, 19 Nov 2019 14:14:57 + Build duration: 8 min 45 sec and counting BUILD ARTIFACTS acc/KF5KIO-5.65.0.

D25402: [KDirOperator] Add Backspace shortcut to cdUp action

meven created this revision. meven added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. meven requested review of this revision. REVISION SUMMARY Very useful when navigating with keyboard in the KDirOperator REPOSITORY R241 KIO BR

D25340: Added background colors to active and inactive icon view

ngraham added a comment. In D25340#563913 , @ndavis wrote: > F7769041: Screenshot_20191117_203818.png > 15% Inactive BG opacity > 10% Minimized BG opacity Might be too subtle, maybe more opacit

D22946: Include API to generically implement --replace arguments

apol updated this revision to Diff 69997. apol added a comment. Made the code less "racey" REPOSITORY R271 KDBusAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22946?vs=69147&id=69997 BRANCH arcpatch-D22946 REVISION DETAIL https://phabricator.kde.org/D22946 AFFECTED F

D25407: EBN cleanup to change quotes and transport protocol

jhayes created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. jhayes requested review of this revision. REVISION SUMMARY Change from "" to '' to add a char to a string. Change transport protocol from http to https. REPOSITORY R266 Breeze I

D25401: Fix deprecation syntax in ktcpsocket.h

vkrause added a comment. In D25401#564683 , @dfaure wrote: > As a data point: this commit changes things for kimap, which has code saying > > src/imapstreamparser.cpp:493:} else if (KTcpSocket *socket = qobject_cast(m_socket)) {

D25276: reStructuredText: Fix inline literals highlighting preceding characters

adrianchavesfernandez added a reviewer: mosra. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D25276 To: adrianchavesfernandez, mosra Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhauman

D25407: EBN cleanup to change quotes and transport protocol

jhayes added a comment. I checked the diff and this change is not what I changed. I changed 3 characters total out of 2 files. John Hayes REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D25407 To: jhayes Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh,

D25106: Also allow invoking session restoration logic when apps are manually launched

ngraham added a comment. Can I get a review on this? REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D25106 To: ngraham, davidedmundson, #frameworks Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25219: Only create a session config when actually restoring a session

ngraham added a comment. Can I get a review on this? REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D25219 To: ngraham, #frameworks, davidedmundson Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25409: rst: Add support for standalone hyperlinks

adrianchavesfernandez created this revision. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. adrianchavesfernandez requested review of this revision. REPOSITORY R216 Syntax Highlighting BRANCH rst-standalone-hyperlinks REVISION DETAIL

D25409: rst: Add support for standalone hyperlinks

adrianchavesfernandez added a reviewer: mosra. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D25409 To: adrianchavesfernandez, mosra Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhauman

D25219: Only create a session config when actually restoring a session

anthonyfieroni added inline comments. INLINE COMMENTS > kconfiggui.cpp:73 > { > return sessionConfig()->name(); > } sessionConfig() can be nullptr can you add a check. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D25219 To: ngraham, #frameworks, davidedmundso

D25414: xattr: fix crash on dangling symlinks

iasensio created this revision. iasensio added a reviewer: astippich. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. iasensio requested review of this revision. REVISION SUMMARY When requesting metadata on a dangling symlink, the framestack ends

D25414: xattr: fix crash on dangling symlinks

iasensio edited the summary of this revision. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D25414 To: iasensio, astippich Cc: kde-frameworks-devel, #baloo, hurikhan77, lots0logs, LeGast00n, fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun,

D25276: reStructuredText: Fix inline literals highlighting preceding characters

dhaumann added inline comments. INLINE COMMENTS > rest.xml:14 >--> > mimetype="text/x-rst" version="5" kateversion="2.4" casesensitive="1"> > Please increase the version from 5 to 6. Every time a highlighting file is changed this needs to be done. REPOSITORY R216 Syntax Highlighting

D25414: xattr: fix crash on dangling symlinks

bruns added inline comments. INLINE COMMENTS > xattr_p.h:228 > > +if (size == -1 && errno == ENOENT) { > +return UserMetaData::Attribute::None; if (size < 0) { if (errno == E2BIG) { return UserMetaData::Attribute::All; } return UserMetaData::Attribute::None

D25414: xattr: fix crash on dangling symlinks

bruns requested changes to this revision. This revision now requires changes to proceed. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D25414 To: iasensio, astippich, bruns Cc: bruns, kde-frameworks-devel, #baloo, hurikhan77, lots0logs, LeGast00n, fbampaloukas, G

D25414: xattr: fix crash on dangling symlinks

bruns added a comment. wrap the summary at <80 characters REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D25414 To: iasensio, astippich, bruns Cc: bruns, kde-frameworks-devel, #baloo, hurikhan77, lots0logs, LeGast00n, fbampaloukas, GB_2, domson, ashaposhnikov,

D25414: xattr: fix crash on dangling symlinks

bruns added a comment. Also add a testcase covering this, autotests/usermetadatawritertest.cpp REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D25414 To: iasensio, astippich, bruns Cc: bruns, kde-frameworks-devel, #baloo, hurikhan77, lots0logs, LeGast00n, fbamp

D25414: xattr: fix crash on dangling symlinks

iasensio edited the summary of this revision. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D25414 To: iasensio, astippich, bruns Cc: bruns, kde-frameworks-devel, #baloo, hurikhan77, lots0logs, LeGast00n, fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astip

D25414: xattr: fix crash on dangling symlinks

iasensio updated this revision to Diff 70029. iasensio marked 2 inline comments as done. iasensio added a comment. - Protect from size < 0 - Add test case for dangling symlink REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25414?vs=70019&id=70029 B

D25414: xattr: fix crash on dangling symlinks

iasensio updated this revision to Diff 70031. iasensio added a comment. - Use temporal symlink REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25414?vs=70029&id=70031 BRANCH fix_symlink REVISION DETAIL https://phabricator.kde.org/D25414 AFFECTED

D25414: xattr: fix crash on dangling symlinks

iasensio edited the test plan for this revision. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D25414 To: iasensio, astippich, bruns Cc: bruns, kde-frameworks-devel, #baloo, hurikhan77, lots0logs, LeGast00n, fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, as

D25407: EBN cleanup to change quotes and transport protocol

jhayes updated this revision to Diff 70030. jhayes added a comment. This is what the diff should have been to start with REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25407?vs=70005&id=70030 REVISION DETAIL https://phabricator.kde.org/D25407 AFFEC

D25407: EBN cleanup to change quotes and transport protocol

jhayes added a comment. This diff was the changes that was made to two lines in a total of two files. Arc sent the original diff with nothing but svg changes. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D25407 To: jhayes Cc: kde-frameworks-devel, LeGast00n,

D25414: xattr: fix crash on dangling symlinks

bruns added inline comments. INLINE COMMENTS > usermetadatawritertest.cpp:44 > +QFile tempTarget(testFilePath("temporal_target")); > +tempTarget.link(testFilePath(TEST_SYMLINK)); > +tempTarget.remove(); You can just use the static overload and provide an invalid target name. https://

D25414: xattr: fix crash on dangling symlinks

iasensio updated this revision to Diff 70035. iasensio marked an inline comment as done. iasensio added a comment. - Simplify symlink creation REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25414?vs=70031&id=70035 BRANCH fix_symlink REVISION DETAI

D25414: xattr: fix crash on dangling symlinks

iasensio added inline comments. INLINE COMMENTS > bruns wrote in usermetadatawritertest.cpp:44 > You can just use the static overload and provide an invalid target name. > https://doc.qt.io/qt-5/qfile.html#link-1 You are right. I tried that with an empty string and it didn't work, but it does w