D26623: KEMailSettings: group names in kconfig files should not be localized

2020-01-21 Thread David Faure
dfaure added a subscriber: mlaurent. dfaure added a comment. @mlaurent Does KMail show the profile name in the UI? I think this is why the profile name was translated, back then. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D26623 To: meven, #frameworks, ervin, df

D26491: [Plasma Quick] Add WaylandIntegration class

2020-01-21 Thread Vlad Zahorodnii
This revision was automatically updated to reflect the committed changes. Closed by commit R242:f5f43514af0d: [Plasma Quick] Add WaylandIntegration class (authored by zzag). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D26491?vs=72969&id=74068#toc REPOSITORY R242 Plasma Framework (Lib

KDE CI: Frameworks » kwindowsystem » kf5-qt5 FreeBSDQt5.13 - Build # 53 - Fixed!

2020-01-21 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kwindowsystem/job/kf5-qt5%20FreeBSDQt5.13/53/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Wed, 22 Jan 2020 00:32:26 + Build duration: 5 min 6 sec and counting JUnit Tests Name: pr

KDE CI: Frameworks » kwindowsystem » kf5-qt5 AndroidQt5.13 - Build # 52 - Fixed!

2020-01-21 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kwindowsystem/job/kf5-qt5%20AndroidQt5.13/52/ Project: kf5-qt5 AndroidQt5.13 Date of build: Wed, 22 Jan 2020 00:32:26 + Build duration: 3 min 3 sec and counting

KDE CI: Frameworks » kwindowsystem » kf5-qt5 AndroidQt5.13 - Build # 51 - Failure!

2020-01-21 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kwindowsystem/job/kf5-qt5%20AndroidQt5.13/51/ Project: kf5-qt5 AndroidQt5.13 Date of build: Wed, 22 Jan 2020 00:17:36 + Build duration: 13 min and counting CONSOLE OUTPUT [...trunca

KDE CI: Frameworks » kwindowsystem » kf5-qt5 FreeBSDQt5.13 - Build # 52 - Failure!

2020-01-21 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kwindowsystem/job/kf5-qt5%20FreeBSDQt5.13/52/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Wed, 22 Jan 2020 00:17:32 + Build duration: 11 min and counting CONSOLE OUTPUT [...trunca

D26457: Introduce shadows API

2020-01-21 Thread Vlad Zahorodnii
This revision was automatically updated to reflect the committed changes. Closed by commit R278:493452e98f99: Introduce shadows API (authored by zzag). REPOSITORY R278 KWindowSystem CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26457?vs=74055&id=74060 REVISION DETAIL https://phabr

D26457: Introduce shadows API

2020-01-21 Thread Vlad Zahorodnii
zzag updated this revision to Diff 74055. zzag added a comment. Set padding of 1 for missing borders REPOSITORY R278 KWindowSystem CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26457?vs=73733&id=74055 BRANCH kwindowshadow REVISION DETAIL https://phabricator.kde.org/D26457

D25814: [KColorScheme] Add SeparatorColor

2020-01-21 Thread Christoph Feck
cfeck added a comment. > Why don't focus and hover colors belong? Because an application cannot know if and how a style does indicate focus or hovering. REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D25814 To: ndavis, #frameworks, #vdg Cc: broulik, manu

D26491: [Plasma Quick] Add WaylandIntegration class

2020-01-21 Thread David Edmundson
davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH port-to-shadows-api REVISION DETAIL https://phabricator.kde.org/D26491 To: zzag, #plasma, davidedmundson Cc: kde-frameworks-devel, LeGast00n, GB_2, mic

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 410 - Fixed!

2020-01-21 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/410/ Project: kf5-qt5 SUSEQt5.12 Date of build: Tue, 21 Jan 2020 23:17:41 + Build duration: 9 min 23 sec and counting BUILD ARTIFACTS acc/KF5KIO-5.67.0.

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 277 - Still Unstable!

2020-01-21 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/277/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Tue, 21 Jan 2020 23:17:41 + Build duration: 7 min 3 sec and counting JUnit Tests Name: projectroo

D26659: [KCoreDirLister] Port QRegExp to QRegularExpression

2020-01-21 Thread David Faure
dfaure added a comment. Fixed, thanks REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D26659 To: ahmadsamir, dfaure Cc: iasensio, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26701: Add KFileCustomDialog constructor with a startDir parameter.

2020-01-21 Thread David Faure
dfaure added a reviewer: mlaurent. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D26701 To: dfaure, broulik, pino, mlaurent Cc: alexeymin, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

T12567: Reduce code/effort duplication around color scheme support

2020-01-21 Thread Noah Davis
ndavis added a comment. In T12567#218405 , @davidedmundson wrote: > The former won't know when to update, the latter can. So we'll need to make property bindings anyway? Or maybe we can use arrays instead of writing 108 individual variab

D26659: [KCoreDirLister] Port QRegExp to QRegularExpression

2020-01-21 Thread Ismael Asensio
iasensio added a comment. Hi! This change fails to build for me, and also in CI (https://build.kde.org/view/Failing/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/409/console) kcoredirlister_p.h:148:37: error: field 'lstFilters' has incomplete type 'QVector' 09:29:39148 |

D26815: Fix python bindings build after ebd14f29f8052ff5119bf97b42e61f404f223615

2020-01-21 Thread Antonio Rojas
This revision was automatically updated to reflect the committed changes. Closed by commit R237:68c1cfd0d8dc: Fix python bindings build after ebd14f29f8052ff5119bf97b42e61f404f223615 (authored by arojas). REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26815?vs

T12567: Reduce code/effort duplication around color scheme support

2020-01-21 Thread David Edmundson
davidedmundson added a comment. > QML can use C++ functions right? Would we still need to make property bindings for all the colors if we had color() functions? C++ functions can be exposed to QML. However: color: myObject.color(fooBar); has one behaviour big behavioural

D26047: Expose KConfig settings to allow registration in KCM Notification

2020-01-21 Thread Kai Uwe Broulik
broulik added a comment. Other than the seemingly missing `config`, looks good INLINE COMMENTS > settings.cpp:173 > -if (!s_settingsInited) { > -DoNotDisturbSettings::instance(config); > -NotificationSettings::instance(config); I still want to be able to specify what `con

D26815: Fix python bindings build after ebd14f29f8052ff5119bf97b42e61f404f223615

2020-01-21 Thread Nicolas Fella
nicolasfella accepted this revision. nicolasfella added a comment. This revision is now accepted and ready to land. looks sensible, but I haven't tried it myself REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D26815 To: arojas, nicolasfella, dfaure Cc: kde-frameworks

D26101: Port away from Qt 5.14 deprecated QList methods

2020-01-21 Thread Ahmad Samir
ahmadsamir added a comment. FTR, a recent discussion on #kde-devel on Freenode, which involved QSet and toSet(), made me understand why the original code was using toSet(), then fromSet(), it was to remove duplicates as QSet doesn't allow duplicates. REPOSITORY R293 Baloo REVISION DETAIL

D26815: Fix python bindings build after ebd14f29f8052ff5119bf97b42e61f404f223615

2020-01-21 Thread Antonio Rojas
arojas created this revision. arojas added reviewers: nicolasfella, dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. arojas requested review of this revision. REVISION SUMMARY The new API breaks python bindings compilation since sip can't understand K

T12567: Reduce code/effort duplication around color scheme support

2020-01-21 Thread Noah Davis
ndavis added a comment. QML can use C++ functions right? Would we still need to make property bindings for all the colors if we had color() functions? TASK DETAIL https://phabricator.kde.org/T12567 To: ndavis Cc: ognarb, plasma-devel, kde-frameworks-devel, ndavis, Orage, LeGast00n, The-Fe

D25814: [KColorScheme] Add SeparatorColor

2020-01-21 Thread Noah Davis
ndavis added a comment. I think this is still ultimately the right thing to do. Making the frame/separator color a mix of 2 other colors makes it harder to get just the right color for both the light and dark variations of a theme unless you design the color palettes to solve problems in the

D26691: Optimize code when dropping files into the desktop

2020-01-21 Thread Tranter Madi
trmdi edited the summary of this revision. REPOSITORY R242 Plasma Framework (Library) BRANCH improve-file-drop-menu REVISION DETAIL https://phabricator.kde.org/D26691 To: trmdi, #plasma, mart, broulik, #vdg, davidedmundson Cc: davidedmundson, anthonyfieroni, #plasma, kde-frameworks-devel,

D26691: Optimize code when dropping files into the desktop

2020-01-21 Thread Tranter Madi
trmdi marked an inline comment as done. REPOSITORY R242 Plasma Framework (Library) BRANCH improve-file-drop-menu REVISION DETAIL https://phabricator.kde.org/D26691 To: trmdi, #plasma, mart, broulik, #vdg, davidedmundson Cc: davidedmundson, anthonyfieroni, #plasma, kde-frameworks-devel, Le

D26691: Optimize code when dropping files into the desktop

2020-01-21 Thread Tranter Madi
trmdi updated this revision to Diff 74036. trmdi marked 2 inline comments as done. trmdi added a comment. - Address comment REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26691?vs=74030&id=74036 BRANCH improve-file-drop-menu REVISION

D26812: Variable expansion: Add variable PercentEncoded

2020-01-21 Thread Dominik Haumann
This revision was automatically updated to reflect the committed changes. Closed by commit R39:b0055e8476bb: Variable expansion: Add variable PercentEncoded (authored by dhaumann). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26812?vs=74032&id=74034 REVI

D26811: Fix crash in variable expansion (used by external tools)

2020-01-21 Thread Dominik Haumann
This revision was automatically updated to reflect the committed changes. Closed by commit R39:22fa707eb7e2: Fix crash in variable expansion (used by external tools) (authored by dhaumann). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26811?vs=74031&id=74

D26812: Variable expansion: Add variable PercentEncoded

2020-01-21 Thread Christoph Cullmann
cullmann accepted this revision. This revision is now accepted and ready to land. REPOSITORY R39 KTextEditor BRANCH variable-percent-encoded REVISION DETAIL https://phabricator.kde.org/D26812 To: dhaumann, cullmann Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, GB_2, domson,

D26812: Variable expansion: Add variable PercentEncoded

2020-01-21 Thread Dominik Haumann
dhaumann created this revision. dhaumann added a reviewer: cullmann. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. dhaumann requested review of this revision. REVISION SUMMARY This can be used to encode the input text such that it can be

D26811: Fix crash in variable expansion (used by external tools)

2020-01-21 Thread Christoph Cullmann
cullmann accepted this revision. This revision is now accepted and ready to land. REPOSITORY R39 KTextEditor BRANCH fix-variable-expansion REVISION DETAIL https://phabricator.kde.org/D26811 To: dhaumann, cullmann Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, GB_2, domson, mi

D26691: Optimize code when dropping files into the desktop

2020-01-21 Thread David Edmundson
davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. Cool cool. I think there's potential to move more logic from ContainmentInterface into DropMenu object, but we can spread that task out. We actually have some crashers i

D26691: Optimize code when dropping files into the desktop

2020-01-21 Thread Tranter Madi
trmdi marked 3 inline comments as done. trmdi added inline comments. INLINE COMMENTS > davidedmundson wrote in containmentinterface.cpp:548 > can you be sure urls has at least 1 at this point? Yes, because all `clearDataForMimeJob` are called from inside of `mimeTypeRetrieved` which is only cal

D26811: Fix crash in variable expansion (used by external tools)

2020-01-21 Thread Dominik Haumann
dhaumann created this revision. dhaumann added a reviewer: cullmann. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. dhaumann requested review of this revision. REVISION SUMMARY findClosing() is already called with +2 to account for the st

D26691: Optimize code when dropping files into the desktop

2020-01-21 Thread Tranter Madi
trmdi updated this revision to Diff 74030. trmdi added a comment. - Code style REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26691?vs=74025&id=74030 BRANCH improve-file-drop-menu REVISION DETAIL https://phabricator.kde.org/D26691

D26782: KFilePlacesModel: On new profile in recent show only recentlyused:/ based entries by default

2020-01-21 Thread Nathaniel Graham
ngraham added a comment. In D26782#597916 , @meven wrote: > In D26782#597811 , @ngraham wrote> > > > But should we just hide them, or not even create them in the first place? Creating hidden-by-defa

D26691: Optimize code when dropping files into the desktop

2020-01-21 Thread Tranter Madi
trmdi updated this revision to Diff 74025. trmdi added a comment. - Handle the case in which the menu is not shown REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26691?vs=73815&id=74025 BRANCH improve-file-drop-menu REVISION DETAIL

D26047: Expose KConfig settings to allow registration in KCM Notification

2020-01-21 Thread Cyril Rossi
crossi updated this revision to Diff 74023. crossi added a comment. Remove unneeded forward declaration REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26047?vs=74021&id=74023 REVISION DETAIL https://phabricator.kde.org/D26047 AFFECTED FILES l

D26047: Expose KConfig settings to allow registration in KCM Notification

2020-01-21 Thread Kevin Ottens
ervin requested changes to this revision. ervin added a comment. This revision now requires changes to proceed. I like it, just an unwanted change to clean up still. @broulik what say you? INLINE COMMENTS > settings.h:33 > > +class KCoreConfigSkeleton; > + This change isn't needed anymore.

D26047: Expose KConfig settings to allow registration in KCM Notification

2020-01-21 Thread Cyril Rossi
crossi updated this revision to Diff 74021. crossi added a comment. Following discussion with @ervin and @broulik, export generated KConfig settings, remove singleton option. The KCM will have its own KConfig settings' instance like other KCMs. REPOSITORY R120 Plasma Workspace CHANGES SIN

D26794: [WIP] Implement comment posting (and reenable voting)

2020-01-21 Thread Dan Leinir Turthra Jensen
leinir edited the summary of this revision. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D26794 To: leinir Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26794: [WIP] Implement comment posting (and reenable voting)

2020-01-21 Thread Dan Leinir Turthra Jensen
leinir updated this revision to Diff 74016. leinir added a comment. - Allow clearing the Rating control when editable - Initial new-comment sheet (needs some layout work) REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26794?vs=73944&id=74016 BRANCH m

D26066: [KProcessInfo] Add parent PID

2020-01-21 Thread Kai Uwe Broulik
broulik abandoned this revision. broulik added a comment. Am now using ksysguard.. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D26066 To: broulik, #frameworks, davidedmundson Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26690: Make "Default Applications" in mimeapps.list the preferred applications

2020-01-21 Thread Méven Car
meven added a task: T12551: Revamp KCM/Component chooser. REPOSITORY R309 KService REVISION DETAIL https://phabricator.kde.org/D26690 To: meven, dfaure, dvratil, ervin, #frameworks Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D26801: Really fix the Windows backend for KNotifications

2020-01-21 Thread Hannah von Reth
vonreth added inline comments. INLINE COMMENTS > notifybysnore.cpp:90 > +KNotification *notification = m_notifications.value(id); > +if (notification == 0) { > qCDebug(LOG_KNOTIFICATIONS) << "Notification not found!"; if (!notification) or at least compare with nullp

D26801: Really fix the Windows backend for KNotifications

2020-01-21 Thread Piyush Aggarwal
brute4s99 marked an inline comment as done. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D26801 To: brute4s99, vonreth, broulik, #kde_connect Cc: anthonyfieroni, kde-frameworks-devel, nalvarez, KunalRaghav, ankitbaluni, ankit, aliencode, Orage, ritwizsinha, LeG

D26801: Really fix the Windows backend for KNotifications

2020-01-21 Thread Piyush Aggarwal
brute4s99 updated this revision to Diff 74005. brute4s99 marked 3 inline comments as done. brute4s99 added a comment. update the diff. REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26801?vs=73983&id=74005 BRANCH master REVISION DETAIL https://

KDE CI: Frameworks » kservice » kf5-qt5 SUSEQt5.12 - Build # 99 - Still Unstable!

2020-01-21 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kservice/job/kf5-qt5%20SUSEQt5.12/99/ Project: kf5-qt5 SUSEQt5.12 Date of build: Tue, 21 Jan 2020 10:36:38 + Build duration: 2 min 57 sec and counting BUILD ARTIFACTS abi-compatibi

KDE CI: Frameworks » kservice » kf5-qt5 SUSEQt5.13 - Build # 73 - Still Unstable!

2020-01-21 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kservice/job/kf5-qt5%20SUSEQt5.13/73/ Project: kf5-qt5 SUSEQt5.13 Date of build: Tue, 21 Jan 2020 10:36:39 + Build duration: 2 min 45 sec and counting BUILD ARTIFACTS abi-compatibi

KDE CI: Frameworks » kservice » kf5-qt5 FreeBSDQt5.13 - Build # 70 - Still Unstable!

2020-01-21 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kservice/job/kf5-qt5%20FreeBSDQt5.13/70/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Tue, 21 Jan 2020 10:36:39 + Build duration: 2 min 41 sec and counting JUnit Tests Name: proje

D26690: Make "Default Applications" in mimeapps.list the preferred applications

2020-01-21 Thread Méven Car
This revision was automatically updated to reflect the committed changes. Closed by commit R309:f10db4e6f0af: Make "Default Applications" in mimeapps.list the preferred applications (authored by meven). REPOSITORY R309 KService CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26690?vs=

D26690: Make "Default Applications" in mimeapps.list the preferred applications

2020-01-21 Thread Méven Car
meven updated this revision to Diff 74002. meven added a comment. Fix indentation issue REPOSITORY R309 KService CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26690?vs=73996&id=74002 BRANCH arcpatch-D26690 REVISION DETAIL https://phabricator.kde.org/D26690 AFFECTED FILES

D26690: Make "Default Applications" in mimeapps.list the preferred applications

2020-01-21 Thread Kevin Ottens
ervin accepted this revision. REPOSITORY R309 KService BRANCH arcpatch-D26690 REVISION DETAIL https://phabricator.kde.org/D26690 To: meven, dfaure, dvratil, ervin, #frameworks Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D26800: autotests: use local desktop file to avoid relying on konsole

2020-01-21 Thread Méven Car
meven added inline comments. INLINE COMMENTS > dfaure wrote in kservicetest.cpp:73 > (to expand on my previous reply: this line ensures that we copy the desktop > files into a test-specific directory) Thanks, did not notice this line and did not know setTestModeEnabled Learning every day... RE

D26800: autotests: use local desktop file to avoid relying on konsole

2020-01-21 Thread David Faure
dfaure added inline comments. INLINE COMMENTS > kservicetest.cpp:73 > setupXdgDirs(); > QStandardPaths::setTestModeEnabled(true); > (to expand on my previous reply: this line ensures that we copy the desktop files into a test-specific directory) REPOSITORY R309 KService REVISION

D26801: Really fix the Windows backend for KNotifications

2020-01-21 Thread Hannah von Reth
vonreth added inline comments. INLINE COMMENTS > anthonyfieroni wrote in notifybysnore.cpp:143 > So the problem isn't here. notification id should be always valid and not > calculated here. I'm not sure what would be correct here but just ignoring those notifications sounds like a bad idea. T

D26690: Make "Default Applications" in mimeapps.list the preferred applications

2020-01-21 Thread Méven Car
meven marked 6 inline comments as done. REPOSITORY R309 KService BRANCH arcpatch-D26690 REVISION DETAIL https://phabricator.kde.org/D26690 To: meven, dfaure, dvratil, ervin, #frameworks Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D26690: Make "Default Applications" in mimeapps.list the preferred applications

2020-01-21 Thread Méven Car
meven updated this revision to Diff 73996. meven added a comment. Add explanatory comment regarding 25 magic number REPOSITORY R309 KService CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26690?vs=73913&id=73996 BRANCH arcpatch-D26690 REVISION DETAIL https://phabricator.kde.

D26782: KFilePlacesModel: On new profile in recent show only recentlyused:/ based entries by default

2020-01-21 Thread Méven Car
meven updated this revision to Diff 73995. meven marked an inline comment as done. meven added a comment. Added missing spaces REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26782?vs=73917&id=73995 BRANCH arcpatch-D26782 REVISION DETAIL https://phabricato

D26782: KFilePlacesModel: On new profile in recent show only recentlyused:/ based entries by default

2020-01-21 Thread Méven Car
meven added a comment. In D26782#597811 , @ngraham wrote> > But should we just hide them, or not even create them in the first place? Creating hidden-by-default entries seems a bit off. I chose hidden by value just to keep the feature som

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 276 - Still Unstable!

2020-01-21 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/276/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Tue, 21 Jan 2020 08:34:05 + Build duration: 6 min 16 sec and counting JUnit Tests Name: projectro

KDE CI: Frameworks » kservice » kf5-qt5 SUSEQt5.13 - Build # 72 - Unstable!

2020-01-21 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kservice/job/kf5-qt5%20SUSEQt5.13/72/ Project: kf5-qt5 SUSEQt5.13 Date of build: Tue, 21 Jan 2020 08:33:38 + Build duration: 2 min 24 sec and counting BUILD ARTIFACTS abi-compatibi

KDE CI: Frameworks » kservice » kf5-qt5 SUSEQt5.12 - Build # 98 - Unstable!

2020-01-21 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kservice/job/kf5-qt5%20SUSEQt5.12/98/ Project: kf5-qt5 SUSEQt5.12 Date of build: Tue, 21 Jan 2020 08:33:38 + Build duration: 2 min 32 sec and counting BUILD ARTIFACTS abi-compatibi

KDE CI: Frameworks » kservice » kf5-qt5 FreeBSDQt5.13 - Build # 69 - Unstable!

2020-01-21 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kservice/job/kf5-qt5%20FreeBSDQt5.13/69/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Tue, 21 Jan 2020 08:33:38 + Build duration: 2 min 26 sec and counting JUnit Tests Name: proje

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 275 - Still Unstable!

2020-01-21 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/275/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Tue, 21 Jan 2020 08:26:18 + Build duration: 7 min 35 sec and counting JUnit Tests Name: projectro

D26800: autotests: use local desktop file to avoid relying on konsole

2020-01-21 Thread David Faure
dfaure closed this revision. REPOSITORY R309 KService REVISION DETAIL https://phabricator.kde.org/D26800 To: dfaure, meven, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 409 - Still Failing!

2020-01-21 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/409/ Project: kf5-qt5 SUSEQt5.12 Date of build: Tue, 21 Jan 2020 08:28:32 + Build duration: 1 min 9 sec and counting CONSOLE OUTPUT [...truncated 670 li

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 408 - Failure!

2020-01-21 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/408/ Project: kf5-qt5 SUSEQt5.12 Date of build: Tue, 21 Jan 2020 08:26:17 + Build duration: 2 min 12 sec and counting CONSOLE OUTPUT [...truncated 663 l

D26692: Fix QRegularExpression::wildcardToRegularExpression() usage

2020-01-21 Thread Ahmad Samir
This revision was automatically updated to reflect the committed changes. Closed by commit R241:0d2959c96b6b: Fix QRegularExpression::wildcardToRegularExpression() usage (authored by ahmadsamir). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26692?vs=73991&id=73

D26692: Fix QRegularExpression::wildcardToRegularExpression() usage

2020-01-21 Thread Ahmad Samir
ahmadsamir updated this revision to Diff 73991. ahmadsamir added a comment. Rebase REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26692?vs=73650&id=73991 BRANCH l-qregularexpression-too-wildcard (branched from master) REVISION DETAIL https://phabricator.k

D26659: [KCoreDirLister] Port QRegExp to QRegularExpression

2020-01-21 Thread Ahmad Samir
ahmadsamir updated this revision to Diff 73989. ahmadsamir edited the summary of this revision. ahmadsamir added a comment. Rebase and tweak the commit message REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26659?vs=73796&id=73989 BRANCH l-qregexp-deprecate

D26659: [KCoreDirLister] Port QRegExp to QRegularExpression

2020-01-21 Thread Ahmad Samir
This revision was automatically updated to reflect the committed changes. Closed by commit R241:df383663d14e: [KCoreDirLister] Port QRegExp to QRegularExpression (authored by ahmadsamir). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26659?vs=73989&id=73990 REVI