D26650: Use KService to look for Filelight

shubham added a comment. @broulik @ngraham Any updates on this, how to proceed? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D26650 To: shubham, broulik, ngraham Cc: sitter, meven, anthonyfieroni, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26920: Change VLC icon to be more like official VLC icons

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R266:e215cca8900f: Change VLC icon to be more like official VLC icons (authored by ndavis). REPOSITORY R266 Breeze Icons

D26920: Change VLC icon to be more like official VLC icons

ndavis edited the summary of this revision. ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D26920 To: ndavis, #vdg Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26920: Change VLC icon to be more like official VLC icons

ndavis created this revision. ndavis added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ndavis requested review of this revision. REVISION SUMMARY This new icon is more in line with our policy on preserving the branding of apps.

KDE CI: Frameworks » ktexteditor » kf5-qt5 FreeBSDQt5.13 - Build # 173 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20FreeBSDQt5.13/173/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sat, 25 Jan 2020 17:17:32 + Build duration: 6 min 12 sec and counting JUnit Tests Name:

D26133: Enable Auto Save

tcanabrava added a comment. I agree with the comments, but I'm a bit lost on how to implement that in KCoreConfigSkeleton: the isSaveNeeded reads the value of the variable and return if it's different from the reference variable. (that I tougth it was a reference *value*, to find out that

D26903: allow programLogo property to be a QIcon, too

cullmann added a comment. Would something like this be ok? Not sure what to write about sizes, e.g. for the program icon we don't mention anything either. The QPixmap case was missing in the docs, too, btw. diff --git a/src/lib/kaboutdata.h b/src/lib/kaboutdata.h index

D26903: allow programLogo property to be a QIcon, too

kossebau added a comment. I propose to also extend the KAboutData::programLogo documentation to specify that QIcon is supported/expected. So this is not some surprise bebaviour. While at it, please also note there recommended logo pixmap size usages, to avoid blurring. REPOSITORY

D26903: allow programLogo property to be a QIcon, too

This revision was automatically updated to reflect the committed changes. Closed by commit R263:260a3094de02: allow programLogo property to be a QIcon, too (authored by cullmann). REPOSITORY R263 KXmlGui CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26903?vs=74330=74364 REVISION

D26918: Improve KNotification API docs

nicolasfella added a reviewer: jucato. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D26918 To: nicolasfella, #frameworks, broulik, jucato Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26918: Improve KNotification API docs

nicolasfella created this revision. nicolasfella added reviewers: Frameworks, broulik. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY Various improvements. Better examples, updated coding

D26407: KFileItem: Improve isSlow to not block when a network mount is unresponsive, make SkipMimeTypeFromContent skip only on slow fs

meven added a dependent revision: D26916: Allow to display in the kicker appliation context menu the recently accessed directories. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D26407 To: meven, #frameworks, ngraham, broulik, dfaure Cc: anthonyfieroni,

D26407: KFileItem: Improve isSlow to not block when a network mount is unresponsive, make SkipMimeTypeFromContent skip only on slow fs

meven added a dependent revision: D26915: Allow to display in the task context menu the recently accessed directories. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D26407 To: meven, #frameworks, ngraham, broulik, dfaure Cc: anthonyfieroni, kde-frameworks-devel,

D26888: work around to fully support the windows backend

brute4s99 added reviewers: vonreth, broulik, KDE Connect. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D26888 To: brute4s99, vonreth, broulik, #kde_connect Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26801: Really fix the Windows backend for KNotifications

brute4s99 marked 2 inline comments as done. brute4s99 added a comment. I will be closing this diff as I recently formed a simpler patch. Inviting your reviews on that one! https://phabricator.kde.org/D26888 REPOSITORY R289 KNotifications REVISION DETAIL

D26888: work around to fully support the windows backend

brute4s99 abandoned this revision. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D26888 To: brute4s99, vonreth, broulik, #kde_connect Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25517: Add an option to extract image data and add front cover property

astippich added a comment. friendly ping for the series REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D25517 To: astippich, #baloo, bruns, mgallien, ngraham Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, fbampaloukas, GB_2, domson,

D26840: Correctly set underMouse() for inline notes

This revision was automatically updated to reflect the committed changes. Closed by commit R39:7f043fbb26d4: inline notes: correctly set underMouse() for inline notes (authored by brauch). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D26840?vs=74110=74351#toc REPOSITORY R39

D26840: Correctly set underMouse() for inline notes

brauch added a comment. Ok, done ;) REPOSITORY R39 KTextEditor BRANCH underMouse (branched from master) REVISION DETAIL https://phabricator.kde.org/D26840 To: davidre, #ktexteditor, cullmann, brauch Cc: brauch, cullmann, kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, GB_2,

D26840: Correctly set underMouse() for inline notes

davidre added a comment. In D26840#600618 , @brauch wrote: > If you want I can integrate these changes and submit your patch, should I? Thanks a lot for your contribution. Feel free to! REPOSITORY R39 KTextEditor BRANCH underMouse

D26840: Correctly set underMouse() for inline notes

brauch accepted this revision. brauch added a comment. If you want I can integrate these changes and submit your patch, should I? Thanks a lot for your contribution. REPOSITORY R39 KTextEditor BRANCH underMouse (branched from master) REVISION DETAIL https://phabricator.kde.org/D26840

D26890: QXmlInputSource is deprecated in qt5.15. Port it to QXmlStreamReader

mlaurent updated this revision to Diff 74349. mlaurent added a comment. We need to open QIODevice. Now all works correctly after rebuilding all REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26890?vs=74348=74349 BRANCH port_QXmlStreamReader (branched