D25326: Move Plasma's SortFilterProxyModel into KItemModel's QML plugin

This revision was automatically updated to reflect the committed changes. Closed by commit R275:4fd7a211bb8d: Move Plasma's SortFilterProxyModel into KItemModel's QML plugin (authored by ahiemstra, committed by davidedmundson). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D25326?vs=7460

KDE CI: Frameworks » kitemmodels » kf5-qt5 FreeBSDQt5.13 - Build # 59 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kitemmodels/job/kf5-qt5%20FreeBSDQt5.13/59/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Thu, 06 Feb 2020 09:35:13 + Build duration: 1 min 51 sec and counting JUnit Tests Name: pr

KDE CI: Frameworks » kitemmodels » kf5-qt5 WindowsMSVCQt5.14 - Build # 4 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kitemmodels/job/kf5-qt5%20WindowsMSVCQt5.14/4/ Project: kf5-qt5 WindowsMSVCQt5.14 Date of build: Thu, 06 Feb 2020 09:35:15 + Build duration: 4 min 19 sec and counting JUnit Tests N

KDE CI: Frameworks » kitemmodels » kf5-qt5 SUSEQt5.12 - Build # 85 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kitemmodels/job/kf5-qt5%20SUSEQt5.12/85/ Project: kf5-qt5 SUSEQt5.12 Date of build: Thu, 06 Feb 2020 09:35:12 + Build duration: 4 min 45 sec and counting BUILD ARTIFACTS abi-compat

KDE CI: Frameworks » kitemmodels » kf5-qt5 SUSEQt5.13 - Build # 62 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kitemmodels/job/kf5-qt5%20SUSEQt5.13/62/ Project: kf5-qt5 SUSEQt5.13 Date of build: Thu, 06 Feb 2020 09:35:14 + Build duration: 8 min 33 sec and counting BUILD ARTIFACTS abi-compat

D27059: KConfigSkeletonItem : allow to set a KconfigGroup to read and write items in nested groups

crossi edited the summary of this revision. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D27059 To: crossi, ervin, dfaure, #frameworks Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D27187: update travel-family icons

mbruchert created this revision. mbruchert added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mbruchert requested review of this revision. REPOSITORY R266 Breeze Icons BRANCH travel-family REVISION DETAIL https://phabricator.kde.org/

D27187: update travel-family icons

mbruchert updated this revision to Diff 75092. mbruchert added a comment. optimize svgs REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27187?vs=75091&id=75092 BRANCH travel-family REVISION DETAIL https://phabricator.kde.org/D27187 AFFECTED FILES

KDE CI: Frameworks » kitemmodels » kf5-qt5 FreeBSDQt5.13 - Build # 60 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kitemmodels/job/kf5-qt5%20FreeBSDQt5.13/60/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Thu, 06 Feb 2020 10:37:23 + Build duration: 3 min 39 sec and counting JUnit Tests Name: pro

KDE CI: Frameworks » kitemmodels » kf5-qt5 WindowsMSVCQt5.14 - Build # 5 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kitemmodels/job/kf5-qt5%20WindowsMSVCQt5.14/5/ Project: kf5-qt5 WindowsMSVCQt5.14 Date of build: Thu, 06 Feb 2020 10:37:24 + Build duration: 5 min 49 sec and counting JUnit Tests Na

KDE CI: Frameworks » kitemmodels » kf5-qt5 SUSEQt5.12 - Build # 86 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kitemmodels/job/kf5-qt5%20SUSEQt5.12/86/ Project: kf5-qt5 SUSEQt5.12 Date of build: Thu, 06 Feb 2020 10:37:24 + Build duration: 6 min 35 sec and counting BUILD ARTIFACTS abi-compati

KDE CI: Frameworks » kitemmodels » kf5-qt5 SUSEQt5.13 - Build # 63 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kitemmodels/job/kf5-qt5%20SUSEQt5.13/63/ Project: kf5-qt5 SUSEQt5.13 Date of build: Thu, 06 Feb 2020 10:37:23 + Build duration: 8 min 5 sec and counting BUILD ARTIFACTS abi-compatib

D27017: [KColorUtils] Add hue(), chroma(), getHcyColor() and update documentation

ndavis updated this revision to Diff 75094. ndavis added a comment. - Update @since version and fix hcyColor comment edit I missed REPOSITORY R273 KGuiAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27017?vs=75022&id=75094 BRANCH hue-chroma (branched from master) REVISIO

D27017: [KColorUtils] Add hue(), chroma(), getHcyColor() and update documentation

ndavis updated this revision to Diff 75097. ndavis added a comment. - Remove getHcy hue value change REPOSITORY R273 KGuiAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27017?vs=75094&id=75097 BRANCH hue-chroma (branched from master) REVISION DETAIL https://phabricator

D27017: [KColorUtils] Add hue(), chroma(), getHcyColor() and update documentation

ndavis added inline comments. INLINE COMMENTS > mwoehlke wrote in kcolorutils.cpp:60 > I guess it will be less confusing if this is also normalized? > > *h = khcy.h + (khcy.h < 0.0 ? 1.0 : 0.0); I should probably put this change in another commit so as not to do too much at once, so I'm remo

D27190: [surface] Fix buffer offset when attaching buffers to surfaces

davidedmundson created this revision. davidedmundson added a reviewer: KWin. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. davidedmundson requested review of this revision. TEST PLAN Unit test Will be tested by hotspots in drag icons REPOSITORY R127 KW

D27190: [surface] Fix buffer offset when attaching buffers to surfaces

zzag accepted this revision. This revision is now accepted and ready to land. REPOSITORY R127 KWayland BRANCH master REVISION DETAIL https://phabricator.kde.org/D27190 To: davidedmundson, #kwin, zzag Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D27190: [surface] Fix buffer offset when attaching buffers to surfaces

This revision was automatically updated to reflect the committed changes. Closed by commit R127:f8760c97b65e: [surface] Fix buffer offset when attaching buffers to surfaces (authored by davidedmundson). REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27190?vs=

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.12 - Build # 98 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.12/98/ Project: kf5-qt5 SUSEQt5.12 Date of build: Thu, 06 Feb 2020 11:29:15 + Build duration: 17 min and counting BUILD ARTIFACTS abi-compatibility-r

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.13 - Build # 57 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.13/57/ Project: kf5-qt5 SUSEQt5.13 Date of build: Thu, 06 Feb 2020 11:29:14 + Build duration: 17 min and counting BUILD ARTIFACTS abi-compatibility-r

D27187: update travel-family icons

ndavis requested changes to this revision. ndavis added a comment. This revision now requires changes to proceed. Whoops, looks like you accidentally made them 48x48 mm instead of 48x48 px :) You'll need to work on the pixel alignment a bit because shrinking them down to the correct size

KDE CI: Frameworks » kwayland » kf5-qt5 FreeBSDQt5.13 - Build # 51 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20FreeBSDQt5.13/51/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Thu, 06 Feb 2020 11:29:16 + Build duration: 32 min and counting JUnit Tests Name: projectroot

D27192: [KColorUtils] Change getHcy() hue range to [0.0, 1.0)

ndavis created this revision. ndavis added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ndavis requested review of this revision. REVISION SUMMARY As suggested by @mwoehlke in D27017 Users a

D27192: [KColorUtils] Change getHcy() hue range to [0.0, 1.0)

ndavis added a reviewer: dfaure. REPOSITORY R273 KGuiAddons REVISION DETAIL https://phabricator.kde.org/D27192 To: ndavis, #frameworks, dfaure Cc: kde-frameworks-devel, mwoehlke, LeGast00n, GB_2, michaelh, ngraham, bruns

D27192: [KColorUtils] Change getHcy() hue range to [0.0, 1.0)

ndavis added a dependency: D27017: [KColorUtils] Add hue(), chroma(), getHcyColor() and update documentation. REPOSITORY R273 KGuiAddons REVISION DETAIL https://phabricator.kde.org/D27192 To: ndavis, #frameworks, dfaure Cc: kde-frameworks-devel, mwoehlke, LeGast00n, GB_2, michaelh, ngraham,

D27017: [KColorUtils] Add hue(), chroma(), getHcyColor() and update documentation

ndavis marked an inline comment as done. REPOSITORY R273 KGuiAddons REVISION DETAIL https://phabricator.kde.org/D27017 To: ndavis, #frameworks, dfaure Cc: mwoehlke, broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D27017: [KColorUtils] Add hue(), chroma(), getHcyColor() and update documentation

ndavis added a dependent revision: D27192: [KColorUtils] Change getHcy() hue range to [0.0, 1.0). REPOSITORY R273 KGuiAddons REVISION DETAIL https://phabricator.kde.org/D27017 To: ndavis, #frameworks, dfaure Cc: mwoehlke, broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, b

D27017: [KColorUtils] Add hue(), chroma(), hcyColor() and update documentation

ndavis retitled this revision from "[KColorUtils] Add hue(), chroma(), getHcyColor() and update documentation" to "[KColorUtils] Add hue(), chroma(), hcyColor() and update documentation". ndavis edited the summary of this revision. REPOSITORY R273 KGuiAddons REVISION DETAIL https://phabrica

D27192: [KColorUtils] Change getHcy() hue range to [0.0, 1.0)

ndavis added a reviewer: mwoehlke. REPOSITORY R273 KGuiAddons REVISION DETAIL https://phabricator.kde.org/D27192 To: ndavis, #frameworks, dfaure, mwoehlke Cc: kde-frameworks-devel, mwoehlke, LeGast00n, GB_2, michaelh, ngraham, bruns

D27017: [KColorUtils] Add hue(), chroma(), hcyColor() and update documentation

ndavis added a reviewer: mwoehlke. REPOSITORY R273 KGuiAddons REVISION DETAIL https://phabricator.kde.org/D27017 To: ndavis, #frameworks, dfaure, mwoehlke Cc: mwoehlke, broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D27187: update travel-family icons

nicolasfella added a comment. Please add some screenshots REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D27187 To: mbruchert, #vdg, ndavis Cc: nicolasfella, ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D27150: Add ecm_qt_install_logging_categories & ecm_qt_export_logging_category

kossebau added a comment. @mlaurent Thanks for review :) Do you happen to know any more complex usages of ecm_qt_declare_logging_category and/or manual category definitions which can and should be checked for how these new methods would work out? I have not really researched bigger parts

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

niccolove added a comment. Nope, I'm absolutely unable to build plasma-framework right now, I have many problems that I don't understand :-/ Also, I have 0 Cmake experience If somebody has time, can they look into how to make Cmake read that file? REPOSITORY R242 Plasma Framework (Library

D27150: Add ecm_qt_install_logging_categories & ecm_qt_export_logging_category

mlaurent added a comment. I don't see other case. For me your macro works for all case that we can implement. No other idea. But avoiding to create by hand the file is a good idea. I never successed to create a macro for it So thanks REPOSITORY R240 Extra CMake Modules BRANCH a

D27195: Change "Redisplay" to "Refresh"

ngraham created this revision. ngraham added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ngraham requested review of this revision. REVISION SUMMARY "Redisplay" is an unusual and archaic term which has ben supplanted in common use with

D27195: Change "Redisplay" to "Refresh"

ngraham edited the summary of this revision. REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D27195 To: ngraham, #vdg Cc: kde-frameworks-devel, The-Feren-OS-Dev, LeGast00n, GB_2, michaelh, ngraham, bruns

D27195: Change "Redisplay" to "Refresh"

ngraham added a comment. "Reload" could also work, as that's also a very common and recognizable term. REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D27195 To: ngraham, #vdg Cc: kde-frameworks-devel, The-Feren-OS-Dev, LeGast00n, GB_2, michaelh, ngraham, brun

D27195: Change "Redisplay" to "Refresh"

The-Feren-OS-Dev accepted this revision. The-Feren-OS-Dev added a comment. This revision is now accepted and ready to land. This is something I've recently suggested myself, so having this happen would be a small change but still a good change. Furthermore this'll make it consistent with

D27195: Change "Redisplay" to "Refresh"

ndavis accepted this revision. REPOSITORY R265 KConfigWidgets BRANCH redisplay-to-refresh (branched from master) REVISION DETAIL https://phabricator.kde.org/D27195 To: ngraham, #vdg, The-Feren-OS-Dev, ndavis Cc: kde-frameworks-devel, The-Feren-OS-Dev, LeGast00n, GB_2, michaelh, ngraham,

D27195: Change "Redisplay" to "Refresh"

The-Feren-OS-Dev added a comment. In D27195#606954 , @ngraham wrote: > "Reload" could also work, as that's also a very common and recognizable term. That is a good point but if you call it "Reload" you might as well proceed to also repla

D27187: update travel-family icons

mbruchert updated this revision to Diff 75114. mbruchert added a comment. - screenshot icon REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27187?vs=75092&id=75114 BRANCH screenshot REVISION DETAIL https://phabricator.kde.org/D27187 AFFECTED FILE

D27187: update travel-family icons

ngraham added a comment. I think he meant to add some screenshots to the Test Plan section of this patch so people can see the new icons without having to apply it. :) REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D27187 To: mbruchert, #vdg, ndavis Cc: ngraham

D27187: update travel-family icons

mbruchert updated this revision to Diff 75116. mbruchert added a comment. fix REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27187?vs=75114&id=75116 BRANCH screenshot REVISION DETAIL https://phabricator.kde.org/D27187 AFFECTED FILES icons-dark

D27017: [KColorUtils] Add hue(), chroma(), hcyColor() and update documentation

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R273:4de9a9318e61: [KColorUtils] Add hue(), chroma(), hcyColor() and update documentation (authored by ndavis). REPOSITORY

D27192: [KColorUtils] Change getHcy() hue range to [0.0, 1.0)

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R273:2dc164e18a95: [KColorUtils] Change getHcy() hue range to [0.0, 1.0) (authored by ndavis). REPOSITORY R273 KGuiAddons

D27187: update travel-family icons

mbruchert updated this revision to Diff 75121. mbruchert added a comment. - fix everything(px) REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27187?vs=75116&id=75121 BRANCH screenshot REVISION DETAIL https://phabricator.kde.org/D27187 AFFECTED F

D27195: Change "Redisplay" to "Refresh"

This revision was automatically updated to reflect the committed changes. Closed by commit R265:fe1d3a3f451a: Change "Redisplay" to "Refresh" (authored by ngraham). REPOSITORY R265 KConfigWidgets CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27195?vs=75113&id=75122 REVISION DETAIL

D27195: Change "Redisplay" to "Refresh"

ngraham added a comment. All right, "Refresh" it is, then! REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D27195 To: ngraham, #vdg, The-Feren-OS-Dev, ndavis Cc: kde-frameworks-devel, The-Feren-OS-Dev, LeGast00n, GB_2, michaelh, ngraham, bruns

D27187: update travel-family icons

mbruchert updated this revision to Diff 75124. mbruchert added a comment. fix everything for real REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27187?vs=75121&id=75124 BRANCH screenshot REVISION DETAIL https://phabricator.kde.org/D27187 AFFECTE

D27197: Add symbolic screenshot icons

mbruchert created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mbruchert requested review of this revision. REPOSITORY R266 Breeze Icons BRANCH sreenshot REVISION DETAIL https://phabricator.kde.org/D27197 AFFECTED FILES icons/action

D27187: update travel-family icons

mbruchert added a comment. F8088755: image.png REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D27187 To: mbruchert, #vdg, ndavis Cc: ngraham, nicolasfella, ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D27187: update travel-family icons

nicolasfella edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D27187 To: mbruchert, #vdg, ndavis Cc: ngraham, nicolasfella, ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D27187: update travel-family icons

ndavis added a comment. Much better. Now the margins need to be 4px rather than 3px. If you haven't already, make sure you read the HIG section on icons and the workflow tips wiki page it links to. https://hig.kde.org/style/icons/index.html https://community.kde.org/Guidelines_and_HOWTOs/

D27195: Change "Redisplay" to "Refresh"

cfeck added a comment. Refresh is fine, Reload could be irritating for applications that don't load anything, but still know the user could be faced with a view state that needs redrawing, e.g. when cleaning corruption caused by non-integer scale factors. REPOSITORY R265 KConfigWidgets RE

D27187: update travel-family icons

mbruchert updated this revision to Diff 75130. mbruchert added a comment. - screenshot icon - 4px border REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27187?vs=75124&id=75130 BRANCH 4px REVISION DETAIL https://phabricator.kde.org/D27187 AFFEC

D27187: update travel-family icons

mbruchert updated this revision to Diff 75131. mbruchert added a comment. remove accidentially commited files REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27187?vs=75130&id=75131 BRANCH 4px REVISION DETAIL https://phabricator.kde.org/D27187 AF

D27187: update travel-family icons

mbruchert updated this revision to Diff 75132. mbruchert added a comment. remove accidentially commited icons REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27187?vs=75131&id=75132 BRANCH 4px REVISION DETAIL https://phabricator.kde.org/D27187 AF

D27200: Make the attached proeprty a simple QObject

mart created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mart requested review of this revision. REVISION SUMMARY move all the logic in an attached property QObject it's a bit less heavy to create so should make things slightly better w

D27200: Make the attached proeprty a simple QObject

mart edited the test plan for this revision. mart added reviewers: bshah, Plasma. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27200 To: mart, bshah, #plasma Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D27200: Make the attached property a simple QObject

nicolasfella retitled this revision from "Make the attached proeprty a simple QObject" to "Make the attached property a simple QObject". REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27200 To: mart, bshah, #plasma Cc: kde-frameworks-devel, LeGast00n

D27187: update travel-family icons

ndavis accepted this revision. ndavis added a comment. This revision is now accepted and ready to land. This looks ready to go. I'll do some additional optimization later. REPOSITORY R266 Breeze Icons BRANCH 4px REVISION DETAIL https://phabricator.kde.org/D27187 To: mbruchert, #vdg, n

D27187: update travel-family icons

This revision was automatically updated to reflect the committed changes. Closed by commit R266:cf10c681f350: update travel-family icons (authored by mbruchert, committed by ndavis). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27187?vs=75132&id=75135

D27187: update travel-family icons

ngraham added a comment. These are lovely icons, BTW. Very nice work. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D27187 To: mbruchert, #vdg, ndavis Cc: ngraham, nicolasfella, ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D27091: Convert license statements to SPDX

cgiboudeaux accepted this revision. This revision is now accepted and ready to land. REPOSITORY R246 Sonnet BRANCH spdx REVISION DETAIL https://phabricator.kde.org/D27091 To: cordlandwehr, cgiboudeaux Cc: cgiboudeaux, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D27103: Convert license headers to SPDX markers

cgiboudeaux added a comment. same remark as for D27106 . Check if FileContributor is more appropriate. REPOSITORY R275 KItemModels REVISION DETAIL https://phabricator.kde.org/D27103 To: cordlandwehr, dfaure Cc: cgiboudeaux, kde-frameworks-devel, LeGas

D27103: Convert license headers to SPDX markers

cgiboudeaux added inline comments. INLINE COMMENTS > modeltest.h:4 > > +SPDX-FileCopyrightText: 2013 Digia Plc and /or its subsidiary(-ies) > > +SPDX-FileCopyrightText: 2010 Stephen Kelly redirects to https://www.qt.io/terms-conditions/ nowadays REP

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

niccolove updated this revision to Diff 75145. niccolove added a comment. Fixed mistakes in breeze dark cmakelist REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27122?vs=75019&id=75145 BRANCH contrast_effect_background_color (branched

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

niccolove marked an inline comment as done. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27122 To: niccolove, ndavis, ngraham Cc: ndavis, filipf, ngraham, davidedmundson, kde-frameworks-devel, manueljlin, Orage, LeGast00n, The-Feren-OS-Dev, cblack,

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

ngraham accepted this revision. ngraham added a comment. Can confirm that it works, and I do think it looks better now. I'm not an expert on the SVG changes but I don't see anything obviously wrong in there. Please add a comment in the Description section of this patch explaining why the

D27200: Make the attached property a simple QObject

apol added a comment. LGTM otherwise INLINE COMMENTS > colorscope.cpp:57 > +connect(parentItem, &QQuickItem::windowChanged, > this, [this]() { > findParentScope(); let's make this a proper method? it's used twice here and a normal method should be quick

D27203: Don't try to open files we can't figure out where they are

apol created this revision. apol added a reviewer: Frameworks. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. apol requested review of this revision. TEST PLAN Been using it for a few days, no regressions. Opening sftp:///localhost/.../somefile.text twice, doesn't try

D25123: [WIP] New yakuake logo/icon

mglb updated this revision to Diff 75148. mglb added a comment. Huh, I was waiting for @hein :) oh well, here it is - C icon with cleaned up source REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25123?vs=69507&id=75148 BRANCH yakuake REVISION DETA

D25123: New yakuake logo/icon

mglb retitled this revision from "[WIP] New yakuake logo/icon" to "New yakuake logo/icon". REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D25123 To: mglb, #vdg, #yakuake, hein Cc: GB_2, ndavis, ognarb, ngraham, hein, kde-frameworks-devel, numerodix, vmarinescu, ry

D27185: Use the right translation catalog to show translations

victorr added a comment. Before F8089258: Before.jpg After F8089261: After.jpg REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D27185 To: yurchor, #frameworks Cc: victorr, k

D27080: Don't warn for invalid plugin metata

ngraham updated this revision to Diff 75149. ngraham added a comment. Use `qCDebug()` instead of removing it REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27080?vs=74823&id=75149 BRANCH less-warning-spam (branched from master) REVISI

D27067: Change "AutoSkip" to "Skip All"

ngraham added a comment. Ping. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D27067 To: ngraham, #frameworks, #vdg, dfaure Cc: broulik, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27141: Drop Policykit backend

lbeltrame accepted this revision. This revision is now accepted and ready to land. REPOSITORY R283 KAuth BRANCH no_policykit REVISION DETAIL https://phabricator.kde.org/D27141 To: davidedmundson, lbeltrame Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D25123: New yakuake logo/icon

davidre added a comment. If you land this please update the summary before. No need to have all the variants in the commit message it should be about the actual change. Thanks :) REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D25123 To: mglb, #vdg, #yakuake, h