D27385: [RFC] Return error instead of aborting when receiving an unexpected answer

broulik added inline comments. INLINE COMMENTS > slavebase.cpp:1100 > } else { > -qFatal("Fatal Error: Got cmd %d, while waiting for an answer!", > cmd); > +qDebug("Error: Got cmd %d, while waiting for an answer!", cmd); > +return -1; Should at least

D27285: Add left/right indent fill (as opposed to left-only), extend indent lines to broken lines

mwolff added a comment. In D27285#611163 , @dhaumann wrote: > Ok, I now fully got this, thanks for the explanation. And indeed without any left fill visual feedback is missing. > > What I wonder is how much of this needs to be configurable. W

D27083: [PC2]Give Label integer width.

gvgeo edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27083 To: gvgeo, #plasma, #vdg, ndavis, davidedmundson Cc: davidedmundson, kde-frameworks-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus

D27083: [PC2]Give Label integer width.

gvgeo added a comment. While I was improving the test.qml, found that Headings also have the same problem but vertically. I imagine that is from the fractional-part in the multiplier. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27083 To: gvge

D25583: Quit baloo_file_extractor if DB transaction fails

davidedmundson added a comment. I'm going to push soon if I don't hear soon. It solves a real world problem and it's had one approval. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D25583 To: davidedmundson, bruns, ngraham Cc: meven, kde-frameworks-devel, #baloo, hur

D27378: smb: map EHOSTUNREACH to ERR_CANNOT_CONNECT

sitter added a comment. Nah. 50.50.50.50 is an actual host on the internet for all your router knows ^^ You need to use an unassigned address within your actual home network, otherwise your router will (likely) send it off to the internet and then it will bounce around there for a bit a

D27396: support icon.width/height

mart created this revision. mart added a reviewer: Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mart requested review of this revision. REVISION SUMMARY support the icon size hint of the control. Reinstate it in ToolButton and add the support for

D27396: support icon.width/height

broulik added a comment. Don't we want to set a default? I keep seeing people hardcoding `icon.width` all over the place when they used PC3 and I want that to stop REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27396 To: mart, #plasma Cc: broulik

D27396: support icon.width/height

mart edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27396 To: mart, #plasma Cc: broulik, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27396: support icon.width/height

mart added a comment. In D27396#611425 , @broulik wrote: > Don't we want to set a default? I keep seeing people hardcoding `icon.width` all over the place when they used PC3 and I want that to stop then should be i think smallMedium size

D27396: support icon.width/height

mart updated this revision to Diff 75675. mart added a comment. - default icon sizes REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27396?vs=75672&id=75675 BRANCH phab/iconSize REVISION DETAIL https://phabricator.kde.org/D27396 AFF

D27396: support icon.width/height

mart updated this revision to Diff 75677. mart added a comment. - don't expose externally default size REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27396?vs=75675&id=75677 BRANCH phab/iconSize REVISION DETAIL https://phabricator.k

D27396: support icon.width/height

broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH phab/iconSize REVISION DETAIL https://phabricator.kde.org/D27396 To: mart, #plasma, broulik Cc: broulik, kde-frameworks-devel, LeGast00n, cblack, GB_2, michae

D27396: support icon.width/height

This revision was automatically updated to reflect the committed changes. Closed by commit R242:3de1c2462eda: support icon.width/height (authored by mart). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27396?vs=75677&id=75678 REVISION DETA

D27399: make sure the size hints are integer and even

mart created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mart requested review of this revision. REVISION SUMMARY for retrocompatibility with pc2 units.gridUnit * 1.6 is used a lot as size hint (we have to guarantee buttons and textfiel

D27399: make sure the size hints are integer and even

broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH phab/sizefixes REVISION DETAIL https://phabricator.kde.org/D27399 To: mart, broulik Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, brun

D27399: make sure the size hints are integer and even

This revision was automatically updated to reflect the committed changes. Closed by commit R242:667dce502acf: make sure the size hints are integer and even (authored by mart). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27399?vs=75681&id=

D27399: make sure the size hints are integer and even

davidedmundson added a comment. Please ensure that you've run the relevant plasma-framework/tests/components in qmlscene REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27399 To: mart, broulik Cc: davidedmundson, kde-frameworks-devel, LeGast00n,

D27221: Make PC3 ToolButton use SmallMedium icon size by default, to match other versions

ngraham abandoned this revision. ngraham added a subscriber: mart. ngraham added a comment. Looks like @mart just did this in D27396 . REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27221 To: ngraham, #vdg, #pla

D27221: Make PC3 ToolButton use SmallMedium icon size by default, to match other versions

ngraham removed a dependent revision: D27260: [applets/systemtray] Set pin button's size correctly. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27221 To: ngraham, #vdg, #plasma, broulik, ndavis Cc: mart, gvgeo, kde-frameworks-devel, LeGast00n, cbl

D27378: smb: map EHOSTUNREACH to ERR_CANNOT_CONNECT

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Gotcha, thanks for the explanation. Makes sense now. REPOSITORY R320 KIO Extras BRANCH bug417166 REVISION DETAIL https://phabricator.kde.org/D27378 To: sitter, ngraham Cc: kde-fra

D25583: Quit baloo_file_extractor if DB transaction fails

bruns added a comment. From the viewpoint of baloo_file, the process just hangs, which is bad. INLINE COMMENTS > app.cpp:138 > > QDBusConnection::sessionBus().send(message); > You still send out the message, though the results have not been commited. REPOSITORY R293 Baloo RE

D27153: port sftp to Result system to force serialization of error/finish condition

sitter updated this revision to Diff 75698. sitter marked 2 inline comments as done. sitter added a comment. s/LL/U call finished() from frontend close() (internal close cannot finish and cannot error). " // must call finish(), which will set d->inOpenLoop=false" one of many expectation

D27153: port sftp to Result system to force serialization of error/finish condition

sitter added inline comments. INLINE COMMENTS > feverfew wrote in kio_sftp.cpp:145 > Technically unrelated to your changes, but does this even work? isn't the > check supposed to be against `errno` in this case, not offset? True enough. I expect, like many things in the slaves, this never actua

D27372: smb: disable mode bits getting forwarded to KIO

This revision was automatically updated to reflect the committed changes. Closed by commit R320:718abcb69b78: smb: disable mode bits getting forwarded to KIO (authored by sitter). REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27372?vs=75618&id=75704 REVIS

D27377: map ECONNABORTED to ERR_CONNECTION_BROKEN

This revision was automatically updated to reflect the committed changes. Closed by commit R320:2075e76389cc: smb: map ECONNABORTED to ERR_CONNECTION_BROKEN (authored by sitter). REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27377?vs=75628&id=75703 REVISI

D27378: smb: map EHOSTUNREACH to ERR_CANNOT_CONNECT

This revision was automatically updated to reflect the committed changes. Closed by commit R320:a813d67cf6af: smb: map EHOSTUNREACH to ERR_CANNOT_CONNECT (authored by sitter). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D27378?vs=75630&id=75706#toc REPOSITORY R320 KIO Extras CHANGES

D27320: enable anonymous and domain extra field in authinfo

This revision was automatically updated to reflect the committed changes. Closed by commit R320:9d52cd9c9144: smb: enable anonymous and domain extra field in authinfo (authored by sitter). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D27320?vs=75466&id=75705#toc REPOSITORY R320 KIO Ex

D27272: Add status icons: data-error, data-warning, data-information

This revision was automatically updated to reflect the committed changes. Closed by commit R266:0f841410f874: Add status icons: data-error, data-warning, data-information (authored by kossebau). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27272?vs=7542

D27412: Port away from deprecated API on Qt 5.15.0

apol created this revision. apol added a reviewer: Frameworks. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY Upstream recommends using QLocale for turning dates into strings. TEST PLAN Builds on my system now

D27321: Add status icons: data-error, data-warning, data-information

This revision was automatically updated to reflect the committed changes. Closed by commit R267:cc173d74cbcc: Add status icons: data-error, data-warning, data-information (authored by kossebau). REPOSITORY R267 Oxygen Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27321?vs=7546

D27035: [KMessageWidget] Draw it with QPainter instead of using stylesheet

davidre updated this revision to Diff 75716. davidre added a comment. Explicitly set TextColor and palettes of the labels and react to parent changes . For example necessary for konsole that uses stylesheet which break palette propagation and reparents the widget after creation. REPOSITOR

D27412: Port away from deprecated API on Qt 5.15.0

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R871 DrKonqi BRANCH master REVISION DETAIL https://phabricator.kde.org/D27412 To: apol, #frameworks, davidedmundson Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, za

D27035: [KMessageWidget] Draw it with QPainter instead of using stylesheet

davidre updated this revision to Diff 75717. davidre added a comment. remove debug remains REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27035?vs=75716&id=75717 BRANCH no-css (branched from master) REVISION DETAIL https://phabricator.kde.org/D

D27412: Port away from deprecated API on Qt 5.15.0

sitter accepted this revision. REPOSITORY R871 DrKonqi BRANCH master REVISION DETAIL https://phabricator.kde.org/D27412 To: apol, #frameworks, davidedmundson, sitter Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngra

D27416: Add small icons for KeePassXC

wsdfhjxc created this revision. wsdfhjxc added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. wsdfhjxc requested review of this revision. REPOSITORY R266 Breeze Icons BRANCH keepassxc-small REVISION DETAIL https://phabricator.kde.org/D

D27416: Add small icons for KeePassXC

wsdfhjxc edited the summary of this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D27416 To: wsdfhjxc, #vdg Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27035: [KMessageWidget] Draw it with QPainter instead of using stylesheet

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R236 KWidgetsAddons BRANCH no-css (branched from master) REVISION DETAIL https://phabricator.kde.org/D27035 To: davidre, #frameworks, ngraham Cc: cfeck, dhaumann, ngraham, kde-frameworks-devel, LeG

D27412: Port away from deprecated API on Qt 5.15.0

usta added a comment. isnt this also needs #include REPOSITORY R871 DrKonqi BRANCH master REVISION DETAIL https://phabricator.kde.org/D27412 To: apol, #frameworks, davidedmundson, sitter Cc: usta, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampalouk

D27035: [KMessageWidget] Draw it with QPainter instead of using stylesheet

cfeck added inline comments. INLINE COMMENTS > kmessagewidget.cpp:155 > }; > - > +// Add bordersize to the margin so it starts from the inner border and > doesn't look to cramped > +q->layout()->setContentsMargins(q->layout()->contentsMargins() + > borderSize); too > kmessagewidg

D27285: Add left/right indent fill (as opposed to left-only), extend indent lines to broken lines

eudoxos added a comment. Note to myself: should handle the case when width percentage disallows the indent, e.g. here: F8104336: image.png REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D27285 To: eudoxos, #vdg Cc: mwolff,

D27285: Add left/right indent fill (as opposed to left-only), extend indent lines to broken lines

eudoxos updated this revision to Diff 75727. eudoxos added a comment. Fix indentation lines shown spuriously when horizontal space was unsufficient for indent fill REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27285?vs=75533&id=75727 BRANCH dynwrap-

Re: 2 kirigami fixes for a point release

On 2020-02-13 00:42, Ben Cooksley wrote: A better way of approaching this would be to freeze the Frameworks version you are going to require API wise at an earlier point in the Plasma development cycle. This would allow for a full Frameworks release cycle to pass where bugs encountered during the

Re: 2 kirigami fixes for a point release

On 2020-02-13 00:48, Kai Uwe Broulik wrote: To minimize potential Frameworks dependency problems I would even go as far as put Feature freeze on same date as Frameworks tagging date so that no new stuff goes in that could require a Framework change, like the wallpaper JPG vs PNG situation. Bu

D27412: Port away from deprecated API on Qt 5.15.0

This revision was automatically updated to reflect the committed changes. Closed by commit R871:781064ba1c13: Port away from deprecated API on Qt 5.15.0 (authored by apol). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D27412?vs=75714&id=75731#toc REPOSITORY R871 DrKonqi CHANGES SINCE

D27419: Update Japanese holidays

nhiga created this revision. nhiga added reviewers: dvratil, winterz. nhiga added projects: KDE PIM, Frameworks. nhiga requested review of this revision. REVISION SUMMARY This patch is purely cosmetic since the predicted Vernal and Autumnal Equinox Days of 2021 are the same as the official anno