D27769: modemmanager-qt: Convert license headers to SPDX expressions

jgrulich accepted this revision. This revision is now accepted and ready to land. REPOSITORY R281 ModemManagerQt BRANCH spdx REVISION DETAIL https://phabricator.kde.org/D27769 To: cordlandwehr, jgrulich Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.13 - Build # 319 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.13/319/ Project: kf5-qt5 SUSEQt5.13 Date of build: Mon, 02 Mar 2020 04:42:35 + Build duration: 24 min and counting BUILD ARTIFACTS

D26095: kio EBN constructor cleanup

jhayes abandoned this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D26095 To: jhayes Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D26092: kidletime EBN constructor cleanup

jhayes abandoned this revision. REPOSITORY R274 KIdleTime REVISION DETAIL https://phabricator.kde.org/D26092 To: jhayes, davidedmundson Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 444 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/444/ Project: kf5-qt5 SUSEQt5.12 Date of build: Mon, 02 Mar 2020 04:42:35 + Build duration: 10 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 310 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/310/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Mon, 02 Mar 2020 04:42:35 + Build duration: 8 min 41 sec and counting JUnit Tests Name:

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.13 - Build # 112 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.13/112/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Mon, 02 Mar 2020 01:57:41 + Build duration: 2 min 0 sec and counting JUnit Tests Name:

D27767: [ModifiedFileIndexer] Correct time checks for new files

bruns edited the summary of this revision. bruns added a dependency: D27766: [ModifiedFileIndexer] Omit BasicIndexingJob run when not required. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D27767 To: bruns, #baloo, ngraham Cc: astippich, kde-frameworks-devel,

D27766: [ModifiedFileIndexer] Omit BasicIndexingJob run when not required

bruns added a dependent revision: D27767: [ModifiedFileIndexer] Correct time checks for new files. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D27766 To: bruns, #baloo, ngraham Cc: anthonyfieroni, kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack,

D27767: [ModifiedFileIndexer] Correct time checks for new files

bruns marked an inline comment as done. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D27767 To: bruns, #baloo, ngraham Cc: astippich, kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, spoorun, ngraham,

D27767: [ModifiedFileIndexer] Correct time checks for new files

bruns updated this revision to Diff 76744. bruns added a comment. const REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27767?vs=76735=76744 REVISION DETAIL https://phabricator.kde.org/D27767 AFFECTED FILES src/file/modifiedfileindexer.cpp To: bruns,

D27772: [WriteTransaction] Extend position test case

bruns created this revision. bruns added reviewers: Baloo, ngraham. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY Until now, the case where a term was kept but all positions for the term are

D27771: [WriteTransaction] Avoid growing m_pendingOperations twice on replace

bruns created this revision. bruns added reviewers: Baloo, ngraham. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY As the following addTerms() does another reserve() with growing by

D27464: Add application menu dbus paths to org_kde_plasma_window interface

cblack added a comment. Would the version number already being 9 in old versions of KWayland cause any issues? I have a feeling old KWayland versions may not like it when they're sent events they don't recognize, unless libwayland/KWayland handle that usecase. REPOSITORY R127 KWayland

D27767: [ModifiedFileIndexer] Correct time checks for new files

astippich added inline comments. INLINE COMMENTS > modifiedfileindexer.cpp:74 > +bool cTimeChanged; > +bool isKnownFile = tr.hasDocument(fileId); > +if (isKnownFile) { const? REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D27767 To: bruns,

D21795: [KAuth] Add support for action details in Polkit1 backend.

This revision was automatically updated to reflect the committed changes. Closed by commit R283:f53d6a29a049: [KAuth] Add support for action details in Polkit1 backend. (authored by feverfew). REPOSITORY R283 KAuth CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21795?vs=76739=76740

D21795: [KAuth] Add support for action details in Polkit1 backend.

feverfew updated this revision to Diff 76739. feverfew added a comment. - Fix & - Use enum class - Use enum instead of string comparison REPOSITORY R283 KAuth CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21795?vs=76497=76739 BRANCH arcpatch-D21795_2 REVISION DETAIL

Re: kreversi 19.12 fails to build at IconSize call

On Mon, Mar 2, 2020 at 2:19 AM Christoph Feck wrote: > > Hi, > > kreversi release/19.12 branch fails to build with this error on CI: > > > pageItem->setIcon(QIcon::fromTheme(icon).pixmap(IconSize(KIconLoader::Toolbar))); > error: IconSize was not declared in this scope > > See >

D27355: POC: Make kstatusnotifieritem available without dbus

bcooksley added a comment. Have you had a chance to look into this @broulik? REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D27355 To: vonreth, bcooksley, jjazeix, broulik Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27769: modemmanager-qt: Convert license headers to SPDX expressions

cordlandwehr created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. Herald added a reviewer: jgrulich. cordlandwehr requested review of this revision. REVISION SUMMARY Convert license headers to SPDX expressions and add license files as

D27769: modemmanager-qt: Convert license headers to SPDX expressions

cordlandwehr added a task: T11550: Add SPDX License markers. REPOSITORY R281 ModemManagerQt REVISION DETAIL https://phabricator.kde.org/D27769 To: cordlandwehr, jgrulich Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27766: [ModifiedFileIndexer] Omit BasicIndexingJob run when not required

anthonyfieroni added inline comments. INLINE COMMENTS > anthonyfieroni wrote in modifiedfileindexer.cpp:118 > This check is redundant now, we here only when `cTimeChanged` is true. I saw it in other patch, i does not need change. REPOSITORY R293 Baloo REVISION DETAIL

D27766: [ModifiedFileIndexer] Omit BasicIndexingJob run when not required

anthonyfieroni added inline comments. INLINE COMMENTS > modifiedfileindexer.cpp:118 > if (tr.hasDocument(job.document().id())) { > if (cTimeChanged) { > tr.replaceDocument(job.document(), XAttrTerms | DocumentTime > | FileNameTerms | DocumentUrl); This

D27767: [ModifiedFileIndexer] Correct time checks for new files

bruns created this revision. bruns added reviewers: Baloo, ngraham. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY In case baloo has just started, a new and immediately modified file can end

D27766: [ModifiedFileIndexer] Omit BasicIndexingJob run when not required

bruns created this revision. bruns added reviewers: Baloo, ngraham. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY In case only the mtime has changed (i.e. only contents), only the times and

D27765: [FileContentIndexer] Remove duplicate condition check for loop break

bruns created this revision. bruns added reviewers: Baloo, ngraham. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY Counting the number of files to be indexed (m_provider->size()) can be

D27528: Adapt action numbering in Android to work like in KNotifications

nicolasfella closed this revision. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D27528 To: cacahueto, #frameworks, nicolasfella, vkrause Cc: jbbgameich, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27740: Adapt action numbering in Android to work like in KNotifications

This revision was automatically updated to reflect the committed changes. Closed by commit R289:92f5564da771: Adapt action numbering in Android to work like in KNotifications (authored by cacahueto, committed by nicolasfella). REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE

D27740: Adapt action numbering in Android to work like in KNotifications

nicolasfella accepted this revision. This revision is now accepted and ready to land. REPOSITORY R289 KNotifications BRANCH adapt-action-numbering-in-android (branched from master) REVISION DETAIL https://phabricator.kde.org/D27740 To: cacahueto, #frameworks, nicolasfella, vkrause Cc:

T10262: Integrate KIO Slaves into file system using FUSE gateway

ngraham closed subtask T10263: FUSE daemon for accessing KIO Slaves as Resolved. TASK DETAIL https://phabricator.kde.org/T10262 To: cfeck, ngraham Cc: chinmoyr, fvogt, feverfew, #frameworks, ngraham, #dolphin, cfeck, pberestov, iasensio, fprice, MrPepe, fbampaloukas, alexde, Codezela, meven,

Re: kreversi 19.12 fails to build at IconSize call

On 01/03/2020 15:17, Christoph Feck wrote: Hi, kreversi release/19.12 branch fails to build with this error on CI: pageItem->setIcon(QIcon::fromTheme(icon).pixmap(IconSize(KIconLoader::Toolbar)));     error: IconSize was not declared in this scope See

kreversi 19.12 fails to build at IconSize call

Hi, kreversi release/19.12 branch fails to build with this error on CI: pageItem->setIcon(QIcon::fromTheme(icon).pixmap(IconSize(KIconLoader::Toolbar))); error: IconSize was not declared in this scope See

D27760: WIP | Added BatchMoveJob

emateli added a comment. In that it supports moving them to different directories but as well as moving them with a different name. This operation is to allow also batch renaming of items. See this patch for more details: D14631 eg: BatchMove

D26211: Port QRegExp to QRegularExpression

This revision was automatically updated to reflect the committed changes. Closed by commit R246:633a9f22340b: Port QRegExp to QRegularExpression (authored by ahmadsamir). REPOSITORY R246 Sonnet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26211?vs=76705=76724 REVISION DETAIL

D27760: WIP | Added BatchMoveJob

nicolasfella added a comment. What's the difference to the job you get with KIO::move with a list of urls? https://api.kde.org/frameworks/kio/html/namespaceKIO.html#a20da0b04660f834de30f9440673f6d5e REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D27760 To: emateli,

D27760: WIP | Added BatchMoveJob

emateli retitled this revision from "Added BatchMoveJob" to "WIP | Added BatchMoveJob". emateli edited the summary of this revision. emateli added reviewers: dfaure, ngraham. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D27760 To: emateli, dfaure, ngraham Cc:

D26211: Port QRegExp to QRegularExpression

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Thanks, guess that should go in now. REPOSITORY R246 Sonnet BRANCH l-qregularexpression (branched from master) REVISION DETAIL https://phabricator.kde.org/D26211 To:

D27760: Added BatchMoveJob

emateli created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. emateli requested review of this revision. REPOSITORY R241 KIO BRANCH batchmove REVISION DETAIL https://phabricator.kde.org/D27760 AFFECTED FILES autotests/CMakeLists.txt

D25315: KDirModel: implement showing a root node for the requested URL

dfaure added a comment. Well, I don't have your code. Which calls are you making into KDirModel? (openUrl(args=?), expandToUrl(args=?)) REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D25315 To: dfaure, stefanocrocco, elvisangelaccio, meven, apol Cc:

D26749: WIP: Support NDK r20 and Qt 5.14

vkrause added a comment. In D26749#620142 , @apol wrote: > Seems ready to land to me. It does seem to break poppler in the old setup here, not sure yet why though. If we land the docker change as well that is probably acceptable though.

D27735: [KConfigGui] Clear styleName font property for Regular font sytles

ahmadsamir added a comment. To get those numbers I tested with this code: QFontDatabase fdb; const QStringList fontFamilies = fdb.families(); QStringList list; int regularCnt = 0; int normalCnt = 0; int bookCnt = 0; int romanCnt = 0; for (const QString :

D27735: [KConfigGui] Clear styleName font property for Regular font sytles

ahmadsamir updated this revision to Diff 76721. ahmadsamir edited the summary of this revision. ahmadsamir added a comment. Add some relevant statistics REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27735?vs=76682=76721 BRANCH l-font-sytleName

D26342: Allow overriding to disable auto language detection

mludwig added a comment. @Simon: If you add a call 'setAutoDetectLanguageDisabled(false)' to 'BackgroundChecker::changeLanguage' and 'BackgroundChecker::setSpeller', you should be able to take Albert's suggestion into account. For the Highlighter it should be similar. REPOSITORY R246