D9734: [KFileItemActions] Allow specifying the number of selected files required for an action

dfaure added a comment. Or upload a patch :) REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D9734 To: broulik, #frameworks, dfaure, michaelh, mlaurent Cc: ngraham, kde-frameworks-devel, juansimon, LeGast00n, cblack, GB_2, michaelh, bruns

D27898: [autotests/*] Port foreach (deprecated) to range-based for loop

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. Thanks REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D27898 To: ahmadsamir, #frameworks, dfaure, meven Cc: kde-frameworks-devel, LeGast00n, cblack, G

D27871: sftp: fix seekPos + file resuming when part file is of size 11

bruns added a comment. In D27871#623542 , @sitter wrote: > In D27871#622933 , @bruns wrote: > > > Can you also mention why errno == EGAIN does not have to be handled ("EAGAIN could only happen iff th

D27871: sftp: fix seekPos + file resuming when part file is of size 11

bruns added inline comments. INLINE COMMENTS > sitter wrote in kio_sftp.cpp:1687 > Which call between the seek and the debug do you take offense here exactly? qCDebug(), operator<< REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D27871 To: sitter, ngraham, feverfew

D27660: Add Inno Setup syntax, including embedded Pascal scripting

zrax updated this revision to Diff 77133. zrax added a comment. Relicense as MIT. REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27660?vs=76398&id=77133 BRANCH innosetup (branched from master) REVISION DETAIL https://phabricator.kde.org/D2

D27872: sftp: fix partial transfer resuming when copying to local

bruns requested changes to this revision. bruns added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > kio_sftp.cpp:1935 > > -if (bMarkPartial && bPartExists && copyFile.size() > 0) { > +if (bMarkPartial && bPartExists && partFile.size() > 0) { >

D27873: sftp: do not show creation time when we do not know it

bruns requested changes to this revision. bruns added a comment. This revision now requires changes to proceed. Please correct the comment in the code - it depends on the server SFTP implementation. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D27873 To: sitter

D27893: Use fallback also on Windows not only mac

jjazeix accepted this revision. jjazeix added a comment. same, good and cleaner. Thank you! REPOSITORY R289 KNotifications BRANCH master REVISION DETAIL https://phabricator.kde.org/D27893 To: vonreth, broulik, bcooksley, jjazeix, cullmann Cc: kde-frameworks-devel, LeGast00n, cblack, G

D27730: Add API to check whether a barcode is one- or two-dimensional

svuorela accepted this revision. svuorela added a comment. This revision is now accepted and ready to land. thanks. REPOSITORY R280 Prison BRANCH pending REVISION DETAIL https://phabricator.kde.org/D27730 To: vkrause, svuorela Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michael

D27893: Use fallback also on Windows not only mac

bcooksley accepted this revision. bcooksley added a comment. This revision is now accepted and ready to land. Looks good to me! REPOSITORY R289 KNotifications BRANCH master REVISION DETAIL https://phabricator.kde.org/D27893 To: vonreth, broulik, bcooksley, jjazeix, cullmann Cc: kde-fr

D27730: Add API to check whether a barcode is one- or two-dimensional

vkrause updated this revision to Diff 77128. vkrause added a comment. Alternative implementation for the barcode dimension API. REPOSITORY R280 Prison CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27730?vs=76661&id=77128 BRANCH pending REVISION DETAIL https://phabricator.kd

D27871: sftp: fix seekPos + file resuming when part file is of size 11

sitter added inline comments. INLINE COMMENTS > bruns wrote in kio_sftp.cpp:1687 > You should save errno immediately after QT_LSEEK, otherwise any function may > overwrite it. See `man 3 errno`: > > > A common mistake is to do > > > > if (somecall() == -1) { > > printf("somecall() fail

D27871: sftp: fix seekPos + file resuming when part file is of size 11

sitter added a comment. In D27871#622933 , @bruns wrote: > Can you also mention why errno == EGAIN does not have to be handled ("EAGAIN could only happen iff the file where opened with O_NONBLOCK. All other seek errors are fatal."). I do

D27901: smb: do not leak pbsd resolvers

This revision was automatically updated to reflect the committed changes. Closed by commit R320:1eacae5267e3: smb: do not leak pbsd resolvers (authored by sitter). REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27901?vs=77113&id=77126 REVISION DETAIL htt

D27900: smb: fix wsdiscovery unknown device fallback string

This revision was automatically updated to reflect the committed changes. Closed by commit R320:6557c6b4793d: smb: fix wsdiscovery unknown device fallback string (authored by sitter). REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27900?vs=77112&id=77127 R

D27900: smb: fix wsdiscovery unknown device fallback string

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R320 KIO Extras BRANCH smb-unknowndevice REVISION DETAIL https://phabricator.kde.org/D27900 To: sitter, ngraham Cc: kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, cblack,

D27883: Register spawned applications as an independent cgroups

ngraham added a task: T12678: Scope applications into transient services . REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D27883 To: davidedmundson Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27901: smb: do not leak pbsd resolvers

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R320 KIO Extras BRANCH smb-resolver-leak REVISION DETAIL https://phabricator.kde.org/D27901 To: sitter, ngraham Cc: kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, cblack,

D27801: smb: add a unit test for smburl

This revision was automatically updated to reflect the committed changes. Closed by commit R320:d8d92670372a: smb: add a unit test for smburl (authored by sitter). REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27801?vs=76935&id=77119 REVISION DETAIL htt

D27802: smb: fix ipv6 support

This revision was automatically updated to reflect the committed changes. Closed by commit R320:bb83a071e0da: smb: fix ipv6 support (authored by sitter). REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27802?vs=76915&id=77120 REVISION DETAIL https://phabri

D27835: sftp: fix free space query for urls with empty path

This revision was automatically updated to reflect the committed changes. Closed by commit R320:5cfd852a975e: sftp: fix free space query for urls with empty path (authored by sitter). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D27835?vs=76940&id=77117#toc REPOSITORY R320 KIO Extras

D27800: smb: split module into two targets of which one is a static lib

This revision was automatically updated to reflect the committed changes. Closed by commit R320:d101d916e324: smb: split module into two targets of which one is a static lib (authored by sitter). REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27800?vs=76829

D27902: smb: figure out the best host to use for the UDS_URL

sitter created this revision. sitter added reviewers: ngraham, dfaure. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. sitter requested review of this revision. REVISION SUMMARY previously we simply used the ip address. this is fairly awkwar

D27901: smb: do not leak pbsd resolvers

sitter created this revision. sitter added a reviewer: ngraham. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. sitter requested review of this revision. REVISION SUMMARY parent them to the discoverer. discoverer lives on the stack and is un

D27900: smb: fix wsdiscovery unknown device fallback string

sitter created this revision. sitter added a reviewer: ngraham. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. sitter requested review of this revision. REVISION SUMMARY wasn't using xi18n so wasn't parsed as markup but rather used verba

D27898: [autotests/*] Port foreach (deprecated) to range-based for loop

ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, dfaure, meven. Herald added a project: Frameworks. ahmadsamir requested review of this revision. TEST PLAN make && ctest REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D27898 AFFECT

D26969: fix type namespace requirement

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. This is rather horrible, but at the same time makes a lot of sense. One minor comment, but then, ship it I guess. INLINE COMMENTS > DBusHelperProxy.cpp:273 > +Q

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 316 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/316/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Fri, 06 Mar 2020 13:04:21 + Build duration: 8 min 47 sec and counting JUnit Tests Name: projectro

D27894: [src/kcms/*] Replace foreach (deprecated) with range/index-based for

This revision was automatically updated to reflect the committed changes. Closed by commit R241:d617bb704d1f: [src/kcms/*] Replace foreach (deprecated) with range/index-based for (authored by ahmadsamir). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27894?vs=770

D27357: Fix infinite recursion in xscreensaver plugin

broulik added a comment. Sorry, I just returned from vacation. I'll merge this on Monday (since Frameworks tagging is tomorrow) so we'll get another month worth of testing. REPOSITORY R274 KIdleTime REVISION DETAIL https://phabricator.kde.org/D27357 To: alnikiforov, davidedmundson, brou

D27894: [src/kcms/*] Replace foreach (deprecated) with range/index-based for

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH l-kcms-foreach (branched from master) REVISION DETAIL https://phabricator.kde.org/D27894 To: ahmadsamir, #frameworks, dfaure, meven, davidedmundson Cc: kde-frameworks-devel,

D27894: [src/kcms/*] Replace foreach (deprecated) with range/index-based for

ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, dfaure, meven. Herald added a project: Frameworks. ahmadsamir requested review of this revision. REVISION SUMMARY Add KF6 TODO about removing KURIFilterModule::load(), it's been redundant for a long time (circa 2014). T

D27893: Use fallback also on Windows not only mac

vonreth added reviewers: broulik, bcooksley, jjazeix, cullmann. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D27893 To: vonreth, broulik, bcooksley, jjazeix, cullmann Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27112: Fix errors in the QRegularExpression porting commit

This revision was automatically updated to reflect the committed changes. Closed by commit R269:408bdaa752fa: Fix errors in the QRegularExpression porting commit (authored by ahmadsamir). REPOSITORY R269 BluezQt CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27112?vs=77096&id=77097

D27112: Fix errors in the QRegularExpression porting commit

ahmadsamir updated this revision to Diff 77096. ahmadsamir added a comment. Rebase REPOSITORY R269 BluezQt CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27112?vs=74880&id=77096 BRANCH l-fix (branched from master) REVISION DETAIL https://phabricator.kde.org/D27112 AFFECTED

D27893: Use fallback also on Windows not only mac

vonreth created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vonreth requested review of this revision. REPOSITORY R289 KNotifications BRANCH master REVISION DETAIL https://phabricator.kde.org/D27893 AFFECTED FILES src/kstatusnotifi

D27357: Fix infinite recursion in xscreensaver plugin

alnikiforov added a comment. Could you please merge this change? Or is something stopping from merging it? REPOSITORY R274 KIdleTime REVISION DETAIL https://phabricator.kde.org/D27357 To: alnikiforov, davidedmundson, broulik, #frameworks Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2

KDE CI: Frameworks » knotifications » kf5-qt5 FreeBSDQt5.13 - Build # 85 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/knotifications/job/kf5-qt5%20FreeBSDQt5.13/85/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Fri, 06 Mar 2020 10:56:39 + Build duration: 1 min 46 sec and counting

D27887: Fix config include

This revision was automatically updated to reflect the committed changes. Closed by commit R289:3d455200c586: Fix config include (authored by vonreth). REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27887?vs=77081&id=77083 REVISION DETAIL https://phab

D27887: Fix config include

broulik accepted this revision. broulik added a comment. This revision is now accepted and ready to land. Thanks REPOSITORY R289 KNotifications BRANCH master REVISION DETAIL https://phabricator.kde.org/D27887 To: vonreth, broulik Cc: broulik, kde-frameworks-devel, LeGast00n, cblack, G

D27887: Fix config include

vonreth created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vonreth requested review of this revision. REPOSITORY R289 KNotifications BRANCH master REVISION DETAIL https://phabricator.kde.org/D27887 AFFECTED FILES src/kstatusnotifi

D27873: sftp: do not show creation time when we do not know it

sitter updated this revision to Diff 77080. sitter added a comment. use flaggy REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27873?vs=77039&id=77080 BRANCH sftp-ctime REVISION DETAIL https://phabricator.kde.org/D27873 AFFECTED FILES sftp/kio_sf

D27463: KconfigXT: Add a value attribute to Enum field choices

ervin accepted this revision. REPOSITORY R237 KConfig BRANCH arcpatch-D27463_2 REVISION DETAIL https://phabricator.kde.org/D27463 To: meven, ervin, bport, crossi, #frameworks Cc: ngraham, davidre, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, bruns

D27872: sftp: fix partial transfer resuming when copying to local

sitter updated this revision to Diff 77076. sitter added a comment. . REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27872?vs=77037&id=77076 BRANCH sftp-resume-to-local REVISION DETAIL https://phabricator.kde.org/D27872 AFFECTED FILES sftp/kio_s

D27463: KconfigXT: Add a value attribute to Enum field choices

meven updated this revision to Diff 77077. meven added a comment. Fix typo REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27463?vs=77064&id=77077 BRANCH arcpatch-D27463_2 REVISION DETAIL https://phabricator.kde.org/D27463 AFFECTED FILES autotests/k

D27463: KconfigXT: Add a value attribute to Enum field choices

ervin accepted this revision. ervin added a comment. This revision is now accepted and ready to land. LGTM, please fix the typo in the docs before pushing though INLINE COMMENTS > README.dox:372 > > +Since 5.68, if present the value attribute will be used used as the > choice value written

D27133: kconfig_compiler : generate kconfig settings with subgroup

ervin accepted this revision. This revision is now accepted and ready to land. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D27133 To: crossi, ervin, dfaure, #frameworks Cc: meven, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » knotifications » kf5-qt5 FreeBSDQt5.13 - Build # 84 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/knotifications/job/kf5-qt5%20FreeBSDQt5.13/84/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Fri, 06 Mar 2020 09:42:42 + Build duration: 59 sec and counting CONSOLE OUTPUT [...trunc

D27355: POC: Make kstatusnotifieritem available without dbus

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R289:e369e43b807e: Make kstatusnotifieritem available without dbus (authored by vonreth). REPOSITORY R289 KNotifications

D27112: Fix errors in the QRegularExpression porting commit

drosca accepted this revision. This revision is now accepted and ready to land. REPOSITORY R269 BluezQt BRANCH l-fix (branched from master) REVISION DETAIL https://phabricator.kde.org/D27112 To: ahmadsamir, #frameworks, drosca, apol, dfaure Cc: kde-frameworks-devel, LeGast00n, cblack, GB_

D27112: Fix errors in the QRegularExpression porting commit

ahmadsamir added a comment. Can I land this? I keep getting side tracked and I haven't written those unit tests, but until then I hate leaving this broken. REPOSITORY R269 BluezQt REVISION DETAIL https://phabricator.kde.org/D27112 To: ahmadsamir, #frameworks, drosca, apol, dfaure Cc: kd

D27883: Register spawned applications as an independent cgroups

davidedmundson created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. davidedmundson requested review of this revision. REVISION SUMMARY Having each application in it's own scope brings numerous advantages: - PIDs are very yesteryear, a m

D27882: Move KProcessRunner into it's own file

davidedmundson created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. davidedmundson requested review of this revision. REVISION SUMMARY Just for readability, krun.cpp was too long. There are no code changes TEST PLAN N/A REPOSITORY

D27463: KconfigXT: Add a value attribute to Enum field choices

meven updated this revision to Diff 77064. meven marked 2 inline comments as done. meven added a comment. Fix comment and formatting REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27463?vs=77006&id=77064 BRANCH arcpatch-D27463_2 REVISION DETAIL https:

D27839: Properly name the content of the kcmcontrols project

meven accepted this revision. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D27839 To: ervin, crossi, hchain, meven, bport, davidedmundson, mart, ngraham, #frameworks, #plasma Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

<    1   2