D28195: Avoid double fetch and temporary hex encoding for NTFS attributes

bruns created this revision. bruns added reviewers: Dolphin, dfaure. Herald added a project: Frameworks. Herald edited subscribers, added: kde-frameworks-devel; removed: Frameworks. bruns requested review of this revision. REVISION SUMMARY The attrib is a DWORD (32 bit unsigned int) in the

D28079: [keditfiletype] Prevent removing the "main" glob pattern for mime types

ahmadsamir abandoned this revision. ahmadsamir added a comment. OK. REPOSITORY R126 KDE CLI Utilities REVISION DETAIL https://phabricator.kde.org/D28079 To: ahmadsamir, #plasma, dfaure, davidedmundson, apol Cc: kde-frameworks-devel, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev,

D28189: karchivetest: avoid interference from kdebugsettings

dfaure added a comment. Can't see what's weird about that. Logging config comes from a config file stored in QStandardPaths::GenericConfigLocation, seems pretty reasonable to me. REPOSITORY R243 KArchive REVISION DETAIL https://phabricator.kde.org/D28189 To: dfaure, apol, sandsmark Cc:

D27951: Allow users to change dropAction to MoveAction through kdeglobals

davidedmundson added a comment. I've done a code review, they need following up regardless. --- As you saw in the bug report I don't like the feature, and I'm against it. Though I can't veto changes. Repeating myself on bugzilla. The two things I really hate as

D14707: autotests: skip '/' fstab check with zfs

dfaure added a comment. Yep, that's exactly what I see in the output from kmountpointtest. One entry for swap, but no entry for "/". So any file on the filesystem doesn't look like it comes from a partition that was mounted at boot time. In other words it looks like everything is from

D27741: KCodecs: Convert license statements to SPDX expressions

cgiboudeaux added inline comments. INLINE COMMENTS > Big5Freq.tab:3 > /* -*- C++ -*- > -* Copyright (C) 1998 > -* > -* > -* Permission is hereby granted, free of charge, to any person obtaining > -* a copy of this software and associated documentation files (the > -* "Software"), to deal

D27601: KConfig: Convert to SPDX license statements

cgiboudeaux accepted this revision. cgiboudeaux added a comment. This revision is now accepted and ready to land. LGTM REPOSITORY R237 KConfig BRANCH spdx REVISION DETAIL https://phabricator.kde.org/D27601 To: cordlandwehr, cgiboudeaux Cc: ognarb, cgiboudeaux, kde-frameworks-devel,

D27738: KCoreAddons: Convert license statements to SPDX expressions

cgiboudeaux added inline comments. INLINE COMMENTS > kshareddatacache.cpp:11 > +placed in the public domain. See http://sites.google.com/site/murmurhash/ > +SPDX-License-Identifier: CC0-1.0 > +*/ Why? REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D27738

D27245: Ki18n: Convert license headers to SPDX statements

cgiboudeaux added a comment. In D27245#619834 , @cordlandwehr wrote: > So, how to move forward with this change? The two open discussion points are: > > - How to handle COPYING files? --> IMO this is a general question that I want to

D27428: KItemViews: Convert license statements to SPDX expressions

cgiboudeaux accepted this revision. cgiboudeaux added a comment. This revision is now accepted and ready to land. LGTM REPOSITORY R276 KItemViews BRANCH spdx REVISION DETAIL https://phabricator.kde.org/D27428 To: cordlandwehr, cgiboudeaux Cc: cgiboudeaux, kde-frameworks-devel,

D27742: Solid: Convert license headers to SPDX expressions

cgiboudeaux accepted this revision. cgiboudeaux added a comment. This revision is now accepted and ready to land. LGTM REPOSITORY R245 Solid BRANCH spdx REVISION DETAIL https://phabricator.kde.org/D27742 To: cordlandwehr, cgiboudeaux Cc: cgiboudeaux, kde-frameworks-devel, LeGast00n,

D27429: ThreadWeaver: Convert license headers to SPDX expressions

cgiboudeaux accepted this revision. cgiboudeaux added a comment. This revision is now accepted and ready to land. LGTM INLINE COMMENTS > main.cpp:1 > -#include > +#include > I don't see what changed here. looks unrelated to this PR REPOSITORY R279 ThreadWeaver BRANCH spdxHeaders

D14707: autotests: skip '/' fstab check with zfs

bcooksley added a comment. That is strange - as our FreeBSD Builders definitely have an /etc/fstab file: root@FreeBSDBuilderIota:~ # cat /etc/fstab # DeviceMountpoint FStype Options Dump Pass# /dev/vtbd0p2noneswapsw

D28193: [KFontChooser] Use one QFontDatabase object for the ::Private class

ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, cfeck, apol, bport. Herald added a project: Frameworks. ahmadsamir requested review of this revision. REVISION SUMMARY Minor optimisation by instantiating one QFontDatabase Object, and using it in KFontChooser::Private

D28189: karchivetest: avoid interference from kdebugsettings

dfaure closed this revision. REPOSITORY R243 KArchive REVISION DETAIL https://phabricator.kde.org/D28189 To: dfaure, apol, sandsmark Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28191: [KFontChooser] General code cleanup

ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, cfeck, apol, bport. Herald added a project: Frameworks. ahmadsamir requested review of this revision. REVISION SUMMARY - Use new connect syntax - Prefix increment where appropriate - Replace foreach/iterator-based for

D28189: karchivetest: avoid interference from kdebugsettings

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. Makes sense. It's weird that this needs doing through QStandardPaths but it's not something we can address here. REPOSITORY R243 KArchive BRANCH master REVISION DETAIL

D21760: Add KListOpenFilesJob

dfaure added a comment. The test fails on FreeBSD, in CI. https://build.kde.org/job/Frameworks/view/Platform%20-%20FreeBSDQt5.13/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.13/118/testReport/junit/projectroot/autotests/klistopenfilesjobtest_unix/ Any plans for fixing it, or should I

KDE CI: Frameworks » kwidgetsaddons » kf5-qt5 FreeBSDQt5.13 - Build # 80 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kwidgetsaddons/job/kf5-qt5%20FreeBSDQt5.13/80/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sat, 21 Mar 2020 18:36:22 + Build duration: 1 min 59 sec and counting JUnit Tests Name:

T12173: KService: provide solution to migrate away from KServiceTypeTrader/KMimeTypeTrader for loading plugins and parts

dfaure updated the task description. TASK DETAIL https://phabricator.kde.org/T12173 To: dfaure Cc: #frameworks, nicolasfella, dfaure, mart, davidre, GB_2, ekasprzak, ahmadsamir, ngraham, kpiwowarski, usta, asturmlechner, jucato, cfeck, cgiboudeaux, cullmann, vkrause, cordlandwehr, knauss

D14707: autotests: skip '/' fstab check with zfs

dfaure abandoned this revision. dfaure added a comment. So, this patch is wrong, and I just disabled that part of kmountpointtest on FreeBSD (https://cgit.kde.org/kio.git/commit/?id=e1ef54531ecf7dc9966860dce890201aa100c240) The fact that KMountPoint sees no mountpoints on the FreeBSD CI

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.13 - Build # 76 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.13/76/ Project: kf5-qt5 SUSEQt5.13 Date of build: Sat, 21 Mar 2020 18:02:20 + Build duration: 8 min 23 sec and counting BUILD ARTIFACTS

D27910: Make sure warning output is enabled before testing if the correct warning is printed

dfaure added a comment. Note that in both cases the env var QT_LOGGING_RULES would break the unittest anyway... so yeah it's only about qtlogging.ini which we can easily skip with test mode. Here's my suggested fix: D28189 @apol Warnings are

D28189: karchivetest: avoid interference from kdebugsettings

dfaure created this revision. dfaure added reviewers: apol, sandsmark. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. dfaure requested review of this revision. REVISION SUMMARY NO_CHANGELOG TEST PLAN test still passes REPOSITORY R243 KArchive BRANCH

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 349 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/349/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sat, 21 Mar 2020 18:00:06 + Build duration: 7 min 6 sec and counting JUnit Tests Name:

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 348 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/348/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sat, 21 Mar 2020 17:13:12 + Build duration: 6 min 51 sec and counting JUnit Tests Name:

D28188: breeze-icons autotests: skip symlinks in the builddir

dfaure created this revision. dfaure added reviewers: sitter, bshah, lbeltrame. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. dfaure requested review of this revision. REVISION SUMMARY It's ok for symlinks in the builddir to be broken. We can't (easily)

D27614: build: fix the build where install prefix is not user-writable

dfaure added a comment. Nobody cares about broken CI, or my comment here wasn't noticed, so I fixed it myself. https://phabricator.kde.org/D28188 REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D27614 To: bshah, ngraham, lbeltrame, sitter Cc: dfaure, sitter,

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 347 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/347/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sat, 21 Mar 2020 16:36:50 + Build duration: 7 min 46 sec and counting JUnit Tests Name:

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 480 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/480/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 21 Mar 2020 16:36:50 + Build duration: 7 min 20 sec and counting BUILD ARTIFACTS

D28033: Create ExpandableListItem

ngraham added a comment. Idea: instead of allowing a context menu to be defined, we require that the contextual actions always be defined as actions and appear in the expanded view. Then, we make the expanded view contain a tab view and put the contextual actions into one tab, hiding the

D28033: Create ExpandableListItem

ngraham updated this revision to Diff 78177. ngraham added a comment. Fix documentation formatting REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28033?vs=78104=78177 BRANCH ExpandableListItem (branched from master) REVISION DETAIL

D28186: GIT_SILENT kpasswdserver, break long lines for readability; add braces around if

This revision was automatically updated to reflect the committed changes. Closed by commit R241:1d644f8f2eb5: GIT_SILENT kpasswdserver, break long lines for readability; add braces around if (authored by ahmadsamir). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

D28186: GIT_SILENT kpasswdserver, break long lines for readability; add braces around if

ahmadsamir added a comment. In D28186#631962 , @dfaure wrote: > Nice. > > clang-format can't be configured to add missing braces, Nope, I'd have had to use clang-format (which requires a "compilation server", I read some docs,

D28187: KIO DesktopExecParser: simplify code

dfaure created this revision. dfaure added reviewers: ahmadsamir, feverfew, ngraham. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. dfaure requested review of this revision. REVISION SUMMARY - Remove special case for hasSchemeHandler, it's just a hack.

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 479 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/479/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 21 Mar 2020 16:09:23 + Build duration: 11 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 346 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/346/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sat, 21 Mar 2020 16:09:23 + Build duration: 7 min 26 sec and counting JUnit Tests Name:

D28184: KIO autotests: repair JobTest::moveDestAlreadyExistsAutoRename

dfaure closed this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D28184 To: dfaure, meven, apol Cc: apol, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D21902: Calendar: add method to show event details

apol added a comment. LGTM +1 REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D21902 To: dvratil, mart, #frameworks, #plasma Cc: apol, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28186: GIT_SILENT kpasswdserver, break long lines for readability; add braces around if

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. Nice. clang-format can't be configured to add missing braces, and to have a max line length? REPOSITORY R241 KIO BRANCH l-kpasswdserver-long-lines (branched from master)

D28184: KIO autotests: repair JobTest::moveDestAlreadyExistsAutoRename

dfaure added a comment. They are not the same. (3,4) vs (2,4) REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D28184 To: dfaure, meven, apol Cc: apol, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28184: KIO autotests: repair JobTest::moveDestAlreadyExistsAutoRename

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. I confirm that the test gets fixed. Also the change makes sense. It seems to me that both else branches end the same. From `list = ...` it can be moved out, no? REPOSITORY R241 KIO

D28186: GIT_SILENT kpasswdserver, break long lines for readability; add braces around if

ahmadsamir updated this revision to Diff 78171. ahmadsamir retitled this revision from "GIT_SILENT break long lines for readability; add braces around if" to "GIT_SILENT kpasswdserver, break long lines for readability; add braces around if". ahmadsamir added a comment. Verbatim REPOSITORY

D28186: GIT_SILENT break long lines for readability; add braces around if

ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, dfaure. Herald added a project: Frameworks. ahmadsamir requested review of this revision. TEST PLAN The code still compiles. REPOSITORY R241 KIO BRANCH l-kpasswdserver-long-lines (branched from master) REVISION

D28169: [krununittest] Skip the test if ktelnetservice5{, .desktop} isn't found

dfaure added a comment. In D28169#631893 , @ahmadsamir wrote: > Yesterday, I did try tweaking XDG_DATA_DIRS to make it find the .desktop file without it being in /usr/share/applications It's more portable to use QStandardPaths test mode

D28184: KIO autotests: repair JobTest::moveDestAlreadyExistsAutoRename

dfaure created this revision. dfaure added a reviewer: meven. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. dfaure requested review of this revision. REVISION SUMMARY It failed for me, and for FreeBSD on CI. I guess the Linux CI has it all on the same

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 345 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/345/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sat, 21 Mar 2020 14:46:12 + Build duration: 6 min 21 sec and counting JUnit Tests Name:

D28169: [krununittest] Skip the test if ktelnetservice5{, .desktop} isn't found

ahmadsamir abandoned this revision. ahmadsamir added a comment. In D28169#631885 , @dfaure wrote: > OK, it's fixed now, after 3 commits :-) > You can drop this change, it's better that CI actually tests the code. [..] Yesterday, I

D28169: [krununittest] Skip the test if ktelnetservice5{, .desktop} isn't found

dfaure added a comment. OK, it's fixed now, after 3 commits :-) You can drop this change, it's better that CI actually tests the code. Thanks for your help though (with this, and with everything else - very much appreciated) REPOSITORY R241 KIO REVISION DETAIL

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 477 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/477/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 21 Mar 2020 13:59:33 + Build duration: 5 min 35 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 344 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/344/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sat, 21 Mar 2020 13:57:46 + Build duration: 5 min 23 sec and counting JUnit Tests Name:

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.13 - Build # 353 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.13/353/ Project: kf5-qt5 SUSEQt5.13 Date of build: Sat, 21 Mar 2020 13:56:44 + Build duration: 5 min 31 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 476 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/476/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 21 Mar 2020 13:51:12 + Build duration: 8 min 19 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 343 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/343/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sat, 21 Mar 2020 13:51:12 + Build duration: 6 min 32 sec and counting JUnit Tests Name:

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.13 - Build # 352 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.13/352/ Project: kf5-qt5 SUSEQt5.13 Date of build: Sat, 21 Mar 2020 13:51:12 + Build duration: 5 min 30 sec and counting BUILD ARTIFACTS

D27950: Assign an icon to action submenus

This revision was automatically updated to reflect the committed changes. Closed by commit R241:3f69e6401e44: Assign an icon to action submenus (authored by apol). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27950?vs=77295=78164 REVISION DETAIL

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 475 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/475/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 21 Mar 2020 13:01:51 + Build duration: 8 min 55 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 342 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/342/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sat, 21 Mar 2020 13:01:51 + Build duration: 7 min 8 sec and counting JUnit Tests Name:

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.13 - Build # 351 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.13/351/ Project: kf5-qt5 SUSEQt5.13 Date of build: Sat, 21 Mar 2020 13:01:51 + Build duration: 6 min 6 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kparts » kf5-qt5 SUSEQt5.12 - Build # 95 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kparts/job/kf5-qt5%20SUSEQt5.12/95/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 21 Mar 2020 13:03:36 + Build duration: 3 min 8 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kparts » kf5-qt5 SUSEQt5.13 - Build # 73 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kparts/job/kf5-qt5%20SUSEQt5.13/73/ Project: kf5-qt5 SUSEQt5.13 Date of build: Sat, 21 Mar 2020 13:03:36 + Build duration: 2 min 43 sec and counting BUILD ARTIFACTS

D21902: Calendar: add method to show event details

dvratil added a comment. Ping? :) REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D21902 To: dvratil, mart, #frameworks, #plasma Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D25301: Move createUDSEntry from file.cpp to file_unix.cpp

dfaure accepted this revision. REPOSITORY R241 KIO BRANCH arcpatch-D25301 REVISION DETAIL https://phabricator.kde.org/D25301 To: meven, #frameworks, dfaure Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D25301: Move createUDSEntry from file.cpp to file_unix.cpp

meven updated this revision to Diff 78159. meven marked 3 inline comments as done. meven added a comment. Add 3 missing static REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25301?vs=78141=78159 BRANCH arcpatch-D25301 REVISION DETAIL

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 474 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/474/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 21 Mar 2020 12:27:21 + Build duration: 8 min 54 sec and counting BUILD ARTIFACTS

D28169: [krununittest] Skip the test if ktelnetservice5{, .desktop} isn't found

dfaure added a comment. The bug is that, after the fuse dbus call fails, we can't just blindly go to kioexec. It depends on `supported`. ktelnetservice supports ssh, so we don't need kioexec. Will rework... REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D28169 To:

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.13 - Build # 350 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.13/350/ Project: kf5-qt5 SUSEQt5.13 Date of build: Sat, 21 Mar 2020 12:27:21 + Build duration: 6 min 35 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 341 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/341/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sat, 21 Mar 2020 12:27:21 + Build duration: 6 min 58 sec and counting JUnit Tests Name:

D28169: [krununittest] Skip the test if ktelnetservice5{, .desktop} isn't found

dfaure added a comment. In D28169#631841 , @ahmadsamir wrote: > In D28169#631809 , @dfaure wrote: > > > Ah, we had tried already to make it work uninstalled. > > > > The actual way to do that

D28097: GIT_SILENT clang-format kpasswdserver.*

This revision was automatically updated to reflect the committed changes. Closed by commit R241:66837e4c049d: GIT_SILENT clang-format kpasswdserver.* (authored by ahmadsamir). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28097?vs=78157=78158 REVISION DETAIL

D28097: GIT_SILENT clang-format kpasswdserver.*

ahmadsamir updated this revision to Diff 78157. ahmadsamir added a comment. Rebase on master REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28097?vs=78155=78157 BRANCH l-kpasswdserver-clang-format (branched from master) REVISION DETAIL

D28169: [krununittest] Skip the test if ktelnetservice5{, .desktop} isn't found

ahmadsamir added a comment. In D28169#631809 , @dfaure wrote: > Ah, we had tried already to make it work uninstalled. > > The actual way to do that would be to copy that desktop file into a local ApplicationsLocation. I'll do that, I just

D28169: [krununittest] Skip the test if ktelnetservice5{, .desktop} isn't found

ahmadsamir updated this revision to Diff 78156. ahmadsamir added a comment. Verbatim REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28169?vs=78152=78156 BRANCH l-krun-ssh-2 (branched from master) REVISION DETAIL https://phabricator.kde.org/D28169

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 340 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/340/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sat, 21 Mar 2020 12:07:11 + Build duration: 15 min and counting JUnit Tests Name: projectroot

D28097: GIT_SILENT clang-format kpasswdserver.*

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. Thanks. Let's do manual changes separately :-) REPOSITORY R241 KIO BRANCH l-kpasswdserver-clang-format (branched from master) REVISION DETAIL https://phabricator.kde.org/D28097 To:

D28097: GIT_SILENT clang-format kpasswdserver.*

ahmadsamir updated this revision to Diff 78155. ahmadsamir retitled this revision from "GIT_SILENT clang-format kpasswdserver.* plus some manual changes" to "GIT_SILENT clang-format kpasswdserver.*". ahmadsamir added a comment. Verbatim REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 473 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/473/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 21 Mar 2020 12:07:11 + Build duration: 10 min and counting BUILD ARTIFACTS

D28097: GIT_SILENT clang-format kpasswdserver.* plus some manual changes

ahmadsamir updated this revision to Diff 78154. ahmadsamir added a comment. clang-format only, less prone to errors, as the level of stupidity of the tool is locked at the compile time of the tool (unlike manual changes) REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.13 - Build # 349 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.13/349/ Project: kf5-qt5 SUSEQt5.13 Date of build: Sat, 21 Mar 2020 12:07:11 + Build duration: 8 min 51 sec and counting BUILD ARTIFACTS

D28122: Move/port KFontDialog from KDELibs4Support to KWidgetAddons

ahmadsamir updated this revision to Diff 78153. ahmadsamir added a comment. Tweak docs REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28122?vs=78124=78153 BRANCH l-kfontdlg (branched from master) REVISION DETAIL

KDE CI: Frameworks » kparts » kf5-qt5 FreeBSDQt5.13 - Build # 67 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kparts/job/kf5-qt5%20FreeBSDQt5.13/67/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sat, 21 Mar 2020 11:50:16 + Build duration: 17 min and counting JUnit Tests Name: projectroot

D28169: [krununittest] Skip the test if ktelnetservice5{, .desktop} isn't found

dfaure added a comment. Ah, we had tried already to make it work uninstalled. The actual way to do that would be to copy that desktop file into a local ApplicationsLocation. I'll do that, I just did something similar in KParts. REPOSITORY R241 KIO REVISION DETAIL

Re: KIO: try to assign an icon to action submenus

On dimanche 15 mars 2020 19:11:39 CET Chloe Kudryavtsev wrote: > So we need to be able to pass an icon inside of a ServiceList. > As mentioned, ServiceList is a QList. > QList is part of Qt and KServiceAction is part of KService. The usual solution for this is to replace ServiceList with struct

D27950: Assign an icon to action submenus

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D27950 To: apol, #frameworks, dfaure Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kparts » kf5-qt5 SUSEQt5.12 - Build # 94 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kparts/job/kf5-qt5%20SUSEQt5.12/94/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 21 Mar 2020 11:50:16 + Build duration: 3 min 18 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kparts » kf5-qt5 WindowsMSVCQt5.14 - Build # 14 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kparts/job/kf5-qt5%20WindowsMSVCQt5.14/14/ Project: kf5-qt5 WindowsMSVCQt5.14 Date of build: Sat, 21 Mar 2020 11:50:15 + Build duration: 2 min 43 sec and counting JUnit Tests Name:

KDE CI: Frameworks » kparts » kf5-qt5 SUSEQt5.13 - Build # 72 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kparts/job/kf5-qt5%20SUSEQt5.13/72/ Project: kf5-qt5 SUSEQt5.13 Date of build: Sat, 21 Mar 2020 11:50:15 + Build duration: 2 min 2 sec and counting BUILD ARTIFACTS

D28169: [krununittest] Skip the test if ktelnetservice5{, .desktop} isn't found

ahmadsamir updated this revision to Diff 78152. ahmadsamir retitled this revision from "[DesktopExecParser] Let the service open protocols is claims to support" to "[krununittest] Skip the test if ktelnetservice5{,.desktop} isn't found". ahmadsamir edited the test plan for this revision.

D25301: Move createUDSEntry from file.cpp to file_unix.cpp

dfaure accepted this revision. dfaure added inline comments. INLINE COMMENTS > file_unix.cpp:147 > + > +QString getUserName(KUserId uid) > +{ static > file_unix.cpp:164 > + > +QString getGroupName(KGroupId gid) > +{ static > file_unix.cpp:248 > + > +bool createUDSEntry(const QString , const

D27936: Windows: Add suport for file date creation

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D27936 To: meven, #frameworks, elvisangelaccio, #windows, dfaure Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh,

D28128: Add force save behavior to KEntryMap

dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed. I would prefer a unittest based on public API, showing the actual bug (before the fix) with kdeglobals and a local config file. INLINE COMMENTS > kconfigdata.h:76 > +/** > +

D27760: WIP | Added BatchMoveJob

dfaure added a comment. Looks good, just a few things. INLINE COMMENTS > batchmovejobtest.cpp:91 > +job->setUiDelegate(nullptr); > +QSignalSpy spy(job, SIGNAL(fileMoved(QUrl, QUrl))); > + Use newer syntax ::BatchMoveJob::fileMoved? > batchmovejobtest.cpp:104 > +

D27883: Register spawned applications as an independent cgroups

dfaure requested changes to this revision. dfaure added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > kprocessrunner.cpp:292 > + > +QDBusMessage message = > QDBusMessage::createMethodCall(QStringLiteral("org.freedesktop.systemd1"), > +

D28097: GIT_SILENT clang-format kpasswdserver.* plus some manual changes

dfaure requested changes to this revision. dfaure added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > kpasswdserver.cpp:249 > #ifdef HAVE_KF5WALLET > -if (!result && > -!m_walletDisabled && > -(info.username.isEmpty() ||

D28079: [keditfiletype] Prevent removing the "main" glob pattern for mime types

dfaure added a comment. I wrote QMimeDatabase, and my only intent was to move the main glob to be first. Not to prevent people from removing it. So this is a Qt bug. REPOSITORY R126 KDE CLI Utilities REVISION DETAIL https://phabricator.kde.org/D28079 To: ahmadsamir, #plasma, dfaure,

KDE CI: Frameworks » kparts » kf5-qt5 FreeBSDQt5.13 - Build # 66 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kparts/job/kf5-qt5%20FreeBSDQt5.13/66/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sat, 21 Mar 2020 10:00:23 + Build duration: 4 min 7 sec and counting JUnit Tests Name:

KDE CI: Frameworks » kparts » kf5-qt5 SUSEQt5.13 - Build # 71 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kparts/job/kf5-qt5%20SUSEQt5.13/71/ Project: kf5-qt5 SUSEQt5.13 Date of build: Sat, 21 Mar 2020 10:00:23 + Build duration: 3 min 15 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kparts » kf5-qt5 SUSEQt5.12 - Build # 93 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kparts/job/kf5-qt5%20SUSEQt5.12/93/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 21 Mar 2020 10:00:23 + Build duration: 2 min 26 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kparts » kf5-qt5 WindowsMSVCQt5.14 - Build # 13 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kparts/job/kf5-qt5%20WindowsMSVCQt5.14/13/ Project: kf5-qt5 WindowsMSVCQt5.14 Date of build: Sat, 21 Mar 2020 10:00:23 + Build duration: 2 min 38 sec and counting JUnit Tests

D25315: KDirModel: implement showing a root node for the requested URL

dfaure added a subscriber: rrosch. dfaure added a comment. @rrosch Does this now behave as expected? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D25315 To: dfaure, stefanocrocco, elvisangelaccio, meven, apol Cc: rrosch, ahmadsamir, kde-frameworks-devel, LeGast00n,

  1   2   >