D28220: Switch to using Kirigami's ShadowedRectangle

ahiemstra added inline comments. INLINE COMMENTS > EntryScreenshots.qml:134 > +Kirigami.Theme.colorSet: Kirigami.Theme.View > +shadow.xOffset: 0 > +shadow.yOffset: 0 The x and y offsets should be 0 by default, so there's little reason t

D26407: KFileItem: Improve isSlow to not block when a network mount is unresponsive, make SkipMimeTypeFromContent skip only on slow fs

meven planned changes to this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D26407 To: meven, #frameworks, ngraham, broulik, dfaure Cc: cfeck, anthonyfieroni, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » sonnet » kf5-qt5 FreeBSDQt5.14 - Build # 3 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/sonnet/job/kf5-qt5%20FreeBSDQt5.14/3/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Tue, 24 Mar 2020 15:47:06 + Build duration: 2 min 7 sec and counting JUnit Tests Name: projectro

KDE CI: Frameworks » sonnet » kf5-qt5 WindowsMSVCQt5.14 - Build # 17 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/sonnet/job/kf5-qt5%20WindowsMSVCQt5.14/17/ Project: kf5-qt5 WindowsMSVCQt5.14 Date of build: Tue, 24 Mar 2020 15:47:06 + Build duration: 1 min 57 sec and counting JUnit Tests Name:

KDE CI: Frameworks » sonnet » kf5-qt5 SUSEQt5.12 - Build # 87 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/sonnet/job/kf5-qt5%20SUSEQt5.12/87/ Project: kf5-qt5 SUSEQt5.12 Date of build: Tue, 24 Mar 2020 15:47:06 + Build duration: 1 min 46 sec and counting BUILD ARTIFACTS abi-compatibili

KDE CI: Frameworks » sonnet » kf5-qt5 SUSEQt5.13 - Build # 64 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/sonnet/job/kf5-qt5%20SUSEQt5.13/64/ Project: kf5-qt5 SUSEQt5.13 Date of build: Tue, 24 Mar 2020 15:47:06 + Build duration: 1 min 43 sec and counting BUILD ARTIFACTS abi-compatibili

D25495: Fix Sonnet autodetect failing on Indian langs

This revision was automatically updated to reflect the committed changes. Closed by commit R246:2ce07be5dff3: Fix Sonnet autodetect failing on Indian langs (authored by waqar, committed by apol). REPOSITORY R246 Sonnet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25495?vs=72684&id=

D28220: Switch to using Kirigami's ShadowedRectangle

leinir added a subscriber: davidedmundson. leinir added a comment. In D28220#633557 , @ngraham wrote: > Just an observation, we should maybe consider making a shared component for this screenshots list so that Discover can use it too. i w

D25495: Fix Sonnet autodetect failing on Indian langs

waqar added a comment. I tried but I don't have the access. So I guess you guys would have land. REPOSITORY R246 Sonnet BRANCH fix-176537 (branched from master) REVISION DETAIL https://phabricator.kde.org/D25495 To: waqar, mludwig, cullmann, apol Cc: apol, ognarb, kde-frameworks-

D28220: Switch to using Kirigami's ShadowedRectangle

ngraham added a comment. Just an observation, we should maybe consider making a shared component for this screenshots list so that Discover can use it too. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D28220 To: leinir, #knewstuff, #frameworks, #plasma, ahiemstr

D25495: Fix Sonnet autodetect failing on Indian langs

apol added a comment. Can you land the patch or you need us to? REPOSITORY R246 Sonnet BRANCH fix-176537 (branched from master) REVISION DETAIL https://phabricator.kde.org/D25495 To: waqar, mludwig, cullmann, apol Cc: apol, ognarb, kde-frameworks-devel, LeGast00n, cblack, GB_2, michae

D25495: Fix Sonnet autodetect failing on Indian langs

waqar added a comment. In D25495#633551 , @apol wrote: > Whatever, let's go with this and we can learn along the way. > > Sorry it took so long. I am excited. Thanks! I will be sure to keep checking in if anything goes amiss in

D25495: Fix Sonnet autodetect failing on Indian langs

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. Whatever, let's go with this and we can learn along the way. Sorry it took so long. REPOSITORY R246 Sonnet BRANCH fix-176537 (branched from master) REVISION DETAIL https://phabricat

D25495: Fix Sonnet autodetect failing on Indian langs

waqar added inline comments. INLINE COMMENTS > apol wrote in guesslanguage.cpp:586 > Why did you handle it here rather than in identify then? is it a problem > doing it there? I see that identify is being used elsewhere too. It will be > wrong there. Initially I handled it in identify () but t

D25495: Fix Sonnet autodetect failing on Indian langs

apol added inline comments. INLINE COMMENTS > waqar wrote in guesslanguage.cpp:586 > `identify()` fails if a certain language is not present in the trigrams. Why did you handle it here rather than in identify then? is it a problem doing it there? I see that identify is being used elsewhere too.

D28241: Check correct file for sandbox detection

This revision was automatically updated to reflect the committed changes. Closed by commit R271:7f8d778b0a05: Check correct file for sandbox detection (authored by jgrulich). REPOSITORY R271 KDBusAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28241?vs=78362&id=78363 REVISION

D28241: Check correct file for sandbox detection

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R271 KDBusAddons BRANCH master REVISION DETAIL https://phabricator.kde.org/D28241 To: jgrulich, apol Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28241: Check correct file for sandbox detection

jgrulich created this revision. jgrulich added a reviewer: apol. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. jgrulich requested review of this revision. REPOSITORY R271 KDBusAddons BRANCH master REVISION DETAIL https://phabricator.kde.org/D28241 AF

D28144: Make animation durations consistent with Kirigami values

ngraham reopened this revision. ngraham added a comment. This revision is now accepted and ready to land. I reverted this for now in e2a13e9ac79a8d8d8a7dfd0916f6826760b73165 because if we land it now before the companion Plasma patches are in, rolling release users will suffer from slow anima

Re: Problems in KWayland causes by API and ABI compatibility promises

On Mon, Mar 23, 2020 at 3:45 PM David Edmundson wrote: > > > > > That's a good question! On one hand, it's nice to have Qt-friendly > > wrappers for Wayland protocols. On the other hand, it would be even > > better to have a library to write Wayland compositors. So, one just > > needs to plug a fe

D27873: sftp: do not show creation time when we do not know it

meven accepted this revision. meven added a comment. Ok to me @bruns ? REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D27873 To: sitter, ngraham, bruns, meven Cc: meven, bruns, kde-frameworks-devel, kfm-devel, nikolaik, pberestov, iasensio, fprice, LeGast00n, cbl

D28144: Make animation durations consistent with Kirigami values

ngraham added a dependent revision: D28239: Stop multiplying duration values. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D28144 To: ngraham, #plasma, davidedmundson, mart Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28144: Make animation durations consistent with Kirigami values

ngraham added a dependent revision: D28238: Stop multiplying duration values. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D28144 To: ngraham, #plasma, davidedmundson, mart Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28235: Add a simpler example

apol created this revision. apol added a reviewer: vkrause. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. apol requested review of this revision. REVISION SUMMARY Just a QPlainTextEdit and a highlighter. TEST PLAN Used it to figure out

D27873: sftp: do not show creation time when we do not know it

sitter updated this revision to Diff 78352. sitter added a comment. . REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27873?vs=77080&id=78352 BRANCH sftp-ctime REVISION DETAIL https://phabricator.kde.org/D27873 AFFECTED FILES sftp/kio_sftp.cpp T

D28128: Add force save behavior to KEntryMap

dfaure added inline comments. INLINE COMMENTS > bport wrote in kconfigtest.cpp:1970 > This is a global local file, not system wide and so not considered as default > cf. https://lxr.kde.org/source/frameworks/kconfig/src/core/kconfig.cpp#0702 > if the entry is set system wide > /etc/kde5rc > /etc

D28122: Copy KFontDialog from KDELibs4Support to KWidgetAddons, now KFontChooserDialog

ahmadsamir added inline comments. INLINE COMMENTS > meven wrote in kfontchooserdialog.cpp:93 > Shouldn't this be not commented IIUC, if a function is declared static inside the class body (e.g. in the header file), the static keyword can't be repeated when it's defined outside the class body.

KDE CI: Frameworks » kwayland » kf5-qt5 FreeBSDQt5.14 - Build # 2 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20FreeBSDQt5.14/2/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Tue, 24 Mar 2020 10:50:32 + Build duration: 15 min and counting JUnit Tests Name: projectroot.

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.12 - Build # 117 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.12/117/ Project: kf5-qt5 SUSEQt5.12 Date of build: Tue, 24 Mar 2020 10:50:33 + Build duration: 6 min 47 sec and counting BUILD ARTIFACTS abi-compatib

D28122: Copy KFontDialog from KDELibs4Support to KWidgetAddons, now KFontChooserDialog

meven added inline comments. INLINE COMMENTS > kfontchooserdialog.cpp:93 > + > +// static > +int KFontChooserDialog::getFontDiff(QFont &theFont, > KFontChooser::FontDiffFlags &diffFlags, Shouldn't this be not commented > kfontchooserdialog.cpp:110 > + > +// static > +int KFontChooserDialog::ge

D27535: Add XdgOutputV1 version 2

This revision was automatically updated to reflect the committed changes. Closed by commit R127:8b355825a3b8: Add XdgOutputV1 version 2 (authored by davidedmundson). REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27535?vs=76077&id=78345 REVISION DETAIL htt

D27873: sftp: do not show creation time when we do not know it

meven added a comment. In D27873#624567 , @sitter wrote: > In D27873#623582 , @bruns wrote: > > > Please correct the comment in the code - it depends on the server SFTP implementation. > > > Bi

D27936: Windows: Add suport for file date creation

This revision was automatically updated to reflect the committed changes. Closed by commit R241:50bc53ffbcf2: Windows: Add suport for file date creation (authored by meven). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27936?vs=77236&id=78343 REVISION DETAIL

D28220: Switch to using Kirigami's ShadowedRectangle

leinir updated this revision to Diff 78342. leinir added a comment. - Less magic numbers - Remove some unneeded bits REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28220?vs=78341&id=78342 BRANCH switch-to-kirigami-shadowedrectangle (branched from mas

D28220: Switch to using Kirigami's ShadowedRectangle

leinir edited the test plan for this revision. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D28220 To: leinir, #knewstuff, #frameworks, #plasma, ahiemstra, broulik, mart, #vdg Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28220: Switch to using Kirigami's ShadowedRectangle

leinir added a reviewer: VDG. leinir marked 3 inline comments as done. leinir added a comment. (pending some screenshots of the visible change) INLINE COMMENTS > broulik wrote in EntryScreenshots.qml:138 > You used `largeSpacing` as `verticalOffset` before Hm, on second thought, it looks /te

D28220: Switch to using Kirigami's ShadowedRectangle

leinir marked 5 inline comments as done. leinir added inline comments. INLINE COMMENTS > broulik wrote in EntryScreenshots.qml:133 > Not needed given you `anchors.fill` Ah yes, quite :) > broulik wrote in EntryScreenshots.qml:135 > What's this for? That's a good question, really - i found that

D28220: Switch to using Kirigami's ShadowedRectangle

broulik added inline comments. INLINE COMMENTS > EntryScreenshots.qml:133 > anchors.fill: thumbnail > -verticalOffset: Kirigami.Units.largeSpacing > -horizontalOffset: 0 > -radius: 12.0 > -samples

D28220: Switch to using Kirigami's ShadowedRectangle

leinir updated this revision to Diff 78341. leinir added a comment. - Increase Kirigami runtime dep version to 2.12 REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28220?vs=78290&id=78341 BRANCH switch-to-kirigami-shadowedrectangle (branched from master

D28223: Add "Stat" prefix to StatDetails Enum entries

meven marked 2 inline comments as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D28223 To: meven, #frameworks, kossebau, dfaure Cc: davidre, broulik, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28223: Add "Stat" prefix to StatDetails Enum entries

meven marked 2 inline comments as done. meven added inline comments. INLINE COMMENTS > davidre wrote in global.h:322 > I think this enum was not released yet Indeed it will be part of KF 5.69 (as the comment above the enum tells), view discussion in D25010

D28223: Add "Stat" prefix to StatDetails Enum entries

davidre added inline comments. INLINE COMMENTS > global.h:322 > /// No field returned, useful to check if a file exists > -NoDetails = 0x0, > +StatNoDetails = 0x0, > /// Filename, access, type, size, linkdest I think this enum was not released yet REPOSITORY R241 KIO REVISI

D28223: Add "Stat" prefix to StatDetails Enum entries

broulik added inline comments. INLINE COMMENTS > global.h:322 > /// No field returned, useful to check if a file exists > -NoDetails = 0x0, > +StatNoDetails = 0x0, > /// Filename, access, type, size, linkdest Is this change source-compatible? REPOSITORY R241 KIO REVISION DE

<    1   2   3