D28476: Samba: Ensure to differenciate mounts sharing the same source

meven added a comment. In D28476#639524 , @bruns wrote: > The comment and commit message are lacking required information. One should not have to go to the bug report to actually see why this is needed. How about the commit title "Ensure

D28647: Fix KIO::Scheduler::emitReparseSlaveConfiguration() to work if called twice in same process

marten created this revision. marten added reviewers: Frameworks, dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. marten requested review of this revision. REVISION SUMMARY I've been looking at porting Konqueror's User Agent Changer plugin to current

T12855: [Breeze Icons] Get rid of redundancy in icons-dark/

ndavis added a comment. I could probably make the python script instead, but I'm in the same spot when it comes to writing CMake. TASK DETAIL https://phabricator.kde.org/T12855 To: ndavis Cc: ndavis, ngraham, kde-frameworks-devel, davidhurka, dmenig, manueljlin, Orage, LeGast00n, cblack,

D27910: Make sure warning output is enabled before testing if the correct warning is printed

sandsmark abandoned this revision. sandsmark added a comment. In D27910#632041 , @dfaure wrote: > Note that in both cases the env var QT_LOGGING_RULES would break the unittest anyway... so yeah it's only about qtlogging.ini which we can easily s

D27910: Make sure warning output is enabled before testing if the correct warning is printed

dfaure added a comment. I like your first suggestion. I don't like the second one, because QT_LOGGING_RULES is used (by at least CI and myself) to enable *more* debug output. unsetenv would break that. REPOSITORY R243 KArchive REVISION DETAIL https://phabricator.kde.org/D27910 To:

D28478: [FileProtocol] change statx stat_dev() to return makedev(major, minor)

ahmadsamir updated this revision to Diff 79567. ahmadsamir marked an inline comment as done. ahmadsamir added a comment. Rebase REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28478?vs=79411&id=79567 BRANCH l-statx (branched from master) REVISION DETAIL ht

D28478: [FileProtocol] change statx stat_dev() to return makedev(major, minor)

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R241:d025ed9bfe4d: [FileProtocol] change statx stat_dev() to return makedev(major, minor) (authored by ahmadsamir). REPOSIT

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.14 - Build # 42 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.14/42/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Tue, 07 Apr 2020 13:23:02 + Build duration: 11 min and counting JUnit Tests Name: projectroot Fail

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 533 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/533/ Project: kf5-qt5 SUSEQt5.12 Date of build: Tue, 07 Apr 2020 13:23:22 + Build duration: 33 min and counting BUILD ARTIFACTS acc/KF5KIO-5.69.0.xmllo

D27557: Auto-generate 24px monochrome icons

davidhurka added a comment. In D27557#616831 , @sitter wrote: > > - if your script is doing a lot of stuff you may want to revise how the script works. specifically for this diff sed needs to iter all the content of all the SVGs th

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.14 - Build # 34 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.14/34/ Project: kf5-qt5 SUSEQt5.14 Date of build: Tue, 07 Apr 2020 13:23:04 + Build duration: 48 min and counting BUILD ARTIFACTS acc/KF5KIO-5.69.0.xmllog

D28324: [Inotify] Remove dead/duplicate code

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. I think this is fine. REPOSITORY R293 Baloo BRANCH submit REVISION DETAIL https://phabricator.kde.org/D28324 To: bruns, #baloo, ngraham Cc: pino, kde-frameworks-devel, hurikhan77,

D28328: [Inotify] Remove not-so-OptimizedByteArray

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH submit REVISION DETAIL https://phabricator.kde.org/D28328 To: bruns, #baloo, ngraham Cc: kde-frameworks-devel, #baloo, hurikhan77, lots0logs, LeGast00n, cblack, fbampaloukas, GB_

D28400: [AdvancedQueryParser] Move semantic handling of tokens to SearchStore

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH submit REVISION DETAIL https://phabricator.kde.org/D28400 To: bruns, #baloo, ngraham Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, fbampaloukas, GB_2, domso

D28500: [PhraseAndIteratorTest] Cleanup, use better variable names

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH submit REVISION DETAIL https://phabricator.kde.org/D28500 To: bruns, #baloo, ngraham Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, fbampaloukas, GB_2, domso

D28401: [SearchStore] Handle double values in property queries

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH submit REVISION DETAIL https://phabricator.kde.org/D28401 To: bruns, #baloo, ngraham Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, fbampaloukas, GB_2, domso

D28328: [Inotify] Remove not-so-OptimizedByteArray

This revision was automatically updated to reflect the committed changes. Closed by commit R293:24e64713592a: [Inotify] Remove not-so-OptimizedByteArray (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28328?vs=78608&id=79583 REVISION DETAIL

D28324: [Inotify] Remove dead/duplicate code

This revision was automatically updated to reflect the committed changes. Closed by commit R293:bcb5950e958e: [Inotify] Remove dead/duplicate code (authored by bruns). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D28324?vs=78600&id=79582#toc REPOSITORY R293 Baloo CHANGES SINCE LAST U

D28400: [AdvancedQueryParser] Move semantic handling of tokens to SearchStore

This revision was automatically updated to reflect the committed changes. Closed by commit R293:2b9c46881645: [AdvancedQueryParser] Move semantic handling of tokens to SearchStore (authored by bruns). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D28400?vs=78783&id=79584#toc REPOSITORY

KDE CI: Frameworks » baloo » kf5-qt5 FreeBSDQt5.14 - Build # 28 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20FreeBSDQt5.14/28/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Tue, 07 Apr 2020 15:18:51 + Build duration: 44 sec and counting CONSOLE OUTPUT [...truncated 666

D28401: [SearchStore] Handle double values in property queries

This revision was automatically updated to reflect the committed changes. Closed by commit R293:2fa16a2865dc: [SearchStore] Handle double values in property queries (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28401?vs=78784&id=79585 REVI

KDE CI: Frameworks » baloo » kf5-qt5 WindowsMSVCQt5.14 - Build # 55 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20WindowsMSVCQt5.14/55/ Project: kf5-qt5 WindowsMSVCQt5.14 Date of build: Tue, 07 Apr 2020 15:18:37 + Build duration: 59 sec and counting CONSOLE OUTPUT [...trunca

KDE CI: Frameworks » baloo » kf5-qt5 WindowsMSVCQt5.14 - Build # 56 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20WindowsMSVCQt5.14/56/ Project: kf5-qt5 WindowsMSVCQt5.14 Date of build: Tue, 07 Apr 2020 15:20:03 + Build duration: 48 sec and counting CONSOLE OUTPUT [...trunca

KDE CI: Frameworks » baloo » kf5-qt5 FreeBSDQt5.14 - Build # 29 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20FreeBSDQt5.14/29/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Tue, 07 Apr 2020 15:20:03 + Build duration: 1 min 25 sec and counting CONSOLE OUTPUT [...truncate

D28500: [PhraseAndIteratorTest] Cleanup, use better variable names

This revision was automatically updated to reflect the committed changes. Closed by commit R293:d4494ee49664: [PhraseAndIteratorTest] Cleanup, use better variable names (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28500?vs=79107&id=79587

KDE CI: Frameworks » baloo » kf5-qt5 WindowsMSVCQt5.14 - Build # 57 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20WindowsMSVCQt5.14/57/ Project: kf5-qt5 WindowsMSVCQt5.14 Date of build: Tue, 07 Apr 2020 15:23:03 + Build duration: 58 sec and counting CONSOLE OUTPUT [...trunca

KDE CI: Frameworks » baloo » kf5-qt5 FreeBSDQt5.14 - Build # 30 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20FreeBSDQt5.14/30/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Tue, 07 Apr 2020 15:23:03 + Build duration: 1 min 18 sec and counting CONSOLE OUTPUT [...truncate

D28128: Add force save behavior to KEntryMap

ervin accepted this revision. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D28128 To: bport, ervin, dfaure, meven, crossi, hchain Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28221: Don't write default value to configuration file when default value came from /etc/* file

ervin added a comment. LGTM but @dfaure concerns need to be addressed. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D28221 To: bport, ervin, dfaure, davidedmundson Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28221: Don't write default value to configuration file when default value came from /etc/* file

bport added a comment. In D28221#641971 , @dfaure wrote: > I have a hard time accepting that the documentation was wrong -- and if it was, then this commit has to fix it, and port as much of the app code that does exactly this, as possible.

D28460: Add KCModuleStateProbe as base class for plugin

ervin requested changes to this revision. ervin added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > kcmoduleloader.cpp:161 > +if (!mod.service() || mod.service()->noDisplay() || > mod.library().isEmpty()) > +{ > +return true; Curly brace shoul

D28520: Fix lifetime of slot in KIO-MTP

This revision was automatically updated to reflect the committed changes. Closed by commit R320:f4e0183adfd8: Fix lifetime of slot in KIO-MTP (authored by feverfew). REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28520?vs=79196&id=79609 REVISION DETAIL h

D28400: [AdvancedQueryParser] Move semantic handling of tokens to SearchStore

kossebau added inline comments. INLINE COMMENTS > searchstore.cpp:82 > +}; > +constexpr std::array internalProperties {{ > +{ "filename","F",QVariant::String }, This might need an explicit `#include ` on some systems, not exactly sure by the error message. At least with FreeBSD & W

D28397: Replace Vokoscreen with VokoscreenNG

This revision was automatically updated to reflect the committed changes. Closed by commit R304:5613fd66c5f4: Replace Vokoscreen with VokoscreenNG (authored by harogaston, committed by ngraham). REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28397?vs=79185&i

D28400: [AdvancedQueryParser] Move semantic handling of tokens to SearchStore

bcooksley added a comment. The following is notice that the following reviews/commits are being scheduled to be reverted in 24 hours due to the FTBFS on Windows and FreeBSD: - 2b9c468816459a318dd2c8fe96e5e5acf1cedfd1

D28397: Replace Vokoscreen with VokoscreenNG

ngraham added a comment. Great patches, @harogaston! Keep 'em coming! :) REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D28397 To: harogaston, #knewstuff, ngraham, leinir Cc: apol, pino, IlyaBizyaev, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham

D28400: [AdvancedQueryParser] Move semantic handling of tokens to SearchStore

bruns added a comment. In D28400#643934 , @bcooksley wrote: > The following is notice that the following reviews/commits are being scheduled to be reverted in 24 hours due to the FTBFS on Windows and FreeBSD: > > - 2b9c468816459a318dd2c8fe96

D28400: [AdvancedQueryParser] Move semantic handling of tokens to SearchStore

bruns added inline comments. INLINE COMMENTS > kossebau wrote in searchstore.cpp:82 > This might need an explicit `#include ` on some systems, not exactly > sure by the error message. > > At least with FreeBSD & Windows KDE CI fails over this: > https://build.kde.org/view/Failing/job/Framework

D28400: [AdvancedQueryParser] Move semantic handling of tokens to SearchStore

bcooksley added a comment. Sorry, but that isn't how this works. Also, you will notice that one of the failing platforms is FreeBSD. Which is freely available and OSS. The responsibility of people to keep code compiling rests with those working on it. Should there be platform specific is

D28400: [AdvancedQueryParser] Move semantic handling of tokens to SearchStore

vkrause added inline comments. INLINE COMMENTS > bruns wrote in searchstore.cpp:82 > Thanks for the heads-up. > > As you have noticed, the message is vague, so someone with access to one of > the affected systems should test it and submit a review. I don't have either of those here to test it

D28400: [AdvancedQueryParser] Move semantic handling of tokens to SearchStore

bruns added a comment. In D28400#643965 , @bcooksley wrote: > Sorry, but that isn't how this works. Also, you will notice that one of the failing platforms is FreeBSD. Which is freely available and OSS. That does not change the fact it r

D28397: Replace Vokoscreen with VokoscreenNG

harogaston added a comment. In D28397#643937 , @ngraham wrote: > Great patches, @harogaston! Keep 'em coming! :) Yes, quarantine is working good for me ;). I've also got a couple of PRs on Konsole. Thank you for your work and support @

KDE CI: Frameworks » baloo » kf5-qt5 WindowsMSVCQt5.14 - Build # 58 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20WindowsMSVCQt5.14/58/ Project: kf5-qt5 WindowsMSVCQt5.14 Date of build: Tue, 07 Apr 2020 20:28:12 + Build duration: 1 min 20 sec and counting

KDE CI: Frameworks » baloo » kf5-qt5 FreeBSDQt5.14 - Build # 31 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20FreeBSDQt5.14/31/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Tue, 07 Apr 2020 20:28:12 + Build duration: 2 min 42 sec and counting JUnit Tests Name: projectro

D28397: Replace Vokoscreen with VokoscreenNG

ngraham added a comment. You're welcome! REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D28397 To: harogaston, #knewstuff, ngraham, leinir Cc: apol, pino, IlyaBizyaev, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

Tips for testing and debugging KWindowSystem

Hi all, Can someone give me tips on how to test KWindowSystem while developing? I have a dual 4K monitor setup and I have found a bug that seems to reside in KWindowSystem. I would like to try to fix it and then submit a patch, but I would like to know what's the best way to test and especially to

D28669: make CopyJob non-recursive

McPain created this revision. McPain added a reviewer: kossebau. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. McPain requested review of this revision. REVISION SUMMARY Break recursive loop causing Dolphin to crash when linking 2 objects from one dire

D28669: make CopyJob non-recursive

kossebau edited reviewers, added: Frameworks, dfaure, meven, ahmadsamir; removed: kossebau. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D28669 To: McPain, #frameworks, dfaure, meven, ahmadsamir Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.14 - Build # 43 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.14/43/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Wed, 08 Apr 2020 04:23:52 + Build duration: 6 min 21 sec and counting JUnit Tests Name: projectroo

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 534 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/534/ Project: kf5-qt5 SUSEQt5.12 Date of build: Wed, 08 Apr 2020 04:23:52 + Build duration: 10 min and counting BUILD ARTIFACTS acc/KF5KIO-5.69.0.xmllo

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.14 - Build # 35 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.14/35/ Project: kf5-qt5 SUSEQt5.14 Date of build: Wed, 08 Apr 2020 04:23:52 + Build duration: 11 min and counting BUILD ARTIFACTS acc/KF5KIO-5.69.0.xmllog

D28669: make CopyJob non-recursive

anthonyfieroni added a comment. If you want to kill the job how this loop will be break? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D28669 To: McPain, #frameworks, dfaure, meven, ahmadsamir Cc: anthonyfieroni, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh,