D28221: Don't write default value to configuration file when default value came from /etc/* file

bport updated this revision to Diff 80624. bport added a comment. Add KConfig unittest REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28221?vs=78862&id=80624 REVISION DETAIL https://phabricator.kde.org/D28221 AFFECTED FILES autotests/kconfigskeletonte

D28919: Drop delayed second phase

This revision was automatically updated to reflect the committed changes. Closed by commit R297:093a673f0e59: Drop delayed second phase (authored by broulik). REPOSITORY R297 KDED CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28919?vs=80388&id=80621 REVISION DETAIL https://phabri

D28909: smb: port to Result system to force serialization of error/finish condition

sitter added inline comments. INLINE COMMENTS > dfaure wrote in kio_smb.h:96 > Whenever we port a 3rd slave to it ;-) Sure, if you think it's solid enough from an API POV. I was thinking that we should amend the slavebase API for KF6 in general. Instead of having error/finished/opened all func

D28980: Revert "add Baloo DBus signals for moved or removed files"

mgallien added a comment. In D28980#652256 , @bruns wrote: > In D28980#652102 , @mgallien wrote: > > > To be clear, I am fine with this change going in. > > > > I would still like to work on a pr

D28701: Add KPackage support to KNewStuffCore

leinir updated this revision to Diff 80617. leinir added a comment. Thank you to @ngraham for noticing this one! It only really pokes its head out if you have multiple things installed and then try and uninstall one of them - if you only have the one thing installed, it looks very much like

D28701: Add KPackage support to KNewStuffCore

leinir added a comment. As i thought, i was indeed holding the KPackage APi incorrectly ;) The culprit is hinted at in the line > org.kde.knewstuff.core: Attempting to perform an installation operation of type 3 on the package "/home/leinir/.local/share/plasma/desktoptheme/Sweet" of t

D29003: Use Q_EMIT and build with QT_NO_KEYWORDS

ahmadsamir added a reviewer: dfaure. ahmadsamir added a comment. We should also have a task on the KF6 workboard[1] about this, so that we cull them out of all the current code in KDE. (Or maybe use a perl-script to get them all?) [1] https://phabricator.kde.org/project/board/310/ R

D28919: Drop delayed second phase

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. I trust your analysis ;) REPOSITORY R297 KDED REVISION DETAIL https://phabricator.kde.org/D28919 To: broulik, #plasma, dfaure, davidedmundson, apol Cc: apol, kde-frameworks-devel, davi

D28919: Drop delayed second phase

broulik requested review of this revision. broulik added a comment. Waiting for @dfaure REPOSITORY R297 KDED REVISION DETAIL https://phabricator.kde.org/D28919 To: broulik, #plasma, dfaure, davidedmundson, apol Cc: apol, kde-frameworks-devel, davidedmundson, LeGast00n, cblack, michaelh,

<    1   2