D29420: Generate DBus interface

nicolasfella updated this revision to Diff 82237. nicolasfella added a comment. - Use q as parent - Change reply type - Use ranged-for REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29420?vs=81920=82237 BRANCH geninterface REVISION DETAIL

D29420: Generate DBus interface

nicolasfella marked 3 inline comments as done. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D29420 To: nicolasfella, #frameworks, broulik Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29513: [kcm trash] Change kcm trash size percent to 2 decimal places

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH trash REVISION DETAIL https://phabricator.kde.org/D29513 To: shubham, ngraham Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

ngraham added a comment. I like #2 the best! REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D28353 To: niccolove, #vdg, #plasma, cblack Cc: filipf, ngraham, cblack, kde-frameworks-devel, LeGast00n, michaelh, bruns

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

niccolove edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D28353 To: niccolove, #vdg, #plasma, cblack Cc: filipf, ngraham, cblack, kde-frameworks-devel, LeGast00n, michaelh, bruns

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

niccolove edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D28353 To: niccolove, #vdg, #plasma, cblack Cc: filipf, ngraham, cblack, kde-frameworks-devel, LeGast00n, michaelh, bruns

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

niccolove edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D28353 To: niccolove, #vdg, #plasma, cblack Cc: filipf, ngraham, cblack, kde-frameworks-devel, LeGast00n, michaelh, bruns

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

niccolove edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D28353 To: niccolove, #vdg, #plasma, cblack Cc: filipf, ngraham, cblack, kde-frameworks-devel, LeGast00n, michaelh, bruns

D25339: update lineHeight if boundingRect indicates a larger value.

rjvbb added a comment. > the code can be smart No, cleverly written at best (don't get me started! ;) ) > but it can't know how a user prefers to read text, there is no one-size fits all. EXACTLY. Words becomes a lot more readable for me when I use 64pt or larger so I read

D29123: Do not mark entry as uninstalled if uninstallation script failed

alex updated this revision to Diff 82228. alex added a comment. Update docs I adjusted your suggestion a bit, the signalEntryChanged gets also emitted, when the user cancels the uninstallation :-). REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE

D29342: Implement support for notification urgency on Android

This revision was automatically updated to reflect the committed changes. Closed by commit R289:9a13dd26d1de: Implement support for notification urgency on Android (authored by vkrause). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D29342?vs=81695=82227#toc REPOSITORY R289

D28208: Move sni icon handling logic from data engine to applet

kmaterka added a comment. @davidre can you extract your test improvement to a separate patch? it would help me in another issue and I don't want to "steal" your code :) REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D28208 To: davidre, kmaterka, broulik,

D25339: update lineHeight if boundingRect indicates a larger value.

ahmadsamir added a comment. In D25339#665827 , @xuetianweng wrote: > [...] > As for higher line, it might not as bad as you thought as it actually might improve readability for many people. I agree with this statement :).

D25339: update lineHeight if boundingRect indicates a larger value.

xuetianweng marked an inline comment as done. xuetianweng added a comment. In D25339#665432 , @rjvbb wrote: > With "we've ever seen" you do mean that lineheight only changes when a line that requires it scrolls into view? > > > Though line

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

niccolove edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D28353 To: niccolove, #vdg, #plasma, cblack Cc: filipf, ngraham, cblack, kde-frameworks-devel, LeGast00n, michaelh, bruns

D29513: [kcm trash] Change kcm trash size percent to 2 decimal places

shubham created this revision. shubham added a reviewer: ngraham. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. shubham requested review of this revision. REVISION SUMMARY This patch changes the precision from 3 decimal places to 2 TEST PLAN Go to

D29502: kwidgetsaddons: Add a named colors support in KColorCombo.

araujoluis updated this revision to Diff 82219. araujoluis added a comment. - kwidgetsaddons: kcolorcombo: code refactoring REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29502?vs=82200=82219 BRANCH named_color_support REVISION DETAIL

D29511: Label: Add ping-pong logic

patrickelectric added a comment. Thanks @davidedmundson and @ognarb, I was able to replicate the issue, I'll think a bit more in my approach REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D29511 To: patrickelectric, #plasma, #vdg, ognarb,

D29511: Label: Add ping-pong logic

davidedmundson requested changes to this revision. davidedmundson added a comment. Plasmacomponents is deprecated please see Plasmacomponents3 then see the readme within that and put this somewhere else. 1. Label is a super super super common element we don't want to add any overhead

D29511: Label: Add ping-pong logic

ognarb requested changes to this revision. ognarb added a comment. This revision now requires changes to proceed. I'm not sure it is a good idea, but at least for me it break the clock in my panel. F8294594: vokoscreenNG-2020-05-07_17-49-49.mkv

D29511: Label: Add ping-pong logic

patrickelectric added a comment. Outoput: F8294587: deepin-screen-recorder_qmlscene_20200507124715.gif REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D29511 To: patrickelectric, #plasma, #vdg Cc: cblack,

D29511: Label: Add ping-pong logic

cblack added a comment. You should include a video in the test plan since you're creating visual changes with motion. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D29511 To: patrickelectric, #plasma, #vdg Cc: cblack, kde-frameworks-devel,

D29511: Label: Add ping-pong logic

patrickelectric updated this revision to Diff 82218. patrickelectric added a comment. Update style REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29511?vs=82217=82218 BRANCH ping_pong_text REVISION DETAIL

D29511: Label: Add ping-pong logic

cblack added reviewers: Plasma, VDG. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D29511 To: patrickelectric, #plasma, #vdg Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29511: Label: Add ping-pong logic

patrickelectric created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. patrickelectric requested review of this revision. REVISION SUMMARY Add friendly ping-pong animation to allow visibility of full text in an animated way

D29502: kwidgetsaddons: Add a named colors support in KColorCombo.

tcanabrava added inline comments. INLINE COMMENTS > kcolorcombo.cpp:244 > +{ > +QList namedColors; > +for (int colorIndex = 0; colorIndex < colors.count(); colorIndex++) { namedColors.reserve(colors.size()); > kcolorcombo.cpp:245 > +QList namedColors; > +for (int colorIndex =

D29502: kwidgetsaddons: Add a named colors support in KColorCombo.

araujoluis added a comment. In D29502#665600 , @tcanabrava wrote: > In D29502#665582 , @cfeck wrote: > > > Does the delegate ensure the text is rendered in a color visible over the colored

D29502: kwidgetsaddons: Add a named colors support in KColorCombo.

araujoluis edited the summary of this revision. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D29502 To: araujoluis, tcanabrava, patrickelectric, hindenburg, ngraham Cc: broulik, cfeck, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29503: Pixel align children of GridViewInternal

fvogt added a comment. In D29503#665612 , @ngraham wrote: > I can't reproduce it, but I wonder if this could fix or help https://bugs.kde.org/show_bug.cgi?id=417488? Yup, that's exactly what I was seeing before this change: F8293538:

D29502: kwidgetsaddons: Add a named colors support in KColorCombo.

araujoluis updated this revision to Diff 82200. araujoluis added a comment. - kwidgetsaddons: kcolorcombo: fix colors() out of range - kwidgetsaddons: kcolorcombo: tests: add example for use named colors. - kwidgetsaddons: kcolorcombo: update named colow view. REPOSITORY R236

D29503: Pixel align children of GridViewInternal

ngraham added a comment. I can't reproduce it, but I wonder if this could fix or help https://bugs.kde.org/show_bug.cgi?id=417488? REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D29503 To: fvogt, #frameworks, broulik, mart, davidedmundson Cc: ngraham,

D29123: Do not mark entry as uninstalled if uninstallation script failed

ngraham accepted this revision. REPOSITORY R304 KNewStuff BRANCH arcpatch-D29123_1 REVISION DETAIL https://phabricator.kde.org/D29123 To: alex, #knewstuff, meven, ngraham, leinir Cc: leinir, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29502: kwidgetsaddons: Add a named colors support in KColorCombo.

broulik added inline comments. INLINE COMMENTS > kcolorcombo.h:60 > +/** Struct used in NamedColors list */ > +struct KNamedColor > +{ Do we really want to leak this `struct` into public API? REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D29502

D29502: kwidgetsaddons: Add a named colors support in KColorCombo.

tcanabrava added a comment. In D29502#665582 , @cfeck wrote: > Does the delegate ensure the text is rendered in a color visible over the colored background? not yet, I talked to gustavo and he's working in an updated version of the

D25339: update lineHeight if boundingRect indicates a larger value.

rjvbb added a comment. This new version does not cause a lineheight regression for me (after backporting it to 5.60.0). However, contrary to what I thought it does not react to emoji F8293110: emoji.txt REPOSITORY R39 KTextEditor REVISION

D29502: kwidgetsaddons: Add a named colors support in KColorCombo.

cfeck added a comment. Does the delegate ensure the text is rendered in a color visible over the colored background? REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D29502 To: araujoluis, tcanabrava, patrickelectric, hindenburg, ngraham Cc: cfeck,

D29175: DBus Runner: Add service property to request actions once

meven added inline comments. INLINE COMMENTS > alex wrote in dbusrunnertest.cpp:206 > The concept behind this test is, that the runner is just loaded. If the > Request-Actions-Once property is correctly implemented the actions are > requested when the plugin is initialized. That means that

D29455: KNS: Deprecate isRemote method and handle parse error properly

This revision was automatically updated to reflect the committed changes. Closed by commit R304:9575f2defb27: KNS: Deprecate isRemote method and handle parse error properly (authored by alex). REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE

D29451: KNS: Do not mark entry as installed if install script failed

This revision was automatically updated to reflect the committed changes. Closed by commit R304:2838e55acd17: KNS: Do not mark entry as installed if install script failed (authored by alex). REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE

KDE CI: Frameworks » kdeclarative » kf5-qt5 FreeBSDQt5.14 - Build # 12 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kdeclarative/job/kf5-qt5%20FreeBSDQt5.14/12/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Thu, 07 May 2020 09:59:21 + Build duration: 1 min 45 sec and counting JUnit Tests Name:

D29503: Pixel align children of GridViewInternal

This revision was automatically updated to reflect the committed changes. Closed by commit R296:9725a21bcd0e: Pixel align children of GridViewInternal (authored by fvogt). REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29503?vs=82183=82184 REVISION

D29455: KNS: Deprecate isRemote method and handle parse error properly

leinir accepted this revision. leinir added a comment. This revision is now accepted and ready to land. Sorted, nicely done :) Makes the code just a touch simpler as well, which is always good :) REPOSITORY R304 KNewStuff BRANCH fix_isremote_stuff (branched from master) REVISION DETAIL

D29123: Do not mark entry as uninstalled if uninstallation script failed

leinir accepted this revision. leinir added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > installation.h:113 > * > * The entry instance will be updated with any new information: > * Not blocking, but the documentation probably wants

D29503: Pixel align children of GridViewInternal

broulik accepted this revision. REPOSITORY R296 KDeclarative BRANCH master REVISION DETAIL https://phabricator.kde.org/D29503 To: fvogt, #frameworks, broulik, mart, davidedmundson Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29503: Pixel align children of GridViewInternal

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R296 KDeclarative BRANCH master REVISION DETAIL https://phabricator.kde.org/D29503 To: fvogt, #frameworks, broulik, mart, davidedmundson Cc: kde-frameworks-devel, LeGast00n, cblack,

D29503: Pixel align children of GridViewInternal

fvogt created this revision. fvogt added reviewers: Frameworks, broulik, mart. Herald added a project: Frameworks. fvogt requested review of this revision. REVISION SUMMARY The scroll bar size can be odd (for breeze it's 21), which causes leftMargin to be 12.5. This causes every delegate

D29451: KNS: Do not mark entry as installed if install script failed

leinir accepted this revision. leinir added a comment. This revision is now accepted and ready to land. Thank you :D Land away :) REPOSITORY R304 KNewStuff BRANCH arcpatch-D29451 REVISION DETAIL https://phabricator.kde.org/D29451 To: alex, #knewstuff, ngraham, leinir Cc:

D29451: KNS: Do not mark entry as installed if install script failed

alex updated this revision to Diff 82180. alex added a comment. Use qOverload No problem :-) REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29451?vs=82177=82180 BRANCH arcpatch-D29451 REVISION DETAIL https://phabricator.kde.org/D29451

D29502: kwidgetsaddons: Add a named colors support in KColorCombo.

araujoluis updated this revision to Diff 82179. araujoluis added a comment. - restore code deleted by mistake REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29502?vs=82178=82179 BRANCH named_color_support REVISION DETAIL

D29502: kwidgetsaddons: Add a named colors support in KColorCombo.

araujoluis updated this revision to Diff 82178. araujoluis added a comment. - Restore code deleted by mistake REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29502?vs=82173=82178 BRANCH named_color_support REVISION DETAIL

D25339: update lineHeight if boundingRect indicates a larger value.

rjvbb added a comment. With "we've ever seen" you do mean that lineheight only changes when a line that requires it scrolls into view? > Though line height won't shrink during the edit phase, it will back to the actual value upon save. Have you tried to reset the max. lineheight

D29451: KNS: Do not mark entry as installed if install script failed

leinir requested changes to this revision. leinir added a comment. This revision now requires changes to proceed. (oops, mistakenly marked as accepted, sorry...) REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D29451 To: alex, #knewstuff, ngraham, leinir Cc:

D29451: KNS: Do not mark entry as installed if install script failed

leinir accepted this revision. leinir added a comment. This revision is now accepted and ready to land. In D29451#665420 , @alex wrote: > Fix connect > > Thanks, I wasn't aware of that until now :-) Same, until a couple of weeks ago

D29451: KNS: Do not mark entry as installed if install script failed

alex updated this revision to Diff 82177. alex added a comment. Fix connect Thanks, I wasn't aware of that until now :-) REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29451?vs=82100=82177 BRANCH arcpatch-D29451 REVISION DETAIL

D29451: KNS: Do not mark entry as installed if install script failed

leinir requested changes to this revision. leinir added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > installation.cpp:355 > QProcess* p = runPostInstallationCommand(installedFiles.size() > == 1 ? installedFiles.first() : targetPath); > -

D29502: kwidgetsaddons: Add a named colors support in KColorCombo.

araujoluis edited the summary of this revision. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D29502 To: araujoluis, tcanabrava, patrickelectric, hindenburg, ngraham Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29502: kwidgetsaddons: Add a named colors support in KColorCombo.

araujoluis edited the summary of this revision. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D29502 To: araujoluis, tcanabrava, patrickelectric, hindenburg, ngraham Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29502: kwidgetsaddons: Add a named colors support in KColorCombo.

araujoluis edited the summary of this revision. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D29502 To: araujoluis, tcanabrava, patrickelectric, hindenburg, ngraham Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29502: kwidgetsaddons: Add a named colors support in KColorCombo.

araujoluis edited the summary of this revision. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D29502 To: araujoluis, tcanabrava, patrickelectric, hindenburg, ngraham Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29502: kwidgetsaddons: Add a named colors support in KColorCombo.

araujoluis created this revision. araujoluis added reviewers: tcanabrava, patrickelectric, hindenburg, ngraham. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. araujoluis requested review of this revision. REVISION SUMMARY Signed-off-by: Gustavo Carneiro