marcingu marked 2 inline comments as done.
REPOSITORY
R320 KIO Extras
REVISION DETAIL
https://phabricator.kde.org/D28745
To: marcingu, ivan, broulik, #dolphin, ngraham, meven, bruns, dfaure
Cc: dfaure, thiago, bruns, meven, ngraham, kde-frameworks-devel, kfm-devel,
waitquietly, azyx,
marcingu updated this revision to Diff 83358.
marcingu added a comment.
Renaming "deviceIdUnset" to "s_deviceIdUnset"
REPOSITORY
R320 KIO Extras
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D28745?vs=83357=83358
REVISION DETAIL
https://phabricator.kde.org/D28745
AFFECTED
dfaure added inline comments.
INLINE COMMENTS
> thumbnail.cpp:741
> +bool allowCache;
> +allowCache = sharesFilesystemWithThumbRoot(filePath);
> +if (!allowCache) {
join with previous line (this isn't C) ;)
> thumbnail.h:95
> +#ifndef Q_OS_WIN
>
