KDE CI: Frameworks » kirigami » kf5-qt5 SUSEQt5.12 - Build # 610 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kirigami/job/kf5-qt5%20SUSEQt5.12/610/ Project: kf5-qt5 SUSEQt5.12 Date of build: Tue, 08 Sep 2020 01:37:51 + Build duration: 54 sec and counting CONSOLE OUTPUT [...truncated 239 li

KDE CI: Frameworks » kirigami » kf5-qt5 SUSEQt5.12 - Build # 609 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kirigami/job/kf5-qt5%20SUSEQt5.12/609/ Project: kf5-qt5 SUSEQt5.12 Date of build: Tue, 08 Sep 2020 01:36:10 + Build duration: 1 min 38 sec and counting CONSOLE OUTPUT [...truncated

D29397: KPreviewJob : Support for DeviceRatioPixel

bruns added a comment. In D29397#663902 , @broulik wrote: > > At the risk of asking a stupid question, why? > > The text thumbnailer should be able to produce readable text on high dpi, or the folder thumbnailer should render the folder icon

D29526: Thumbnails: make thumbnail generation dpr-aware

bruns added inline comments. INLINE COMMENTS > imagecreator.cpp:48 > +ir.setQuality(75); // set quality so that the jpeg handler will use a > high quality downscaler > + > img = ir.read(); This whole hunk should not be part of this submission. Also, the comment ("jpeg") is likely wron

D29526: Thumbnails: make thumbnail generation dpr-aware

bruns added inline comments. INLINE COMMENTS > thumbnail.cpp:143 > > +bool createThumbnail(ThumbCreator *creator, const QString &path, int width, > int height, QImage &img, qreal devicePixelRatio = 1.0) > +{ Has to be static or in an anonymous namespace. > thumbnail.cpp:149 > +} else { >

D29526: Thumbnails: make thumbnail generation dpr-aware

bruns requested changes to this revision. bruns added a comment. This revision now requires changes to proceed. For all but text the DPR is completely irrelevant, large@1 is identical to normal@2. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D29526 To: meven, #

D29397: KPreviewJob : Support for DeviceRatioPixel

bruns added a comment. Most thumbnailers are completely DPR agnostic, and will create identical thumbnails for large@1 and normal@2. Having both is a waste of disk space and CPU time. The thumbnailer should have a key in its metadata to tell if it depends on the DPR, and only then diffe

D29526: Thumbnails: make thumbnail generation dpr-aware

meven added a comment. I just sent a specification evolution to cover this use case : https://gitlab.freedesktop.org/xdg/xdg-specs/-/merge_requests/35 REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D29526 To: meven, #frameworks, dfaure, broulik, sitter, ngraham C

KDE CI: Frameworks » kitemmodels » kf5-qt5 WindowsMSVCQt5.14 - Build # 51 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kitemmodels/job/kf5-qt5%20WindowsMSVCQt5.14/51/ Project: kf5-qt5 WindowsMSVCQt5.14 Date of build: Mon, 07 Sep 2020 09:08:13 + Build duration: 2 min 28 sec and counting JUnit Tests

KDE CI: Frameworks » kitemmodels » kf5-qt5 SUSEQt5.12 - Build # 129 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kitemmodels/job/kf5-qt5%20SUSEQt5.12/129/ Project: kf5-qt5 SUSEQt5.12 Date of build: Mon, 07 Sep 2020 09:08:13 + Build duration: 2 min 18 sec and counting BUILD ARTIFACTS abi-compa

KDE CI: Frameworks » kitemmodels » kf5-qt5 SUSEQt5.15 - Build # 19 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kitemmodels/job/kf5-qt5%20SUSEQt5.15/19/ Project: kf5-qt5 SUSEQt5.15 Date of build: Mon, 07 Sep 2020 09:08:13 + Build duration: 2 min 29 sec and counting BUILD ARTIFACTS abi-compat

KDE CI: Frameworks » kitemmodels » kf5-qt5 FreeBSDQt5.15 - Build # 19 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kitemmodels/job/kf5-qt5%20FreeBSDQt5.15/19/ Project: kf5-qt5 FreeBSDQt5.15 Date of build: Mon, 07 Sep 2020 09:08:13 + Build duration: 1 min 8 sec and counting JUnit Tests Name: pro