bruns added inline comments.
INLINE COMMENTS
> bruns wrote in jobtest.cpp:780
> This will set `m_SkipXattr` unconditionally even if the source FS does not
> support Xattrs.
And now you **only** check the source FS, but no longer the destination FS.
REVISION DETAIL
https://phabricator.kde.org
usta added inline comments.
INLINE COMMENTS
> jobtest.cpp:465
> +{
> +QString writeTest = dir + "/fsXattrTestFile";
> +createTestFile(writeTest);
const ?
> file_unix.cpp:1517
> }
> acl = acl_from_text(ACLString.toLatin1().constData());
> if (acl_valid(acl) ==
arrowd updated this revision to Diff 83364.
arrowd marked 2 inline comments as done.
arrowd added a comment.
- Make checkXattrFsSupport accept directory as a parameter.
- Consitify QStrings.
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D17816?vs=83361&id=83364
BRANCH
arcpatch-D
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20FreeBSDQt5.15/12/
Project:
kf5-qt5 FreeBSDQt5.15
Date of build:
Thu, 10 Sep 2020 10:04:36 +
Build duration:
2 min 38 sec and counting
JUnit Tests
Name
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20FreeBSDQt5.15/11/
Project:
kf5-qt5 FreeBSDQt5.15
Date of build:
Thu, 10 Sep 2020 10:01:14 +
Build duration:
3 min 16 sec and counting
JUnit Tests
Name
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20WindowsMSVCQt5.14/446/
Project:
kf5-qt5 WindowsMSVCQt5.14
Date of build:
Thu, 10 Sep 2020 09:16:35 +
Build duration:
16 min and counting
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20WindowsMSVCQt5.14/241/
Project:
kf5-qt5 WindowsMSVCQt5.14
Date of build:
Thu, 10 Sep 2020 09:16:11 +
Build duration:
14 min and counting
JUnit Tests
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks/job/krunner/job/kf5-qt5%20WindowsMSVCQt5.14/105/
Project:
kf5-qt5 WindowsMSVCQt5.14
Date of build:
Thu, 10 Sep 2020 09:16:08 +
Build duration:
11 min and counting
JUnit Tests
Name: pro
BUILD FAILURE
Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20WindowsMSVCQt5.14/240/
Project:
kf5-qt5 WindowsMSVCQt5.14
Date of build:
Thu, 10 Sep 2020 09:13:37 +
Build duration:
22 sec and counting
CONSOLE OUTPUT
BUILD FAILURE
Build URL
https://build.kde.org/job/Frameworks/job/krunner/job/kf5-qt5%20WindowsMSVCQt5.14/104/
Project:
kf5-qt5 WindowsMSVCQt5.14
Date of build:
Thu, 10 Sep 2020 09:13:38 +
Build duration:
27 sec and counting
CONSOLE OUTPUT
Started
BUILD FAILURE
Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20WindowsMSVCQt5.14/445/
Project:
kf5-qt5 WindowsMSVCQt5.14
Date of build:
Thu, 10 Sep 2020 09:13:35 +
Build duration:
18 sec and counting
CONSOLE OUTPUT
Started by
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20WindowsMSVCQt5.14/104/
Project:
kf5-qt5 WindowsMSVCQt5.14
Date of build:
Thu, 10 Sep 2020 07:58:35 +
Build duration:
2 min 45 sec and counting
JUnit Tests
12 matches
Mail list logo
