Kioslave repos

2014-04-07 Thread Alex Merry
Aleix wanted a separate thread for this, so here it is. The current runtime splitting plan says that ioslaves should be in three places: core ones (file, http, etc) in kio, other useful ones (archive, bookmarks, etc) in kioslaves, and curiosities (cgi, finger) in kioslave-extra. In my view, this

Re: Review Request 117313: Deprecate ThumbCreatorV2 and improve ThumbCreator apidox

2014-04-05 Thread Alex Merry
-runtime (where there is code that implements and makes use of these interfaces). Apidox builds and looks fine. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks

Re: Review Request 117313: Deprecate ThumbCreatorV2 and improve ThumbCreator apidox

2014-04-05 Thread Alex Merry
-runtime (where there is code that implements and makes use of these interfaces). Apidox builds and looks fine. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks

Re: Review Request 117317: Improve the KAbstractFileItemActionPlugin apidox

2014-04-05 Thread Alex Merry
/diff/ Testing --- Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: DrKonqi placement

2014-04-05 Thread Alex Merry
On 05/04/14 11:36, David Faure wrote: On Thursday 03 April 2014 22:36:04 Alex Merry wrote: On 02/04/14 18:07, Kevin Ottens wrote: KF5::WindowSystem That's only for KStartupInfo right? Pretty sure that doesn't work, either. QX11Info should probably get a startupId() method. That's vaguely

Re: Q: kconfig without kaboutdata behavior

2014-04-03 Thread Alex Merry
On 03/04/14 09:34, Harald Sitter wrote: ahoy, I just wanted to ask whether it is still mandatory to have a KAboutData instance set to have classes such as KConfigShared work in a convenient fashion (e.g. KConfigShared::openConfig() will open the applications config as long as

Re: Review Request 117304: Update comment about re-fetching clipboard data.

2014-04-03 Thread Alex Merry
clipboard data. The line should really be removed, but I don't have the time to do the necessary testing right now. Diffs (updated) - src/widgets/paste.cpp 1d1cafca2f494e44f9ba7bd279cefd7df813b9c0 Diff: https://git.reviewboard.kde.org/r/117304/diff/ Testing --- Thanks, Alex

Re: DrKonqi placement

2014-04-03 Thread Alex Merry
On 02/04/14 18:07, Kevin Ottens wrote: KF5::WindowSystem That's only for KStartupInfo right? Pretty sure that doesn't work, either. QX11Info should probably get a startupId() method. That's vaguely on my to-do list somewhere... Alex ___

Re: Review Request 117318: Move methods from KCompletionPrivate to KCompletionMatchesWrapper

2014-04-02 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117318/#review54851 --- Ship it! Ship It! - Alex Merry On April 1, 2014, 10:37

Review Request 117325: Improve the desktoptojson man page

2014-04-02 Thread Alex Merry
: kservice Description --- Improve the desktoptojson man page Diffs - docs/desktoptojson/man-desktoptojson.8.docbook 28f4307cd6347472b2c64b47303bb730d3deca78 Diff: https://git.reviewboard.kde.org/r/117325/diff/ Testing --- Built, visually inspected man page. Thanks, Alex Merry

Review Request 117328: Update the docbook

2014-04-02 Thread Alex Merry
--- Temporarily re-enabled building the docbook, and checked it still built. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 117330: Update documentation not found docbook

2014-04-02 Thread Alex Merry
it (tried `khelpcenter help:blah`, but that just displays the string There is no documentation available for /blah.). Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks

Re: Review Request 117325: Improve the desktoptojson man page

2014-04-02 Thread Alex Merry
://git.reviewboard.kde.org/r/117325/diff/ Testing --- Built, visually inspected man page. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 117271: KIconDialog: do not connect to a signal that does not exist

2014-04-01 Thread Alex Merry
, apparently because QIcon::fromTheme() is not working. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 117271: KIconDialog: do not connect to a signal that does not exist

2014-04-01 Thread Alex Merry
, apparently because QIcon::fromTheme() is not working. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 117275: Deprecate the catalog name stuff from KAboutData

2014-04-01 Thread Alex Merry
Diff: https://git.reviewboard.kde.org/r/117275/diff/ Testing --- Builds, tests pass. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 117277: KDatePicker: override changeEvent() instead of setEnabled()

2014-04-01 Thread Alex Merry
5f29110f2335bb110b3470007a59f9cb8b6bcfee Diff: https://git.reviewboard.kde.org/r/117277/diff/ Testing --- Builds. Tests pass. Played around with kdatepicktest; behaviour seems unchanged. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list

Review Request 117278: Remove KDE4 TODO

2014-04-01 Thread Alex Merry
4fa9699121c9056c58cd35894fd39eb755758a71 Diff: https://git.reviewboard.kde.org/r/117278/diff/ Testing --- Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 117274: Fix kf5kross i18n, and resurrect its KAboutData

2014-04-01 Thread Alex Merry
: https://git.reviewboard.kde.org/r/117274/#review54753 --- On April 1, 2014, 1:17 a.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 117275: Deprecate the catalog name stuff from KAboutData

2014-04-01 Thread Alex Merry
generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117275/#review54756 --- On April 1, 2014, 10:09 a.m., Alex Merry wrote: --- This is an automatically generated e

Review Request 117283: Fix i18n in kbuildsycoca5

2014-04-01 Thread Alex Merry
/diff/ Testing --- Builds and installs. Output of kbuildsycoca5 --help looks sensible. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 117278: Remove KDE4 TODO

2014-04-01 Thread Alex Merry
to QListWidget::scrollToItem(). Diffs - src/kfontchooser.cpp 4fa9699121c9056c58cd35894fd39eb755758a71 Diff: https://git.reviewboard.kde.org/r/117278/diff/ Testing --- Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks

Re: Review Request 117296: ecm_create_qm_from_po_files: do not replace - with _ in .po files

2014-04-01 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117296/#review54776 --- Ship it! Ship It! - Alex Merry On April 1, 2014, 1:16 p.m

Re: Review Request 116568: Fixes to PIC image format handler

2014-04-01 Thread Alex Merry
discarded. Review request for KDE Frameworks and Alex Merry. Repository: kimageformats Description --- Fixes to PIC image format handler Better error handling (returns false on error in read() and write()) and use the correct format if there is no alpha channel. Diffs - src

Re: Review Request 117268: Deprecate the RESTORE macro

2014-04-01 Thread Alex Merry
://git.reviewboard.kde.org/r/117268/diff/ Testing --- Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 117283: Fix i18n in kbuildsycoca5

2014-04-01 Thread Alex Merry
/kbuildsycoca.cpp a7799164b4a296ebff849c3d302c197e6aaca437 Diff: https://git.reviewboard.kde.org/r/117283/diff/ Testing --- Builds and installs. Output of kbuildsycoca5 --help looks sensible. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde

Re: Review Request 117274: Resurrect the KAboutData for the kross console

2014-04-01 Thread Alex Merry
5b28a3c210232d9682af43afec9401416b858ca0 src/console/main.cpp f81672e1c15681719943f64698ada19eeebc0bef Diff: https://git.reviewboard.kde.org/r/117274/diff/ Testing --- Ran kf5kross --help. Not investigated how to test the translation stuff. Thanks, Alex Merry

Review Request 117299: Resolve a KDE4 TODO in KDesktopFileActions

2014-04-01 Thread Alex Merry
true for around 15 years, as far as I can tell (git commit 7bda6331, svn revision 20718). Diffs - src/widgets/kdesktopfileactions.cpp 686f9f0592473d569d4acbf01a1c8da0ccaf6893 Diff: https://git.reviewboard.kde.org/r/117299/diff/ Testing --- Builds. Thanks, Alex Merry

Re: Review Request 117299: Resolve a KDE4 TODO in KDesktopFileActions

2014-04-01 Thread Alex Merry
://git.reviewboard.kde.org/r/117299/diff/ Testing --- Builds. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 117304: Remove clipboard data re-fetching line and its comment

2014-04-01 Thread Alex Merry
1d1cafca2f494e44f9ba7bd279cefd7df813b9c0 Diff: https://git.reviewboard.kde.org/r/117304/diff/ Testing --- Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks

Re: Review Request 117274: Fix i18n in kross

2014-04-01 Thread Alex Merry
Diff: https://git.reviewboard.kde.org/r/117274/diff/ Testing --- Ran kf5kross --help. Not investigated how to test the translation stuff. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org

Re: Review Request 117304: Remove clipboard data re-fetching line and its comment

2014-04-01 Thread Alex Merry
--- On April 1, 2014, 4:01 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117304

Re: Review Request 117304: Remove clipboard data re-fetching line and its comment

2014-04-01 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117304/#review54807 --- On April 1, 2014, 4:01 p.m., Alex Merry wrote

Review Request 117313: Deprecate ThumbCreatorV2 and improve ThumbCreator apidox

2014-04-01 Thread Alex Merry
and looks fine. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 117314: Improve kross console app i18n

2014-04-01 Thread Alex Merry
--- Builds, kf5kross --help looks sensible. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 117315: [kbuildsycoca] Tidy up command-line parsing and kaboutdata code

2014-04-01 Thread Alex Merry
/r/117315/diff/ Testing --- Builds, kbuildsycoca5 [--help|--author|--license] look sensible. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 117316: Bump source-incompatible KDE4 TODO to KF6

2014-04-01 Thread Alex Merry
--- Bump source-incompatible KDE4 TODO to KF6 Diffs - src/browserarguments.h 3d092262af9b374f6fffabbc32cb56d8b3302ab7 Diff: https://git.reviewboard.kde.org/r/117316/diff/ Testing --- Thanks, Alex Merry ___ Kde-frameworks-devel mailing

Review Request 117317: Improve the KAbstractFileItemActionPlugin apidox

2014-04-01 Thread Alex Merry
--- Improve the KAbstractFileItemActionPlugin apidox Diffs - src/widgets/kabstractfileitemactionplugin.h fe4c3d5b3ab49b35f3dd8627245cc8e4bb0fccd3 Diff: https://git.reviewboard.kde.org/r/117317/diff/ Testing --- Thanks, Alex Merry

Review Request 117320: Update the kbuildsycoca5 man page

2014-04-01 Thread Alex Merry
Description --- Update the kbuildsycoca5 man page Diffs - docs/kbuildsycoca5/man-kbuildsycoca5.8.docbook dc39386b36c102e8f043b9bd6e9b571c9460ef25 Diff: https://git.reviewboard.kde.org/r/117320/diff/ Testing --- Built and visually inspected the man page. Thanks, Alex

Re: Review Request 117314: Improve kross console app i18n

2014-04-01 Thread Alex Merry
aba23e2360f76b285db637215d9ac9a273828aa9 Diff: https://git.reviewboard.kde.org/r/117314/diff/ Testing --- Builds, kf5kross --help looks sensible. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman

Re: Review Request 117315: [kbuildsycoca] Tidy up command-line parsing and kaboutdata code

2014-04-01 Thread Alex Merry
/kbuildsycoca.cpp d6b643e7552b2240602696a92a9c85582450b9b9 Diff: https://git.reviewboard.kde.org/r/117315/diff/ Testing --- Builds, kbuildsycoca5 [--help|--author|--license] look sensible. Thanks, Alex Merry ___ Kde-frameworks-devel mailing

Re: Review Request 117316: Bump source-incompatible KDE4 TODO to KF6

2014-04-01 Thread Alex Merry
--- Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Translation support in Qt-translation-based frameworks

2014-03-31 Thread Alex Merry
On 31/03/14 15:30, Aurélien Gâteau wrote: Do not commit the po/ dir, it will be generated at release time from the kde translation infrastructure. Should go in .gitignore, yes? Alex ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org

Re: Review Request 117195: [kio] Replace COULD_NOT with CANNOT in the error code enum

2014-03-31 Thread Alex Merry
pass. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 117185: Remove KPluginLoader dependency on KService

2014-03-31 Thread Alex Merry
--- On March 30, 2014, 11:41 a.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117185

Re: Review Request 117185: Remove KPluginLoader dependency on KService

2014-03-31 Thread Alex Merry
, tests pass. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 117185: Remove KPluginLoader dependency on KService

2014-03-31 Thread Alex Merry
--- Builds, tests pass. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 117195: [kio] Replace COULD_NOT with CANNOT in the error code enum

2014-03-31 Thread Alex Merry
/tcpslavebase.cpp ea0434e19a7fb35cc708dece1ff904d6739aa4de src/core/slavebase.h 4726915da0757c64ab735f586142806891b517d1 src/widgets/accessmanagerreply_p.cpp 4322e0275f57f10aeba2ea8381f53d06f6b6fe25 Diff: https://git.reviewboard.kde.org/r/117195/diff/ Testing --- Builds, tests pass. Thanks, Alex

Re: Review Request 117195: [kio] Replace COULD_NOT with CANNOT in the error code enum

2014-03-31 Thread Alex Merry
/tcpslavebase.cpp ea0434e19a7fb35cc708dece1ff904d6739aa4de src/core/slavebase.h 4726915da0757c64ab735f586142806891b517d1 src/widgets/accessmanagerreply_p.cpp 4322e0275f57f10aeba2ea8381f53d06f6b6fe25 Diff: https://git.reviewboard.kde.org/r/117195/diff/ Testing --- Builds, tests pass. Thanks, Alex

Review Request 117268: Deprecate the RESTORE macro

2014-03-31 Thread Alex Merry
--- Deprecate the RESTORE macro RESTORE is just a non-typesafe version of kRestoreMainWindows(). Diffs - src/kmainwindow.h 37eed1a37902ce05c12b9288e275757de196639c Diff: https://git.reviewboard.kde.org/r/117268/diff/ Testing --- Thanks, Alex Merry

Re: Translation support in Qt-translation-based frameworks

2014-03-31 Thread Alex Merry
On 01/04/14 00:14, Albert Astals Cid wrote: El Dilluns, 31 de març de 2014, a les 23:46:40, Alex Merry va escriure: On 31/03/14 23:22, Albert Astals Cid wrote: El Dilluns, 31 de març de 2014, a les 15:38:39, Alex Merry va escriure: On 31/03/14 15:30, Aurélien Gâteau wrote: Do not commit

Review Request 117271: KIconDialog: do not connect to a signal that does not exist

2014-03-31 Thread Alex Merry
66432ba878a4133ea3210089d3fdfbaec145bf1b Diff: https://git.reviewboard.kde.org/r/117271/diff/ Testing --- Tested with the new kicondialogtest, and everything seems to be in order. The old kiconbuttontest is not working properly, apparently because QIcon::fromTheme() is not working. Thanks, Alex Merry

Review Request 117272: Use KIconDialog instead of running kdialog to choose icons

2014-03-31 Thread Alex Merry
: https://git.reviewboard.kde.org/r/117272/diff/ Testing --- Builds and tests pass. kwindowtest allows an icon to be selected when editing the toolbars, although that icon doesn't appear (probably because QIcon::fromTheme() isn't working properly for me). Thanks, Alex Merry

Review Request 117273: Fix i18n in ksendbugmail

2014-03-31 Thread Alex Merry
a3eaa393dcaa0d79c322488a1d46ed8e1fba9db8 Diff: https://git.reviewboard.kde.org/r/117273/diff/ Testing --- Builds. ksendbugmail --help seems to work with no translations installed; not figured out how to test the translations. Thanks, Alex Merry ___ Kde

Re: Review Request 117269: Use KEMailSettings, instead of parsing configurations directly

2014-03-31 Thread Alex Merry
/kbugreport.cpp bb37fdf45cf956d80ca351e57c1444d417439ec8 Diff: https://git.reviewboard.kde.org/r/117269/diff/ Testing --- Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde

Re: Review Request 117273: Fix i18n in ksendbugmail

2014-03-31 Thread Alex Merry
) - Alex --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117273/#review54733 --- On April 1, 2014, 12:48 a.m., Alex Merry wrote

Review Request 117274: Fix kf5kross i18n, and resurrect its KAboutData

2014-03-31 Thread Alex Merry
. Not investigated how to test the translation stuff. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 117272: Use KIconDialog instead of running kdialog to choose icons

2014-03-31 Thread Alex Merry
because QIcon::fromTheme() isn't working properly for me). Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 117273: Fix i18n in ksendbugmail

2014-03-31 Thread Alex Merry
to test the translations. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 117275: Deprecate the catalog name stuff from KAboutData

2014-03-31 Thread Alex Merry
ce64a13aaa89bb4bc077f05e5f8e175d6a441ead Diff: https://git.reviewboard.kde.org/r/117275/diff/ Testing --- Builds, tests pass. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde

Re: Moving KPlugionLoader|Factory to KCoreAddons?

2014-03-30 Thread Alex Merry
On 29/03/14 15:57, Alex Merry wrote: I just realised a flaw with this: KPluginLoader has a constructor that takes a KService argument. Which is annoying, because the only difference between KPluginLoader(service) and KPluginLoader(service.library()) is the error message you get

Review Request 117185: Remove KPluginLoader dependency on KService

2014-03-30 Thread Alex Merry
2b0afb81469f18f93ea43e6ac73df95a60cbd7f3 autotests/CMakeLists.txt dcc4a40bd81f7e17f10219649214a8c9aac5cc60 Diff: https://git.reviewboard.kde.org/r/117185/diff/ Testing --- Builds, tests pass. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list

Re: Review Request 117185: Remove KPluginLoader dependency on KService

2014-03-30 Thread Alex Merry
://git.reviewboard.kde.org/r/117185/diff/ Testing --- Builds, tests pass. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 117185: Remove KPluginLoader dependency on KService

2014-03-30 Thread Alex Merry
pass. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 117194: Remove weird comment

2014-03-30 Thread Alex Merry
like that... - Alex Merry On March 30, 2014, 10:05 p.m., Albert Astals Cid wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117194

Review Request 117195: [kio] Replace COULD_NOT with CANNOT in the error code enum

2014-03-30 Thread Alex Merry
/widgets/accessmanagerreply_p.cpp 4322e0275f57f10aeba2ea8381f53d06f6b6fe25 Diff: https://git.reviewboard.kde.org/r/117195/diff/ Testing --- Builds, tests pass. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel

Re: Review Request 117154: Simplify the plugin lookup code

2014-03-29 Thread Alex Merry
pass and generally seems to work on my Linux machine. Windows stuff completely untested. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Moving KPlugionLoader|Factory to KCoreAddons?

2014-03-29 Thread Alex Merry
On 29/03/14 00:38, Alex Merry wrote: While doing work on KService, I realised that KPluginLoader, KPluginFactory and KExportPlugin could all quite happily go in KCoreAddons, and it would be really nice to have them there (KPluginTrader would stay in KService, of course). I'm not sure

Re: Review Request 117052: Add ECMSetupQtTranslations

2014-03-28 Thread Alex Merry
On March 27, 2014, 8:31 p.m., Alex Merry wrote: modules/ECMSetupQtTranslations.cmake, lines 81-83 https://git.reviewboard.kde.org/r/117052/diff/2/?file=257836#file257836line81 FindGettext calls the target pofiles. Is it worth making this target qmfiles for consistency

Re: Review Request 117052: Add ECMSetupQtTranslations

2014-03-28 Thread Alex Merry
/ECMSetupQtTranslations.cmake https://git.reviewboard.kde.org/r/117052/#comment38078 likewise: _ecm_sqts prefix - Alex Merry On March 28, 2014, 9:45 a.m., Aurélien Gâteau wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Move KDED out of frameworks?

2014-03-28 Thread Alex Merry
On 27/03/14 22:25, Àlex Fiestas wrote: Hi there First of all sorry for sending this email so late in the release process, but today has been the first day in months that I have been able to work fully concentrated on Frameworks. KDED is a weird framework, while it is a solution it is

Re: Review Request 117137: Remove use of KPluginFactory::componentName()

2014-03-28 Thread Alex Merry
:-( Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 117137: Remove use of KPluginFactory::componentName()

2014-03-28 Thread Alex Merry
, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 117016: Allow overriding DrKonqi lookup directories by PATH

2014-03-28 Thread Alex Merry
On March 24, 2014, 3:41 p.m., Alex Merry wrote: The correct solution is to get drkonqi merged into kcrash (see http://community.kde.org/Frameworks/Epics/New_Runtime_Organization). Aleix Pol Gonzalez wrote: Agreed. If somebody has the time, it would be interesting to figure out

Re: Review Request 117052: Add ECMSetupQtTranslations

2014-03-28 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117052/#review54446 --- Ship it! Ship It! - Alex Merry On March 28, 2014, 1:46

Review Request 117137: Remove use of KPluginFactory::componentName()

2014-03-28 Thread Alex Merry
34e4a83325e52babae4d28691abaf90f3576f379 Diff: https://git.reviewboard.kde.org/r/117137/diff/ Testing --- KCMUtils now builds with https://git.reviewboard.kde.org/r/117074/ applied to kservice. No unit tests :-( Thanks, Alex Merry ___ Kde-frameworks

Re: Review Request 117074: KPluginFactory: remove argumented contructor and componentName()

2014-03-28 Thread Alex Merry
/plugin/kpluginfactory.cpp cf71906d47aba4decca7d261d84ca1cb67913e7e src/plugin/kpluginfactory_p.h 103ae5029e508e22c99a727ef5b7568269ba7580 Diff: https://git.reviewboard.kde.org/r/117074/diff/ Testing --- Builds, tests pass. Thanks, Alex Merry

Re: Review Request 117137: Remove use of KPluginFactory::componentName()

2014-03-28 Thread Alex Merry
--- On March 28, 2014, 2:49 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117137

Moving KPlugionLoader|Factory to KCoreAddons?

2014-03-28 Thread Alex Merry
While doing work on KService, I realised that KPluginLoader, KPluginFactory and KExportPlugin could all quite happily go in KCoreAddons, and it would be really nice to have them there (KPluginTrader would stay in KService, of course). I'm not sure of the BCness or SCness of this, though. I think

Review Request 117154: Simplify the plugin lookup code

2014-03-28 Thread Alex Merry
stuff completely untested. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 117052: Add ECMSetupQtTranslations

2014-03-27 Thread Alex Merry
On March 25, 2014, 2:33 p.m., Alex Merry wrote: The docs need cleaning up, but I'd like to concentrate on the API first. I'd rather this followed the convention of other file-generating macros in getting the user to provide a variable name to store the file(s) in, rather than

Review Request 117112: Make KPLuginLoader encapsulate QPluginLoader, rather than inheriting

2014-03-27 Thread Alex Merry
is tight before beta1. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 117102: Remove unused methods from KStartupInfo

2014-03-27 Thread Alex Merry
://git.reviewboard.kde.org/r/117102/#review54287 --- On March 26, 2014, 10:55 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 117114: Print module name for not found dependend component

2014-03-27 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117114/#review54323 --- Ship it! Oops! - Alex Merry On March 27, 2014, 1:46 p.m

Re: Review Request 116980: Update the kded5 man page

2014-03-27 Thread Alex Merry
--- Built, installed, visually inspected man page. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 116981: Use new terminology in webkit docs.

2014-03-27 Thread Alex Merry
7092ee3cabf3f5c5296f9e7db367bed53dbf45c1 src/kwebpage.h 15b3878e7096c254c81d360ab93ca8968d1048ee src/kwebpluginfactory.h 6dfe2d84f3ba9d2bbe95bb75bb228858f0745225 src/kwebview.h 1d8269f64c7ec265b315474ee46bb2ce4e047eb0 Diff: https://git.reviewboard.kde.org/r/116981/diff/ Testing --- Thanks, Alex Merry

Re: Review Request 116998: Remove reference to KDE4_BUILD_TESTS CMake option

2014-03-27 Thread Alex Merry
7b590b823b394ca340e14d6729b4229f49946852 Diff: https://git.reviewboard.kde.org/r/116998/diff/ Testing --- Builds, installs. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 117065: Remove KDE4 TODO

2014-03-27 Thread Alex Merry
6bbbefc47535f38611839464824c6b537426c496 Diff: https://git.reviewboard.kde.org/r/117065/diff/ Testing --- Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 117072: Add autotests for KPluginLoader and KPluginFactory

2014-03-27 Thread Alex Merry
/versionedplugin.h PRE-CREATION autotests/versionedplugin.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/117072/diff/ Testing --- Builds, tests pass. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org

Re: Review Request 117102: Remove unused methods from KStartupInfo

2014-03-27 Thread Alex Merry
: https://git.reviewboard.kde.org/r/117102/diff/ Testing --- Builds, kstartupinfo test passes. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Build failed in Jenkins: kprintutils_master_qt5 #28

2014-03-27 Thread Alex Merry
On 27/03/14 17:30, KDE CI System wrote: See http://build.kde.org/job/kprintutils_master_qt5/28/changes Changes: [agateau] Add src/Messages.sh What on earth does this still exist for? kprintutils is dead... John: did you file a sysadmin request to have the repo deleted? Alex

Re: Review Request 116984: Fix configuring of kde5init_win32lib_dummy.cpp.in

2014-03-27 Thread Alex Merry
. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 117052: Add ECMSetupQtTranslations

2014-03-27 Thread Alex Merry
. modules/ECMTrLoader.cpp.in https://git.reviewboard.kde.org/r/117052/#comment38014 QLatin1String() when you're using + - Alex Merry On March 27, 2014, 3:26 p.m., Aurélien Gâteau wrote: --- This is an automatically generated e-mail

Re: Review Request 117125: start_kdeinit: Use capabilities instead of SUID

2014-03-27 Thread Alex Merry
a CMake find module in extra-cmake-modules/docs? In particular, it should be called FindLibcap, include the license directly (rather than in a separate file) and use imported targets. - Alex Merry On March 27, 2014, 7:57 p.m., Hrvoje Senjan wrote

Re: Review Request 117052: Add ECMSetupQtTranslations

2014-03-27 Thread Alex Merry
On March 27, 2014, 8:31 p.m., Alex Merry wrote: modules/ECMTrLoader.cpp.in, line 19 https://git.reviewboard.kde.org/r/117052/diff/2/?file=257837#file257837line19 QLatin1String() when you're using + Aleix Pol Gonzalez wrote: Why? That doesn't make sense on my book. *Goes

Re: Review Request 117016: Allow overriding DrKonqi lookup directories by PATH

2014-03-27 Thread Alex Merry
On March 24, 2014, 3:41 p.m., Alex Merry wrote: The correct solution is to get drkonqi merged into kcrash (see http://community.kde.org/Frameworks/Epics/New_Runtime_Organization). Aleix Pol Gonzalez wrote: Agreed. If somebody has the time, it would be interesting to figure out

KLibrary to KDE4Support

2014-03-26 Thread Alex Merry
I'd like to move KLibrary to KDE4Support. From my investigations, I think this will break two things: KWin and Oxygen, both of which use KLibrary but do not link against KDE4Support. Those should be ported to QLibrary + KPluginLoader::findPlugin(), which I'll sort out today. Any objections?

Re: Review Request 117049: Ensure that pluginVersion gets resolved for multiple KPluginLoader

2014-03-26 Thread Alex Merry
to be integrated into the ones I merged last night? Sorry for the extra work. - Alex Merry On March 25, 2014, 9:18 a.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r

Re: Review Request 117040: Remove FIXME in KCompletion

2014-03-26 Thread Alex Merry
about, really. - Alex Merry On March 24, 2014, 11:23 p.m., David Gil Oliva wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117040

Re: Review Request 117058: plasma-nm CMake fixes

2014-03-26 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117058/#review54201 --- Ship it! Ship It! - Alex Merry On March 25, 2014, 3:48

<    1   2   3   4   5   6   7   8   9   10   >