Re: Review Request 116090: Use $ instead of get_target_property(... LOCATION)

2014-03-05 Thread Alex Merry
> On Feb. 27, 2014, 9:54 a.m., Alex Merry wrote: > > The problem with doing this in support code is that it is not strictly > > source compatible. An example this would break is if you want to embed the > > value of QT_QMAKE_EXECUTABLE into a C++ executable

Re: Review Request 116588: Improve the README

2014-03-04 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116588/#review51872 --- Ship it! Ship It! - Alex Merry On March 4, 2014, 12:32

Re: Review Request 116588: Improve the README

2014-03-04 Thread Alex Merry
> On March 4, 2014, 11:02 a.m., Alex Merry wrote: > > README.md, line 9 > > <https://git.reviewboard.kde.org/r/116588/diff/1/?file=251921#file251921line9> > > > > "allows to interact with" is bad grammar; "allows interaction with" &g

Re: Review Request 116568: Fixes to PIC image format handler

2014-03-04 Thread Alex Merry
ting up an emulator for a big-endian architecture. - Alex --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116568/#review51854 -------

Re: KUnitConversion Review

2014-03-04 Thread Alex Merry
On 02/03/14 18:58, Kevin Ottens wrote: > On Thursday 27 February 2014 17:15:56 John Layt wrote: >> I've done the first step, and I just need a volunteer to do the git magic >> required to: >> >> * Move kcurrencycode.h and kcurrencycode.cpp including history from >> "kunitconversion/src" to "kde4sup

Re: Review Request 116588: Improve the README

2014-03-04 Thread Alex Merry
588/#comment36905> "allows to interact with" is bad grammar; "allows interaction with" would work, and "allows to interact with" would be better. Maybe "clients" in place of ? - Alex Merry On

[kwallet] src/runtime/kwalletd: Change KWallet daemon files to LGPLv2+

2014-03-04 Thread Alex Merry
Git commit 0da2a5c94544ffc58230dd6dc2f12fe3fdcb98f7 by Alex Merry. Committed on 04/03/2014 at 10:55. Pushed by alexmerry into branch 'master'. Change KWallet daemon files to LGPLv2+ Permission granted by George Staikos on kde-frameworks-devel. CCMAIL: stai...@kde.org CCMAIL:

Re: Review Request 116103: Make KI18N a public dependency of KIO since public installed headers of KIO requires it

2014-03-04 Thread Alex Merry
> On March 4, 2014, 12:06 a.m., Aleix Pol Gonzalez wrote: > > Ok, I just realized this was being dealt with and I did a different patch: > > https://git.reviewboard.kde.org/r/116573/ > > > > I think that having UI strings on a header file is quite bad TBH, but since > > I see there's consensus

Re: Review Request 116087: KCrash: remove usage of strlcpy

2014-03-03 Thread Alex Merry
e startup id as a const char* somewhere and > > use strlcpy. > > > > Unless we can make sure that the call to startupId() will always just > > return an existing QByteArray - but looking at the code, this doesn't seem > > to be the case. > > Alex Merry

Re: Review Request 116087: KCrash: remove usage of strlcpy

2014-03-03 Thread Alex Merry
> On March 1, 2014, 4:17 p.m., David Faure wrote: > > Hmm, this might be equivalent, but all it means is that the orig code was > > wrong. > > > > We should not make any memory allocations within the crash handler. > > > > So we should instead store the startup id as a const char* somewhere an

Re: Review Request 116567: Implement fuzzy image matching in readtest

2014-03-03 Thread Alex Merry
still works. Most tests still pass; note that the non-alpha pic tests fail without https://git.reviewboard.kde.org/r/116568/diff/ as the wrong format (ARGB32 instead of RGB32) is constructed. This should make the xcf tests pass again on Jenkins. Thanks, Alex Merry

Re: Review Request 116568: Fixes to PIC image format handler

2014-03-03 Thread Alex Merry
Alex Merry. Changes --- Transfer copyright/license information properly from merged files. Repository: kimageformats Description --- Fixes to PIC image format handler Better error handling (returns false on error in read() and write()) and use the correct format if there is no

Re: Review Request 116566: Fix warnings while running kdeinit5

2014-03-03 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116566/#review51769 --- Ship it! Ship It! - Alex Merry On March 3, 2014, 12:58

Review Request 116568: Fixes to PIC image format handler

2014-03-03 Thread Alex Merry
/diff/ Testing --- Builds and tests pass, both with and without https://git.reviewboard.kde.org/r/116567/ applied. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde

Review Request 116567: Implement fuzzy image matching in readtest

2014-03-03 Thread Alex Merry
should make the xcf tests pass again on Jenkins. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: c++ plugins with Frameworks 5

2014-03-03 Thread Alex Merry
On 03/03/14 11:28, Aaron J. Seigo wrote: > hello, > > over the weekend i wrote up a small tool that does what is needed for > libsprinter, which is a Qt5 library (no frameworks deps), to harvest > translations from .desktop files into .json files for inclusion in its > plugins. > > one decisio

Re: Review Request 116532: Add imagedump: a utility to dump the raw data of a QImage

2014-03-02 Thread Alex Merry
in RGB32 format) All data dumps sanity-checked in Okteta. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 116080: find_dependency: Update to match CMake's version

2014-03-02 Thread Alex Merry
dency, rather than the one shipped with CMake 3.0). Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 116532: Add imagedump: a utility to dump the raw data of a QImage

2014-03-02 Thread Alex Merry
formats) imagedump something.xcf something.data (dumps data in ARGB32 format) imagedump something.png something.data (dumps data in ARGB32 format) imagedump -q RGB32 something.xcf something.data (dumps data in RGB32 format) All data dumps sanity-checked in Okteta. Thanks, Alex Merry

Re: Review Request 115959: Resurrect KConfigDialog::setHelp (used to come from KDialog). Move KHelpClient down from kxmlgui, for use in KConfigDialog.

2014-03-01 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115959/#review51426 --- Ship it! Ship It! - Alex Merry On Feb. 23, 2014, 11 a.m

Re: Review Request 115959: Resurrect KConfigDialog::setHelp (used to come from KDialog). Move KHelpClient down from kxmlgui, for use in KConfigDialog.

2014-03-01 Thread Alex Merry
> On March 1, 2014, 11:15 a.m., Alex Merry wrote: > > The implementation all looks fine. The only concern I have is that it's an > > odd location for it; I wouldn't expect to go looking for a method to invoke > > Help in KConfigWidgets. Although I'

Re: Review Request 116064: @deprecated docs for KUrl methods that duplicate QUrl methods

2014-03-01 Thread Alex Merry
with a note saying what QUrl method should be used instead. Diffs - src/kdecore/kurl.h 4ac893382c76def83f8e6e12698931df243085f9 Diff: https://git.reviewboard.kde.org/r/116064/diff/ Testing --- Thanks, Alex Merry ___ Kde-frameworks

Re: Review Request 115959: Resurrect KConfigDialog::setHelp (used to come from KDialog). Move KHelpClient down from kxmlgui, for use in KConfigDialog.

2014-03-01 Thread Alex Merry
rgument does, for apps that want to point to a website. - Alex Merry On Feb. 23, 2014, 11 a.m., David Faure wrote: > > --- > This is an automatically generated e-mail. To reply, visi

Re: Review Request 116064: @deprecated docs for KUrl methods that duplicate QUrl methods

2014-03-01 Thread Alex Merry
16064/diff/ Testing --- Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: KDNSSD merge

2014-03-01 Thread Alex Merry
On 01/03/14 09:57, David Faure wrote: > On Wednesday 26 February 2014 14:36:49 Nicolas Lécureuil wrote: >> as there is already a kdnssd tarball for kde 4, i think this would be safer >> to keep the -framework in the name. > > I can't see how the name of the kde-sc-4 tarballs matter? > > This is v

Re: KDNSSD merge

2014-03-01 Thread Alex Merry
On 01/03/14 09:55, David Faure wrote: > On Tuesday 25 February 2014 20:37:28 Alex Merry wrote: >> I've had a look at the kdnssd repositoy, and it contains two related >> bits of code: the zeroconf ioslave and a kded/KDirWatch module to notify >> KIO about changes to avail

Re: kprintutils - next steps

2014-02-28 Thread Alex Merry
On 27/02/14 13:02, Alex Merry wrote: > On 27/02/14 11:21, John Layt wrote: >> On 23 February 2014 20:02, John Layt wrote: >>> 2) Copy code from kprintutils to kde4support >>> - Do we bother to keep the history? >>> - Where do we put it? >> >> Alex

Re: Review Request 116103: Make KI18N a public dependency of KIO since public installed headers of KIO requires it

2014-02-28 Thread Alex Merry
> On Feb. 26, 2014, 9:57 p.m., Albert Astals Cid wrote: > > have you tried removing the include? > > Albert Astals Cid wrote: > Ignore me, there's i18n calls in there :D > > Alex Merry wrote: > However, I wonder if those calls should really be in the

Re: Review Request 116103: Make KI18N a public dependency of KIO since public installed headers of KIO requires it

2014-02-27 Thread Alex Merry
> On Feb. 26, 2014, 9:57 p.m., Albert Astals Cid wrote: > > have you tried removing the include? > > Albert Astals Cid wrote: > Ignore me, there's i18n calls in there :D > > Alex Merry wrote: > However, I wonder if those calls should really be in the

Re: Review Request 116012: Inline deprecated methods, and silence false positives in tests

2014-02-27 Thread Alex Merry
4a35879a15992d19378c7e9baa9b206e187713fd src/kfilterdev.cpp 60660a0c08922ee0f4ddaf4ad4d1adf0e7f1c5a3 Diff: https://git.reviewboard.kde.org/r/116012/diff/ Testing --- Builds, tests pass. No deprecation warnings (before there were two in the tests). Thanks, Alex Merry

Re: Review Request 116012: Inline deprecated methods, and silence false positives in tests

2014-02-27 Thread Alex Merry
4a35879a15992d19378c7e9baa9b206e187713fd src/kfilterdev.cpp 60660a0c08922ee0f4ddaf4ad4d1adf0e7f1c5a3 Diff: https://git.reviewboard.kde.org/r/116012/diff/ Testing --- Builds, tests pass. No deprecation warnings (before there were two in the tests). Thanks, Alex Merry

[solid] src/imports: Relicense solid "imports" files to LGPLv2.1+

2014-02-27 Thread Alex Merry
Git commit 5bebd4332ea137849f2060f12a684551dbc81dc6 by Alex Merry. Committed on 28/02/2014 at 00:41. Pushed by alexmerry into branch 'master'. Relicense solid "imports" files to LGPLv2.1+ Permission granted by Ivan Čukić. CCMAIL: ivan.cu...@kde.org CCMAIL: kde-licens...

Re: Review Request 115953: Clean up kdesu CMake files

2014-02-27 Thread Alex Merry
- CMakeLists.txt 15b01a0745206cbc761fd3572393ec56753ff2b6 KF5SuConfig.cmake.in 9c2f96e3712490c56fd697b862c5d6a39755402d Diff: https://git.reviewboard.kde.org/r/115953/diff/ Testing --- Configures, compiles, installs. Thanks, Alex Merry

Re: kprintutils - next steps

2014-02-27 Thread Alex Merry
On 27/02/14 11:21, John Layt wrote: > On 23 February 2014 20:02, John Layt wrote: >> 2) Copy code from kprintutils to kde4support >> - Do we bother to keep the history? >> - Where do we put it? > > Alex, if you have that git magic I'd appreciate your doing it, I have > no clue what to do :-) I'm

Re: [kde-doc-english] Core documentation repository

2014-02-27 Thread Alex Merry
On 26/02/14 23:45, T.C. Hollingsworth wrote: So, perhaps we need a kde-core-docs.git or something like that to house them in? And advise distros to make sure and add runtime Requires on it from kdoctools or whereever the help: kioslave is shipped? (Alternatively we could just

Re: qt5 polkit-qt-1 and kdesrc-build

2014-02-27 Thread Alex Merry
On 26/02/14 21:25, Milian Wolff wrote: > Hey all, > > I today sat down trying to finally get a KF5 & kdesrc-build setup done. After > lots of issues related to missing dependencies not listed (fixed now) on > techbase, I hit an issue with kauth, namely that it tried to build agains > tthe > _q

Re: Review Request 116098: Use KDEInstallDirs

2014-02-27 Thread Alex Merry
: KDEInstallDirs is really just one more file layout policy, like GNUInstallDirs. I think KDEInstallDirs makes more sense than GNUInstallDirs for Qt-based code in general, though. If you're going to use it, though, I suggest using it consistently (eg: for include files as well). - Alex Merry O

Re: Review Request 116090: Use $ instead of get_target_property(... LOCATION)

2014-02-27 Thread Alex Merry
;, which is obviously not what was wanted. - Alex Merry On Feb. 26, 2014, 5:03 p.m., Alexander Richardson wrote: > > --- > This is an automatically generated e-mail. To reply, visit: >

Re: Review Request 116087: KCrash: remove usage of strlcpy

2014-02-27 Thread Alex Merry
argv array itself, so should be fine. - Alex Merry On Feb. 26, 2014, 5 p.m., Alexander Richardson wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Review Request 116103: Make KI18N a public dependency of KIO since public installed headers of KIO requires it

2014-02-26 Thread Alex Merry
> On Feb. 26, 2014, 9:57 p.m., Albert Astals Cid wrote: > > have you tried removing the include? > > Albert Astals Cid wrote: > Ignore me, there's i18n calls in there :D However, I wonder if those calls should really be in the header. I have no idea what catalogue they will use at runtime

Review Request 116096: Re-enable autotests

2014-02-26 Thread Alex Merry
sting --- Tests build. 3 out of 4 pass. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: KItemModels, Solid & KJS licenses

2014-02-26 Thread Alex Merry
On 20/02/14 11:41, Alex Merry wrote: >> [1] https://build.opensuse.org/request/show/223061 > > KItemModels > > kcheckableproxymodel.(cpp|h) is Stephen Kelly (and, for safety, David > Faure). Changed. > modeltest.(cpp|h) were taken from Qt Concurrent, and subsequent

Re: Review Request 116079: Be more explicit with QFile include

2014-02-26 Thread Alex Merry
framework policies, I > > think. > > Alex Merry wrote: > Yeah, the conclusion was that using module names in includes caused more > trouble than it was worth. > > We're generally assuming that downstreams will use either qmake or CMake; > this sh

Re: Review Request 116079: Be more explicit with QFile include

2014-02-26 Thread Alex Merry
> On Feb. 26, 2014, 3:36 p.m., Aurélien Gâteau wrote: > > My memory may be failing me, but I think it was actually decided to go the > > other way around for Qt5 includes: not prepending the module dir. Can > > anyone else confirm? This should be mentioned in the framework policies, I > > thin

Re: KDNSSD merge

2014-02-26 Thread Alex Merry
On 26/02/14 13:36, Nicolas Lécureuil wrote: > Le mercredi 26 février 2014 11:54:16 Alex Merry a écrit : >> On 26/02/14 10:01, Alex Merry wrote: >>> Actually, having slept on it, my suggestion is: >>> >>> - rename kdnssd to zeroconf-ioslave >>> - rena

Re: Review Request 116080: find_dependency: Update to match CMake's version

2014-02-26 Thread Alex Merry
e 3.0). Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: KDNSSD merge

2014-02-26 Thread Alex Merry
On 26/02/14 10:01, Alex Merry wrote: > Actually, having slept on it, my suggestion is: > > - rename kdnssd to zeroconf-ioslave > - rename kdnssd-framework to kdnssd > - merge the frameworks branch of zeroconf-ioslave into kio I don't think the last part is necessarily a block

Review Request 116080: find_dependency: Update to match CMake's version

2014-02-26 Thread Alex Merry
cmake ee6bfd6f7e79a9f842ad6d34931a9273c2ee3c4f Diff: https://git.reviewboard.kde.org/r/116080/diff/ Testing --- None yet, but I'll do a rebuild of the frameworks before I commit. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://ma

Re: Review Request 116056: Port to Qt5 and Kf5 of dnssd ioslave and kded module

2014-02-26 Thread Alex Merry
frameworks to resolve If you want more pointers, I and other frameworks folks are usually hanging around on #kde-devel on irc, and there's the kde-frameworks-devel email list. - Alex Merry On Feb. 25, 2014, 8:02 p.m., Matthieu Gallien wrote: > >

Re: Review Request 116064: @deprecated docs for KUrl methods that duplicate QUrl methods

2014-02-26 Thread Alex Merry
, visit: https://git.reviewboard.kde.org/r/116064/#review50906 ------- On Feb. 25, 2014, 11:03 p.m., Alex Merry wrote: > > --- > This is an automatically genera

Re: KDNSSD merge

2014-02-26 Thread Alex Merry
On 26/02/14 07:09, Kevin Ottens wrote: > On Tuesday 25 February 2014 20:37:28 Alex Merry wrote: >> I've had a look at the kdnssd repositoy, and it contains two related >> bits of code: the zeroconf ioslave and a kded/KDirWatch module to notify >> KIO about cha

QUrl -> KUrl porting script

2014-02-25 Thread Alex Merry
Hi David, The convert-kurl.pl script doesn't appear to actually convert any KUrl usages or API, as the comments at the top (and the name) suggest it should. In fact, the git history suggests it never did. Is there actually a script around to do this? Alex ___

Review Request 116064: @deprecated docs for KUrl methods that duplicate QUrl methods

2014-02-25 Thread Alex Merry
4ac893382c76def83f8e6e12698931df243085f9 Diff: https://git.reviewboard.kde.org/r/116064/diff/ Testing --- Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks

Re: Review Request 115897: Remove FindDocBook*.cmake

2014-02-25 Thread Alex Merry
dules/FindDocBookXSL.cmake a7320aed66b72c92f0286658e38b7fc32266790c Diff: https://git.reviewboard.kde.org/r/115897/diff/ Testing --- Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/lis

KDNSSD merge

2014-02-25 Thread Alex Merry
I've had a look at the kdnssd repositoy, and it contains two related bits of code: the zeroconf ioslave and a kded/KDirWatch module to notify KIO about changes to available services. These two obviously belong together; the question is where? They can go in kdnssd-framework, making it depend on K

Re: Review Request 116025: Add documentation about writing find modules

2014-02-25 Thread Alex Merry
es.md PRE-CREATION Diff: https://git.reviewboard.kde.org/r/116025/diff/ Testing --- Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 116025: Add documentation about writing find modules

2014-02-25 Thread Alex Merry
gt; > they have the library in a non-predicted location. Well, I meant the reason we set Foo_LIBRARY and then just set Foo_LIBRARIES to that same value, rather than using Foo_LIBRARIES directly. But I guess I should talk about making the cache entries the user has to set consis

Re: KDocTools history import

2014-02-25 Thread Alex Merry
On 25/02/14 11:48, Alex Merry wrote: > On 24/02/14 22:16, Luigi Toscano wrote: >> Alex Merry wrote: >>> I screwed up the history import of the FindDocBook*.cmake files from >>> e-c-m into KDocTools, so Luigi asked me to do it again. This involves >>> removing

Re: Review Request 116046: Improve FindXCB

2014-02-25 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116046/#review50822 --- Ship it! Ship It! - Alex Merry On Feb. 25, 2014, 1:45 p.m

Re: Review Request 116018: Add a FindWayland module

2014-02-25 Thread Alex Merry
> On Feb. 25, 2014, 12:54 p.m., Alex Merry wrote: > > find-modules/FindWayland.cmake, line 192 > > <https://git.reviewboard.kde.org/r/116018/diff/4/?file=246029#file246029line192> > > > > You know this is going be printed as something like > >

Re: Review Request 116018: Add a FindWayland module

2014-02-25 Thread Alex Merry
nd, a display server protocol designed to replace X11", or something like that. - Alex Merry On Feb. 25, 2014, 12:46 p.m., Martin Gräßlin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > ht

Re: Review Request 116014: Add a FindEgl module

2014-02-25 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116014/#review50811 --- Ship it! Ship It! - Alex Merry On Feb. 25, 2014, 12:42

Re: Review Request 116026: Remove the WebP format

2014-02-25 Thread Alex Merry
p.xml 68ddbbf334031ea8d023b16a4904f07b8cc8d0ba Diff: https://git.reviewboard.kde.org/r/116026/diff/ Testing --- Compiles, installs, tests pass. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/ma

Re: Review Request 116014: Add a FindEgl module

2014-02-25 Thread Alex Merry
org/r/116014/#comment35678> Caps find-modules/FindEgl.cmake <https://git.reviewboard.kde.org/r/116014/#comment35679> Caps find-modules/FindEgl.cmake <https://git.reviewboard.kde.org/r/116014/#comment35680> Caps - Alex Merry On Feb. 25, 2014, 12:02 p.m., Ma

Re: Review Request 116014: Add a FindEgl module

2014-02-25 Thread Alex Merry
> On Feb. 25, 2014, 11:46 a.m., Alex Merry wrote: > > Generally looks good, but I'm wondering about the WIN32 clause. EGL is > > really just an API, right? What we're really searching for is the Mesa > > implementation. I guess that other pl

Re: KDocTools history import

2014-02-25 Thread Alex Merry
On 24/02/14 22:16, Luigi Toscano wrote: > Alex Merry wrote: >> I screwed up the history import of the FindDocBook*.cmake files from >> e-c-m into KDocTools, so Luigi asked me to do it again. This involves >> removing those files, then merging in a more sensible history (th

Re: Review Request 116014: Add a FindEgl module

2014-02-25 Thread Alex Merry
message on WIN32 about how we're not looking for anything. Some of the stuff should then go outside the WIN32 clause, like find_package_handle_standard_args and set_package_properties. Also: what about APPLE? Does that use Mesa? Also: capitalisation. Shouldn't it be EGL, rather tha

Re: Review Request 116018: Add a FindWayland module

2014-02-25 Thread Alex Merry
ealt with by find_package_handle_standard_args (the last call, with HANDLE_COMPONENTS) anyway. - Alex Merry On Feb. 25, 2014, 7:46 a.m., Martin Gräßlin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.revi

Re: Review Request 116025: Add documentation about writing find modules

2014-02-25 Thread Alex Merry
85b97b7fa003282e1eeb1113c4668a9b73e3f731 docs/writing-find-modules.md PRE-CREATION Diff: https://git.reviewboard.kde.org/r/116025/diff/ Testing --- Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde

Re: Review Request 116025: Add documentation about writing find modules

2014-02-25 Thread Alex Merry
iewboard.kde.org/r/116025/#review50781 --- On Feb. 24, 2014, 5:02 p.m., Alex Merry wrote: > > --- > This is an automatically generated e-mail. To reply, vi

Review Request 116026: Remove the WebP format

2014-02-24 Thread Alex Merry
sting --- Compiles, installs, tests pass. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115913: Rename webp.xml to kf5-imagesformats-webp.xml on installation

2014-02-24 Thread Alex Merry
clashes with mime packages from other software). Diffs - src/imageformats/CMakeLists.txt e2242a6bc84c9fef10f7a06200daeac5e990e6c6 Diff: https://git.reviewboard.kde.org/r/115913/diff/ Testing --- Installs with correct name. Mime database properly updated. Thanks, Alex Merry

Review Request 116025: Add documentation about writing find modules

2014-02-24 Thread Alex Merry
, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 116018: Add a FindWayland module

2014-02-24 Thread Alex Merry
> On Feb. 24, 2014, 2:55 p.m., Alex Merry wrote: > > Same comments as for FindEGL.cmake: > > - what projects are using it? I guess KWin is one; any others? > > - it needs to set the DESCRIPTION and URL package properties (from > > FeatureSummary) > > - I&

Re: Review Request 116014: Add a FindEgl module

2014-02-24 Thread Alex Merry
> On Feb. 24, 2014, 2:51 p.m., Alex Merry wrote: > > Three things: > > - what projects are using it? I guess KWin is one; any others? > > - it needs to set the DESCRIPTION and URL package properties (from > > FeatureSummary) > > - I've been aiming to creat

extra-cmake-modules maintainership

2014-02-24 Thread Alex Merry
Alex, I seem to have ended up becoming the de facto extra-cmake-modules maintainer. Kevin said that you might interested in taking up the reins again at some point in the future, so I thought I'd check whether you were happy with me taking on the role officially, at least until you feel you have

KDocTools history import

2014-02-24 Thread Alex Merry
I screwed up the history import of the FindDocBook*.cmake files from e-c-m into KDocTools, so Luigi asked me to do it again. This involves removing those files, then merging in a more sensible history (that isn't curtailed like the other one was). This can be found at g...@git.kde.org:clones/kdoc

Re: Review Request 116018: Add a FindWayland module

2014-02-24 Thread Alex Merry
ageformats for better examples). - Alex Merry On Feb. 24, 2014, 1:52 p.m., Martin Gräßlin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.review

Re: Review Request 116014: Add a FindEgl module

2014-02-24 Thread Alex Merry
r examples). - Alex Merry On Feb. 24, 2014, 1:08 p.m., Martin Gräßlin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.review

Re: kprintutils - next steps

2014-02-24 Thread Alex Merry
On 23/02/14 19:02, John Layt wrote: > 2) Copy code from kprintutils to kde4support > - Do we bother to keep the history? > - Where do we put it? I would be inclined to keep the history. I can dig up the magic to do that if you like. Alex ___ Kde-frame

Review Request 116012: Inline deprecated methods, and silence false positives in tests

2014-02-24 Thread Alex Merry
://git.reviewboard.kde.org/r/116012/diff/ Testing --- Builds, tests pass. No deprecation warnings (before there were two in the tests). Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman

Re: Review Request 115956: More generic (renamed) DocBookXML4.cmake, few fixes

2014-02-23 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115956/#review50594 --- Ship it! Ship It! - Alex Merry On Feb. 23, 2014, 3:02 p.m

Re: Review Request 115897: Remove FindDocBook*.cmake

2014-02-23 Thread Alex Merry
> On Feb. 22, 2014, 6:29 p.m., Luigi Toscano wrote: > > As this was already committed, can this RR be closed? > > Alex Merry wrote: > Actually, I never committed this one, since I never got a ship it. I > added the files to kdoctools, but never removed them from e-c-

Re: Review Request 115956: More generic (renamed) KDocBookXML4.cmake

2014-02-23 Thread Alex Merry
org/r/115956/#comment35589> You'll need to include the FeatureSummary module for this. cmake/FindDocBookXSL.cmake <https://git.reviewboard.kde.org/r/115956/#comment35590> Likewise, FeatureSummary is needed - Alex Merry On Feb. 23, 2014, 2:34 p.m., Lu

Re: Review Request 115504: Only perform tests for plugins that are built

2014-02-23 Thread Alex Merry
marked as submitted. Review request for KDE Frameworks and Alex Merry. Repository: kimageformats Description --- Only perform tests for plugins that are built This both excludes the autotests and tests subdirs if the user sets BUILD_TESTING off, and makes sure we do not run tests for

Re: Review Request 115028: Inline deprecated KUser::fullName() method

2014-02-23 Thread Alex Merry
/115028/diff/ Testing --- configures, compiles, tests pass (well, except KDirWatch-FAM, which has never passed for me). Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde

Re: Review Request 115897: Remove FindDocBook*.cmake

2014-02-23 Thread Alex Merry
- Alex --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115897/#review50553 --- On Feb. 19, 2014, 11:45 p.m., Alex Me

Re: Review Request 115956: More generic (renamed) KDocBookXML4.cmake

2014-02-23 Thread Alex Merry
- ie: pass a version to find_package(), and it will find that DTD version, otherwise it will find 4.2. - Alex Merry On Feb. 22, 2014, 6:19 p.m., Luigi Toscano wrote: > > --- > This is an automatically generated e-mail. To

Re: Review Request 115876: More generic DocBookXML -> DocBookXML4

2014-02-22 Thread Alex Merry
> On Feb. 21, 2014, 7:47 p.m., Luigi Toscano wrote: > > The files have been moved to kdoctools, should I open a new review against > > the kdoctools component or can I get a shipit here? :) > > Alex Merry wrote: > I thought I'd already made this reply, bu

Re: Review Request 115876: More generic DocBookXML -> DocBookXML4

2014-02-22 Thread Alex Merry
> On Feb. 21, 2014, 7:47 p.m., Luigi Toscano wrote: > > The files have been moved to kdoctools, should I open a new review against > > the kdoctools component or can I get a shipit here? :) > > Alex Merry wrote: > I thought I'd already made this reply, bu

Review Request 115953: Clean up kdesu CMake files

2014-02-22 Thread Alex Merry
9c2f96e3712490c56fd697b862c5d6a39755402d Diff: https://git.reviewboard.kde.org/r/115953/diff/ Testing --- Configures, compiles, installs. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman

Re: Review Request 115876: More generic DocBookXML -> DocBookXML4

2014-02-22 Thread Alex Merry
> On Feb. 21, 2014, 7:47 p.m., Luigi Toscano wrote: > > The files have been moved to kdoctools, should I open a new review against > > the kdoctools component or can I get a shipit here? :) I thought I'd already made this reply, but let's try again... (maybe I did it on another RR?) I would r

Re: KItemModels, Solid & KJS licenses

2014-02-22 Thread Alex Merry
On 20/02/14 16:00, šumski wrote: > On Thursday 20 of February 2014 11:41:48 Alex Merry wrote: > ... >> KItemModels >> >> kcheckableproxymodel.(cpp|h) is Stephen Kelly (and, for safety, David >> Faure). >> >> modeltest.(cpp|h) were taken from Qt Concurren

Re: Review Request 115028: Inline deprecated KUser::fullName() method

2014-02-22 Thread Alex Merry
://git.reviewboard.kde.org/r/115028/diff/ Testing --- configures, compiles, tests pass (well, except KDirWatch-FAM, which has never passed for me). Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https

Re: configuration file found with version 4.96.0 but version 5.2 is required by the KF5 buld

2014-02-22 Thread Alex Merry
s a bug in CMake. I've posted a patch to the cmake-developers list. You can wait for that to be applied, apply it yourself (attached), or use an older version of CMake (anything from the 2.8.12 series is fine). Alex >From d9da7a712d331e647d94fc12162e2c4df29ca7eb Mon Sep 17 00:00:00 2001 F

Re: Review Request 115485: Porting KTranscript from KJS to QtScript

2014-02-22 Thread Alex Merry
> On Feb. 22, 2014, 1:35 p.m., Chusslove Illich wrote: > > I tried to run a standalone non-GUI program using ki18n: > > > > #include > > #include > > > > int main (int argc, char *argv[]) > > { > > setlocale (LC_ALL, ""); > > KLocalizedString::setApplicationDomain("test-ki

Re: configuration file found with version 4.96.0 but version 5.2 is required by the KF5 buld

2014-02-22 Thread Alex Merry
On 22/02/14 11:26, Alex Merry wrote: > On 21/02/14 16:01, Shivam Makkar wrote: >> /CMake Error at >> /home/amourphious/kf5/inst/share/cmake-3.0/Modules/CMakeFindDependencyMacro.cmake:52 >> (find_package):/ >> / Could not find a configuration file for package &qu

Re: configuration file found with version 4.96.0 but version 5.2 is required by the KF5 buld

2014-02-22 Thread Alex Merry
On 21/02/14 16:01, Shivam Makkar wrote: > /CMake Error at > /home/amourphious/kf5/inst/share/cmake-3.0/Modules/CMakeFindDependencyMacro.cmake:52 > (find_package):/ > / Could not find a configuration file for package "KF5Pty" that is > compatible/ > / with requested version "5.2"./ Huh. I have n

Re: WebP image plugin

2014-02-22 Thread Alex Merry
On 22/02/14 09:11, David Faure wrote: > On Friday 21 February 2014 16:33:29 Hrvoje Senjan wrote: >>> On Feb. 20, 2014, 12:56 p.m., Commit Hook wrote: >>>> This review has been submitted with commit >>>> 4fbbc75429597dc545ae8af24e870d9bac5f2f2a by Alex Merry t

Re: Review Request 115207: Improve integration QCommandLineParser <-> KAboutData

2014-02-21 Thread Alex Merry
/lib/kaboutdata.cpp <https://git.reviewboard.kde.org/r/115207/#comment35499> No point changing this - Alex Merry On Feb. 21, 2014, 12:26 p.m., Aleix Pol Gonzalez wrote: > > --- > This is an automatically generated e-mail. To reply, v

<    5   6   7   8   9   10   11   12   13   14   >