Re: Extending the license policy to include ODbL-1.0

Thank you Volker! On Thu, Sep 23, 2021 at 6:01 PM Volker Krause wrote: > > done > > On Mittwoch, 22. September 2021 23:20:56 CEST Alexander Potashev wrote: > > Thanks! > > > > Could you please update the changelog section > > https://community.kde.org

Re: Extending the license policy to include ODbL-1.0

v1.0]'''. > > > > > > What do you think? > > > > Regards, > > Volker > > > > [1] https://invent.kde.org/frameworks/ki18n/-/merge_requests/19 > > [2] https://spdx.org/licenses/ODbL-1.0.html > > [3] https://invent.kde.org/pim/kitinerary/-/blob/master/src/lib/knowledgedb/ > > timezonedb_data.cpp > > [4] https://invent.kde.org/libraries/kpublictransport/-/blob/master/src/lib/ > > knowledgedb/linemetadata_data.cpp > -- Alexander Potashev

Re: Information regarding upcoming Gitlab Migration

On Fri, May 1, 2020 at 10:14 PM Ben Cooksley wrote: > On Sat, May 2, 2020 at 6:17 AM Alexander Potashev > wrote: > > I have a similar use case. Sometimes I need to share a URL to a > > project. For this purpose I used to share e.g. > > https://cgit.kde.org/releaseme.git

Re: Information regarding upcoming Gitlab Migration

the project moves to another group, for example https://invent.kde.org/unmaintained/knetwalk -- Alexander Potashev

D26168: i18n: Split translations for strings "Translation"

This revision was automatically updated to reflect the committed changes. Closed by commit R263:cfa4f04d4303: i18n: Split translations for strings "Translation" (authored by aspotashev). REPOSITORY R263 KXmlGui CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26168?vs=72025&id=72787 R

D26170: i18n: Add more semantic context strings

This revision was automatically updated to reflect the committed changes. Closed by commit R263:b834a855bf29: i18n: Add more semantic context strings (authored by aspotashev). REPOSITORY R263 KXmlGui CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26170?vs=72028&id=72788 REVISION DET

D26168: i18n: Split translations for strings "Translation"

aspotashev added a comment. In D26168#581665 , @kossebau wrote: > Seems you went fully "at it", good work :) > > "after string freeze" meant "after relase tagging for string freeze reasons" , right? ;) Yes, of course. REPOSITORY R2

D26168: i18n: Split translations for strings "Translation"

aspotashev added a comment. will try to push around January 5, 2020 after string freeze REPOSITORY R263 KXmlGui BRANCH i18n-split REVISION DETAIL https://phabricator.kde.org/D26168 To: aspotashev, kossebau Cc: kossebau, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26170: i18n: Add more semantic context strings

aspotashev added a comment. will try to push around January 5, 2020 after string freeze REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D26170 To: aspotashev Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26168: i18n: Split translations for strings "Translation"

aspotashev added a comment. In D26168#581637 , @kossebau wrote: > Looks good to me for what I know as programmer, but none-translator :) > While at it, for consistency the other tab titles could also get a "@title:tab" UI marker context?

D26170: i18n: Add more semantic context strings

aspotashev created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. aspotashev requested review of this revision. TEST PLAN it compiles REPOSITORY R263 KXmlGui BRANCH i18n-more-msgctxt REVISION DETAIL https://phabricator.kde.org/D26170

D26168: i18n: Split translations for strings "Translation"

aspotashev added a subscriber: kossebau. REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D26168 To: aspotashev Cc: kossebau, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26168: i18n: Split translations for strings "Translation"

aspotashev created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. aspotashev requested review of this revision. TEST PLAN it compiles REPOSITORY R263 KXmlGui BRANCH i18n-split REVISION DETAIL https://phabricator.kde.org/D26168 AFFECT

D25720: Fix shortcut conflict between Cut and Delete File

aspotashev added a comment. In D25720#572291 , @ngraham wrote: > Though Dolphin seems to have some kind of local hack to make Shift+delete work for file deletion. But it doesn't work for Cut. It's all pretty messy. I don't know the intern

D25720: Fix shortcut conflict between Cut and Delete File

aspotashev added a comment. What are the applications where both actions are used and thus one may notice this conflict? REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D25720 To: ngraham, #frameworks, cfeck Cc: aspotashev, bcooksley, davidedmundson, aacid, apol, kde

D25638: autotests: Find perl executable on all platforms

This revision was automatically updated to reflect the committed changes. Closed by commit R172:accdbdd65ee0: autotests: Find perl executable on all platforms (authored by aspotashev). REPOSITORY R172 KCalendar Core CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25638?vs=70636&id=706

D25638: autotests: Find perl executable on all platforms

aspotashev added inline comments. INLINE COMMENTS > apol wrote in CMakeLists.txt:93 > maybe it would make sense to check for BSD instead? > I don't know much about BSD, but I'd expect the shebang to work there as well. I think it's better to minimize platform-specific if-endifs and make CMake co

D25638: autotests: Find perl executable on all platforms

aspotashev added a reviewer: Frameworks. aspotashev added a project: Frameworks. aspotashev added a subscriber: Frameworks. REPOSITORY R172 KCalendar Core REVISION DETAIL https://phabricator.kde.org/D25638 To: aspotashev, #frameworks Cc: #frameworks, kde-pim, bcooksley, LeGast00n, fbampalouk

Re: KDE CI: Frameworks » kcalendarcore » kf5-qt5 FreeBSDQt5.13 - Build # 29 - Still Unstable!

ecursOn_RFC2445_RRULETest20.ics* > > > * - Failed: projectroot.autotests.RecursOn_RFC2445_RRULETest21.ics* > > > * - Failed: projectroot.autotests.RecursOn_RFC2445_RRULETest22.ics* > > > * - Failed: projectroot.autotests.RecursOn_RFC2445_RRULETest23.ics* > > > * - Failed: projectroot.autotests.RecursOn_RFC2445_RRULETest24.ics* > > > * - Failed: projectroot.autotests.RecursOn_RFC2445_RRULETest25.ics* > > > * - Failed: projectroot.autotests.RecursOn_RFC2445_RRULETest26.ics* > > > * - Failed: projectroot.autotests.RecursOn_RFC2445_RRULETest27.ics* > > > * - Failed: projectroot.autotests.RecursOn_RFC2445_RRULETest28.ics* > > > * - Failed: projectroot.autotests.RecursOn_RFC2445_RRULETest29.ics* > > > * - Failed: projectroot.autotests.RecursOn_RFC2445_RRULETest30.ics* > > > * - Failed: projectroot.autotests.RecursOn_RFC2445_RRULETest31.ics* > > > * - Failed: projectroot.autotests.RecursOn_RFC2445_RRULETest32.ics* > > > * - Failed: projectroot.autotests.RecursOn_RFC2445_RRULETest33.ics* > > > * - Failed: projectroot.autotests.RecursOn_RFC2445_RRULETest34.ics* > > > * - Failed: projectroot.autotests.RecursOn_RFC2445_RRULETest35.ics* > > > * - Failed: projectroot.autotests.RecursOn_RFC2445_RRULETest36.ics* > > > * - Failed: projectroot.autotests.RecursOn_RFC2445_RRULETest36U.ics* > > > * - Failed: projectroot.autotests.RecursOn_RFC2445_RRULETest37.ics* > > > * - Failed: projectroot.autotests.RecursOn_RFC2445_RRULETest38.ics* > > > * - Failed: projectroot.autotests.RecursOn_RFC2445_RRULETest39.ics* > > > * - Failed: projectroot.autotests.RecursOn_RFC2445_RRULETest40.ics* > > > * - Failed: projectroot.autotests.RecursOn_RFC2445_RRULETest41.ics* > > > * - Failed: projectroot.autotests.RecursOn_Until_TestCase02.ics* > > > * - Failed: projectroot.autotests.RecursOn_Until_TestCase03.ics* > > > * - Failed: projectroot.autotests.RecursOn_Until_TestCase04.ics* > > > * - Failed: projectroot.autotests.RecursOn_Until_TestCase05.ics* > > > * - Failed: projectroot.autotests.RecursOn_Until_TestCase06.ics* > > > * - Failed: projectroot.autotests.RecursOn_anniversary_4.6.1.ics* > > > * - Failed: projectroot.autotests.RecursOn_daily.ics* > > > * - Failed: projectroot.autotests.RecursOn_exdate.ics* > > > * - Failed: projectroot.autotests.RecursOn_hourly.ics* > > > * - Failed: projectroot.autotests.RecursOn_lastworkday.ics* > > > * - Failed: projectroot.autotests.RecursOn_monthly.ics* > > > * - Failed: projectroot.autotests.RecursOn_rdate.ics* > > > * - Failed: projectroot.autotests.RecursOn_test1.ics* > > > * - Failed: projectroot.autotests.RecursOn_weekly.ics* > > > * - Failed: projectroot.autotests.RecursOn_yearly.ics* > > > * - Failed: projectroot.autotests.VCalIn_KOrganizer_vCalTestCase01.vcs* > > > * - Failed: projectroot.autotests.VCalIn_KOrganizer_vCalTestCase02.vcs* > > > * - Failed: projectroot.autotests.VCalIn_KOrganizer_vCalTestCase03.vcs* > > > * - Failed: projectroot.autotests.VCalIn_KOrganizer_vCalTestCase04.vcs* > > > * - Failed: projectroot.autotests.VCalIn_KOrganizer_vCalTestCase05.vcs* > > > * - Failed: projectroot.autotests.VCalIn_KOrganizer_vCalTestCase06.vcs* > > > * - Failed: projectroot.autotests.VCalIn_KOrganizer_vCalTestCase07.vcs* > > > * - Failed: projectroot.autotests.VCalIn_KOrganizer_vCalTestCase08.vcs* > > > * - Failed: projectroot.autotests.VCalIn_KOrganizer_vCalTestCase09.vcs* > > > * - Failed: projectroot.autotests.VCalIn_KOrganizer_vCalTestCase10.vcs* > > > * - Failed: projectroot.autotests.VCalIn_KOrganizer_vCalTestCase11.vcs* > > > * - Failed: projectroot.autotests.VCalIn_KOrganizer_vCalTestCase12.vcs* > > > * - Failed: projectroot.autotests.VCalIn_KOrganizer_vCalTestCase13.vcs* > > > * - Failed: projectroot.autotests.testcalendarobserver* > > > * - Failed: projectroot.autotests.testicaltimezones* > > > * - Failed: projectroot.autotests.testrecurtodo* > -- Alexander Potashev

D25530: Sonnet: Add locales that are missing in QLocale

aspotashev added inline comments. INLINE COMMENTS > waqar wrote in loader.cpp:255 > I used wikipedia and the description files provided with the dictionaries for > this information. It may not be correct however. If you know the language or > the rules, please feel free to correct me and I will

D25530: Sonnet: Add locales that are missing in QLocale

aspotashev added inline comments. INLINE COMMENTS > loader.cpp:255 > +{QLatin1String("cv"), {QStringLiteral("Чӑвашла"), > QString()}}, //Chuvash > +{QLatin1String("cv_RU"), {QStringLiteral("Чӑвашла"), > QStringLiteral("Россия")}}, > +{

D19498: loadLibrary: Use enum values to define what type of plugin we load

This revision was automatically updated to reflect the committed changes. Closed by commit R317:f6a65feda870: loadLibrary: Use enum values to define what type of plugin we load (authored by aspotashev). REPOSITORY R317 Kross CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19498?vs=530

D19498: loadLibrary: Use enum values to define what type of plugin we load

aspotashev added a comment. ping? REPOSITORY R317 Kross REVISION DETAIL https://phabricator.kde.org/D19498 To: aspotashev, #frameworks Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

Re: New Framework Review: KDAV

вс, 10 нояб. 2019 г. в 15:44, David Faure : > > On samedi 9 novembre 2019 21:14:46 CET Alexander Potashev wrote: > > сб, 9 нояб. 2019 г. в 14:37, Volker Krause : > > > during Akademy there was a request to promote KDAV from KDE PIM to > > > Frameworks for use by Plas

Re: New Framework Review: KDAV

; classified as a functional tier 3 framework. Hi Volker, The name "KDAV" suggests that it might implement WebDAV. Do you think if it should be renamed to something like "DAVExtensions" or let's say "AnyDAV"? -- Alexander Potashev

D25216: Fix translations of $GenericName

aspotashev accepted this revision. aspotashev added a comment. LGTM since it fixes the issue. A next step could be a clearer explaination of what $GenericName will be replaced with. Is it always replaced with Filelight's GenericName from its filelight.desktop file? REPOSITORY R304 KNe

D25216: Fix translations of $GenericName

aspotashev added a comment. In general, string concatenation that you suggested is a big red flag for me as a translator. Concatenation often creates an untranslatable word puzzle. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D25216 To: meven, leinir, ngraham Cc

D25216: Fix translations of $GenericName

aspotashev added a comment. I suggest a more flexible approach which allows translators to more around the "$GenericName" part inside their translation and change the " - " separator to anything more appropriate in their language: i18nc("@action:inmenu %1=\"$GenericName\"", "%1 - curre

Re: Quick Charts in KDE Review

een a little over two weeks. If there are no objections, I > will move this to frameworks later today. Hi Arjen, Did anyone from the Plasma team approve the new KSysGuard UI? -- Alexander Potashev

Re: Vacations

eviewed during that time. > > -- > David Faure, fa...@kde.org, http://www.davidfaure.fr > Working on KDE Frameworks 5 > > > -- Alexander Potashev

Re: Quick Charts in KDE Review

it. > > And of course, a link would be useful: > > https://invent.kde.org/kde/kquickcharts > > > > > - Arjen -- Alexander Potashev

D24464: i18n: Add ellipsis to action items (X-Purpose-ActionDisplay)

This revision was automatically updated to reflect the committed changes. Closed by commit R495:39b92febeec5: i18n: Add ellipsis to action items (X-Purpose-ActionDisplay) (authored by aspotashev). REPOSITORY R495 Purpose Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24464?vs

D24464: i18n: Add ellipsis to action items (X-Purpose-ActionDisplay)

aspotashev created this revision. aspotashev added reviewers: apol, nicolasfella. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. aspotashev requested review of this revision. TEST PLAN none REPOSITORY R495 Purpose Library BRANCH master REVISION DETAIL

D23149: Only build tests when DBus is available

aspotashev added a comment. At least for now Window CI tries and tests something: https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20WindowsMSVCQt5.13/1/console REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D23149 To: nicolasfella, bcooksley, broulik,

D23149: Only build tests when DBus is available

aspotashev added a comment. Does this mean we cannot test Solid on Windows CI? https://api.kde.org/frameworks/solid/html/ says Solid is supported also on Windows. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D23149 To: nicolasfella, bcooksley, broulik, bruns, #fram

D22544: [RFC] Deprecate KPassivePopup

aspotashev added a comment. In D22544#505476 , @ngraham wrote: > In D22544#497637 , @aspotashev wrote: > > > > The case where no notification daemon is running is IMHO an edge case that we don't nee

D22884: [RFC] Don't show title on page by default

aspotashev added a comment. In D22884#505656 , @ndavis wrote: > Perhaps it is technically a bug, but it seems to me that most of the time (at least in all of the KDE programs I have installed), the title is just the section name, "Configure (the

D21660: remove dbus for windows build and change audio dep logic

aspotashev added a comment. This broke some public APIs on Windows: since Qt5DBus is not being "imported" by CMake, a group of .cpp files is not being compiled, see e.g. https://cgit.kde.org/knotifications.git/tree/src/CMakeLists.txt#n25 . Thus e.g. class KStatusNotifierItem implementation b

Re: New framework: KCalCore

So I suggested KCalendarCore, and Volker agreed. Hi David, How about KCalendarFormats? In my opinion KCalendarCore is bad because it would suggest there must be other KCalendar[...] libraries that depend on KCalendarCore, in a manner similar to - QtCore <- QtGui,QtQuick and - KIOCore <- KIOWidgets,KIOGui. -- Alexander Potashev

D22544: [RFC] Deprecate KPassivePopup

aspotashev added a comment. kdialog also uses KPassivePopup REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D22544 To: nicolasfella, #frameworks, broulik Cc: aspotashev, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22544: [RFC] Deprecate KPassivePopup

aspotashev added a comment. > The case where no notification daemon is running is IMHO an edge case that we don't need to support. Disagree here. I believe a lot of people don't use a notification system on Linux. If we remove KPassivePopup, some apps with stop working properly for them

Re: New framework: KCalCore

dn't try this approach yet because it's uncommon). All in all, I agree to follow the golden rule "if it works, don't touch it". -- Alexander Potashev

D22047: Fix translation of actiondisplay

aspotashev added inline comments. INLINE COMMENTS > imgurplugin.json:105 > +"Name[zh_TW]": "Imgur", > +"X-Purpose-ActionDisplay": "Imgur" > }, same for Imgur :( REPOSITORY R495 Purpose Library REVISION DETAIL https://phabricator.kde.org/D22047 To: nicolasfella, apol,

D22047: Fix translation of actiondisplay

aspotashev added inline comments. INLINE COMMENTS > pastebinplugin.json:105 > +"Name[zh_TW]": "Pastebin", > +"X-Purpose-ActionDisplay": "Pastebin" > }, oops, ActionDisplay should have ellipsis, e.g. "Pastebin..." REPOSITORY R495 Purpose Library REVISION DETAIL https://

D22069: Localize long number strings

aspotashev added a comment. Dammit, I'm still not on the same page with the review request. In fact you had to trust your unit test and go fix the code :) diff --git a/src/klocalizedstring.cpp b/src/klocalizedstring.cpp index b1ba745..fed5b8a 100644 --- a/src/klocalizedstrin

D22069: Localize long number strings

aspotashev added a comment. In D22069#485921 , @ngraham wrote: > Actual (ki18n("%1").subs(4.2, 5, 'f', 2).toString()): " 4.20" > Expected (QString(" 4,20")) : " 4,20" > > > What am I doing wrong?

D22069: Localize long number strings

aspotashev added a comment. You might want to test against different locales, like this: https://cgit.kde.org/ktimetracker.git/tree/src/tests/formattimetest.cpp REPOSITORY R249 KI18n REVISION DETAIL https://phabricator.kde.org/D22069 To: ngraham, #localization, #frameworks, broulik Cc:

D13150: Add ellipsis where appropriate

aspotashev added a comment. We probably need to fall back to "%1..." if X-Purpose-Action is not defined, which is possible for 3rd-party plugins. REPOSITORY R495 Purpose Library REVISION DETAIL https://phabricator.kde.org/D13150 To: nicolasfella, #vdg, apol, ngraham Cc: aspotashev, apol

D19498: loadLibrary: Use enum values to define what type of plugin we load

aspotashev added a reviewer: Frameworks. REPOSITORY R317 Kross REVISION DETAIL https://phabricator.kde.org/D19498 To: aspotashev, #frameworks Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21565: phabricator: Fix fallthrough in switch

This revision was automatically updated to reflect the committed changes. Closed by commit R495:a520d9ea1800: phabricator: Fix fallthrough in switch (authored by aspotashev). REPOSITORY R495 Purpose Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21565?vs=59080&id=59122 REVIS

D21565: phabricator: Fix fallthrough in switch

aspotashev created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. aspotashev requested review of this revision. TEST PLAN none REPOSITORY R495 Purpose Library BRANCH phab-fix-fallthrough REVISION DETAIL https://phabricator.kde.org/D21

Re: New framework: KCalCore

вт, 9 апр. 2019 г. в 20:10, Volker Krause : > > On Sunday, 7 April 2019 16:24:13 CEST Alexander Potashev wrote: > > вс, 7 апр. 2019 г. в 15:45, Volker Krause : > > > Hi, > > > > > > I'd like to propose KCalCore for review to move from KDE PIM to KF5.

Re: New framework: KCalCore

вс, 7 апр. 2019 г. в 17:24, Alexander Potashev : > > вс, 7 апр. 2019 г. в 15:45, Volker Krause : > > Hi, > > > > I'd like to propose KCalCore for review to move from KDE PIM to KF5. > > > > KCalCore is an implementation of the iCalendar standard based on li

Re: New framework: KCalCore

rshal/unmarshal methods, then actual r/w from disk can be done in FileStorage. Otherwise, for me to add KIO support right now I need to subclass ICalFormat rather than FileStorage which is weird. P.S. Sorry for the off-topic. -- Alexander Potashev

D20005: Report human-readable error if Qt5Widgets is required but is not found

This revision was automatically updated to reflect the committed changes. Closed by commit R249:490602677222: Report human-readable error if Qt5Widgets is required but is not found (authored by aspotashev). REPOSITORY R249 KI18n CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20005?vs

D20005: Report human-readable error if Qt5Widgets is required but is not found

aspotashev updated this revision to Diff 54695. aspotashev retitled this revision from "WIP: Find Qt5Widgets, required for Qt5::uic" to "Report human-readable error if Qt5Widgets is required but is not found". aspotashev added a comment. Implement probably the most lightweight behaviour. REP

D20005: WIP: Find Qt5Widgets, required for Qt5::uic

aspotashev added a comment. I'm not sure about this because 1. Not a find_package() guru 2. We may need to add Qt5Widgets as a new dependency of ki18n. For now ki18n won't pull qtwidgets, and your projects may fail compiling which is not very developer-friendly. REPOSITORY R249 KI18

D20005: WIP: Find Qt5Widgets, required for Qt5::uic

aspotashev created this revision. aspotashev added a reviewer: Frameworks. aspotashev added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. aspotashev requested review of this revision. REVISION SUMMARY If I have find_package(KF5I18n ${KF5_MIN_VERSION} CONFIG REQUI

D13150: Add ellipsis where appropriate

aspotashev added a comment. In D13150#428167 , @ngraham wrote: > This results in every item in the menu getting an ellipsis, which isn't appropriate because not all of them require more user action to proceed (the imgur plugin is one such exampl

D19501: Do not use deprecated KUrlRequester::fileDialog()

This revision was automatically updated to reflect the committed changes. Closed by commit R317:32502e83a1a6: Do not use deprecated KUrlRequester::fileDialog() (authored by aspotashev). REPOSITORY R317 Kross CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19501?vs=53090&id=53100 REVI

D19501: Do not use deprecated KUrlRequester::fileDialog()

aspotashev created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. aspotashev requested review of this revision. REPOSITORY R317 Kross BRANCH fix-deprecated REVISION DETAIL https://phabricator.kde.org/D19501 AFFECTED FILES src/ui/actio

D19498: loadLibrary: Use enum values to define what type of plugin we load

aspotashev created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. aspotashev requested review of this revision. REVISION SUMMARY Enum values are more lightweight and easier to compare than strings. TEST PLAN The manual test ".../kross-inter

Re: Review Request 124398: Install Kross modules to ${KDE_INSTALL_QTPLUGINDIR}

marked as submitted. Review request for KDE Frameworks. Changes --- Submitted with commit aef8165848ad157c81a9aa36ab1b40a0c7ec929c by Alexander Potashev to branch master. Repository: kross Description --- All shared libraries (including modules) are loaded by KrossCore with the use

D16966: Fix typo in i18n message (cmdline option description)

This revision was automatically updated to reflect the committed changes. Closed by commit R290:49a674d3bdb0: Fix typo in i18n message (cmdline option description) (authored by aspotashev). REPOSITORY R290 KPackage CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16966?vs=47770&id=4777

D16966: Fix typo in i18n message (cmdline option description)

aspotashev updated this revision to Diff 47770. aspotashev added a comment. fix another typo REPOSITORY R290 KPackage CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16966?vs=45698&id=47770 BRANCH arcpatch-D16966 REVISION DETAIL https://phabricator.kde.org/D16966 AFFECTED FI

Re: KDE Frameworks web page

nouncement link which seems to be > the best way to point the visitor to the newest release. https://download.kde.org/stable/frameworks/ could also work as a download link. Other products' announcements at https://www.kde.org/announcements/ may confuse newcomers. IMO the best would be a page with links to https://cgit.kde.org/... for each of the frameworks. -- Alexander Potashev

Re: KDE Frameworks web page

ould be "organiZation" for the US variant. 4. Can't find no direct link nor straightforward way to go to Git repos or download source tarballs. I think these must be easy to access, since KF5 is a developer-oriented product. -- Alexander Potashev

D16966: Fix typo in i18n message (cmdline option description)

aspotashev created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. aspotashev requested review of this revision. TEST PLAN none REPOSITORY R290 KPackage BRANCH opt-i18n REVISION DETAIL https://phabricator.kde.org/D16966 AFFECTED FILES

D16395: Update the "About KDE" text

aspotashev added a comment. FYI, according to an old custom mentioned at https://community.kde.org/Schedules/Frameworks , KF5.52 is already in string freeze, thus this change may only be pushed after 5.52 is released. However you can ask for an exception in the kde-i18n-doc mailing list unle

D13294: baloodb: Make changes to cmdline arg description after rename prune -> clean

This revision was automatically updated to reflect the committed changes. Closed by commit R293:3671d67a7956: baloodb: Make changes to cmdline arg description after rename prune -> clean (authored by aspotashev). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13

D13294: baloodb: Make changes to cmdline arg description after rename prune -> clean

aspotashev created this revision. aspotashev added a reviewer: michaelh. Restricted Application added projects: Frameworks, Baloo. Restricted Application added subscribers: Baloo, kde-frameworks-devel. aspotashev requested review of this revision. REPOSITORY R293 Baloo BRANCH rename-prune-to-

D7849: Fix the tray icon scaling on HiDPI screens

aspotashev added a comment. related bug report: https://bugs.kde.org/show_bug.cgi?id=360333 REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D7849 To: pgkos, #plasma Cc: aspotashev, ngraham, anthonyfieroni, broulik, #frameworks, davidedmundson, plas

D9107: Add undo support to BatchRenameJob

aspotashev added a comment. Please don't push this while in string freeze because you added a new translatable ('i18n()') message. https://community.kde.org/Schedules/Frameworks REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D9107 To: chinmoyr, #fr

D8767: Fix translation of toolbar name when it has i18n context

This revision was automatically updated to reflect the committed changes. Closed by commit R263:17eeaf00b651: Fix translation of toolbar name when it has i18n context (authored by aspotashev). REPOSITORY R263 KXmlGui CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8767?vs=22243&id=222

D8767: Fix translation of toolbar name when it has i18n context

aspotashev marked an inline comment as done. REPOSITORY R263 KXmlGui BRANCH toolbar-i18n-with-ctxt REVISION DETAIL https://phabricator.kde.org/D8767 To: aspotashev, dfaure, apol Cc: #frameworks

D8767: Fix translation of toolbar name when it has i18n context

aspotashev updated this revision to Diff 22243. aspotashev added a comment. const QString &key REPOSITORY R263 KXmlGui CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8767?vs=22207&id=22243 BRANCH toolbar-i18n-with-ctxt REVISION DETAIL https://phabricator.kde.org/D8767 AFFEC

D8767: Fix translation of toolbar name when it has i18n context

aspotashev created this revision. aspotashev added a reviewer: dfaure. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY The Configure Toolbars dialog did not take into account the "context" attribute of toolbar text whic

Re: Review Request 129609: utils.js: Escape backslash in i18n string

uot; as "s". - Alexander Potashev On Янв. 19, 2017, 7:09 п.п., Alexander Potashev wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://

Re: Review Request 129609: utils.js: Escape backslash in i18n string

marked as submitted. Review request for Kate and KDE Frameworks. Changes --- Submitted with commit 4eac3b9b3c78cc854751ab2e8e128bb6eb030056 by Alexander Potashev to branch master. Repository: ktexteditor Description --- utils.js: Escape backslash in i18n string Diffs - src

[Differential] [Accepted] D4023: kformat: Make it possible to properly translate relative days of the week

aspotashev accepted this revision. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D4023 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mpyne, #frameworks, kde-i18n-doc, aacid, aspotashev Cc: aacid

[Differential] [Commented On] D4023: kformat: Make it possible to properly translate relative days of the week

aspotashev added inline comments. INLINE COMMENTS > kformatprivate.cpp:381 > { > -return tr("Last %1").arg(m_locale.dayName(date.dayOfWeek(), format)); > +switch(date.dayOfWeek()) { > +case 1: return tr("Last Monday","day in the previous week"); Needs a space

Review Request 129609: utils.js: Escape backslash in i18n string

Description --- utils.js: Escape backslash in i18n string Diffs - src/script/data/commands/utils.js a47e2b41a3c2bb581c48b566244b108b531be71a Diff: https://git.reviewboard.kde.org/r/129609/diff/ Testing --- None! Thanks, Alexander Potashev

Re: Review Request 129510: Add FreeBSD to metainfo.yaml.

, but should be good because it does not contain any platform-specific code. - Alexander Potashev On Ноя. 20, 2016, 7:19 п.п., Tobias Berner wrote: > > --- > This is an automatically generated e-mail. To reply,

Re: Review Request 129341: [kwallet] boost::shared_ptr -> std::shared_ptr

it's not mentioned here: https://community.kde.org/Frameworks/Policies#Frameworks_compiler_requirements_and_C.2B.2B11 - Alexander Potashev On Ноя. 5, 2016, 3:05 п.п., Andreas Sturmlechner wrote: > > --- > This is an automa

Re: Review Request 128818: Revert "Remove unused KF5 dependencies"

53965efbbe72746f5dc6528686d4c8d965f0097a Diff: https://git.reviewboard.kde.org/r/128818/diff/ Testing --- Compiles. Thanks, Alexander Potashev

Re: Review Request 128818: Revert "Remove unused KF5 dependencies"

ivial. - Alexander Potashev On Сен. 3, 2016, 12:11 п.п., Alexander Potashev wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard

Re: Review Request 128582: Remove unused KF5 dependencies

successfully. Thanks, Alexander Potashev

Re: Review Request 128582: Remove unused KF5 dependencies

> On Авг. 25, 2016, 10:02 п.п., Andreas Sturmlechner wrote: > > lddtree /usr/lib64/libKF5KrossUi.so is listing all these three dependencies > > still in use. > > Alexander Potashev wrote: > Oops... You're right: kross/src/ui/actioncollectionview.cpp uses >

Review Request 128818: Revert "Remove unused KF5 dependencies"

--- Compiles. Thanks, Alexander Potashev

Re: Review Request 128582: Remove unused KF5 dependencies

ommit. - Alexander --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128582/#review98658 --- On Авг. 3, 2016, 5:23 д.п., Alex

Re: Review Request 128583: Make KrossUi and the command-line tool optional

> On Авг. 3, 2016, 4:28 д.п., Aleix Pol Gonzalez wrote: > > Why? > > Alexander Potashev wrote: > To make Kross easier to build for exotic (= non-Linux) platforms. (We > have no actual users for these options yet.) > > Aleix Pol Gonzalez wrote: > My

Re: Review Request 128583: Make KrossUi and the command-line tool optional

/CMakeLists.txt 48e2c0219072b1b1335821b0290d261d8dc3d361 Diff: https://git.reviewboard.kde.org/r/128583/diff/ Testing --- Still compiles successfully in all 4 configurations: {BUILD_KROSSUI = ON, OFF} x {BUILD_KROSS_CLI = ON, OFF}. Thanks, Alexander Potashev

Re: Review Request 128589: Take over maintainership; remove framework deprecation flags

--- Thanks, Alexander Potashev

Re: Review Request 128587: Move the QtScript backend into a separate directory

marked as submitted. Review request for KDE Frameworks. Changes --- Submitted with commit b359b9939d5b5e1a7d76e81da5ce0d8d449e29a8 by Alexander Potashev to branch master. Repository: kross Description --- Move the QtScript backend into a separate directory Diffs - src

Re: Review Request 128586: Use a dedicated Qt logging category in KrossUi

marked as submitted. Review request for KDE Frameworks. Changes --- Submitted with commit dfac6e7005624a7cb433a4cedef2494a4ee63a00 by Alexander Potashev to branch master. Repository: kross Description --- Use a dedicated Qt logging category in KrossUi Diffs - src/ui

Re: Review Request 128585: Use a dedicated Qt logging category in qts/*

marked as submitted. Review request for KDE Frameworks. Changes --- Submitted with commit 3a9ea94f9304b641895dbe2d4277fbaaf4e658c8 by Alexander Potashev to branch master. Repository: kross Description --- Use a dedicated Qt logging category in qts/* Diffs - src/qts

Re: Review Request 128584: Use a dedicated Qt logging category in KrossCore's .cpp files

marked as submitted. Review request for KDE Frameworks. Changes --- Submitted with commit a0dde322b465198d2434dc42616feffedb18c4be by Alexander Potashev to branch master. Repository: kross Description --- Use a dedicated Qt logging category in KrossCore's .cpp files

Re: Review Request 128582: Remove unused KF5 dependencies

marked as submitted. Review request for KDE Frameworks. Changes --- Submitted with commit ce2a58313fbeaee6482c9718ce4dfdf5cc190875 by Alexander Potashev to branch master. Repository: kross Description --- Remove unused KF5 dependencies Diffs - CMakeLists.txt

Re: Review Request 128583: Make KrossUi and the command-line tool optional

nerated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128583/#review98025 --- On Авг. 3, 2016, 2:36 д.п., Alexander Potashev wrote: > > --- > This is an automaticall

Review Request 128589: Take over maintainership; remove framework deprecation flags

--- Take over maintainership; remove framework deprecation flags Diffs - metainfo.yaml 28937c96ba71aecd81d3565d071fe6560ef2e68e Diff: https://git.reviewboard.kde.org/r/128589/diff/ Testing --- Thanks, Alexander Potashev ___ Kde

  1   2   >