D16018: Fix align of doxygen comments in templates

buschinski closed this revision. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D16018 To: buschinski, #ktexteditor, dhaumann Cc: cullmann, kwrite-devel, kde-frameworks-devel, michaelh, ngraham, bruns, demsking, sars, dhaumann

D16018: Fix align of doxygen comments in templates

buschinski updated this revision to Diff 44010. buschinski retitled this revision from "Fix align of doxygen comments" to "Fix align of doxygen comments in templates". buschinski removed a project: KDevelop. buschinski removed a subscriber: kdevelop-devel. buschinski added a comment. -

D16018: Fix align of doxygen comments

buschinski added a comment. Thx for the review :) I will update the patch (and post it here again). I can commit it myself, to master? or any special branch? REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D16018 To: buschinski, #ktexteditor, dhaumann Cc:

D16018: Fix align of doxygen comments

buschinski updated this revision to Diff 43201. buschinski added a comment. Changed to (correct) ktexteditor repository. Someday... I will learn how to use phabricator :) REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16018?vs=43088=43201 REVISION

D16018: Fix align of doxygen comments

buschinski changed the repository for this revision from R32 KDevelop to R39 KTextEditor. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D16018 To: buschinski, #ktexteditor Cc: kdevelop-devel, cullmann, kwrite-devel, kde-frameworks-devel, glebaccon, antismap,

D16018: Fix align of doxygen comments

buschinski added a comment. This did not work for templates as "isComment" uses line attributes and at the time the template is inserted it is always "C/C++ Code/Data"-attribute never a comment. It only becomes a "doxygen comment"-attribute after the template "editing" is finished.

D16018: Fix align of doxygen comments

buschinski updated this revision to Diff 43088. buschinski edited the summary of this revision. buschinski edited the test plan for this revision. Herald added a project: KDevelop. Herald added a subscriber: kdevelop-devel. REPOSITORY R32 KDevelop CHANGES SINCE LAST UPDATE

D16018: Fix align of doxygen comments

buschinski added a comment. In D16018#338441 , @cullmann wrote: > ... > For the code: > Hmm, why do you use rtrim? That removes trailing spaces, that won't help the startsWith checks. Or do I misread that? You are absolutely right,

D16018: Fix align of doxygen comments

buschinski created this revision. buschinski added a reviewer: KTextEditor. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. buschinski requested review of this revision. REVISION SUMMARY After https://bugs.kde.org/show_bug.cgi?id=360456

Re: KItemModels, Solid KJS licenses

hi, I confirm that I would be happy to the files listed below relicensed from GPL to LGPLv2+. Seriously, I don't really care that much if its gpl or lgpl, as long as its available for everyone who want to improve it ; Or ,if possible, I would relicense it to LGPLv2+ beer license, but sadly they

Re: Review Request 115502: Fix math function checks

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115502/#review49067 --- Ship it! Ship It! - Bernd Buschinski On Feb. 5, 2014, 5

Re: Review Request 115494: Build on Mac OS X

, visit: https://git.reviewboard.kde.org/r/115494/ --- (Updated Feb. 5, 2014, 4:06 p.m.) Review request for KDE Frameworks and Bernd Buschinski. Repository: kjs Description --- Build on Mac OS X Seems that clang on OS X

Re: Review Request 115502: Fix math function checks

On Feb. 5, 2014, 7:37 p.m., Bernd Buschinski wrote: Ship It! and btw good catch for the math vs. cmake undef, seems like I overlooked it :) - Bernd --- This is an automatically generated e-mail. To reply, visit: https