[frameworks/extra-cmake-modules] modules: Revert "ECMEnableSanitizers: do not enable linker flags when not supported"

Git commit fffae63daa48648784919aec4b576034e44a2da0 by Bhushan Shah. Committed on 26/01/2022 at 07:46. Pushed by cgiboudeaux into branch 'master'. Revert "ECMEnableSanitizers: do not enable linker flags when not supported" This reverts commit abc3a698abc0dfea1904

Merge tags in master branch?

e have any opinion on "merging" latest git tag in master branch? and potentially doing that for next releases as well? Thanks -- Bhushan Shah http://blog.bshah.in IRC Nick : bshah on Freenode GPG key fingerprint : 0AAC 775B B643 7A8D 9AF7 A3AC FE07 8411 7FBC E11D signature.asc Description: PGP signature

[sysadmin/repo-metadata] projects: projects: move new wayland repos to their final place

Git commit 53d913c3af459024d359c13def87db8913d8ed6b by Bhushan Shah. Committed on 29/04/2020 at 11:09. Pushed by bshah into branch 'master'. projects: move new wayland repos to their final place - plasma-wayland-protocols -> frameworks - kwayland-server -> kde/workspace Ref: T13

Information regarding upcoming Gitlab Migration: clarifications

a.git/tree/projects-invent?h=bshah/invent -- Bhushan Shah http://blog.bshah.in IRC Nick : bshah on Freenode GPG key fingerprint : 0AAC 775B B643 7A8D 9AF7 A3AC FE07 8411 7FBC E11D signature.asc Description: PGP signature

Re: Information regarding upcoming Gitlab Migration

nclude any namespace. [url "https://invent.kde.org/";] insteadOf = invent: [url "g...@invent.kde.org:"] pushInsteadOf = invent: > (That said, bigflatlistofrepositories.kde.org .. or maybe call it > cgit.kde.org > .. could be a particular view onto gitlab wh

Re: Information regarding upcoming Gitlab Migration

n it was projects.kde.org (chiliproject installation). [1] https://blog.bshah.in/2013/09/01/hello-planet/ -- Bhushan Shah http://blog.bshah.in IRC Nick : bshah on Freenode GPG key fingerprint : 0AAC 775B B643 7A8D 9AF7 A3AC FE07 8411 7FBC E11D signature.asc Description: PGP signature

Re: Information regarding upcoming Gitlab Migration

sitories but they are instead offered the empty page. One have to click on Shared repositories tab to actually see the list. https://invent.kde.org/groups/sysadmin/test/test2/-/shared This defeats the purpose of the creating subgroups (offering easy reachability). -- Bhushan Shah http://blog.bshah.in IR

Re: Information regarding upcoming Gitlab Migration

ma" and > "Frameworks", and so on). As explained above, while grouping repositories is trying to solve the merge requests/issue organization, it is not sole purpose of the suggested grouping, discoverability and reachability is the main issue we are trying to solve here. [1] https://

Re: Information regarding upcoming Gitlab Migration

refer when I don't have to guess this kind of things when > fetching a repository. [*] Ironically, in your case search would be helpful as you know you are looking for knetwalk so you can just add it and search it -- Bhushan Shah http://blog.bshah.in IRC Nick : bshah on Freenode GPG key fingerprint : 0AAC 775B B643 7A8D 9AF7 A3AC FE07 8411 7FBC E11D signature.asc Description: PGP signature

Information regarding upcoming Gitlab Migration

lement this next week and move projects to https://invent.kde.org. Thanks! Bhushan for sysadmin team [1] https://cgit.kde.org/sysadmin/repo-metadata.git/tree/projects-invent?h=bshah/invent -- Bhushan Shah http://blog.bshah.in IRC Nick : bshah on Freenode GPG key fingerprint : 0AAC 775B B643 7A8D

D28163: Add input-dialpad and call-voicemail

bshah added a comment. Hmm yeah I am also not a fan of the stretched out dialpad icon REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D28163 To: ndavis, #vdg Cc: ngraham, bshah, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, bruns

D28114: Add call-incoming/missed/outgoing

bshah added a subscriber: jbbgameich. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D28114 To: ndavis, #vdg Cc: jbbgameich, bshah, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27708: Cleanup accounts kded module

bshah accepted this revision. REPOSITORY R155 KAccounts Integration BRANCH arcpatch-D27708 REVISION DETAIL https://phabricator.kde.org/D27708 To: nicolasfella, #frameworks, bshah, leinir

D27637: kill twitter support

bshah accepted this revision. This revision is now accepted and ready to land. REPOSITORY R495 Purpose Library BRANCH killtwitter REVISION DETAIL https://phabricator.kde.org/D27637 To: nicolasfella, #frameworks, apol, bshah Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngra

D27622: only find bash once

bshah accepted this revision. This revision is now accepted and ready to land. REPOSITORY R266 Breeze Icons BRANCH master REVISION DETAIL https://phabricator.kde.org/D27622 To: sitter, bshah Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27614: build: fix the build where install prefix is not user-writable

This revision was automatically updated to reflect the committed changes. Closed by commit R266:462c5dfe2e9a: build: fix the build where install prefix is not user-writable (authored by bshah). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27614?vs=76278

D27614: build: fix the build where install prefix is not user-writable

bshah updated this revision to Diff 76278. bshah added a comment. rebase REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27614?vs=76256&id=76278 BRANCH bshah/fix-build REVISION DETAIL https://phabricator.kde.org/D27614 AFFECTED FILES icons-dark

D27614: build: fix the build where install prefix is not user-writable

bshah created this revision. bshah added reviewers: ngraham, lbeltrame. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. bshah requested review of this revision. REVISION SUMMARY - Validate only the files and symlinks - Fix target names, they were swapped

D26273: cmake: don't use taglib-config if we are cross compiling

bshah created this revision. bshah added a reviewer: vkrause. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. bshah requested review of this revision. REVISION SUMMARY If we are cross compiling two things are possible, - cmake finds host tagl

D22968: Make it possible to modify contacts

bshah requested changes to this revision. bshah added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > abstracteditablecontact.h:31 > + * > + * @since 5.60 > + * @internal Since 5.62 > persondata.h:103 > > +Q_SCRIPTABLE bool setContactCustomProperty(const

KCalendarCore plugins/datasources?

akonadi storage, and Akonadi have it's own custom code for this. Would it make sense to have something like this in kcalcore itself? Volker mentioned to me that it needs close look at Akonadi based implementation and trying to finalize API. Thanks -- Bhushan Shah http://blog.bshah.in

D22836: Fix checking dirs for metainfo.yaml with non-ascii chars with Python 2.7

bshah accepted this revision. bshah added a comment. As a short term workaround, this is fine, in terms of porting to python3 it will also need changes on our server zivo.kde.org which is hosting api.kde.org, right now every scripts including krazy2 and apidox generation scripts are too much

D22425: personsmodel: Add phoneNumber

bshah added a reviewer: apol. REPOSITORY R307 KPeople REVISION DETAIL https://phabricator.kde.org/D22425 To: jbbgameich, #plasma:_mobile, #kde_pim, apol Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22049: pluginloader: Change behavior of X-KDE-ParentApp

This revision was automatically updated to reflect the committed changes. Closed by commit R242:7ae271987ca2: pluginloader: Change behavior of X-KDE-ParentApp (authored by bshah). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22049?vs=60501

D22049: pluginloader: Change behavior of X-KDE-ParentApp

bshah created this revision. bshah added reviewers: mart, apol. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. bshah requested review of this revision. REVISION SUMMARY X-KDE-ParentApp is the key in desktop file to display that given service or application

D21778: Add some documentation for PlatformDependent

This revision was automatically updated to reflect the committed changes. Closed by commit R235:fbda1d799cc1: Add some documentation for PlatformDependent (authored by bshah). REPOSITORY R235 Attica CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21778?vs=59711&id=59712 REVISION DETA

D21778: Add some documentation for PlatformDependent

bshah created this revision. bshah added a reviewer: leinir. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. bshah requested review of this revision. REVISION SUMMARY Also add note about deprecating askForCredentials and saveCredentials in future. REPOSITO

Re: [sysadmin/ci-tooling] build-specs/Plasma: Disable execution of tests for plasma-integration.

> > Can we try to get this documented? 1.7GB isn't a lot for lots of people with > fast internet (if the server serves fast enough). https://invent.kde.org/sysadmin/ci-tooling/wikis/CI-On-Local-Machine I have added some initial documentation here, which I will improve later. --

D17808: Don't force Phonon on Android

bshah accepted this revision. This revision is now accepted and ready to land. REPOSITORY R289 KNotifications BRANCH master REVISION DETAIL https://phabricator.kde.org/D17808 To: vkrause, bshah Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17345: Support Bluetooth batteries

bshah accepted this revision. This revision is now accepted and ready to land. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D17345 To: broulik, #plasma, bruns, davidedmundson, bshah Cc: kde-frameworks-devel, michaelh, ngraham, bruns

Re: Downtime announcement: www.kde.org

logies for any inconvenience caused. > > The maintenance window has now commenced. > The above sites will be inaccessible until the maintenance is completed. > > > > > Regards, > > Ben Cooksley > > KDE Sysadmin > > Regards, > Ben -- Bhushan Shah http://blog.bshah.in IRC Nick : bshah on Freenode GPG key fingerprint : 0AAC 775B B643 7A8D 9AF7 A3AC FE07 8411 7FBC E11D signature.asc Description: PGP signature

Re: Pre-review CI

request is open, also we are thinking of the "cleanup" at regular period to purge the review request builds which had no updates in "some period". Thanks -- Bhushan Shah http://blog.bshah.in IRC Nick : bshah on Freenode GPG key fingerprint : 0AAC 775B B643 7A8D 9AF7 A3AC FE07 8411 7FBC E11D signature.asc Description: PGP signature

Re: Pre-review CI

quot; is link to jenkins build. But the test was if you were able to spot it in first glance, and it failed. :P so yeah we will keep comments enabled even if it means extra emails. > Cheers and Thanks again for improving the review system > Friedrich Thanks -- Bhushan Shah http://blog.bsh

Pre-review CI

the comment? See linked review for example [1]. Looking forward to feedback. Thanks! [1] https://mail.kde.org/pipermail/kde-frameworks-devel/2018-June/065616.html [2] https://phabricator.kde.org/D14438 -- Bhushan Shah http://blog.bshah.in IRC Nick : bshah on Freenode GPG key fingerprint : 0AAC

D13819: dummy commit to test pre-review CI

bshah removed a project: Frameworks. bshah removed a subscriber: kde-frameworks-devel. Restricted Application added a project: Frameworks. REPOSITORY R243 KArchive REVISION DETAIL https://phabricator.kde.org/D13819 To: bshah Cc: jenkins-ci, michaelh, ngraham, bruns, kde-frameworks-devel

D13819: dummy commit to test pre-review CI

bshah updated this revision to Diff 38634. bshah added a comment. - Revert "make it fail" - break test REPOSITORY R243 KArchive CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13819?vs=38632&id=38634 BRANCH bshah REVISION DETAIL https://phabricator.kde.org/D13819 AFFECTED

D13819: dummy commit to test pre-review CI

bshah updated this revision to Diff 38632. bshah added a comment. - make it fail REPOSITORY R243 KArchive CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13819?vs=38631&id=38632 BRANCH bshah REVISION DETAIL https://phabricator.kde.org/D13819 AFFECTED FILES CMakeLists.txt

D13819: dummy commit to test pre-review CI

bshah updated this revision to Diff 38631. bshah added a comment. - change REPOSITORY R243 KArchive CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13819?vs=38500&id=38631 BRANCH bshah REVISION DETAIL https://phabricator.kde.org/D13819 AFFECTED FILES CMakeLists.txt To: bs

D13819: dummy commit to test pre-review CI

bshah updated this revision to Diff 38500. bshah added a comment. - change REPOSITORY R243 KArchive CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13819?vs=37574&id=38500 BRANCH bshah REVISION DETAIL https://phabricator.kde.org/D13819 AFFECTED FILES CMakeLists.txt To: bs

D13819: dummy commit to test pre-review CI

bshah updated this revision to Diff 37574. bshah added a comment. - jhdkjfhdskj REPOSITORY R243 KArchive CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13819?vs=37004&id=37574 BRANCH bshah REVISION DETAIL https://phabricator.kde.org/D13819 AFFECTED FILES CMakeLists.txt T

D13559: Fix some of cppcheck warnings

This revision was automatically updated to reflect the committed changes. Closed by commit R127:84bc3cbd6102: Fix some of cppcheck warnings (authored by bshah). REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13559?vs=37088&id=37135 REVISION DETAIL https://

D13559: Fix some of cppcheck warnings

bshah added subscribers: aacid, apol. bshah added a comment. Added subscribers back which arc removed. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D13559 To: bshah, #frameworks Cc: apol, aacid, kde-frameworks-devel, michaelh, ngraham, bruns

D13559: Fix some of cppcheck warnings

bshah updated this revision to Diff 37088. bshah edited the summary of this revision. bshah removed subscribers: aacid, apol. bshah added a comment. update commit message REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13559?vs=37087&id=37088 BRANCH fix-

D13559: Fix some of cppcheck warnings

bshah updated this revision to Diff 37087. bshah added a comment. - fix memory leak properly REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13559?vs=36199&id=37087 BRANCH fix-cppcheck REVISION DETAIL https://phabricator.kde.org/D13559 AFFECTED FILES

D13559: Fix some of cppcheck warnings

bshah added a comment. In D13559#285804 , @apol wrote: > I don't see any fix here. It's just silencing cppcheck. Only supressing done is the memleak in the autotests, otherwise for selfInitialization it is the false alarm, which can be fi

D13819: dummy commit to test pre-review CI

bshah updated this revision to Diff 37004. bshah added a comment. - fix tests REPOSITORY R243 KArchive CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13819?vs=36992&id=37004 BRANCH bshah REVISION DETAIL https://phabricator.kde.org/D13819 AFFECTED FILES CMakeLists.txt To:

D13559: Fix some of cppcheck warnings

bshah added a comment. bump? REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D13559 To: bshah, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13819: dummy commit to test pre-review CI

bshah updated this revision to Diff 36992. bshah added a comment. - less fun, but this time try failing unit test REPOSITORY R243 KArchive CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13819?vs=36991&id=36992 BRANCH bshah REVISION DETAIL https://phabricator.kde.org/D13819

D13819: dummy commit to test pre-review CI

bshah updated this revision to Diff 36991. bshah added a comment. - find qt5 fun, because that will make build fail REPOSITORY R243 KArchive CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13819?vs=36989&id=36991 BRANCH bshah REVISION DETAIL https://phabricator.kde.org/D13819

D13819: dummy commit to test pre-review CI

bshah updated this revision to Diff 36989. bshah added a comment. - final change handover chnage REPOSITORY R243 KArchive CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13819?vs=36988&id=36989 BRANCH bshah REVISION DETAIL https://phabricator.kde.org/D13819 AFFECTED FILES

D13819: dummy commit to test pre-review CI

bshah updated this revision to Diff 36988. bshah added a comment. - enough derps REPOSITORY R243 KArchive CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13819?vs=36987&id=36988 BRANCH bshah REVISION DETAIL https://phabricator.kde.org/D13819 AFFECTED FILES CMakeLists.txt

D13819: dummy commit to test pre-review CI

bshah updated this revision to Diff 36987. bshah added a comment. - derp REPOSITORY R243 KArchive CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13819?vs=36986&id=36987 BRANCH bshah REVISION DETAIL https://phabricator.kde.org/D13819 AFFECTED FILES CMakeLists.txt To: bsha

D13819: dummy commit to test pre-review CI

bshah updated this revision to Diff 36986. bshah added a comment. - derp REPOSITORY R243 KArchive CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13819?vs=36985&id=36986 BRANCH bshah REVISION DETAIL https://phabricator.kde.org/D13819 AFFECTED FILES CMakeLists.txt To: bsha

D13819: dummy commit to test pre-review CI

bshah updated this revision to Diff 36985. bshah added a comment. - edit 4, to check change handover works REPOSITORY R243 KArchive CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13819?vs=36982&id=36985 BRANCH bshah REVISION DETAIL https://phabricator.kde.org/D13819 AFFECTE

D13819: dummy commit to test pre-review CI

bshah created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. Harbormaster failed remote builds in B508: Diff 36977! Harbormaster returned this revision to the author for changes because remote builds failed. bshah

PSA: Phabricator staging repositories

g this to some list, feel free to forward it and please make sure to include sysad...@kde.org or me in reply. Thanks [1] https://secure.phabricator.com/book/phabricator/article/harbormaster/ -- Bhushan Shah http://blog.bshah.in IRC Nick : bshah on Freenode GPG key fingerprint : 0AAC 775B

D13559: Fix some of cppcheck warnings

bshah created this revision. bshah added a reviewer: Frameworks. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. bshah requested review of this revision. REVISION SUMMARY - selfInitialization - memleak I could probably s

D13533: Add the arclint file in kwayland

This revision was automatically updated to reflect the committed changes. Closed by commit R127:b046ca8e9d1f: Add the arclint file in kwayland (authored by bshah). REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13533?vs=36152&id=36192 REVISION DETAIL https

D13533: Add the arclint file in kwayland

bshah created this revision. bshah added a reviewer: Frameworks. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. bshah requested review of this revision. REVISION SUMMARY - xml linter to make sure that we don't add broken proto

D13076: Increase org_kde_plasma_shell interface version

bshah accepted this revision. bshah added a comment. This revision is now accepted and ready to land. Works for me, (and makes sense). Thanks for debugging this @romangg REPOSITORY R127 KWayland BRANCH fixPlasmaShellVersion REVISION DETAIL https://phabricator.kde.org/D13076 To: romang

D12919: [Plotter] Don't render if m_node is null

bshah accepted this revision. bshah added a comment. This revision is now accepted and ready to land. Sounds good to me. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D12919 To: broulik, #plasma, bshah Cc: bshah, kde-frameworks-devel, michaelh, ngraham, bruns

D12820: Add KWayland virtual desktop protocol

bshah added inline comments. INLINE COMMENTS > registry.h:154 > PlasmaShell, ///< Refers to org_kde_plasma_shell interface > +PlasmaVirtualDesktopManagement, ///< Refers to > org_kde_plasma_virtual_desktop_management interface > PlasmaWindowManagement, ///< Refers to >

D11717: regenerate qrc on every build

This revision was automatically updated to reflect the committed changes. Closed by commit R290:f3619363ed63: regenerate qrc on every build (authored by bshah). REPOSITORY R290 KPackage CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11717?vs=30628&id=30631 REVISION DETAIL https://

D11717: regenerate qrc on every build

bshah created this revision. bshah added a reviewer: mart. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. bshah requested review of this revision. REVISION SUMMARY this will ensure that file deletion and inclusion are taken care of when

D11709: Don't create dependency loop

This revision was automatically updated to reflect the committed changes. Closed by commit R290:0a26d53a0f86: Don't create dependency loop (authored by bshah). REPOSITORY R290 KPackage CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11709?vs=30610&id=30611 REVISION DETAIL https://p

D11709: Don't create dependency loop

bshah created this revision. bshah added a reviewer: romangg. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. bshah requested review of this revision. REVISION SUMMARY The code tried to depend on the generated .rcc file which was generat

D11642: Fix the rcc binary package generation

bshah marked 2 inline comments as done. bshah added a comment. opened PR for KDE_INSTALL_DATADIR : https://phabricator.kde.org/D11675 REPOSITORY R290 KPackage REVISION DETAIL https://phabricator.kde.org/D11642 To: bshah, mart, davidedmundson, apol Cc: kossebau, #frameworks, michaelh, ngr

D11675: use KDE_INSTALL_DATADIR instead of FULL_DATADIR

bshah created this revision. bshah added a reviewer: kossebau. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. bshah requested review of this revision. REVISION SUMMARY This is inline with other install statements REPOSITORY R290 KPac

D11642: Fix the rcc binary package generation

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R290:b69866996e7e: Fix the rcc binary package generation (authored by bshah). REPOSITORY R290 KPackage CHANGES SINCE LAS

D11642: Fix the rcc binary package generation

bshah added inline comments. INLINE COMMENTS > kossebau wrote in KF5PackageMacros.cmake:164 > Does a plain `${KDE_INSTALL_DATADIR}` not also work? The non-FULL variable > variants are the ones used usually with `install()`. Not exactly sure why > they are, but doing here as well would be consis

D11642: Fix the rcc binary package generation

bshah marked 2 inline comments as done. REPOSITORY R290 KPackage REVISION DETAIL https://phabricator.kde.org/D11642 To: bshah, mart, davidedmundson, apol Cc: kossebau, #frameworks, michaelh, ngraham

D11642: Fix the rcc binary package generation

bshah updated this revision to Diff 30412. bshah added a comment. - regnerate rcc file on every build - add comment in add_custom_target for logging in build log - Fix the path in the qrc file which broke in previous attempt, plasma/plasmoids// v/s plasma/plasmoids// REPOSITORY R290 KPa

D11642: Fix the rcc binary package generation

bshah added a comment. In D11642#232866 , @apol wrote: > See older reviews. This won't work because cmake doesn't know when one of the contained files is modified so rcc files are never regenerated properly. I've solution for that in mind

D11642: Fix the rcc binary package generation

bshah added reviewers: mart, davidedmundson, apol. REPOSITORY R290 KPackage REVISION DETAIL https://phabricator.kde.org/D11642 To: bshah, mart, davidedmundson, apol Cc: #frameworks, michaelh, ngraham

D11642: Fix the rcc binary package generation

bshah updated this revision to Diff 30385. bshah edited the test plan for this revision. bshah added a comment. update commit message REPOSITORY R290 KPackage CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11642?vs=30384&id=30385 BRANCH fix-bundled-packages REVISION DETAIL h

D11642: Fix the rcc binary package generation

bshah created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. bshah requested review of this revision. REVISION SUMMARY kpackage_install_bundled_package used install(CODE ..) for the generation and installation of the rc

D11331: add gaming_input devices and others to Battery

bshah added reviewers: broulik, Plasma. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D11331 To: dollinger, broulik, #plasma Cc: #frameworks, michaelh, ngraham

D10072: Add APKBUILD to be highlighted as a Bash file

bshah added a comment. In D10072#204816 , @ltoscano wrote: > I suggest to push a revert and push it again with the right metadata. done. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D10072 To: Pure

D10072: Add APKBUILD to be highlighted as a Bash file

bshah added a comment. Uhm sorry, arc screwed up author metadata :-( but submitted patch anyway. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D10072 To: PureTryOut, vkrause Cc: dhaumann, bshah, vkrause, bcooksley, #frameworks, michaelh

D10072: Add APKBUILD to be highlighted as a Bash file

This revision was automatically updated to reflect the committed changes. Closed by commit R216:7bafdc592040: Add APKBUILD to be highlighted as a Bash file (authored by bshah). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10072?vs=25985&id=26985

D10450: Generate a custom target in kcoreaddons_desktop_to_json

bshah accepted this revision. bshah added a comment. This revision is now accepted and ready to land. +1 REPOSITORY R244 KCoreAddons BRANCH master REVISION DETAIL https://phabricator.kde.org/D10450 To: tcberner, #freebsd, mpyne, bshah, dfaure Cc: adridg, kossebau, #frameworks, michael

D9589: Unexport kjscmd

bshah added inline comments. INLINE COMMENTS > vkrause wrote in CMakeLists.txt:6 > That suggests it shouldn't even be installed in the first place? Would fix > the cross-compilation issue too. I am not sure tbh, question is what it does and what does it mean by developer tool? - KJSEmbed fram

D9587: Make kdoctools dependency optional

bshah accepted this revision. This revision is now accepted and ready to land. REPOSITORY R314 KJs BRANCH master REVISION DETAIL https://phabricator.kde.org/D9587 To: vkrause, #frameworks, bshah Cc: michaelh

D9588: Make kdoctools dependency optional

bshah accepted this revision. This revision is now accepted and ready to land. REPOSITORY R315 KJsEmbed BRANCH master REVISION DETAIL https://phabricator.kde.org/D9588 To: vkrause, #frameworks, bshah Cc: michaelh

D9594: Make kdoctools dependency optional

bshah accepted this revision. This revision is now accepted and ready to land. REPOSITORY R298 KDesignerPlugin BRANCH master REVISION DETAIL https://phabricator.kde.org/D9594 To: vkrause, #frameworks, bshah Cc: michaelh

D9589: Unexport kjscmd

bshah added inline comments. INLINE COMMENTS > CMakeLists.txt:6 > > # This is a developer tool, not intended for normal user installs > add_executable(kjscmd5 ${kjscmd_SRCS}) :-P REPOSITORY R315 KJsEmbed REVISION DETAIL https://phabricator.kde.org/D9589 To: vkrause, #frameworks Cc: bs

D10072: Add APKBUILD to be highlighted as a Bash file

bshah added subscribers: vkrause, bshah. bshah added a reviewer: vkrause. bshah added a comment. Adding @vkrause as reviewer who is listed as maintainer in metainfo.yaml REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D10072 To: PureTryOut, vkrause Cc: bsh

D10074: parametrize qqc2 version

bshah accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH phab/qqcversion REVISION DETAIL https://phabricator.kde.org/D10074 To: mart, #plasma, bshah Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-m

D9894: [UDisks Device] Show loop device with their backing file name and icon

bshah accepted this revision. bshah added a comment. This revision is now accepted and ready to land. , showed up with file name a REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D9894 To: broulik, #vdg, davidedmundson, bshah Cc: bshah, apol, #frameworks

D9895: [UDisks] Ignore non-user mounts

bshah accepted this revision as: bshah. This revision is now accepted and ready to land. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D9895 To: broulik, #plasma, #vdg, #frameworks, bshah Cc: mart, ngraham, sitter, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohame

D10020: add a workaround to mark snap bundle mounts as hidden

bshah added subscribers: broulik, bshah. bshah added a comment. umm, @broulik had a patch for this somewhere... https://phabricator.kde.org/D9895 REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D10020 To: sitter, apol Cc: bshah, broulik, #frameworks

D8806: Do not leak rfkill file descriptors.

bshah added a comment. In https://phabricator.kde.org/D8806#167510, @drosca wrote: > Why? It's not like any other process can't open /dev/rfkill as we ship udev rule to enable r+w access to /dev/rfkill for all users. My comment was question :-) But well I didn't know about ud

D8806: Do not leak rfkill file descriptors.

bshah added a comment. I do wonder if this is security fix? And should probably be handled like that? REPOSITORY R269 BluezQt REVISION DETAIL https://phabricator.kde.org/D8806 To: ofreyermuth, davidedmundson Cc: drosca, bshah, broulik, #frameworks

D8806: Do not leak rfkill file descriptors.

bshah added a comment. Do you have commit access? REPOSITORY R269 BluezQt REVISION DETAIL https://phabricator.kde.org/D8806 To: ofreyermuth, davidedmundson Cc: bshah, broulik, #frameworks

D8111: Require Kirigami 2.1 instead of 1.0 for KNewStuffQuick

bshah added a comment. +1, looks good to me. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D8111 To: leinir, #knewstuff Cc: bshah, #frameworks, ZrenBot

D8105: Find test helper

bshah accepted this revision. This revision is now accepted and ready to land. REPOSITORY R278 KWindowSystem BRANCH master REVISION DETAIL https://phabricator.kde.org/D8105 To: davidedmundson, bshah Cc: #frameworks

D8107: Find test helper

bshah accepted this revision. This revision is now accepted and ready to land. REPOSITORY R278 KWindowSystem BRANCH master REVISION DETAIL https://phabricator.kde.org/D8107 To: davidedmundson, bshah Cc: #frameworks

D7533: KIO: port the URI filter plugins from KServiceTypeTrader to json+KPluginMetaData

bshah added a comment. In https://phabricator.kde.org/D7533#140680, @dfaure wrote: > Ah, phabricator is strange, I have indeed modified the commit log before doing `arc diff` but it didn't update it here. And it also did overwrite your change in actual commit message it seems *sh

D7533: KIO: port the URI filter plugins from KServiceTypeTrader to json+KPluginMetaData

bshah accepted this revision. bshah added a comment. This revision is now accepted and ready to land. Looks good to me. (Maybe modify the commit message to remove the priority int/string bits) BRANCH master REVISION DETAIL https://phabricator.kde.org/D7533 To: dfaure, apol, davidedm

D7533: KIO: port the URI filter plugins from KServiceTypeTrader to json+KPluginMetaData

bshah added a comment. > One thing I don't understand is the need for toString().toInt(), > or in other words, why my json file with a numeric value gets turned > into a string value when using qtplugininfo to inspect the plugin: Maybe you need to add following in the `src/widgets/ku

  1   2   3   >