comparison required it (to avoid using an old cache).
I guess the alternative would be to also store the file size in
CacheHiddenFile, but it sounds like this would only be useful for the
unittest, I can't think of a real-life problem with mtime having a 1s
resolution.
Bruno Nova
/#review72882
---
On Jan. 1, 2015, 9:55 p.m., Bruno Nova wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119607
in Kubuntu 14.04,
and it worked everywhere I tested (Dolphin, open/save dialogs, folder widget
and detailed/tree view in Dolphin).
It wasn't an intensive test, though.
Thanks,
Bruno Nova
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
/kdirlistertest.cpp (or autotests/kdirmodeltest.cpp).
Bruno Nova wrote:
OK, I'll try to add a unittest later.
I've searched for a general specification for .hidden files, but have
found none.
However, I have accidentally found, through Wikipedia, the commit that
adds
location ~/Desktop).
More testing is required.
The version for KDE4/Qt4 submitted to Bug #246260 was tested in Kubuntu 14.04,
and it worked everywhere I tested (Dolphin, open/save dialogs, folder widget
and detailed/tree view in Dolphin).
It wasn't an intensive test, though.
Thanks,
Bruno Nova
/Qt4 submitted to Bug #246260 was tested in Kubuntu 14.04,
and it worked everywhere I tested (Dolphin, open/save dialogs, folder widget
and detailed/tree view in Dolphin).
It wasn't an intensive test, though.
Thanks,
Bruno Nova
___
Kde-frameworks-devel
---
On Dez. 9, 2014, 2:14 p.m., Bruno Nova wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119607
if this should be part of
KFileItem's public API.
David Faure wrote:
I don't have an issue with that. Gives more possibilities to the app (or
file dialog) etc.
Bruno Nova wrote:
So, should this be left public or not?
Bruno Nova wrote:
I still need an answer here
-rootItem.localPath();
if (!localPath.isEmpty()) {
filesToHide =
filesInDotHiddenForDir(QUrl::fromLocalFile(localPath));
}
}
This should take care of the case of desktop:/ URLs. Can you test?
Bruno Nova wrote:
Thanks
-rootItem.localPath();
if (!localPath.isEmpty()) {
filesToHide =
filesInDotHiddenForDir(QUrl::fromLocalFile(localPath));
}
}
This should take care of the case of desktop:/ URLs. Can you test?
Bruno Nova wrote:
Thanks
-rootItem.localPath();
if (!localPath.isEmpty()) {
filesToHide =
filesInDotHiddenForDir(QUrl::fromLocalFile(localPath));
}
}
This should take care of the case of desktop:/ URLs. Can you test?
Bruno Nova wrote:
Thanks
~/Desktop).
More testing is required.
The version for KDE4/Qt4 submitted to Bug #246260 was tested in Kubuntu 14.04,
and it worked everywhere I tested (Dolphin, open/save dialogs, folder widget
and detailed/tree view in Dolphin).
It wasn't an intensive test, though.
Thanks,
Bruno Nova
KCoreDirLister, right?
Bruno Nova wrote:
I left this method (and others) public because I thought that, maybe in
the future, someone may want to use this method.
But you're right, it's not used anywhere else and should probably be
private/protected.
I moved this method
-rootItem.localPath();
if (!localPath.isEmpty()) {
filesToHide =
filesInDotHiddenForDir(QUrl::fromLocalFile(localPath));
}
}
This should take care of the case of desktop:/ URLs. Can you test?
Bruno Nova wrote:
Thanks
if this should be part of
KFileItem's public API.
David Faure wrote:
I don't have an issue with that. Gives more possibilities to the app (or
file dialog) etc.
Bruno Nova wrote:
So, should this be left public or not?
I still need an answer here. :-)
Besides this issue
if this should be part of
KFileItem's public API.
David Faure wrote:
I don't have an issue with that. Gives more possibilities to the app (or
file dialog) etc.
Bruno Nova wrote:
So, should this be left public or not?
Bruno Nova wrote:
I still need an answer here
. 18, 2014, 10:06 a.m., Bruno Nova wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119607/
---
(Updated Set. 18, 2014, 10
:06 a.m., Bruno Nova wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119607/
---
(Updated Set. 18, 2014, 10:06 a.m
*/, CacheHiddenFile
m_cacheHiddenFiles;
m_cacheHiddenFiles.setMaxCost(10);
This requires making the filesInDotHiddenForDir method not file-static as
I previously suggested, but rather a method of KCoreDirLister::Private, which
would also have the above member.
Bruno Nova
*/, CacheHiddenFile
m_cacheHiddenFiles;
m_cacheHiddenFiles.setMaxCost(10);
This requires making the filesInDotHiddenForDir method not file-static as
I previously suggested, but rather a method of KCoreDirLister::Private, which
would also have the above member.
Bruno Nova
/kdirlistertest.cpp (or autotests/kdirmodeltest.cpp).
Bruno Nova wrote:
OK, I'll try to add a unittest later.
I've searched for a general specification for .hidden files, but have
found none.
However, I have accidentally found, through Wikipedia, the commit that
adds
);
This requires making the filesInDotHiddenForDir method not file-static as
I previously suggested, but rather a method of KCoreDirLister::Private, which
would also have the above member.
Bruno Nova wrote:
Now that you mention remote protocols, I just found out that Nautilus
.hidden
generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119607/#review66872
---
On Set. 18, 2014, 10:06 a.m., Bruno Nova wrote:
---
This is an automatically generated e-mail
to Bug #246260 was tested in Kubuntu 14.04,
and it worked everywhere I tested (Dolphin, open/save dialogs, folder widget
and detailed/tree view in Dolphin).
It wasn't an intensive test, though.
Thanks,
Bruno Nova
___
Kde-frameworks-devel mailing list
Kde
:
https://git.reviewboard.kde.org/r/119607/#review66777
---
On Set. 18, 2014, 10:06 a.m., Bruno Nova wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
On Set. 14, 2014, 3:27 p.m., Frank Reininghaus wrote:
src/core/kcoredirlister.cpp, line 1218
https://git.reviewboard.kde.org/r/119607/diff/2/?file=301215#file301215line1218
const
Bruno Nova wrote:
What do you mean? `filesToHide` should be `const`?
(I thought I had added
was tested in Kubuntu 14.04,
and it worked everywhere I tested (Dolphin, open/save dialogs, folder widget
and detailed/tree view in Dolphin).
It wasn't an intensive test, though.
Thanks,
Bruno Nova
___
Kde-frameworks-devel mailing list
Kde-frameworks
. 14, 2014, 3:32 p.m., Bruno Nova wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119607/
---
(Updated Set. 14, 2014, 3:32
in Kubuntu
14.04, and it worked everywhere I tested (Dolphin, open/save dialogs, folder
widget and detailed/tree view in Dolphin).
It wasn't an intensive test, though.
Thanks,
Bruno Nova
___
Kde-frameworks-devel mailing list
Kde-frameworks
was tested in Kubuntu 14.04,
and it worked everywhere I tested (Dolphin, open/save dialogs, folder widget
and detailed/tree view in Dolphin).
It wasn't an intensive test, though.
Thanks,
Bruno Nova
___
Kde-frameworks-devel mailing list
Kde-frameworks
On Set. 14, 2014, 3:27 p.m., Frank Reininghaus wrote:
src/core/kcoredirlister.cpp, line 2801
https://git.reviewboard.kde.org/r/119607/diff/2/?file=301215#file301215line2801
I think that you can remove this line.
Bruno Nova wrote:
Oops, forgot to remove `QString` from line
31 matches
Mail list logo
