Re: Review Request 126392: Fix some Clazy warnings in kcoreaddons

const? Or would this be an ABI breakage? src/lib/text/kmacroexpander.cpp (line 74) <https://git.reviewboard.kde.org/r/126392/#comment61703> Qt5 has a new overload QStringList::join(QChar) -> join(QLatin1Char(' ')) - Christian Ehrlicher On Dez. 18

Re: Review Request 129186: [baloo] Speedup Positioncodec::encode()

/ Testing --- positoncodectest calculates the same md5sum as before. Thanks, Christian Ehrlicher

Re: Review Request 129186: [baloo] Speedup Positioncodec::encode()

/coding.cpp 5961077 Diff: https://git.reviewboard.kde.org/r/129186/diff/ Testing --- positoncodectest calculates the same md5sum as before. Thanks, Christian Ehrlicher

Re: Review Request 129186: [baloo] Speedup Positioncodec::encode()

marked as submitted. Review request for Baloo, KDE Frameworks and Vishesh Handa. Changes --- Submitted with commit 2717080c46072b2a2998cb7d043a7cbcefa6a843 by Christian Ehrlicher to branch master. Repository: baloo Description --- This patch speeds up PostingCodec::encode() by a

D7926: Remove pf.path() from container before the reference got screwed up by it.remove()

chehrlic created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY With https://phabricator.kde.org/R293:a75db7aedfcd356b027774e0dc156c334d4cb869 I introduced a crash when removing a watched directory. T

D7926: Remove pf.path() from container before the reference got screwed up by it.remove()

chehrlic closed this revision. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D7926 To: chehrlic, broulik Cc: #frameworks

D11346: Only set iconText() if actually changed

chehrlic accepted this revision. chehrlic added a comment. This revision is now accepted and ready to land. This should at least fix the most cases as described in the bug report :) REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D11346 To: cfeck, #frameworks,

D23789: RFC: Add ECMGenerateExportHeaders, for improved handling of deprecated API

chehrlic added a comment. In D23789#536338 , @kossebau wrote: > Actual questions I have: > > - why is QT_DEPRECATED_WARNINGS_SINCE not officially documented? like, any plans to change that macro to something else? Just forgot it (and

D23789: RFC: Add ECMGenerateExportHeaders, for improved handling of deprecated API

chehrlic added a comment. In D23789#538985 , @kossebau wrote: > >> - why has all Qt code not yet been adapted to QT_DEPRECATED_VERSION/QT_DEPRECATED_VERSION_X, are there places where those macros should not be used, but the version-less ones?

D24841: Use modern way to set the C/CXX standad

chehrlic added a comment. I would also use CMAKE_CXX_STANDARD_REQUIRED to make sure the compiler actually *can* c++11, otherwise the flag is only added when the compiler supports it. Should not make much difference nowadays but since it's in ECM... REPOSITORY R240 Extra CMake Modules REVI

D7700: Show list of tags in PlacesView

chehrlic added inline comments. INLINE COMMENTS > kfileplacesmodel.cpp:172 > + tags(), > + tagsLister(new KCoreDirLister()) > { While I way playing around with asan, I got a report that tagsLister is leaking. I can't see a deletion of this object anywhere, even in current

D25994: KFilePlacesModel: properly parent tagsLister to avoid memleak. Introduced with D7700

chehrlic created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. chehrlic requested review of this revision. REVISION SUMMARY HTTP ioslave: call correct base class in virtual_hook(). The base of HTTP ioslave is TCPSlaveBase, not SlaveBase.

D25994: KFilePlacesModel: properly parent tagsLister to avoid memleak. Introduced with D7700

chehrlic abandoned this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D25994 To: chehrlic Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25995: HTTP ioslave: call correct base class in virtual_hook(). The base of HTTP ioslave is TCPSlaveBase, not SlaveBase.

chehrlic created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. chehrlic requested review of this revision. REPOSITORY R241 KIO BRANCH http REVISION DETAIL https://phabricator.kde.org/D25995 AFFECTED FILES src/ioslaves/http/http.cpp

D25997: KFilePlacesModel: properly parent tagsLister to avoid memleak. Introduced with D7700

chehrlic created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. chehrlic requested review of this revision. REPOSITORY R241 KIO BRANCH kfileplacesmodel REVISION DETAIL https://phabricator.kde.org/D25997 AFFECTED FILES src/filewidgets/

D25996: KRemoteEncoding::encoding: don't return temporary. Found with clazy.

chehrlic created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. chehrlic requested review of this revision. REPOSITORY R241 KIO BRANCH remoteencoding REVISION DETAIL https://phabricator.kde.org/D25996 AFFECTED FILES src/core/kremoteen

D25995: HTTP ioslave: call correct base class in virtual_hook(). The base of HTTP ioslave is TCPSlaveBase, not SlaveBase.

chehrlic added reviewers: dfaure, ngraham, Dolphin. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D25995 To: chehrlic, dfaure, ngraham, #dolphin Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25996: KRemoteEncoding::encoding: don't return temporary. Found with clazy.

chehrlic added reviewers: thiago, dfaure. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D25996 To: chehrlic, thiago, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25997: KFilePlacesModel: properly parent tagsLister to avoid memleak. Introduced with D7700

chehrlic added reviewers: dfaure, nicolasfella, ngraham, Dolphin. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D25997 To: chehrlic, dfaure, nicolasfella, ngraham, #dolphin Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25996: KRemoteEncoding::encoding: don't return temporary. Found with clazy.

chehrlic added a comment. It was clazy, not me - just wanted to fix a memleak in kio :) REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D25996 To: chehrlic, thiago, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25995: HTTP ioslave: call correct base class in virtual_hook(). The base of HTTP ioslave is TCPSlaveBase, not SlaveBase.

This revision was automatically updated to reflect the committed changes. Closed by commit R241:6f1628706490: HTTP ioslave: call correct base class in virtual_hook(). The base of HTTP… (authored by chehrlic). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25995?vs

D25997: KFilePlacesModel: properly parent tagsLister to avoid memleak. Introduced with D7700

This revision was automatically updated to reflect the committed changes. Closed by commit R241:be9537998890: KFilePlacesModel: properly parent tagsLister to avoid memleak. Introduced with… (authored by chehrlic). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D259

D25996: KRemoteEncoding::encoding: don't return temporary. Found with clazy.

This revision was automatically updated to reflect the committed changes. Closed by commit R241:d80cb8c96eef: KRemoteEncoding::encoding: don't return temporary. Found with clazy. (authored by chehrlic). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25996?vs=71529