D12992: New elisa icon

januz added a comment. In D12992#267534 , @lshoravi wrote: > I agree in that a circle doesn't have as much personality as maybe a > casette. I also agree in that the casette felt off when looking at it. > > How would something like an LP pl

D12992: New elisa icon

januz added a comment. TBH I like the concept of the cassette icon more than the current implementation of it. What was good about about is that it had //personality//, which is a big deal since usually icons also double as logos. IMO a solid icon should be 1) Memorable and 2) Descriptive. I

D12992: New elisa icon

januz added a comment. In D12992#266673 , @mgallien wrote: > In D12992#266288 , @alex-l wrote: > > > F5863162: image.png > > > > ^ I'm for this one without t

D10365: New icon for Elisa music player

januz added a comment. Agree with the text not being useful for small sizes, but it could look good for a large logo-style image (like say, a 256px logo on the wiki/homepage). A cassette is definitely an interesting idea for an icon. At least it's not another musical note or play icon

D8371: Support for underscores in numeric literals (Python 3.6)

januz added a comment. Thanks for the tips guys! This patch still has two problems (that I'm aware :) ): - I can't get it to match the dot in the float regex. The regex itself is ok (https://regexr.com/3idtj), but it just doesn't work. - The regexes don't work inside lists or dicti

D8371: Support for underscores in numeric literals (Python 3.6)

januz updated this revision to Diff 24317. januz added a comment. - Tweaked regexes to fit better with the other regex in the file - Version bump - Added autotests and updated references REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8371?vs

D8371: Support for underscores in numeric literals (Python 3.6)

januz added a comment. In https://phabricator.kde.org/D8371#177673, @cullmann wrote: > b) an extended unit test would be nice, to really show that the regex are right. Hi, sure. Is there any documentation on how to make those tests? I noticed there are some ref and input files, d

D8371: Support for underscores in numeric literals (Python 3.6)

januz created this revision. januz added a project: Framework: Syntax Highlighting. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY This patch adds support for underscores in numeric literals for Python 3.6 (from PEP 51