D11331: add gaming_input devices and others to Battery

dollinger updated this revision to Diff 30141. dollinger added a comment. Hopefully correct now :D REPOSITORY R245 Solid CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11331?vs=29636=30141 REVISION DETAIL https://phabricator.kde.org/D11331 AFFECTED FILES

D11553: Adding Battery Devices Enum

dollinger added a comment. No i don't - my eMail is dollinger.flor...@gmx.de REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D11553 To: dollinger, broulik Cc: #frameworks, michaelh, ngraham

D11331: add gaming_input devices and others to Battery

dollinger added a comment. see D11553 REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D11331 To: dollinger, broulik, #plasma Cc: aleksejshilin, #frameworks, michaelh, ngraham

D11553: Adding Battery Devices Enum

dollinger created this revision. dollinger added a reviewer: broulik. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. dollinger requested review of this revision. REVISION SUMMARY As mentioned in D11331

D11331: add gaming_input devices and others to Battery

dollinger updated this revision to Diff 29636. dollinger added a comment. I'm not sure where to add that enum you mentioned since there is already one in `frontend\battery.h`: enum BatteryType { UnknownBattery, PdaBattery, UpsBattery, PrimaryBattery,

D11331: add gaming_input devices and others to Battery

dollinger added a comment. Okay :) But what's about the other entries, like `UP_DEVICE_KIND_TABLET`, `UP_DEVICE_KIND_MEDIA_PLAYER`? Is there a reason why they are excluded? REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D11331 To: dollinger, broulik, #plasma Cc:

D11331: add gaming_input devices and others to Battery

dollinger added a comment. Btw, this "new" type (`UP_DEVICE_KIND_GAMING_INPUT`) was added half an year ago ;) https://cgit.freedesktop.org/upower/tree/libupower-glib/up-types.h?h=UPOWER_0_99_5 **vs** https://cgit.freedesktop.org/upower/tree/libupower-glib/up-types.h?h=UPOWER_0_99_6

D11331: add gaming_input devices and others to Battery

dollinger added inline comments. INLINE COMMENTS > dollinger wrote in upowerdevice.cpp:98 > Well then it is added automatically, which is what you would expect I think, > and that is the reason why gaming_input wasn't detected. But we can also do it the following way, personally I don't care

D11331: add gaming_input devices and others to Battery

dollinger added inline comments. INLINE COMMENTS > aleksejshilin wrote in upowerdevice.cpp:98 > So you're changing from 'whitelist' to 'blacklist' behavior here. What will > happen when another UPower device type is added by the upstream? Well then it is added automatically, which is what you

D11331: add gaming_input devices and others to Battery

dollinger created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. dollinger requested review of this revision. REVISION SUMMARY automatically add new types like gaming_input, as discussed here: