D24003: kwaylandScanner produce version enum per class

gladhorn marked an inline comment as done. gladhorn added inline comments. INLINE COMMENTS > zzag wrote in generator.cpp:431 > Is it correct thogugh? Can you provide some test input so it's easier to see > the problem? run kwaylandScanner on

D24004: Teach kwaylandscanner about PrimarySelection

gladhorn added subscribers: zzag, romangg, davidedmundson. gladhorn added a comment. @romangg and @davidedmundson any comments? I think @zzag prefers the class names without the V1. I'd like to progress on this step by step and the generator at least gives a good starting point.

D24002: Sort files alphabetically in cmake list

This revision was automatically updated to reflect the committed changes. Closed by commit R127:6c8f110f3a22: Sort files alphabetically in cmake list (authored by gladhorn). REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24002?vs=66278=66279 REVISION DETAIL

D24003: kwaylandScanner produce version enum per class

gladhorn added a comment. The unstable primary selection v1 protocol produces code that doesn't compile, after this change it does compile - since it expects the version enums for three classes, but only the first one is actually written into the file. REPOSITORY R127 KWayland REVISION

D24002: Sort files alphabetically in cmake list

gladhorn updated this revision to Diff 66278. gladhorn added a comment. Actually sort all files REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24002?vs=66254=66278 BRANCH arcpatch-D24002 REVISION DETAIL https://phabricator.kde.org/D24002 AFFECTED

D24004: Teach kwaylandscanner about PrimarySelection

gladhorn created this revision. gladhorn added a reviewer: KWin. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. gladhorn requested review of this revision. REVISION SUMMARY This allows generating the skeleton classes for the primary selection protocol.

D24003: kwaylandScanner produce version enum per class

gladhorn created this revision. gladhorn added a reviewer: KWin. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. gladhorn requested review of this revision. REVISION SUMMARY Otherwise it only creates the enum for the first class encountered. REPOSITORY

D24002: Sort files alphabetically in cmake list

gladhorn created this revision. gladhorn added a reviewer: KWin. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. gladhorn requested review of this revision. REVISION SUMMARY Adding further files is confusing, since the list is almost alphabetical.

D23915: Improve documentation

This revision was automatically updated to reflect the committed changes. Closed by commit R127:6388d550e3a2: Improve documentation (authored by gladhorn). REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23915?vs=66078=66150 REVISION DETAIL

D23586: Improve code that detects useful elements in an Svg file

gladhorn added inline comments. INLINE COMMENTS > svg.cpp:103 > while (!reader.atEnd()) { > -if (reader.readNext() == QXmlStreamReader::StartElement && > +const auto t = reader.readNext(); > +if (t == QXmlStreamReader::StartElement) { Maybe use

D23915: Improve documentation

gladhorn updated this revision to Diff 66078. gladhorn retitled this revision from "Improve documentation Some of the documentation did not say what the purpose of the respective class was, but rather gave a tautology. For people new to the code base it helps to mention that DPMS is power

D23917: Use const_iterator

This revision was automatically updated to reflect the committed changes. Closed by commit R127:28841048d555: Use const_iterator (authored by gladhorn). REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23917?vs=66021=66027 REVISION DETAIL

D23915: Improve documentationSome of the documentation did not say what the purpose of therespective class was, but rather gave a tautology.For people new to the code base it helps to mention thatDPMS

gladhorn added inline comments. INLINE COMMENTS > romangg wrote in dpms.h:44 > Yea, maybe just write that this class is meant to create the DPMS object > below only. You already have the information you provided here there then. I agree. The first two lines are actually repetitions and they

D23915: Improve documentationSome of the documentation did not say what the purpose of therespective class was, but rather gave a tautology.For people new to the code base it helps to mention thatDPMS

gladhorn updated this revision to Diff 66026. gladhorn retitled this revision from "Add some docstrings" to "Improve documentation Some of the documentation did not say what the purpose of the respective class was, but rather gave a tautology. For people new to the code base it helps to mention

D23917: Use const_iterator

gladhorn updated this revision to Diff 66021. gladhorn edited the summary of this revision. gladhorn removed subscribers: broulik, zzag. gladhorn added a comment. Fixed two missing spots REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23917?vs=65946=66021

D23917: Use const_iterator

gladhorn added a comment. Yes, for me always using constBegin/constEnd makes reading the code slightly easier. INLINE COMMENTS > zzag wrote in registry.cpp:879 > constEnd Thanks! > zzag wrote in output_interface.cpp:119 > constEnd Thanks! REPOSITORY R127 KWayland REVISION DETAIL

D23917: Use const_iterator

gladhorn updated this revision to Diff 65946. gladhorn added a comment. fixup REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23917?vs=65945=65946 BRANCH master REVISION DETAIL https://phabricator.kde.org/D23917 AFFECTED FILES

D23917: Use const_iterator

gladhorn created this revision. gladhorn added a reviewer: KWin. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. gladhorn requested review of this revision. REVISION SUMMARY When trivial, replace iterators with the const versrion. REPOSITORY R127 KWayland

D23916: Remove capture of this in lambda

This revision was automatically updated to reflect the committed changes. Closed by commit R127:858d9255f722: Remove capture of this in lambda (authored by gladhorn). REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23916?vs=65943=65944 REVISION DETAIL

D23916: Remove capture of this in lambda

gladhorn updated this revision to Diff 65943. gladhorn added a comment. Remove more lambda this captures REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23916?vs=65942=65943 BRANCH arcpatch-D23916 REVISION DETAIL https://phabricator.kde.org/D23916

D23916: Remove capture of this in lambda

gladhorn created this revision. gladhorn added a reviewer: KWin. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. gladhorn requested review of this revision. REVISION SUMMARY When this is not used, there is no point in capturing it. REPOSITORY R127

D23915: Add some docstrings

gladhorn created this revision. gladhorn added a reviewer: KWin. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. gladhorn requested review of this revision. REVISION SUMMARY When first reading the KWayland code, some explanations help getting around.

D14240: Improve API docs a bit

This revision was automatically updated to reflect the committed changes. Closed by commit R296:9dd578b12d40: Improve API docs a bit (authored by gladhorn). REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14240?vs=38116=38145 REVISION DETAIL

D14240: Improve API docs a bit

gladhorn created this revision. gladhorn added a reviewer: Plasma. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. gladhorn requested review of this revision. REVISION SUMMARY Some typos and make some sentences easier to read

D14118: Improve "Remove this [widget]" text

gladhorn accepted this revision. gladhorn added a comment. This revision is now accepted and ready to land. I'd say make the casing consistent, otherwise it's a clear improvement in my opinion. INLINE COMMENTS > containment.cpp:127 > if (closeApplet) { > -

D6877: Add Conan files

This revision was automatically updated to reflect the committed changes. Closed by commit R243:802d106c8e81: Add Conan files (authored by gladhorn). REPOSITORY R243 KArchive CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6877?vs=17127=17153 REVISION DETAIL

D6877: Add Conan files

gladhorn updated this revision to Diff 17127. gladhorn marked an inline comment as done. gladhorn added a comment. fix url REPOSITORY R243 KArchive CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6877?vs=17126=17127 BRANCH master REVISION DETAIL

D6877: Add Conan files

gladhorn marked 3 inline comments as done. gladhorn added inline comments. INLINE COMMENTS > apol wrote in conanfile.py:5 > Can we re-use the version from the `CMakeLists.txt`? The goal is to generate it. > apol wrote in conanfile.py:7 > Re-use from metainfo.yml? For now we consider this as a

D6877: Add Conan files

gladhorn updated this revision to Diff 17126. gladhorn added a comment. Updated according to comments REPOSITORY R243 KArchive CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6877?vs=17124=17126 BRANCH master REVISION DETAIL https://phabricator.kde.org/D6877 AFFECTED FILES

D6877: Add Conan files

gladhorn updated this revision to Diff 17124. gladhorn added a comment. remove -git from the version REPOSITORY R243 KArchive CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6877?vs=17118=17124 BRANCH master REVISION DETAIL https://phabricator.kde.org/D6877 AFFECTED FILES

D6877: Add Conan files

gladhorn updated this revision to Diff 17118. gladhorn added a comment. Fix license REPOSITORY R243 KArchive CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6877?vs=17116=17118 BRANCH master REVISION DETAIL https://phabricator.kde.org/D6877 AFFECTED FILES conanfile.py

D6877: Add Conan files

gladhorn updated this revision to Diff 17116. gladhorn added a comment. Remove private test stuff REPOSITORY R243 KArchive CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6877?vs=17115=17116 BRANCH master REVISION DETAIL https://phabricator.kde.org/D6877 AFFECTED FILES

D6877: Add Conan files

gladhorn created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY Conan is a C++ package manager. This is an experiment to make KF5 frameworks available on Conan to make building KDE applications easier.

D6624: do not crash qaccessible by causing a resize in a resize event

gladhorn added a comment. Considering that the Qt bug will not be fixed in the next few days (I hope to get around to it, but it's involved), this makes sense. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D6624 To: sitter, gladhorn Cc: cfeck,

Re: Review Request 122918: revert 2ee76f0 to fix QtQuickControls

QWidget's file dialog when set to modal. Iirc this breaks for example the open dialogs in qt creator. - Frederik Gladhorn On March 12, 2015, 1:19 p.m., Marco Martin wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 122555: knotifications: Add optional dependency on Qt5TextToSpeech for speech notifications.

/#comment52450 I have no idea how this is used, should it be i18n'ed? And Text to Speech - Frederik Gladhorn On Feb. 13, 2015, 3:11 a.m., Jeremy Whiting wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 122554: knotifyconfig: Add optional dependency on QtSpeech to reenable speaking notifications.

.) Review request for KDE Frameworks and Frederik Gladhorn. Repository: knotifyconfig Description --- Change config from KTTS to Speech. If QtSpeech is available when building return true from have_speech static method. Otherwise return false. Could also add a check to see

Re: Review Request 122554: knotifyconfig: Add optional dependency on QtSpeech to reenable speaking notifications.

p.m.) Review request for KDE Frameworks and Frederik Gladhorn. Repository: knotifyconfig Description --- Change config from KTTS to Speech. If QtSpeech is available when building return true from have_speech static method. Otherwise return false. Could also add a check

Fwd: [Development] Qt Contributors' Summit 2014 in Berlin 10-11th June

chance to influence many things in Qt directly with great discussions. Also a great start to getting deeper involved of course ;) See the forwarded mail for details. -- Best regards, Frederik Gladhorn Senior Software Engineer - Digia, Qt Visit us on: http://qt.digia.com ---BeginMessage--- Hello

Re: KSpeech

Torsdag 6. mars 2014 20.34.05 skrev Christoph Feck: On Thursday 06 March 2014 17:13:19 Jeremy Whiting wrote: On Thu, Mar 6, 2014 at 6:43 AM, Frederik Gladhorn gladh...@kde.org wrote: Onsdag 5. mars 2014 23.04.12 skrev Jeremy Whiting: 3. user configurability (As a user I can't set up

Re: KSpeech

be more than happy to get contributions of course. I cannot promise much from my side, of course I'd like to continue working on this project as time permits (so far it really is a spare time thing). Greetings, Frederik Jeremy On Wed, Mar 5, 2014 at 12:29 PM, Frederik Gladhorn gladh...@kde.org

Re: kf5 alpha 1 : attica?

On Thursday 6. February 2014 00.29.45 David Faure wrote: Frederik wrote: From my point of view, please just go ahead and change it as you think is sensible. OK, thanks for the green lights, I went ahead: * Qt4 support for attica is now in the qt4 branch * Attica master is now qt5

Re: Review LibKdeAccessibilityClient

Søndag 7. oktober 2012 21.45.17 skrev Alexander Neundorf: On Thursday 04 October 2012, Frederik Gladhorn wrote: Hi, so after we took the time to hack a bit more on the library in Randa, I would be happy about more comments. Why does it use KDEPIMLIBS_INSTALL_DIR ? macro

Re: Review LibKdeAccessibilityClient

(assuming you have qt- at-spi and libatspi2). Greetings Frederik On Thursday 23. August 2012 22.41.46 Kevin Ottens wrote: Hello, On Thursday 16 August 2012 09:29:27 Frederik Gladhorn wrote: Feedback is much appreciated. If you aim at releasing with KDE Frameworks, I would like to see

Review LibKdeAccessibilityClient

Hi, a few of us trying to improve accessibility of KDE worked on a little library, LibKdeAccessibilityClient. What it does is making the AT-SPI over DBus protocol easy to use for KDE apps. This is the accessibility framework that we share with Gnome. It enables two way communication between